Item Doesn't Open Iron Door

[AnonymousModder]

I've made an item and I've got the code for the item to open an iron door, but it only makes the sound when I right click on the iron door.

 

Here's my code

@Override
    public boolean onItemUse(ItemStack stack, EntityPlayer player, World world, BlockPos pos, EnumFacing side, float hitX, float hitY, float hitZ)
{
	if(!world.isRemote){
		if(world.getBlockState(pos).getBlock() instanceof BlockDoor) {
			String sound;
			if(world.getBlockState(pos).getValue(BlockDoor.HALF) == EnumDoorHalf.UPPER){
				world.setBlockState(pos.down(), world.getBlockState(pos.down()).withProperty(BlockDoor.OPEN, world.getBlockState(pos.down()).getValue(BlockDoor.OPEN)));
				sound = (Boolean) world.getBlockState(pos.down()).getValue(BlockDoor.OPEN) ? "random.door_close" : "random.door_open";
				world.playSoundAtEntity(player, sound, 1.0f, 1.0f);
				return true;
			} else {
				world.setBlockState(pos, world.getBlockState(pos).withProperty(BlockDoor.OPEN, world.getBlockState(pos).getValue(BlockDoor.OPEN)));
				sound = (Boolean) world.getBlockState(pos).getValue(BlockDoor.OPEN) ? "random.door_close" : "random.door_open";
				world.playSoundAtEntity(player, sound, 1.0f, 1.0f);
				return true;
			}
		}
	}
	return true;
}

[AnonymousModder]

Also, if I remove the (boolean) before the world.getBlockstate stuff, it suggests to either add "!= null" after that line or make that line a "if/else".

[swordkorn]

Are you telling it to update the block?

 

Also, your else statement is checking for the exact same blockState as your if statement. You also never check to see if the blockState is set to .CLOSED in your if statement.

 

Your code is only ever checking for the .OPEN state. This may be why it's not updating.

 

The other glaringly obvious issue is you return true everywhere. Your main if(!world.isremote) should return false.

[LexManos]

Your code is to complex maybe you may find the issue if you write it simpler, this is your code:

				world.setBlockState(pos.down(), world.getBlockState(pos.down()).withProperty(BlockDoor.OPEN, world.getBlockState(pos.down()).getValue(BlockDoor.OPEN)));

Simplified:

BlockPos down = pos.down();
IBlockState state = world.getBlockState(down);
boolean open = state.getValue(BlockDoor.OPEN);
state = state.withProperty(BlockDoor.OPEN, open);
world.setBlockState(down, state);

Now read that carefully, and No I did not make any typos when translating your code.