[1.7.10] Ore Generator don't work [SOLVED]

[Darki]

I made an Ore Generator but it don't work. My own Ore isn't anywhere in the World. Here my Ore Generator:

public class OreGenerator implements IWorldGenerator {

@Override
public void generate(Random random, int chunkX, int chunkZ, World world, IChunkProvider chunkGenerator,IChunkProvider chunkProvider) {

	switch(world.provider.dimensionId){
	case -1: generateNether(world, random, chunkX * 16, chunkZ * 16);
	case  0: generateSurface(world, random, chunkX * 16, chunkZ * 16);
	case  1: generateEnd(world, random, chunkX * 16, chunkZ * 16);
	}

}

private void generateSurface(World world, Random random, int x, int z) {

}

private void generateEnd(World world, Random random, int x, int z) {

}

private void generateNether(World world, Random random, int x, int z) {
	oreGen(ChemMix.leavyumOre, world, random, x, z, 16, 16, 100, 15, 100, 60);
}

public void oreGen(Block b, World w, Random r, int posX, int posZ, int maxX, int maxZ, int maxAder, int spawnChance, int minY, int maxY){

	int diffMinMaxY = maxY - minY;

	for(int i = 0; i < spawnChance; i++){

		int posiX = posX + r.nextInt(maxX);
		int posiY = minY + r.nextInt(diffMinMaxY);
		int posiZ = posZ + r.nextInt(maxZ);

		(new WorldGenMinable(b, maxAder)).generate(w, r, posiX, posiY, posiZ);
	}
}


}

 

I registered the Generator in the postInit part:

GameRegistry.registerWorldGenerator(new OreGenerator(), 1);

[Draco18s]

Just to check:

You know your ore is only generating in the nether, right? And WorldgenMinable only replaces stone, right?

[wdolezal5]

What you could do is make your ore as common as possible by removing the "int spawnChance" and replacing it with a random integer or a specific integer. That's what I do to test my ores, but I have that in my generateSurface() method;

private void generateSurface(World world, Random random, int i, int j) {
	for(int k = 0; k < random.nextInt(124) + 1; k++) {
		int firstBlockXCoord = i + random.nextInt(16);
		int firstBlockYCoord = random.nextInt(44);
		int firstBlockZCoord = j + random.nextInt(16);

		new WorldGenMinable(TaserItemsAndBlocks.Salt_Ore, random.nextInt(10)).generate(world, random, firstBlockXCoord, firstBlockYCoord, firstBlockZCoord);
	}
}

 

Try playing around with the y-coord integer too, to see if it can spawn.

Everyone has their own way of doing things, and I've found this to work 100% of the time for me, but I hope this helps you.

 

Thanks,

Will.

 

EDIT: Since you're using 1.7.10 this code may be different, so just be aware, I'm using 1.8 code.

[Darki]

Now I changed it to generateSurface but now my Minecraft crashes:

http://pastebin.com/xVdaDFQs

[Choonster]

You passed a non-positive number to

Random#nextInt

in

OreGenerator#oreGen

(line 44). The code in your original post uses 100 as the minimum y position and 60 as the maximum y position, so

maxY - minY

is negative.

[Darki]

Thanks Very Much^^

 

[Darki]

Now there is a NullPointerException but why?!

http://pastebin.com/rsD0LpUZ

[Choonster]

You created a

WorldGenMinable

with a

null

Block

on line 47 of

OreGenerator

.

[Darki]

But the block isn't null this is my own Block which I registered int the preInit Part

[Darki]

Ore I am very stupid at the moment

[Darki]

I solved it on my own....I didn't set an Unlocalized Name for the Block so that it was null