LivingAttackEvent problems [solved]

[bloodi]

Hey,

 

I am working on a method that returns the attacker of an entity. I tried:

 

  
DamageSource source = event.source;
    	    	
if(source != null){
if (((source instanceof EntityDamageSource))){    		
if(source.getEntity() != null){	    		
if(source.getEntity() instanceof EntityPlayerMP){

 EntityPlayerMP attacker = (EntityPlayerMP)source.getEntity();
  	    	      
 System.out.println(attacker.toString() + " is the attacker");
}
}
}
    			  
}

 

These if-functions should prevent the case to go on if there is no attacker but the game crashes as soon as I hit an animal.

Here is the error:

java.lang.NoSuchMethodError: net.minecraft.util.DamageSource.getEntity()Lnet/minecraft/entity/Entity;

at com.blooditor.damagedetection.DamageDetection.onHurt(DamageDetection.java:61)

at cpw.mods.fml.common.eventhandler.ASMEventHandler_0_DamageDetection_onHurt_LivingAttackEvent.invoke(.dynamic)

at cpw.mods.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:54)

at cpw.mods.fml.common.eventhandler.EventBus.post(EventBus.java:140)

at net.minecraftforge.common.ForgeHooks.onLivingAttack(ForgeHooks.java:292)

at net.minecraft.entity.EntityLivingBase.func_70097_a(EntityLivingBase.java:737)

at net.minecraft.entity.passive.EntityAnimal.func_70097_a(SourceFile:145)

at net.minecraft.entity.player.EntityPlayer.func_71059_n(EntityPlayer.java:1232)

at net.minecraft.client.multiplayer.PlayerControllerMP.func_78764_a(PlayerControllerMP.java:406)

at net.minecraft.client.Minecraft.func_147116_af(Minecraft.java:1393)

at net.minecraft.client.Minecraft.func_71407_l(Minecraft.java:1948)

at net.minecraft.client.Minecraft.func_71411_J(Minecraft.java:973)

at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:898)

at net.minecraft.client.main.Main.main(SourceFile:148)

at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)

at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)

at java.lang.reflect.Method.invoke(Method.java:483)

at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)

at net.minecraft.launchwrapper.Launch.main(Launch.java:28)

 

 

Line 61 is: " if(source.getEntity() != null){"

 

I am using the recommended Forge 1.7.10 version.

 

I hope someone can help.

[Draco18s]

You checked if source was an instance of EntityDamageSource, but you didn't cast it.

 

((EntityDamageSource)source).getEntity()

[bloodi]

You checked if source was an instance of EntityDamageSource, but you didn't cast it.

 

((EntityDamageSource)source).getEntity()

 

Thanks, seems helpful but I tried it and it crashes with the same error when casting it.

 

  
if(source != null){
if (((source instanceof EntityDamageSource))){
Entity sourceentity = ((EntityDamageSource)source).getEntity();

 

Where is the problem?

Its also pretty weird because I as a player am an entity and a player, so there should be no error 

[Choonster]

Side note: The

instanceof

operator already returns

false

if the object is

null

, there's no need to check for

null

before using the operator.

[bloodi]

If you are running your mod outside the development environment (which you are) you must build it using

gradle build

, otherwise it will not be reobfuscated and not work.

 

Thank you sooo much, I'm new to Forge Modding

Spent so much time with that, so dumb^^

 

Liebe Grüße Kollege