[1.9] TileEntity empty packets

[Notunknown]

So I am trying to make a TileEntity send data from the server to the client but when the packets arrive they are empty. I have registered the TileEntity, do I need to register anything to do with the network?

 

The packets do, however, work when the TileEntity loads initially, it just doesn't work when updated.

 

@Override
public Packet<?> getDescriptionPacket()
{
NBTTagCompound tag = new NBTTagCompound();
if (this.hasStoredBlock())
{
	NBTTagCompound stored = new NBTTagCompound();
	stored.setString("name", storedBlock.getItem().getRegistryName().toString());
	stored.setInteger("meta", storedBlock.getItemDamage());
	stored.setInteger("amount", storeAmount);
	tag.setTag("storedBlock", stored);
}
return new SPacketUpdateTileEntity(this.getPos(), this.getBlockMetadata(), tag);
}

@Override
public void onDataPacket(NetworkManager net, SPacketUpdateTileEntity pkt)
{
System.out.println(pkt.getNbtCompound().toString());
}

[Ernio]

Have you considered that "if (this.hasStoredBlock())" might be false?

 

 

[Notunknown]

Yes - but it isn't. Although I removed it prior to posting, I printed out the value of

tag

before the return statement.

[Notunknown]

Okay - got it working. Somehow. But now I have a strange issue:

 

It will not update when I right click (I call

this.markDirty()

), but will update whenever I left click in creative or survival (It wont break in creative)

[Draco18s]

markDirty only indicates that the data has changed and will need to be saved to disk when the next save() cycle runs.  It does not indicate that the data needs to be synced to the client.  IIRC, you want World#markBlockForUpdate()

[Notunknown]

markDirty only indicates that the data has changed and will need to be saved to disk when the next save() cycle runs.  It does not indicate that the data needs to be synced to the client.  IIRC, you want World#markBlockForUpdate()

 

Do you mean

World#markAndNotifyBlock

? That requires a lot of stuff like a Chunk, two IBlockStates and integer flags, in addition to a BlockPos.

[Notunknown]

Apparently

World#markAndNotifyBlock

is what I wanted - I have no idea how to use it though. Why do I want to pass in the old IBlockState - or is that a supposed to be a blank object which will have its values copied onto by the IBlockState? Same goes for why I need to pass in a chunk object - is that the chunk the block is in? If so, why is that not calculated by the BlockPos I passed in?

 

And as for the flags, no idea what to pass there. Checking the code just reveals a load of magic numbers - I just passed in Integer.MAX_VALUE to be safe.

 

The one line comment is no help, either.

[Ernio]

Here we go again...

 

getDescriptionPacket() and onDataPacket() is used by internals only in one case (generally speaking) - when block is loaded by given client and server sends data about it, it (obviously) knows that this block has TileEntity and sends it too using those methods.

 

This update happens only when block is loaded (first packet) or when you tell it (block) to update.

This is why it requires few of mentioned fields.

 

Generally speaking - if you don't need to send something, you don't do it. And what I mean by that is that if you need to update NOT ALL of values held by TileEntity, you don't send ALL. You use SNW and IMessage and send: x/y/z and data (not even NBT). On client you get TE in x/y/z and update it.

End. Of. Story.

 

Anything that you do that is not needed is sign of poor or bad design.

 

SNW: www.minecraftforge.net/forum/index.php/topic,20135.0.html

 

As to how use markAndNotifyBlock - in this case it is quite bad in my opinion, but as to params - just look at callbacks

[Notunknown]

Here we go again...

 

getDescriptionPacket() and onDataPacket() is used by internals only in one case (generally speaking) - when block is loaded by given client and server sends data about it, it (obviously) knows that this block has TileEntity and sends it too using those methods.

 

This update happens only when block is loaded (first packet) or when you tell it (block) to update.

This is why it requires few of mentioned fields.

 

Generally speaking - if you don't need to send something, you don't do it. And what I mean by that is that if you need to update NOT ALL of values held by TileEntity, you don't send ALL. You use SNW and IMessage and send: x/y/z and data (not even NBT). On client you get TE in x/y/z and update it.

End. Of. Story.

 

Anything that you do that is not needed is sign of poor or bad design.

 

SNW: www.minecraftforge.net/forum/index.php/topic,20135.0.html

 

As to how use markAndNotifyBlock - in this case it is quite bad in my opinion, but as to params - just look at callbacks

 

I know - I am now going to get it to only send the data which it needs to send - the entire point of this was GETTING it to send, which I have now achieved. Not quite sure how I did it, but I did it.

[Notunknown]

However - that does present a question: What methods are employed to prevent the resending of redundant information? Currently I have two boolean values which are set prior to marking it for an update and are true by default (and reset to true after sending it). I believe this should send the appropriate information.