Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

[Solved][1.7.10] checking biome location

Glistre

By Glistre
in Modder Support

 Share

Recommended Posts

Glistre Creeper Killer

Glistre

Posted
Posted

Trying to check for biome location to play Thunder in my biome, nothing seems to catch the biome: if I check for (event.player.worldObj.isRemote ) it plays constant thunder, or (!event.player.worldObj.isRemote ), I think is correct for server side ...then nothing happens

 

What I want to happen is for thunder to ONLY play in my biome

 

@SubscribeEvent
public void thunderStorm (PlayerTickEvent event){

Random rand = new Random(); 

int varX=rand.nextInt(25); 
int varZ=rand.nextInt(25);
int spawnchance=rand.nextInt(150);

if (spawnchance == 0){	

	if (!event.player.worldObj.isRemote )
	{ 
		if (event.player.worldObj.getBiomeGenForCoords(event.player.chunkCoordX, event.player.chunkCoordZ) == BiomeRegistry.biomeFreon){

			event.player.worldObj.playSound(event.player.posX, event.player.posY, event.player.posZ, "ambient.weather.thunder", 100.0F, 1.0F, false);



	event.player.worldObj.addWeatherEffect(new EntityLightningBolt(event.player.worldObj, event.player.posX + varX, 
			event.player.posY, event.player.posZ + varZ));

       
	}
	}
}
}

Link to comment
Share on other sites
Draco18s Reality Controller

Draco18s

Posted
Posted

Well, the sound doesn't play on the server because World#playSound on the server thread is empty.

 

What you need to do is debug this line:

 

if (event.player.worldObj.getBiomeGenForCoords(event.player.chunkCoordX, event.player.chunkCoordZ) == BiomeRegistry.biomeFreon){

 

And figure out why it isn't doing what you want.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites
Glistre Creeper Killer

Glistre

Posted
  • Author
Posted

Well, the sound doesn't play on the server because World#playSound on the server thread is empty.

 

What you need to do is debug this line:

 

if (event.player.worldObj.getBiomeGenForCoords(event.player.chunkCoordX, event.player.chunkCoordZ) == BiomeRegistry.biomeFreon){

 

And figure out why it isn't doing what you want.

 

How do you debug if it's not doing anything at all?

 

I solved the problem, but I would still like to learn to be a better modder and I might have solved it much quicker

 

By the way, I replaced the line with this and it works

			if (event.player.worldObj.getBiomeGenForCoords(event.player.getPlayerCoordinates().posX, event.player.getPlayerCoordinates().posZ) == BiomeRegistry.biomeFreon){
			// DEBUG

			       System.out.println("Getting biome coords" + event.player.chunkCoordX );

 

But, of course the original way, nothing prints in the console at all

 

Link to comment
Share on other sites
Draco18s Reality Controller

Draco18s

Posted
Posted

Do it the other way around :|

 

System.out.println("Getting biome: " + event.player.worldObj.getBiomeGenForCoords(event.player.getPlayerCoordinates().posX, event.player.getPlayerCoordinates().posZ));
if (event.player.worldObj.getBiomeGenForCoords(event.player.getPlayerCoordinates().posX, event.player.getPlayerCoordinates().posZ) == BiomeRegistry.biomeFreon){

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites
Glistre Creeper Killer

Glistre

Posted
  • Author
Posted

Do it the other way around :|

 

System.out.println("Getting biome: " + event.player.worldObj.getBiomeGenForCoords(event.player.getPlayerCoordinates().posX, event.player.getPlayerCoordinates().posZ));
if (event.player.worldObj.getBiomeGenForCoords(event.player.getPlayerCoordinates().posX, event.player.getPlayerCoordinates().posZ) == BiomeRegistry.biomeFreon){

 

When I try the debug the way I originally had the code (did not work) ie,

 

 if (event.player.worldObj.getBiomeGenForCoords(event.player.chunkCoordX, event.player.chunkCoordZ) == BiomeRegistry.biomeFreon){

 

the console reads:


[20:20:28] [Client thread/INFO] [sTDOUT]: [com.glistre.glistremod.GlistreEventHandler:thunderStorm:97]: Getting biome coordstrue
[20:20:31] [Client thread/INFO] [sTDOUT]: [com.glistre.glistremod.GlistreEventHandler:thunderStorm:97]: Getting biome coordstrue
[20:20:31] [Client thread/INFO] [sTDOUT]: [com.glistre.glistremod.GlistreEventHandler:thunderStorm:97]: Getting biome coordstrue
[20:20:33] [server thread/INFO] [sTDOUT]: [com.glistre.glistremod.GlistreEventHandler:thunderStorm:86]: Player Tick for: SERVER
[20:20:33] [server thread/INFO] [sTDOUT]: [com.glistre.glistremod.GlistreEventHandler:thunderStorm:97]: Getting biome coordsfalse
[20:20:34] [Client thread/INFO]: Warning: Clientside chunk ticking took 101 ms
[20:20:36] [Client thread/INFO] [sTDOUT]: [com.glistre.glistremod.GlistreEventHandler:thunderStorm:97]: Getting biome coordstrue
[20:20:37] [server thread/INFO] [sTDOUT]: [com.glistre.glistremod.GlistreEventHandler:thunderStorm:86]: Player Tick for: SERVER
[20:20:37] [server thread/INFO] [sTDOUT]: [com.glistre.glistremod.GlistreEventHandler:thunderStorm:97]: Getting biome coordsfalse
[20:20:38] [server thread/INFO] [sTDOUT]: [com.glistre.glistremod.GlistreEventHandler:thunderStorm:86]: Player Tick for: SERVER
[20:20:38] [server thread/INFO] [sTDOUT]: [com.glistre.glistremod.GlistreEventHandler:thunderStorm:97]: Getting biome coordsfalse
[20:20:38] [server thread/INFO] [sTDOUT]: [com.glistre.glistremod.GlistreEventHandler:thunderStorm:86]: Player Tick for: SERVER
[20:20:38] [server thread/INFO] [sTDOUT]: [com.glistre.glistremod.GlistreEventHandler:thunderStorm:97]: Getting biome coordsfalse
[20:20:39] [server thread/INFO] [sTDOUT]: [com.glistre.glistremod.GlistreEventHandler:thunderStorm:86]: Player Tick for: SERVER
[20:20:39] [server thread/INFO] [sTDOUT]: [com.glistre.glistremod.GlistreEventHandler:thunderStorm:97]: Getting biome coordsfalse
[20:20:40] [server thread/INFO] [sTDOUT]: [com.glistre.glistremod.GlistreEventHandler:thunderStorm:86]: Player Tick for: SERVER
[20:20:40] [server thread/INFO] [sTDOUT]: [com.glistre.glistremod.GlistreEventHandler:thunderStorm:97]: Getting biome coordsfalse

 

 

 

Link to comment
Share on other sites
Draco18s Reality Controller

Draco18s

Posted
Posted

That console output matches neither what I did, nor what you did (and is useless).

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites
Glistre Creeper Killer

Glistre

Posted
  • Author
Posted 

[21:13:51] [Client thread/INFO] [sTDOUT]: [com.glistre.glistremod.GlistreEventHandler:thunderStorm:93]: Getting biome coordscom.glistre.glistremod.biome.FreonBiome@29e66bc1
[21:13:51] [server thread/INFO] [sTDOUT]: [com.glistre.glistremod.GlistreEventHandler:thunderStorm:86]: Player Tick for: SERVER
[21:13:51] [server thread/INFO] [sTDOUT]: [com.glistre.glistremod.GlistreEventHandler:thunderStorm:93]: Getting biome coordscom.glistre.glistremod.biome.FreonBiome@29e66bc1

 

the way you did it  ...console shows getting the biome ...works fine

 

the way I did it originally ... does not work ...seems to just check true in the biome or not but the code does not work ...

 

Works fine now here is my final code

 

@SubscribeEvent
public void thunderStorm (PlayerTickEvent event){
BiomeGenBase b = BiomeRegistry.biomeFreon;
Random rand = new Random(); 
int varX=rand.nextInt(25); 
int varZ=rand.nextInt(25);
int spawnchance=rand.nextInt(150);

if (spawnchance == 0){	

	if (!event.player.worldObj.isRemote )
		// DEBUG
		 System.out.println("Player Tick for: " + event.side );

	{ 
			// DEBUG
			System.out.println("Getting biome coords" + event.player.worldObj.getBiomeGenForCoords(event.player.getPlayerCoordinates().posX, event.player.getPlayerCoordinates().posZ));
			if (event.player.worldObj.getBiomeGenForCoords(event.player.getPlayerCoordinates().posX, event.player.getPlayerCoordinates().posZ) == BiomeRegistry.biomeFreon ||  event.player.worldObj.provider.dimensionId == {

						       //1.8 code			if(player.worldObj.getBiomeGenForCoords(new BlockPos(player.posX, player.posY, player.posZ)) == BiomeRegistry.biomeFreon)						
			event.player.worldObj.playSound(event.player.posX, event.player.posY, event.player.posZ, "ambient.weather.thunder", 100.0F, 1.0F, false);

			event.player.worldObj.addWeatherEffect(new EntityLightningBolt(event.player.worldObj, event.player.posX + varX, 
			event.player.posY, event.player.posZ + varZ));
		}
	  }
   }
}

Link to comment
Share on other sites
Draco18s Reality Controller

Draco18s

Posted
Posted

the way you did it  ...console shows getting the biome ...works fine

 

I'm not surprised. To debug an if-statement you need to be logging outside of it and printing out the objects being compared not the comparison result.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



  • Recently Browsing

    • No registered users viewing this page.

  • Posts

    • matwaua
      Launcher using wrong constructor

      By matwaua · Posted

      I am following a tutorial for modding minecraft 1.20.1, and while running the mod with the minecraft of the idea, no errors was present but, when I switched to real minecraft, it started to want a default constructor "public ZeroToAutomation()" instead of the one recomended by the video "public ZeroToAutomation(FMLJavaModLoadingContext context) {...}", and I can't use the default constructor because I need the FMLJavaModLoadingContext to register the blocks and items.   The problem is at: "net/myself/zerotoautomation/ZeroToAutomation.java" the file contains the default constructor, "Logger"s, and the code for the mod the defaut constructor was added after an error requesting it the Loggers was used to see which methods/constructors was used by the Launcher   things that I tried to fix the issue: remove the default constructor, but an error appeared "net.myself.zerotoautomation.ZeroToAutomation.<init>()", and nothing else on the class runs adding an "public static void init()" method, but it changed nothing   The mod files: https://github.com/Matwaua/Zero_To_Automation/tree/not-finished
    • TileEntity
      Oculus Not Working with embeddium in custom modpack

      By TileEntity · Posted

      It is an issue/conflict with distanthorizons
    • SurgePlayzYT
      Oculus Not Working with embeddium in custom modpack

      By SurgePlayzYT · Posted

      I have been trying to combat this issue between oculus and embeddium and to no avail... I have already tried a few online tutorials on how to get this working but it doesn't work at all. https://pastebin.com/geQgifjc
    • bb115
      Installing Risugami's Mods on Forge 1.6.2

      By bb115 · Posted

      wow you sound like fun to play with
    • Levitoxx
      Problemas con Custom npc en mi servidor

      By Levitoxx · Posted

      Instale el mod en mi servidor y este se queda iniciando por horas, en la consola me habla de algo de permisos y trate de seguir la ruta que me da pero no existe.   [13:05:32 INFO]: CustomNPC Permissions available: [13:05:32 INFO]: customnpcs.edit.blocks [13:05:32 INFO]: customnpcs.edit.villager [13:05:32 INFO]: customnpcs.global.bank [13:05:32 INFO]: customnpcs.global.dialog [13:05:32 INFO]: customnpcs.global.faction [13:05:32 INFO]: customnpcs.global.linked [13:05:32 INFO]: customnpcs.global.naturalspawn [13:05:32 INFO]: customnpcs.global.playerdata [13:05:32 INFO]: customnpcs.global.quest [13:05:32 INFO]: customnpcs.global.recipe [13:05:32 INFO]: customnpcs.global.transport [13:05:32 INFO]: customnpcs.npc.advanced [13:05:32 INFO]: customnpcs.npc.ai [13:05:32 INFO]: customnpcs.npc.clone [13:05:32 INFO]: customnpcs.npc.create [13:05:32 INFO]: customnpcs.npc.delete [13:05:32 INFO]: customnpcs.npc.display [13:05:32 INFO]: customnpcs.npc.freeze [13:05:32 INFO]: customnpcs.npc.gui [13:05:32 INFO]: customnpcs.npc.inventory [13:05:32 INFO]: customnpcs.npc.reset [13:05:32 INFO]: customnpcs.npc.stats [13:05:32 INFO]: customnpcs.scenes [13:05:32 INFO]: customnpcs.soulstone.all [13:05:32 INFO]: customnpcs.spawner.create [13:05:32 INFO]: customnpcs.spawner.mob [13:05:32 INFO]: customnpcs.tool.mounter [13:05:32 INFO]: customnpcs.tool.nbtbook [13:05:32 INFO]: customnpcs.tool.pather [13:05:32 INFO]: customnpcs.tool.scripter

  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept