Jump to content

[Solved] Planting crops on other blocks besides farmland (1.8.9)


Ronaldi2001

Recommended Posts

I am adding on to my mod More Items and i'm adding material crops. I am making my diamond crop right now and I want the seed to plant the crop on a block of diamond. I added the diamond block where farmland should be but it still wont let me plant it on it.

 

Diamond Plant Registry:

GameRegistry.registerItem(diamond_seeds = new MIItemSeeds(MoreItemsCrops.diamond_crop, Blocks.diamond_block, "diamond_seeds"), "diamond_seeds");	

~ Ronaldi2001

Link to comment
Share on other sites

I'm pretty sure the farmland-block needs to cooperate as well.  Which the diamond block doesn't know anything about crops, so the calls made to allow planting fail.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Reeds (sugar cane) can be planted on any of several types of blocks. Can they be imitated? Do they need co-operation from sand, dirt etc?

 

Walk through the reed code to see if you can extend that class (or its parent) to achieve your purpose.

 

EDIT: Oh, and netherwart is a "bush" that grows on soul sand. Maybe that's what you should imitate.

The debugger is a powerful and necessary tool in any IDE, so learn how to use it. You'll be able to tell us more and get better help here if you investigate your runtime problems in the debugger before posting.

Link to comment
Share on other sites

There is a chunk of code somewhere that handles valid placement that wass't in the BlockCrops class, I just don't remember where it was.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

I'm looking in net.minecraft.item.ItemSeeds#onItemUse right now and there's this if statement:

 

/**
     * Called when a Block is right-clicked with this Item
     */
    public boolean onItemUse(ItemStack stack, EntityPlayer playerIn, World worldIn, BlockPos pos, EnumFacing side, float hitX, float hitY, float hitZ)
    {
        if (side != EnumFacing.UP)
        {
            return false;
        }
        else if (!playerIn.canPlayerEdit(pos.offset(side), side, stack))
        {
            return false;
        }
        else if (worldIn.getBlockState(pos).getBlock().canSustainPlant(worldIn, pos, EnumFacing.UP, this) && worldIn.isAirBlock(pos.up()))
        {
            worldIn.setBlockState(pos.up(), this.crops.getDefaultState());
            --stack.stackSize;
            return true;
        }
        else
        {
            return false;
        }
    }

 

So short of creating a coremod and altering the diamond block's canSustainPlant function, you should make an item that alters the diamond block, eg turns it into a custom diamond block which overrides this method and returns true. My advice would be to take a look at net.minecraft.block.Block#canSustainPlant and net.minecraft.block.Block#canHarvestBlock methods. I may just be talking out of my ass though, someone with more knowledge can and should correct me if I am.

Link to comment
Share on other sites

getBlock().canSustainPlant()

 

That's the one.  Go look at Block#canSustainPlant

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

However, we're not trying to plant wheat here, so we don't even need to work around ItemSeeds#onItemUse. We're trying to plant some custom thingy, so let's override the custom thing's onItemUse method to do a different test. Have it copy the early branches of the seed's version, and then look for diamond block instead of calling canSustainPlant.

 

PS: It would help if you could post the source code to MIItemSeeds. I think that's where you need to override onItemUse.

The debugger is a powerful and necessary tool in any IDE, so learn how to use it. You'll be able to tell us more and get better help here if you investigate your runtime problems in the debugger before posting.

Link to comment
Share on other sites

Diamond Seeds Class:

package ronaldi2001.MoreItems.crops;

import net.minecraft.block.Block;
import net.minecraft.block.BlockBush;
import net.minecraft.block.material.Material;
import net.minecraft.init.Blocks;
import net.minecraft.init.Items;
import net.minecraft.item.Item;
import net.minecraft.util.BlockPos;
import net.minecraft.util.EnumFacing;
import net.minecraft.world.World;
import ronaldi2001.MoreItems.init.MoreItemsItems;

public class MIDiamondCrop extends BlockBush {

public MIDiamondCrop(String name) {
	this.setUnlocalizedName(name);
}

public Item getSeed() {
	return MoreItemsItems.diamond_seeds;
}

public Item getCrop() {
	return Items.diamond;	
}


}

 

MIItemSeeds Class:

package ronaldi2001.MoreItems.items;

import net.minecraft.block.Block;
import net.minecraft.item.ItemSeeds;
import ronaldi2001.MoreItems.main.MoreItems;

public class MIItemSeeds extends ItemSeeds {

public MIItemSeeds(Block crops, Block soil, String name) {
	super(crops, soil);
	this.setUnlocalizedName(name);
	this.setCreativeTab(MoreItems.tabMoreItems);
}

}

~ Ronaldi2001

Link to comment
Share on other sites

You need to override #onItemUse in your custom seed class; from there, you can do any type of checking you want and plant your crop on any type of block you want. As your code is now, your seed uses the same logic as its parent class, the vanilla ItemSeed, which makes all sorts of checks for plant type / sustainability and you don't want any of that.

 

Here's an example of a seed that can be planted only on stone / rock-based blocks that are next to lava. As you can see, there is nothing that requires you to make the same checks as the vanilla seeds do.

Link to comment
Share on other sites

Guest
This topic is now closed to further replies.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Try deliting feur builder  It caused this issue in my modpack
    • I am not using hardcoded recipes, I'm using Vanilla's already existing code for leather armor dying. (via extending and implementing DyeableArmorItem / DyeableLeatherItem respectively) I have actually figured out that it's something to do with registering item colors to the ItemColors instance, but I'm trying to figure out where exactly in my mod's code I would be placing a call to the required event handler. Unfortunately the tutorial is criminally undescriptive. The most I've found is that it has to be done during client initialization. I'm currently trying to do the necessary setup via hijacking the item registry since trying to modify the item classes directly (via using SubscribeEvent in the item's constructor didn't work. Class so far: // mrrp mrow - mcmod item painter v1.0 - catzrule ch package catzadvitems.init; import net.minecraft.client.color.item.ItemColors; import net.minecraft.world.item.Item; import net.minecraftforge.registries.ObjectHolder; import net.minecraftforge.fml.event.lifecycle.FMLClientSetupEvent; import net.minecraftforge.fml.common.Mod; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.client.event.ColorHandlerEvent; import catzadvitems.item.DyeableWoolArmorItem; @Mod.EventBusSubscriber(bus = Mod.EventBusSubscriber.Bus.MOD) public class Painter { @ObjectHolder("cai:dyeable_wool_chestplate") public static final Item W_CHEST = null; @ObjectHolder("cai:dyeable_wool_leggings") public static final Item W_LEGS = null; @ObjectHolder("cai:dyeable_wool_boots") public static final Item W_SOCKS = null; public Painter() { // left blank, idk if forge throws a fit if constructors are missing, not taking the chance of it happening. } @SubscribeEvent public static void init(FMLClientSetupEvent event) { new Painter(); } @Mod.EventBusSubscriber private static class ForgeBusEvents { @SubscribeEvent public static void registerItemColors(ColorHandlerEvent.Item event) { ItemColors col = event.getItemColors(); col.register(DyeableUnderArmorItem::getItemDyedColor, W_CHEST, W_LEGS, W_SOCKS); //placeholder for other dye-able items here later.. } } } (for those wondering, i couldn't think of a creative wool helmet name)
    • nvm found out it was because i had create h and not f
    • Maybe there's something happening in the 'leather armor + dye' recipe itself that would be updating the held item texture?
    • @SubscribeEvent public static void onRenderPlayer(RenderPlayerEvent.Pre e) { e.setCanceled(true); model.renderToBuffer(e.getPoseStack(), pBuffer, e.getPackedLight(), 0f, 0f, 0f, 0f, 0f); //ToaPlayerRenderer.render(); } Since getting the render method from a separate class is proving to be bit of a brick wall for me (but seems to be the solution in older versions of minecraft/forge) I've decided to try and pursue using the renderToBuffer method directly from the model itself. I've tried this route before but can't figure out what variables to feed it for the vertexConsumer and still can't seem to figure it out; if this is even a path to pursue.  The vanilla model files do not include any form of render methods, and seem to be fully constructed from their layer definitions? Their renderer files seem to take their layers which are used by the render method in the vanilla MobRenderer class. But for modded entities we @Override this function and don't have to feed the method variables because of that? I assume that the render method in the extended renderer takes the layer definitions from the renderer classes which take those from the model files. Or maybe instead of trying to use a render method I should be calling the super from the renderer like   new ToaPlayerRenderer(context, false); Except I'm not sure what I would provide for context? There's a context method in the vanilla EntityRendererProvider class which doesn't look especially helpful. I've been trying something like <e.getEntity(), model<e.getEntity()>> since that generally seems to be what is provided to the renderers for context, but I don't know if it's THE context I'm looking for? Especially since the method being called doesn't want to take this or variations of this.   In short; I feel like I'm super super close but I have to be missing something obvious? Maybe this insane inane ramble post will provide some insight into this puzzle?
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.