Jump to content

Recommended Posts

Posted

Hi.

I made config with entity class names list. All working fine except checking:

 

String[] mob = Config.entityList.split(",");
    			
String[] mobNames = new String[mob.length];
    			
for(int i = 0; i < mob.length; i++)
{
    mobNames[i] = mob[i];
}

for (int i = 0; i < mobNames.length; i++)
{
    if (event.entity.class.getSimpleName() == mobNames[i])
    {
        //
    }
    else
    {
        System.out.println(event.entity.class.getSimpleName() + " --- "+ mobNames[i]);
    }
}

 

I getting it:

"EntityZombie --- EntityZombie"

 

Wt..?

Posted

You can't use == to compare strings in java. Use equals().

 

As to design - you should consider using class comprasions (isAssignableFrom() and EntityList.class from mc).

1.7.10 is no longer supported by forge, you are on your own.

Posted

Ernio is right, just use the Class#isAssignableFrom method.

 

The only reason to compare strings is if one of the objects isn't actually a class reference. i.e. I was read class names from the config file and had to validate against a class reference (and then because it's user-entered, I wanted to be able to check for typos, so there's some Levenshtein distance code in there too; inefficient as hell, but it only runs when there's no match for the supplied string).

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.