Jump to content

Recommended Posts

Posted

Hey guys,

I'm working on a big mod here, wrote about 10 custom mobs, 10 custom blocks, but when the items occur, i get stuck :S

I want to give a player a custom written book with some pages of text in it but I can't seem to get it working.

 

I've tried writing some NBT tags but that didn't seem to work :/ (Or i messed up)

Is there a way to let the player get an item from the creative menu (so really a custom item) and when the rightclick executes, it opens up a hard-coded text?

the item itself is already added to the menu etc. but i want it to have the text in it...

 

can you guys help me out?

 

thanks :)

Posted

Well, you'd need to do the NBT data on the ItemStack correctly.

 

Unfortunately I cannot locate the documentation regarding this, but it would be available by looking at the WrittenBook item class.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted

i tried to, but it didn't seem to work for some reason :/ so either i used the wrong method, OR i used the wrong tags, OR i messed up somewhere else... i tried an example from another mod [1.7] but the WrittenBook class is no longer a thing :/

Posted

this is my current item class:

package nl.JKCTech.fnaf.items;

import java.util.ArrayList;
import java.util.List;

import com.google.common.collect.Lists;

import net.minecraft.block.BlockContainer;
import net.minecraft.block.material.Material;
import net.minecraft.enchantment.Enchantment;
import net.minecraft.enchantment.EnchantmentData;
import net.minecraft.entity.Entity;
import net.minecraft.entity.EntityLiving;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.Item;
import net.minecraft.item.ItemBook;
import net.minecraft.item.ItemFireworkCharge;
import net.minecraft.item.ItemStack;
import net.minecraft.item.ItemWritableBook;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.nbt.NBTTagList;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.StatCollector;
import net.minecraft.world.World;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;

public class Manual extends ItemBook {

@SideOnly(Side.CLIENT)
    public boolean hasEffect(ItemStack stack)
    {
        return true;
    }

@Override
public void onUpdate(ItemStack itemstack, World world, Entity entity, int metadata, boolean bool)
{
	System.out.println("FIRED Update");
    if (itemstack.getTagCompound() == null)
    {
    	System.out.println("IF = Y");
    	itemstack.setTagCompound(new NBTTagCompound());
    	itemstack.getTagCompound().setString("author", "JKCTech");
     	itemstack.getTagCompound().setString("title", "Test");
    } else {
    	System.out.println("IF = N");
    }
}

public ItemStack onItemRightClick(ItemStack par1ItemStack, World par2World, EntityPlayer par3EntityPlayer)
{
	System.out.println("FIRED onRIghtClick");
	par3EntityPlayer.displayGUIBook(par1ItemStack);
	return par1ItemStack;
}
}

 

i've added some debug stuff as well, when receiving the item, the console outputs:

292c5b13e120d8720c1aafa1a230e9a2.png

 

when i right-click, the event also fires.

 

but just nothing happens...

i'm getting really confused.

 

i also checked the nbt data of both items, the data IS written, but it just doesn't get recognised as a book....

the only difference between the 2 is the item ID, and the fact my item doesn't contain pages (yet) since i don't exactly now how to do that... (Would also be of help)

Posted

this is my current item class:

package nl.JKCTech.fnaf.items;

import java.util.ArrayList;
import java.util.List;

import com.google.common.collect.Lists;

import net.minecraft.block.BlockContainer;
import net.minecraft.block.material.Material;
import net.minecraft.enchantment.Enchantment;
import net.minecraft.enchantment.EnchantmentData;
import net.minecraft.entity.Entity;
import net.minecraft.entity.EntityLiving;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.Item;
import net.minecraft.item.ItemBook;
import net.minecraft.item.ItemFireworkCharge;
import net.minecraft.item.ItemStack;
import net.minecraft.item.ItemWritableBook;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.nbt.NBTTagList;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.StatCollector;
import net.minecraft.world.World;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;

public class Manual extends ItemBook {

@SideOnly(Side.CLIENT)
    public boolean hasEffect(ItemStack stack)
    {
        return true;
    }

@Override
public void onUpdate(ItemStack itemstack, World world, Entity entity, int metadata, boolean bool)
{
	System.out.println("FIRED Update");
    if (itemstack.getTagCompound() == null)
    {
    	System.out.println("IF = Y");
    	itemstack.setTagCompound(new NBTTagCompound());
    	itemstack.getTagCompound().setString("author", "JKCTech");
     	itemstack.getTagCompound().setString("title", "Test");
    } else {
    	System.out.println("IF = N");
    }
}

public ItemStack onItemRightClick(ItemStack par1ItemStack, World par2World, EntityPlayer par3EntityPlayer)
{
	System.out.println("FIRED onRIghtClick");
	par3EntityPlayer.displayGUIBook(par1ItemStack);
	return par1ItemStack;
}
}

 

i've added some debug stuff as well, when receiving the item, the console outputs:

292c5b13e120d8720c1aafa1a230e9a2.png

 

when i right-click, the event also fires.

 

but just nothing happens...

i'm getting really confused.

 

i also checked the nbt data of both items, the data IS written, but it just doesn't get recognised as a book....

the only difference between the 2 is the item ID, and the fact my item doesn't contain pages (yet) since i don't exactly now how to do that... (Would also be of help)

Posted

Its not recognized as a written book because it's not an ItemWritableBook.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted

Its not recognized as a written book because it's not an ItemWritableBook.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted

do you mean it has to be the exact item? because i tried to extend the ItemWritableBook Class but still the same result, and if it has to be the ItemWritableBook item, how do i create a custom dupe?

Posted

do you mean it has to be the exact item? because i tried to extend the ItemWritableBook Class but still the same result, and if it has to be the ItemWritableBook item, how do i create a custom dupe?

Posted

You can just create a new ItemStack of the ItemWritableBook instance (check the

Items

list) and apply the correct NBT tags.

 

You can now clone and distribute this itemstack however.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted

You can just create a new ItemStack of the ItemWritableBook instance (check the

Items

list) and apply the correct NBT tags.

 

You can now clone and distribute this itemstack however.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.