Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

[1.8.9] While Holding Item Get Potion Effect?

Monstrous_Apple

By Monstrous_Apple
in Modder Support

 Share

Recommended Posts

Monstrous_Apple Creeper Killer

Monstrous_Apple

Posted
Posted

Okay so at the moment my gemstone gives the person regeneration 1 while it's in their inventory but what I want to happen is only while the player is holding the gemstone it will give the potion effect, does anyone know how to do this?

 

package com.MonstrousApple.mod.gemstones;

import com.MonstrousApple.mod.MAGlobal;

import net.minecraft.enchantment.Enchantment;
import net.minecraft.enchantment.EnchantmentHelper;
import net.minecraft.entity.Entity;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.entity.projectile.EntityArrow;
import net.minecraft.init.Items;
import net.minecraft.item.EnumAction;
import net.minecraft.item.Item;
import net.minecraft.item.Item.ToolMaterial;
import net.minecraft.item.ItemPickaxe;
import net.minecraft.item.ItemStack;
import net.minecraft.potion.Potion;
import net.minecraft.potion.PotionEffect;
import net.minecraft.stats.StatList;
import net.minecraft.world.World;

public class MAVitalityGemstone extends Item {

public MAVitalityGemstone(String unlocalizedName) {
	super();
	this.setUnlocalizedName(unlocalizedName);
	this.setCreativeTab(MAGlobal.maCreativeTabGemstones);
	this.setMaxStackSize(1);
}

@Override
public void onUpdate(ItemStack stack, World worldIn, Entity entityIn, int itemSlot, boolean isSelected) {
	if(stack.getItem() == MAGemstones.VitalityGemstone) {
		effectPlayer(entityIn, Potion.regeneration, 1 - 1);
	super.onUpdate(stack, worldIn, entityIn, itemSlot, isSelected);
}
}
	private void effectPlayer(Entity entityIn, Potion potion, int amplifier) {

		//((EntityLivingBase) entityIn).addPotionEffect(new PotionEffect(potion.id, 40, amplifier, true, true));
		EntityLivingBase player = (EntityLivingBase) entityIn;
		if (player.getActivePotionEffect(potion)== null || player.getActivePotionEffect(potion).getDuration() <=0)
			player.addPotionEffect(new PotionEffect(potion.id, 40 /** Duration */, amplifier, true, true));
}

}

Link to comment
Share on other sites
Draco18s Reality Controller

Draco18s

Posted
Posted

Regeneration works based on ticks remaining. If that value doesn't change, then no effect is actually granted.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites
Choonster Reality Controller

Choonster

Posted
Posted

The 

boolean

argument of 

Item#onUpdate

is whether the item is currently selected (held).

 

If you update to 1.9 (which you should) and want it to work in the off hand as well, you'll need to check if the entity's off hand item is the 

ItemStack

argument (like 

ItemMap

does).

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Link to comment
Share on other sites
Monstrous_Apple Creeper Killer

Monstrous_Apple

Posted
  • Author
Posted

Regeneration works based on ticks remaining. If that value doesn't change, then no effect is actually granted.

 

No it does regenerate but I want it to only work if holding it in your hand rather than in your inventory without being selected, if that makes sense?

 

Regeneration works based on ticks remaining. If that value doesn't change, then no effect is actually granted.

 

No it does regenerate but I want it to only work if holding it in your hand rather than in your inventory without being selected, if that makes sense?

Yeah but it still gives regeneration 1 even when not selected how do I change this?

 

Also I would update to 1.9 but I just don't like the combat system changes :P just my preference haha thanks though. :)

Link to comment
Share on other sites
YoungErtu Stone Miner

YoungErtu

Posted
Posted

Regeneration works based on ticks remaining. If that value doesn't change, then no effect is actually granted.

 

No it does regenerate but I want it to only work if holding it in your hand rather than in your inventory without being selected, if that makes sense?

 

Regeneration works based on ticks remaining. If that value doesn't change, then no effect is actually granted.

 

No it does regenerate but I want it to only work if holding it in your hand rather than in your inventory without being selected, if that makes sense?

Yeah but it still gives regeneration 1 even when not selected how do I change this?

 

Also I would update to 1.9 but I just don't like the combat system changes :P just my preference haha thanks though. :)

 

because you using the method which is always true, onUpdate is' executed every tick while the item is in the inventory.

 

you could simply make a if statement if the player is currently holding the item, like you know if the current holding item is the current itemstack, which activates this effect.

"My Crew is World Wide." 「ヤング • エルトウ」

Link to comment
Share on other sites
Monstrous_Apple Creeper Killer

Monstrous_Apple

Posted
  • Author
Posted

Okay now I have it so that when you hold the item then you will have the potion effects but now I need the timer to tick down so I can effects like regeneration to work, how would I do this?

 

Here's my code:

 

package com.MonstrousApple.mod.gemstones;

import com.MonstrousApple.mod.MAGlobal;

import net.minecraft.enchantment.Enchantment;
import net.minecraft.enchantment.EnchantmentHelper;
import net.minecraft.entity.Entity;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.entity.projectile.EntityArrow;
import net.minecraft.init.Items;
import net.minecraft.item.EnumAction;
import net.minecraft.item.Item;
import net.minecraft.item.Item.ToolMaterial;
import net.minecraft.item.ItemPickaxe;
import net.minecraft.item.ItemStack;
import net.minecraft.potion.Potion;
import net.minecraft.potion.PotionEffect;
import net.minecraft.stats.StatList;
import net.minecraft.world.World;

public class MAVitalityGemstone extends Item {

public MAVitalityGemstone(String unlocalizedName) {
	super();
	this.setUnlocalizedName(unlocalizedName);
	this.setCreativeTab(MAGlobal.maCreativeTabGemstones);
	this.setMaxStackSize(1);
}

private void effectPlayer(EntityPlayer player, Potion potion, int amplifier) {
	if (player.getActivePotionEffect(potion)== null || player.getActivePotionEffect(potion).getDuration() <=40)
		player.addPotionEffect(new PotionEffect(potion.id, 40 /** Duration */, amplifier, true, true));
}

public void onUpdate(ItemStack itemstack, World world, Entity entity, int i, boolean flag)
{
     if (entity instanceof EntityPlayer)
    	 
     {          EntityPlayer Player = (EntityPlayer) entity;
          if(Player.getCurrentEquippedItem() != null && Player.getCurrentEquippedItem().getItem() instanceof MAVitalityGemstone)
          {
        	  Player.addPotionEffect(new PotionEffect(Potion.regeneration.id, 1 - 1));
          }
          else
          { 
        	  Player.removePotionEffect(i);
          }
     }	 

/**@Override
public void onUpdate(ItemStack stack, World worldIn, Entity entityIn, int itemSlot, boolean isSelected) {
	if(stack.getItem() == MAGemstones.VitalityGemstone) {
		effectPlayer(entityIn, Potion.regeneration, 1 - 1);
	super.onUpdate(stack, worldIn, entityIn, itemSlot, isSelected);
}
}
	private void effectPlayer(Entity entityIn, Potion potion, int amplifier) {

		//((EntityLivingBase) entityIn).addPotionEffect(new PotionEffect(potion.id, 40, amplifier, true, true));
		EntityLivingBase player = (EntityLivingBase) entityIn;
		if (player.getActivePotionEffect(potion)== null || player.getActivePotionEffect(potion).getDuration() <=0)
			player.addPotionEffect(new PotionEffect(potion.id, 40 /** Duration *///, amplifier, true, true));
}
}

Link to comment
Share on other sites
Draco18s Reality Controller

Draco18s

Posted
Posted

Also, why are you adding the duration as 

1 - 1

?

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites
Draco18s Reality Controller

Draco18s

Posted
Posted

Also, why are you adding the duration as 

1 - 1

?

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites
Monstrous_Apple Creeper Killer

Monstrous_Apple

Posted
  • Author
Posted

  • Why are you still checking manually if the currently selected item is yours? Use the parameter to the onUpdate method, like you have been told already.
  • Do not add the potion effect every time.
  • The part where you remove the potion effect is useless, since when the item is no longer in your inventory, onUpdate will not be called anymore.

 

  • This doesn't need changing because at the moment if I am not holding my item the effect goes, well at least I don't think it needs changing?
  • Why? Or at least clarify what you mean?
  • No it's not useless because what I want to happen is only give the effect when held, so that means it can still be in your inventory and then it will not give the effect.

 

 

Also, why are you adding the duration as 

1 - 1

?

 

Was testing something lol

Link to comment
Share on other sites
Monstrous_Apple Creeper Killer

Monstrous_Apple

Posted
  • Author
Posted

  • Why are you still checking manually if the currently selected item is yours? Use the parameter to the onUpdate method, like you have been told already.
  • Do not add the potion effect every time.
  • The part where you remove the potion effect is useless, since when the item is no longer in your inventory, onUpdate will not be called anymore.

 

  • This doesn't need changing because at the moment if I am not holding my item the effect goes, well at least I don't think it needs changing?
  • Why? Or at least clarify what you mean?
  • No it's not useless because what I want to happen is only give the effect when held, so that means it can still be in your inventory and then it will not give the effect.

 

 

Also, why are you adding the duration as 

1 - 1

?

 

Was testing something lol

Link to comment
Share on other sites
Monstrous_Apple Creeper Killer

Monstrous_Apple

Posted
  • Author
Posted

Okay I'll say what I need to do at this moment, I need it so that when I am not holding the item, the potion effect goes completely, even if it starts at 4 seconds, ends at 0 seconds, and currently is on 2 seconds duration left, it will disappear.

 

I also need it so that when holding the item the duration of the potion effect still ticks even while holding the item, so that regeneration will work, so for example I hold the gem it gives 4 seconds of regeneration, it ticks down to 0 and then refreshes to 4 again, but of course if the item is not held at any point, the regeneration effect completely goes even if it's not reached 0 seconds yet.

 

 

This is what my code looks like at the moment:

 

package com.MonstrousApple.mod.gemstones;

import com.MonstrousApple.mod.MAGlobal;

import net.minecraft.enchantment.Enchantment;
import net.minecraft.enchantment.EnchantmentHelper;
import net.minecraft.entity.Entity;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.entity.projectile.EntityArrow;
import net.minecraft.init.Items;
import net.minecraft.item.EnumAction;
import net.minecraft.item.Item;
import net.minecraft.item.Item.ToolMaterial;
import net.minecraft.item.ItemPickaxe;
import net.minecraft.item.ItemStack;
import net.minecraft.potion.Potion;
import net.minecraft.potion.PotionEffect;
import net.minecraft.stats.StatList;
import net.minecraft.world.World;

public class MAVitalityGemstone extends Item {

public MAVitalityGemstone(String unlocalizedName) {
	super();
	this.setUnlocalizedName(unlocalizedName);
	this.setCreativeTab(MAGlobal.maCreativeTabGemstones);
	this.setMaxStackSize(1);
}

public void onUpdate(ItemStack itemstack, World world, Entity entity, int i, boolean flag)
{
     if (entity instanceof EntityPlayer)
    	 
     {          EntityPlayer Player = (EntityPlayer) entity;
          if(Player.getCurrentEquippedItem() != null && Player.getCurrentEquippedItem().getItem() instanceof MAVitalityGemstone)
        	  
          {
        	  Player.addPotionEffect(new PotionEffect(Potion.regeneration.id, 50, 1 - 1));
          }
          else
          { 
        	  Player.removePotionEffect(i);
          }
     }	 
}
     }
}

Link to comment
Share on other sites
Monstrous_Apple Creeper Killer

Monstrous_Apple

Posted
  • Author
Posted

Okay I'll say what I need to do at this moment, I need it so that when I am not holding the item, the potion effect goes completely, even if it starts at 4 seconds, ends at 0 seconds, and currently is on 2 seconds duration left, it will disappear.

 

I also need it so that when holding the item the duration of the potion effect still ticks even while holding the item, so that regeneration will work, so for example I hold the gem it gives 4 seconds of regeneration, it ticks down to 0 and then refreshes to 4 again, but of course if the item is not held at any point, the regeneration effect completely goes even if it's not reached 0 seconds yet.

 

 

This is what my code looks like at the moment:

 

package com.MonstrousApple.mod.gemstones;

import com.MonstrousApple.mod.MAGlobal;

import net.minecraft.enchantment.Enchantment;
import net.minecraft.enchantment.EnchantmentHelper;
import net.minecraft.entity.Entity;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.entity.projectile.EntityArrow;
import net.minecraft.init.Items;
import net.minecraft.item.EnumAction;
import net.minecraft.item.Item;
import net.minecraft.item.Item.ToolMaterial;
import net.minecraft.item.ItemPickaxe;
import net.minecraft.item.ItemStack;
import net.minecraft.potion.Potion;
import net.minecraft.potion.PotionEffect;
import net.minecraft.stats.StatList;
import net.minecraft.world.World;

public class MAVitalityGemstone extends Item {

public MAVitalityGemstone(String unlocalizedName) {
	super();
	this.setUnlocalizedName(unlocalizedName);
	this.setCreativeTab(MAGlobal.maCreativeTabGemstones);
	this.setMaxStackSize(1);
}

public void onUpdate(ItemStack itemstack, World world, Entity entity, int i, boolean flag)
{
     if (entity instanceof EntityPlayer)
    	 
     {          EntityPlayer Player = (EntityPlayer) entity;
          if(Player.getCurrentEquippedItem() != null && Player.getCurrentEquippedItem().getItem() instanceof MAVitalityGemstone)
        	  
          {
        	  Player.addPotionEffect(new PotionEffect(Potion.regeneration.id, 50, 1 - 1));
          }
          else
          { 
        	  Player.removePotionEffect(i);
          }
     }	 
}
     }
}

Link to comment
Share on other sites
Draco18s Reality Controller

Draco18s

Posted
Posted

Jeus H Chirst on a fucking stick.

 

public void onUpdate(ItemStack itemstack, World world, Entity entity, int i, boolean am_I_holding_this_item) {
    if(am_I_holding_this_item) {
        Player.addPotionEffect(new PotionEffect(Potion.regeneration.id, 50, 0));
    }
}

 

Fuck.

 

Was it really that hard?

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites
Draco18s Reality Controller

Draco18s

Posted
Posted

Jeus H Chirst on a fucking stick.

 

public void onUpdate(ItemStack itemstack, World world, Entity entity, int i, boolean am_I_holding_this_item) {
    if(am_I_holding_this_item) {
        Player.addPotionEffect(new PotionEffect(Potion.regeneration.id, 50, 0));
    }
}

 

Fuck.

 

Was it really that hard?

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites
Monstrous_Apple Creeper Killer

Monstrous_Apple

Posted
  • Author
Posted

Jeus H Chirst on a fucking stick.

 

public void onUpdate(ItemStack itemstack, World world, Entity entity, int i, boolean am_I_holding_this_item) {
    if(am_I_holding_this_item) {
        Player.addPotionEffect(new PotionEffect(Potion.regeneration.id, 50, 0));
    }
}

 

Fuck.

 

Was it really that hard?

 

Removed my code and tried yours, doesn't work, says I get an error at ".addPotionEffect" saying that "The method addPotionEffect(PotionEffect) is undefined for the type player"?

Link to comment
Share on other sites
Monstrous_Apple Creeper Killer

Monstrous_Apple

Posted
  • Author
Posted

Jeus H Chirst on a fucking stick.

 

public void onUpdate(ItemStack itemstack, World world, Entity entity, int i, boolean am_I_holding_this_item) {
    if(am_I_holding_this_item) {
        Player.addPotionEffect(new PotionEffect(Potion.regeneration.id, 50, 0));
    }
}

 

Fuck.

 

Was it really that hard?

 

Removed my code and tried yours, doesn't work, says I get an error at ".addPotionEffect" saying that "The method addPotionEffect(PotionEffect) is undefined for the type player"?

Link to comment
Share on other sites
pickaxe_engineer Stone Miner

pickaxe_engineer

Posted
Posted

Hi

 

Did you really just copy the code?

If you would have posted your code, we could better see why it's not working.

I for my self had 3 minutes after reading this post an item giving any potion effect upon beeing held in the offhand for mc 1.9

 

Sincerely -pick

Since English is not my mother tongue, my sentences may are confusing.

 

I'm coding java for a long time now - just MC and forge stop me sometimes.

Link to comment
Share on other sites
pickaxe_engineer Stone Miner

pickaxe_engineer

Posted
Posted

Hi

 

Did you really just copy the code?

If you would have posted your code, we could better see why it's not working.

I for my self had 3 minutes after reading this post an item giving any potion effect upon beeing held in the offhand for mc 1.9

 

Sincerely -pick

Since English is not my mother tongue, my sentences may are confusing.

 

I'm coding java for a long time now - just MC and forge stop me sometimes.

Link to comment
Share on other sites
Monstrous_Apple Creeper Killer

Monstrous_Apple

Posted
  • Author
Posted

I did post my code on post #9 :) I'll post it again here:

 

package com.MonstrousApple.mod.gemstones;

import com.MonstrousApple.mod.MAGlobal;

import net.minecraft.enchantment.Enchantment;
import net.minecraft.enchantment.EnchantmentHelper;
import net.minecraft.entity.Entity;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.entity.projectile.EntityArrow;
import net.minecraft.init.Items;
import net.minecraft.item.EnumAction;
import net.minecraft.item.Item;
import net.minecraft.item.Item.ToolMaterial;
import net.minecraft.item.ItemPickaxe;
import net.minecraft.item.ItemStack;
import net.minecraft.potion.Potion;
import net.minecraft.potion.PotionEffect;
import net.minecraft.stats.StatList;
import net.minecraft.world.World;

public class MAVitalityGemstone extends Item {

public MAVitalityGemstone(String unlocalizedName) {
	super();
	this.setUnlocalizedName(unlocalizedName);
	this.setCreativeTab(MAGlobal.maCreativeTabGemstones);
	this.setMaxStackSize(1);
}

public void onUpdate(ItemStack itemstack, World world, Entity entity, int i, boolean flag)
{
     if (entity instanceof EntityPlayer)
    	 
     {          EntityPlayer Player = (EntityPlayer) entity;
          if(Player.getCurrentEquippedItem() != null && Player.getCurrentEquippedItem().getItem() instanceof MAVitalityGemstone)
        	  
          {
        	  Player.addPotionEffect(new PotionEffect(Potion.regeneration.id, 50, 1 - 1));
          }
          else
          { 
        	  Player.removePotionEffect(i);
          }
     }	 
}
     }
}

Link to comment
Share on other sites
Monstrous_Apple Creeper Killer

Monstrous_Apple

Posted
  • Author
Posted

I did post my code on post #9 :) I'll post it again here:

 

package com.MonstrousApple.mod.gemstones;

import com.MonstrousApple.mod.MAGlobal;

import net.minecraft.enchantment.Enchantment;
import net.minecraft.enchantment.EnchantmentHelper;
import net.minecraft.entity.Entity;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.entity.projectile.EntityArrow;
import net.minecraft.init.Items;
import net.minecraft.item.EnumAction;
import net.minecraft.item.Item;
import net.minecraft.item.Item.ToolMaterial;
import net.minecraft.item.ItemPickaxe;
import net.minecraft.item.ItemStack;
import net.minecraft.potion.Potion;
import net.minecraft.potion.PotionEffect;
import net.minecraft.stats.StatList;
import net.minecraft.world.World;

public class MAVitalityGemstone extends Item {

public MAVitalityGemstone(String unlocalizedName) {
	super();
	this.setUnlocalizedName(unlocalizedName);
	this.setCreativeTab(MAGlobal.maCreativeTabGemstones);
	this.setMaxStackSize(1);
}

public void onUpdate(ItemStack itemstack, World world, Entity entity, int i, boolean flag)
{
     if (entity instanceof EntityPlayer)
    	 
     {          EntityPlayer Player = (EntityPlayer) entity;
          if(Player.getCurrentEquippedItem() != null && Player.getCurrentEquippedItem().getItem() instanceof MAVitalityGemstone)
        	  
          {
        	  Player.addPotionEffect(new PotionEffect(Potion.regeneration.id, 50, 1 - 1));
          }
          else
          { 
        	  Player.removePotionEffect(i);
          }
     }	 
}
     }
}

Link to comment
Share on other sites
Draco18s Reality Controller

Draco18s

Posted
Posted

Was it really that hard?

 

Apparently. :|

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites
Draco18s Reality Controller

Draco18s

Posted
Posted

Was it really that hard?

 

Apparently. :|

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



  • Recently Browsing

    • No registered users viewing this page.

  • Posts

    • DaCrankyLizard
      Join a Minecraft Civilization! (Worldbuilding and Roleplay!)

      By DaCrankyLizard · Posted

      Join one of the largest civilization experiments in Minecraft under our banner!   Our goal is to create the largest and most prominent civilization across the entirety of Minecraft, and we’d like you to join! We offer lots of unique roles and jobs that tailor to your specific skillset in Minecraft! You can build a city, participate in the government, or fight for Gold, God, and Glory on the battlefield!   Join our nation today! https://discord.gg/hb3cuaDezA
    • sfxprt2
      1.18.2 How To Save LevelChunk Capability Or Mark Chunk Dirty

      By sfxprt2 · Posted

      I have an issue where after I exit the world the capability data does not save when I reload the world. It will save the initial data such as village name but if I modify any data during gameplay theres a 5% chance the data saves when I exit then reload the world. I read the docs and was told that chunks need to be marked dirty but the docs does not say how to mark the chunk dirty... Heres the provider: public class ChunkCapProvider implements ICapabilityProvider, ICapabilitySerializable<CompoundTag> { private final Capability<IChunk> capability = ChunkCapability.CHUNK_CAPABILITY; private final ChunkCapability instance = new ChunkCapability(); private final LazyOptional lazy = LazyOptional.of(()->instance).cast(); public void invalidate(){ lazy.invalidate(); } @Nonnull @Override public <T> LazyOptional<T> getCapability(@Nonnull Capability<T> cap, @Nullable Direction direction) { if(cap == capability ) return lazy; return LazyOptional.empty(); } @Override public CompoundTag serializeNBT() { return instance.serializeNBT(); } @Override public void deserializeNBT(CompoundTag tag) { instance.deserializeNBT(tag); } }   Heres the capability class: public class ChunkCapability implements IChunk { public static final ResourceLocation ID = new ResourceLocation(Main.MODID, "owner"); public static final String VILLAGE_NAME = "village_name"; public static final String SAVED_ROLES = "saved_roles"; public static final String SAVED_POINTS = "saved_points"; public static final String BAD_CHUNK = "BAD_VILLAGE_CHUNK"; public static Capability<IChunk> CHUNK_CAPABILITY = null; private String villageName = "BAD_VILLAGE_CHUNK"; private String savedRoles = ""; private String savedPoints = ""; public ChunkCapability(){ this.getClass(); } @Override public CompoundTag serializeNBT() { CompoundTag nbt = new CompoundTag(); nbt.putString(SAVED_ROLES, this.savedRoles); nbt.putString(SAVED_POINTS, this.savedPoints); nbt.putString(VILLAGE_NAME, this.villageName); return nbt; } public void deserializeNBT(CompoundTag tag) { this.setVillageName(tag.getString(VILLAGE_NAME)); this.setSavedRoles(tag.getString(SAVED_ROLES)); this.setSavedPoints(tag.getString(SAVED_POINTS)); } public String getVillageName() { return this.villageName; } public void setVillageName(String str) { this.villageName = str; } public void setSavedRoles(String str) { this.savedRoles = str; } public void setRole(String name, String role){ if(!this.hasRole(name)) { this.savedRoles += (name + ":" + role + ","); this.savedPoints += (name + ":" + 10 + ","); return; } String roleName = this.getRole(name); String firstStr = this.savedRoles.substring(0, this.savedRoles.indexOf(name + ":") + name.length() + 1); String lastStr = this.savedRoles.substring(this.savedRoles.indexOf(name + ":") + ((name.length() + 1) + roleName.length())); this.savedRoles = firstStr + role + lastStr; } public String getRole(String name){ if(this.savedRoles.isEmpty() || !this.savedRoles.contains(name)) { this.setRole(name, Roles.Role.FOREIGNER.getName()); } String fStr = this.savedRoles.substring(this.savedRoles.indexOf(name + ":"), this.savedRoles.indexOf(',')); return fStr.substring(fStr.indexOf(':') + 1); } public boolean hasRole(String name) { if(this.savedRoles.isEmpty()) return false; return this.savedRoles.contains(name); } public String getSavedRoles() { return this.savedRoles; } public String getSavedPoints() { return this.savedPoints; } public void setSavedPoints(String name) { this.savedPoints = name; } public int getPoints(String name) { if(this.savedPoints.isEmpty() || !this.savedRoles.contains(name)) this.setPoints(name, 10); String fStr = this.savedPoints.substring(this.savedPoints.indexOf(name + ':')); return Integer.parseInt(fStr.substring(fStr.indexOf(':') + 1, fStr.indexOf(','))); } public void setPoints(String name, int rV) { if(!this.hasPoints(name)){ this.savedPoints += (name + ":" + rV + ","); return; } String oldPoints = String.valueOf(this.getPoints(name)); String points = String.valueOf(rV); String firstStr = this.savedPoints.substring(0, this.savedPoints.indexOf(name + ":") + name.length() + 1); String lastStr = this.savedPoints.substring(this.savedPoints.indexOf(name + ":") + ((name.length() + 1) + oldPoints.length())); Minecraft.getInstance().player.displayClientMessage(Component.nullToEmpty("Saved String: " + (firstStr + points + lastStr)), false); this.savedPoints = (firstStr + points + lastStr); } public boolean hasPoints(String name) { if(this.savedPoints.isEmpty()) return false; return this.savedPoints.contains(name); } }   Heres where I attach/register: @Mod.EventBusSubscriber(modid = Main.MODID) public class CapabilityEvents { @SubscribeEvent public static void attachCapability(AttachCapabilitiesEvent<LevelChunk> event){ ChunkCapProvider provider = new ChunkCapProvider(); event.addCapability(ChunkCapability.ID, provider); event.addListener(provider::invalidate); } }  
    • sfxprt2
      [1.20.2] How locate the nearest instance of a structure?

      By sfxprt2 · Posted

      Id use this ServerLevel#findNearestMapFeature  
    • CharaDemon
      Tinkers Construct, Buildcraft and Blood Arsenal error [1.7.10]

      By CharaDemon · Posted

      Trying to play with the mods: Tinkers Construct, Buildcraft and the Blood Magic addon Blood Arsenal; the game crashes. I noticed that when trying to use only two of the three in any combination the game opens without problems, but when trying to put all three together the error occurs. Is there any configuration I can modify or any other way to solve the problem?   ---- Minecraft Crash Report ---- // Hi. I'm Minecraft, and I'm a crashaholic. Time: 5/22/24 8:48 PM Description: There was a severe problem during mod loading that has caused the game to fail cpw.mods.fml.common.LoaderException: java.lang.NoClassDefFoundError: tconstruct/library/weaponry/AmmoWeapon     at cpw.mods.fml.common.LoadController.transition(LoadController.java:163)     at cpw.mods.fml.common.Loader.loadMods(Loader.java:544)     at cpw.mods.fml.client.FMLClientHandler.beginMinecraftLoading(FMLClientHandler.java:208)     at net.minecraft.client.Minecraft.func_71384_a(Minecraft.java:480)     at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:878)     at net.minecraft.client.main.Main.main(SourceFile:148)     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)     at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)     at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)     at java.lang.reflect.Method.invoke(Unknown Source)     at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)     at net.minecraft.launchwrapper.Launch.main(Launch.java:28) Caused by: java.lang.NoClassDefFoundError: tconstruct/library/weaponry/AmmoWeapon     at java.lang.Class.forName0(Native Method)     at java.lang.Class.forName(Unknown Source)     at cpw.mods.fml.common.ProxyInjector.inject(ProxyInjector.java:42)     at cpw.mods.fml.common.FMLModContainer.constructMod(FMLModContainer.java:512)     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)     at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)     at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)     at java.lang.reflect.Method.invoke(Unknown Source)     at com.google.common.eventbus.EventSubscriber.handleEvent(EventSubscriber.java:74)     at com.google.common.eventbus.SynchronizedEventSubscriber.handleEvent(SynchronizedEventSubscriber.java:47)     at com.google.common.eventbus.EventBus.dispatch(EventBus.java:322)     at com.google.common.eventbus.EventBus.dispatchQueuedEvents(EventBus.java:304)     at com.google.common.eventbus.EventBus.post(EventBus.java:275)     at cpw.mods.fml.common.LoadController.sendEventToModContainer(LoadController.java:212)     at cpw.mods.fml.common.LoadController.propogateStateMessage(LoadController.java:190)     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)     at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)     at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)     at java.lang.reflect.Method.invoke(Unknown Source)     at com.google.common.eventbus.EventSubscriber.handleEvent(EventSubscriber.java:74)     at com.google.common.eventbus.SynchronizedEventSubscriber.handleEvent(SynchronizedEventSubscriber.java:47)     at com.google.common.eventbus.EventBus.dispatch(EventBus.java:322)     at com.google.common.eventbus.EventBus.dispatchQueuedEvents(EventBus.java:304)     at com.google.common.eventbus.EventBus.post(EventBus.java:275)     at cpw.mods.fml.common.LoadController.distributeStateMessage(LoadController.java:119)     at cpw.mods.fml.common.Loader.loadMods(Loader.java:513)     ... 10 more Caused by: java.lang.ClassNotFoundException: tconstruct.library.weaponry.AmmoWeapon     at net.minecraft.launchwrapper.LaunchClassLoader.findClass(LaunchClassLoader.java:191)     at java.lang.ClassLoader.loadClass(Unknown Source)     at java.lang.ClassLoader.loadClass(Unknown Source)     ... 36 more Caused by: java.lang.NoClassDefFoundError: tconstruct/library/weaponry/AmmoItem     at java.lang.ClassLoader.defineClass1(Native Method)     at java.lang.ClassLoader.defineClass(Unknown Source)     at java.security.SecureClassLoader.defineClass(Unknown Source)     at net.minecraft.launchwrapper.LaunchClassLoader.findClass(LaunchClassLoader.java:182)     ... 38 more Caused by: java.lang.ClassNotFoundException: tconstruct.library.weaponry.AmmoItem     at net.minecraft.launchwrapper.LaunchClassLoader.findClass(LaunchClassLoader.java:101)     at java.lang.ClassLoader.loadClass(Unknown Source)     at java.lang.ClassLoader.loadClass(Unknown Source)     ... 42 more A detailed walkthrough of the error, its code path and all known details is as follows: --------------------------------------------------------------------------------------- -- System Details -- Details:     Minecraft Version: 1.7.10     Operating System: Windows 10 (x86) version 10.0     Java Version: 1.8.0_411, Oracle Corporation     Java VM Version: Java HotSpot(TM) Client VM (mixed mode, sharing), Oracle Corporation     Memory: 271923192 bytes (259 MB) / 402653184 bytes (384 MB) up to 536870912 bytes (512 MB)     JVM Flags: 9 total; -Xmx512M -XX:+UnlockExperimentalVMOptions -XX:+UseG1GC -XX:G1NewSizePercent=20 -XX:G1ReservePercent=20 -XX:MaxGCPauseMillis=50 -XX:G1HeapRegionSize=32M -XX:+IgnoreUnrecognizedVMOptions -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump     AABB Pool Size: 0 (0 bytes; 0 MB) allocated, 0 (0 bytes; 0 MB) used     IntCache: cache: 0, tcache: 0, allocated: 0, tallocated: 0     FML: MCP v9.05 FML v7.10.99.99 Minecraft Forge 10.13.4.1614 14 mods loaded, 14 mods active     States: 'U' = Unloaded 'L' = Loaded 'C' = Constructed 'H' = Pre-initialized 'I' = Initialized 'J' = Post-initialized 'A' = Available 'D' = Disabled 'E' = Errored     UC    mcp{9.05} [Minecraft Coder Pack] (minecraft.jar)      UC    FML{7.10.99.99} [Forge Mod Loader] (forge-1.7.10-10.13.4.1614-1.7.10.jar)      UC    Forge{10.13.4.1614} [Minecraft Forge] (forge-1.7.10-10.13.4.1614-1.7.10.jar)      UC    AWWayofTime{v1.3.3} [Blood Magic: Alchemical Wizardry] (BloodMagic-1.7.10-1.3.3-17.jar)      UC    Mantle{1.7.10-0.3.2.jenkins191} [Mantle] (Mantle-1.7.10-0.3.2b.jar)      UE    TConstruct{1.7.10-1.8.8.build991} [Tinkers' Construct] (TConstruct-1.7.10-1.8.8.build991.jar)      UC    BloodArsenal{1.2-5} [Blood Arsenal] (BloodArsenal-1.7.10-1.2-5.jar)      UC    BuildCraft|Core{7.1.25} [BuildCraft] (buildcraft-7.1.25.jar)      UC    BuildCraft|Builders{7.1.25} [BC Builders] (buildcraft-7.1.25.jar)      UC    BuildCraft|Robotics{7.1.25} [BC Robotics] (buildcraft-7.1.25.jar)      UC    BuildCraft|Silicon{7.1.25} [BC Silicon] (buildcraft-7.1.25.jar)      UC    BuildCraft|Energy{7.1.25} [BC Energy] (buildcraft-7.1.25.jar)      UC    BuildCraft|Transport{7.1.25} [BC Transport] (buildcraft-7.1.25.jar)      UC    BuildCraft|Factory{7.1.25} [BC Factory] (buildcraft-7.1.25.jar)      GL info: ' Vendor: 'Intel' Version: '4.4.0 - Build 21.20.16.4541' Renderer: 'Intel(R) HD Graphics 610'     Mantle Environment: Environment healthy.     TConstruct Environment: Environment healthy.
    • Firebird_Films
      Modpack keeps crashing. In need of assistance

      By Firebird_Films · Posted

      fixed this problem but now i have a new one  java.lang.RuntimeException: java.lang.NoSuchFieldException: processor  Help 

  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept