[1.8.9] While Holding Item Get Potion Effect?

[Monstrous_Apple]

Okay so at the moment my gemstone gives the person regeneration 1 while it's in their inventory but what I want to happen is only while the player is holding the gemstone it will give the potion effect, does anyone know how to do this?

 

package com.MonstrousApple.mod.gemstones;

import com.MonstrousApple.mod.MAGlobal;

import net.minecraft.enchantment.Enchantment;
import net.minecraft.enchantment.EnchantmentHelper;
import net.minecraft.entity.Entity;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.entity.projectile.EntityArrow;
import net.minecraft.init.Items;
import net.minecraft.item.EnumAction;
import net.minecraft.item.Item;
import net.minecraft.item.Item.ToolMaterial;
import net.minecraft.item.ItemPickaxe;
import net.minecraft.item.ItemStack;
import net.minecraft.potion.Potion;
import net.minecraft.potion.PotionEffect;
import net.minecraft.stats.StatList;
import net.minecraft.world.World;

public class MAVitalityGemstone extends Item {

public MAVitalityGemstone(String unlocalizedName) {
	super();
	this.setUnlocalizedName(unlocalizedName);
	this.setCreativeTab(MAGlobal.maCreativeTabGemstones);
	this.setMaxStackSize(1);
}

@Override
public void onUpdate(ItemStack stack, World worldIn, Entity entityIn, int itemSlot, boolean isSelected) {
	if(stack.getItem() == MAGemstones.VitalityGemstone) {
		effectPlayer(entityIn, Potion.regeneration, 1 - 1);
	super.onUpdate(stack, worldIn, entityIn, itemSlot, isSelected);
}
}
	private void effectPlayer(Entity entityIn, Potion potion, int amplifier) {

		//((EntityLivingBase) entityIn).addPotionEffect(new PotionEffect(potion.id, 40, amplifier, true, true));
		EntityLivingBase player = (EntityLivingBase) entityIn;
		if (player.getActivePotionEffect(potion)== null || player.getActivePotionEffect(potion).getDuration() <=0)
			player.addPotionEffect(new PotionEffect(potion.id, 40 /** Duration */, amplifier, true, true));
}

}

[Draco18s]

Regeneration works based on ticks remaining. If that value doesn't change, then no effect is actually granted.

[Choonster]

The

boolean

argument of

Item#onUpdate

is whether the item is currently selected (held).

 

If you update to 1.9 (which you should) and want it to work in the off hand as well, you'll need to check if the entity's off hand item is the

ItemStack

argument (like

ItemMap

does).

[Monstrous_Apple]

Regeneration works based on ticks remaining. If that value doesn't change, then no effect is actually granted.

 

No it does regenerate but I want it to only work if holding it in your hand rather than in your inventory without being selected, if that makes sense?

 

Regeneration works based on ticks remaining. If that value doesn't change, then no effect is actually granted.

 

No it does regenerate but I want it to only work if holding it in your hand rather than in your inventory without being selected, if that makes sense?

Yeah but it still gives regeneration 1 even when not selected how do I change this?

 

Also I would update to 1.9 but I just don't like the combat system changes just my preference haha thanks though.

[YoungErtu]

Regeneration works based on ticks remaining. If that value doesn't change, then no effect is actually granted.

 

No it does regenerate but I want it to only work if holding it in your hand rather than in your inventory without being selected, if that makes sense?

 

Regeneration works based on ticks remaining. If that value doesn't change, then no effect is actually granted.

 

No it does regenerate but I want it to only work if holding it in your hand rather than in your inventory without being selected, if that makes sense?

Yeah but it still gives regeneration 1 even when not selected how do I change this?

 

Also I would update to 1.9 but I just don't like the combat system changes just my preference haha thanks though.

 

because you using the method which is always true, onUpdate is' executed every tick while the item is in the inventory.

 

you could simply make a if statement if the player is currently holding the item, like you know if the current holding item is the current itemstack, which activates this effect.

[Monstrous_Apple]

Okay now I have it so that when you hold the item then you will have the potion effects but now I need the timer to tick down so I can effects like regeneration to work, how would I do this?

 

Here's my code:

 

package com.MonstrousApple.mod.gemstones;

import com.MonstrousApple.mod.MAGlobal;

import net.minecraft.enchantment.Enchantment;
import net.minecraft.enchantment.EnchantmentHelper;
import net.minecraft.entity.Entity;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.entity.projectile.EntityArrow;
import net.minecraft.init.Items;
import net.minecraft.item.EnumAction;
import net.minecraft.item.Item;
import net.minecraft.item.Item.ToolMaterial;
import net.minecraft.item.ItemPickaxe;
import net.minecraft.item.ItemStack;
import net.minecraft.potion.Potion;
import net.minecraft.potion.PotionEffect;
import net.minecraft.stats.StatList;
import net.minecraft.world.World;

public class MAVitalityGemstone extends Item {

public MAVitalityGemstone(String unlocalizedName) {
	super();
	this.setUnlocalizedName(unlocalizedName);
	this.setCreativeTab(MAGlobal.maCreativeTabGemstones);
	this.setMaxStackSize(1);
}

private void effectPlayer(EntityPlayer player, Potion potion, int amplifier) {
	if (player.getActivePotionEffect(potion)== null || player.getActivePotionEffect(potion).getDuration() <=40)
		player.addPotionEffect(new PotionEffect(potion.id, 40 /** Duration */, amplifier, true, true));
}

public void onUpdate(ItemStack itemstack, World world, Entity entity, int i, boolean flag)
{
     if (entity instanceof EntityPlayer)
    	 
     {          EntityPlayer Player = (EntityPlayer) entity;
          if(Player.getCurrentEquippedItem() != null && Player.getCurrentEquippedItem().getItem() instanceof MAVitalityGemstone)
          {
        	  Player.addPotionEffect(new PotionEffect(Potion.regeneration.id, 1 - 1));
          }
          else
          { 
        	  Player.removePotionEffect(i);
          }
     }	 

/**@Override
public void onUpdate(ItemStack stack, World worldIn, Entity entityIn, int itemSlot, boolean isSelected) {
	if(stack.getItem() == MAGemstones.VitalityGemstone) {
		effectPlayer(entityIn, Potion.regeneration, 1 - 1);
	super.onUpdate(stack, worldIn, entityIn, itemSlot, isSelected);
}
}
	private void effectPlayer(Entity entityIn, Potion potion, int amplifier) {

		//((EntityLivingBase) entityIn).addPotionEffect(new PotionEffect(potion.id, 40, amplifier, true, true));
		EntityLivingBase player = (EntityLivingBase) entityIn;
		if (player.getActivePotionEffect(potion)== null || player.getActivePotionEffect(potion).getDuration() <=0)
			player.addPotionEffect(new PotionEffect(potion.id, 40 /** Duration *///, amplifier, true, true));
}
}

[Draco18s]

Also, why are you adding the duration as

1 - 1

?

[Draco18s]

Also, why are you adding the duration as

1 - 1

?

[Monstrous_Apple]

• Why are you still checking manually if the currently selected item is yours? Use the parameter to the onUpdate method, like you have been told already.
  
• Do not add the potion effect every time.
  
• The part where you remove the potion effect is useless, since when the item is no longer in your inventory, onUpdate will not be called anymore.

 

• This doesn't need changing because at the moment if I am not holding my item the effect goes, well at least I don't think it needs changing?
  
• Why? Or at least clarify what you mean?
  
• No it's not useless because what I want to happen is only give the effect when held, so that means it can still be in your inventory and then it will not give the effect.
  

 

 

Also, why are you adding the duration as

1 - 1

?

 

Was testing something lol

[Monstrous_Apple]

• Why are you still checking manually if the currently selected item is yours? Use the parameter to the onUpdate method, like you have been told already.
  
• Do not add the potion effect every time.
  
• The part where you remove the potion effect is useless, since when the item is no longer in your inventory, onUpdate will not be called anymore.

 

• This doesn't need changing because at the moment if I am not holding my item the effect goes, well at least I don't think it needs changing?
  
• Why? Or at least clarify what you mean?
  
• No it's not useless because what I want to happen is only give the effect when held, so that means it can still be in your inventory and then it will not give the effect.
  

 

 

Also, why are you adding the duration as

1 - 1

?

 

Was testing something lol

[Monstrous_Apple]

Okay I'll say what I need to do at this moment, I need it so that when I am not holding the item, the potion effect goes completely, even if it starts at 4 seconds, ends at 0 seconds, and currently is on 2 seconds duration left, it will disappear.

 

I also need it so that when holding the item the duration of the potion effect still ticks even while holding the item, so that regeneration will work, so for example I hold the gem it gives 4 seconds of regeneration, it ticks down to 0 and then refreshes to 4 again, but of course if the item is not held at any point, the regeneration effect completely goes even if it's not reached 0 seconds yet.

 

 

This is what my code looks like at the moment:

 

package com.MonstrousApple.mod.gemstones;

import com.MonstrousApple.mod.MAGlobal;

import net.minecraft.enchantment.Enchantment;
import net.minecraft.enchantment.EnchantmentHelper;
import net.minecraft.entity.Entity;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.entity.projectile.EntityArrow;
import net.minecraft.init.Items;
import net.minecraft.item.EnumAction;
import net.minecraft.item.Item;
import net.minecraft.item.Item.ToolMaterial;
import net.minecraft.item.ItemPickaxe;
import net.minecraft.item.ItemStack;
import net.minecraft.potion.Potion;
import net.minecraft.potion.PotionEffect;
import net.minecraft.stats.StatList;
import net.minecraft.world.World;

public class MAVitalityGemstone extends Item {

public MAVitalityGemstone(String unlocalizedName) {
	super();
	this.setUnlocalizedName(unlocalizedName);
	this.setCreativeTab(MAGlobal.maCreativeTabGemstones);
	this.setMaxStackSize(1);
}

public void onUpdate(ItemStack itemstack, World world, Entity entity, int i, boolean flag)
{
     if (entity instanceof EntityPlayer)
    	 
     {          EntityPlayer Player = (EntityPlayer) entity;
          if(Player.getCurrentEquippedItem() != null && Player.getCurrentEquippedItem().getItem() instanceof MAVitalityGemstone)
        	  
          {
        	  Player.addPotionEffect(new PotionEffect(Potion.regeneration.id, 50, 1 - 1));
          }
          else
          { 
        	  Player.removePotionEffect(i);
          }
     }	 
}
     }
}

[Monstrous_Apple]

Okay I'll say what I need to do at this moment, I need it so that when I am not holding the item, the potion effect goes completely, even if it starts at 4 seconds, ends at 0 seconds, and currently is on 2 seconds duration left, it will disappear.

 

I also need it so that when holding the item the duration of the potion effect still ticks even while holding the item, so that regeneration will work, so for example I hold the gem it gives 4 seconds of regeneration, it ticks down to 0 and then refreshes to 4 again, but of course if the item is not held at any point, the regeneration effect completely goes even if it's not reached 0 seconds yet.

 

 

This is what my code looks like at the moment:

 

package com.MonstrousApple.mod.gemstones;

import com.MonstrousApple.mod.MAGlobal;

import net.minecraft.enchantment.Enchantment;
import net.minecraft.enchantment.EnchantmentHelper;
import net.minecraft.entity.Entity;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.entity.projectile.EntityArrow;
import net.minecraft.init.Items;
import net.minecraft.item.EnumAction;
import net.minecraft.item.Item;
import net.minecraft.item.Item.ToolMaterial;
import net.minecraft.item.ItemPickaxe;
import net.minecraft.item.ItemStack;
import net.minecraft.potion.Potion;
import net.minecraft.potion.PotionEffect;
import net.minecraft.stats.StatList;
import net.minecraft.world.World;

public class MAVitalityGemstone extends Item {

public MAVitalityGemstone(String unlocalizedName) {
	super();
	this.setUnlocalizedName(unlocalizedName);
	this.setCreativeTab(MAGlobal.maCreativeTabGemstones);
	this.setMaxStackSize(1);
}

public void onUpdate(ItemStack itemstack, World world, Entity entity, int i, boolean flag)
{
     if (entity instanceof EntityPlayer)
    	 
     {          EntityPlayer Player = (EntityPlayer) entity;
          if(Player.getCurrentEquippedItem() != null && Player.getCurrentEquippedItem().getItem() instanceof MAVitalityGemstone)
        	  
          {
        	  Player.addPotionEffect(new PotionEffect(Potion.regeneration.id, 50, 1 - 1));
          }
          else
          { 
        	  Player.removePotionEffect(i);
          }
     }	 
}
     }
}

[Draco18s]

Jeus H Chirst on a fucking stick.

 

public void onUpdate(ItemStack itemstack, World world, Entity entity, int i, boolean am_I_holding_this_item) {
    if(am_I_holding_this_item) {
        Player.addPotionEffect(new PotionEffect(Potion.regeneration.id, 50, 0));
    }
}

 

Fuck.

 

Was it really that hard?

[Draco18s]

Jeus H Chirst on a fucking stick.

 

public void onUpdate(ItemStack itemstack, World world, Entity entity, int i, boolean am_I_holding_this_item) {
    if(am_I_holding_this_item) {
        Player.addPotionEffect(new PotionEffect(Potion.regeneration.id, 50, 0));
    }
}

 

Fuck.

 

Was it really that hard?

[Monstrous_Apple]

Jeus H Chirst on a fucking stick.

 

public void onUpdate(ItemStack itemstack, World world, Entity entity, int i, boolean am_I_holding_this_item) {
    if(am_I_holding_this_item) {
        Player.addPotionEffect(new PotionEffect(Potion.regeneration.id, 50, 0));
    }
}

 

Fuck.

 

Was it really that hard?

 

Removed my code and tried yours, doesn't work, says I get an error at ".addPotionEffect" saying that "The method addPotionEffect(PotionEffect) is undefined for the type player"?

[Monstrous_Apple]

Jeus H Chirst on a fucking stick.

 

public void onUpdate(ItemStack itemstack, World world, Entity entity, int i, boolean am_I_holding_this_item) {
    if(am_I_holding_this_item) {
        Player.addPotionEffect(new PotionEffect(Potion.regeneration.id, 50, 0));
    }
}

 

Fuck.

 

Was it really that hard?

 

Removed my code and tried yours, doesn't work, says I get an error at ".addPotionEffect" saying that "The method addPotionEffect(PotionEffect) is undefined for the type player"?

[pickaxe_engineer]

Hi

 

Did you really just copy the code?

If you would have posted your code, we could better see why it's not working.

I for my self had 3 minutes after reading this post an item giving any potion effect upon beeing held in the offhand for mc 1.9

 

Sincerely -pick

[pickaxe_engineer]

Hi

 

Did you really just copy the code?

If you would have posted your code, we could better see why it's not working.

I for my self had 3 minutes after reading this post an item giving any potion effect upon beeing held in the offhand for mc 1.9

 

Sincerely -pick

[Monstrous_Apple]

I did post my code on post #9 I'll post it again here:

 

package com.MonstrousApple.mod.gemstones;

import com.MonstrousApple.mod.MAGlobal;

import net.minecraft.enchantment.Enchantment;
import net.minecraft.enchantment.EnchantmentHelper;
import net.minecraft.entity.Entity;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.entity.projectile.EntityArrow;
import net.minecraft.init.Items;
import net.minecraft.item.EnumAction;
import net.minecraft.item.Item;
import net.minecraft.item.Item.ToolMaterial;
import net.minecraft.item.ItemPickaxe;
import net.minecraft.item.ItemStack;
import net.minecraft.potion.Potion;
import net.minecraft.potion.PotionEffect;
import net.minecraft.stats.StatList;
import net.minecraft.world.World;

public class MAVitalityGemstone extends Item {

public MAVitalityGemstone(String unlocalizedName) {
	super();
	this.setUnlocalizedName(unlocalizedName);
	this.setCreativeTab(MAGlobal.maCreativeTabGemstones);
	this.setMaxStackSize(1);
}

public void onUpdate(ItemStack itemstack, World world, Entity entity, int i, boolean flag)
{
     if (entity instanceof EntityPlayer)
    	 
     {          EntityPlayer Player = (EntityPlayer) entity;
          if(Player.getCurrentEquippedItem() != null && Player.getCurrentEquippedItem().getItem() instanceof MAVitalityGemstone)
        	  
          {
        	  Player.addPotionEffect(new PotionEffect(Potion.regeneration.id, 50, 1 - 1));
          }
          else
          { 
        	  Player.removePotionEffect(i);
          }
     }	 
}
     }
}

[Monstrous_Apple]

I did post my code on post #9 I'll post it again here:

 

package com.MonstrousApple.mod.gemstones;

import com.MonstrousApple.mod.MAGlobal;

import net.minecraft.enchantment.Enchantment;
import net.minecraft.enchantment.EnchantmentHelper;
import net.minecraft.entity.Entity;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.entity.projectile.EntityArrow;
import net.minecraft.init.Items;
import net.minecraft.item.EnumAction;
import net.minecraft.item.Item;
import net.minecraft.item.Item.ToolMaterial;
import net.minecraft.item.ItemPickaxe;
import net.minecraft.item.ItemStack;
import net.minecraft.potion.Potion;
import net.minecraft.potion.PotionEffect;
import net.minecraft.stats.StatList;
import net.minecraft.world.World;

public class MAVitalityGemstone extends Item {

public MAVitalityGemstone(String unlocalizedName) {
	super();
	this.setUnlocalizedName(unlocalizedName);
	this.setCreativeTab(MAGlobal.maCreativeTabGemstones);
	this.setMaxStackSize(1);
}

public void onUpdate(ItemStack itemstack, World world, Entity entity, int i, boolean flag)
{
     if (entity instanceof EntityPlayer)
    	 
     {          EntityPlayer Player = (EntityPlayer) entity;
          if(Player.getCurrentEquippedItem() != null && Player.getCurrentEquippedItem().getItem() instanceof MAVitalityGemstone)
        	  
          {
        	  Player.addPotionEffect(new PotionEffect(Potion.regeneration.id, 50, 1 - 1));
          }
          else
          { 
        	  Player.removePotionEffect(i);
          }
     }	 
}
     }
}

[Draco18s]

Was it really that hard?

 

Apparently.

[Draco18s]

Was it really that hard?

 

Apparently.