[1.9.4] Configuration not enforcing min max

[HaiDozo]

The Configuration .get method (I'm getting an int) has the arguments: (category, key, default, comment, min, max) but it's not enforcing the min and max values.

 

I edited my config file and set a value to 1000, the code has min, max set to 0, 100 respectively, still I get a value of 1000.

 

Configuration config = new Configuration(configFile);
config.load();
mobEssenceDropRate = config.get(config.CATEGORY_GENERAL, "mobEssenceDropRate", MobEssenceDropRate_DEFAULT, "comment_here", 0, 100).getInt();
config.save();

 

Did I miss something or is it perhaps a bug in forge?

[Abastro]

I think it is not a bug but a feature in forge configuration system.

Since it should load properties before any property is initialized, the value loaded from the file couldn't be checked.

Also it is not checked in getInt(or getValue), since it might be odd to check and give value in bound while the actual value does not change. (Changing the value will result in messy code, in my opinion.)

 

The minValue / maxValue are only for Gui Configs, currently.

[Draco18s]

The min/max are also displayed to the user in the config file.

[HaiDozo]

The min/max are also displayed to the user in the config file.

 

Oh nice, how do you enable this? I've been manually writing it in the comment argument.

[Draco18s]

You don't have to do anything.

 

Here's what my config getter looks like

int cycle = config.getInt("sluiceCycleTime", "SLUICE", 2, 1, 20, "Time it takes for the sluice to make 1 operation.  This value is multiplied by 75 ticks.");

 

And the config file:

    # Time it takes for the sluice to make 1 operation.  This value is multiplied by 75 ticks. [range: 1 ~ 20, default: 2]
    I:sluiceCycleTime=2