Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

[1.9.4] ASM how to get a private value from a class

perromercenary00

By perromercenary00
in Modder Support

 Share

Recommended Posts

perromercenary00 Dragon Slayer

perromercenary00

Posted
Posted

 

 

 

good days im trying to solve and old trouble and for this i need to know basic asm

 

the thing is this i need to get the float value from a private varible from a class two know what is internally happend

 

exactly i wanna see    "private float equippedProgressMainHand;"  from a runing instance of:

net.minecraft.client.renderer.ItemRenderer.java

 

 

to do this im doing client side of course

 

 

 

			Minecraft mc = Minecraft.getMinecraft();
			EntityPlayer playerIn = mc.thePlayer;
			ItemRenderer IR = mc.getItemRenderer();

			try{
				float a1=0.5F;
				{

					Field field = ItemRenderer.class.getDeclaredField("equippedProgressMainHand");
					field.setAccessible(true);


					Float f = field.getFloat(field);

					System.out.println("f="+f);
					//field.setFloat(IR,a1);
				}

 

well seems like this is not the right way to observe a float value throght reflection methods

i been trying diferents things from google today but just get and error here or there in other test it wass something about the field is privated

 

in the other hand field.setFloat(IR,a1); seems to works  but i need to know first whath are the values i gonna force here

coz sething this float a1=1.0F;  to  1.0F just cause the item to go up in first person view

and sething this float a1=0.5F; causes the item to slowing go down 

 

 

[14:48:03] [Client thread/INFO] [sTDERR]: [mercenarymod.items.armasdefuego.pistolaMercenaria:shouldCauseReequipAnimation:1269]: java.lang.IllegalArgumentException: Can not set float field net.minecraft.client.renderer.ItemRenderer.equippedProgressMainHand to java.lang.reflect.Field
[14:48:03] [Client thread/INFO] [sTDERR]: [mercenarymod.items.armasdefuego.pistolaMercenaria:shouldCauseReequipAnimation:1269]: 	at sun.reflect.UnsafeFieldAccessorImpl.throwSetIllegalArgumentException(UnsafeFieldAccessorImpl.java:167)
[14:48:03] [Client thread/INFO] [sTDERR]: [mercenarymod.items.armasdefuego.pistolaMercenaria:shouldCauseReequipAnimation:1269]: 	at sun.reflect.UnsafeFieldAccessorImpl.throwSetIllegalArgumentException(UnsafeFieldAccessorImpl.java:171)
[14:48:03] [Client thread/INFO] [sTDERR]: [mercenarymod.items.armasdefuego.pistolaMercenaria:shouldCauseReequipAnimation:1269]: 	at sun.reflect.UnsafeFieldAccessorImpl.ensureObj(UnsafeFieldAccessorImpl.java:58)
[14:48:03] [Client thread/INFO] [sTDERR]: [mercenarymod.items.armasdefuego.pistolaMercenaria:shouldCauseReequipAnimation:1269]: 	at sun.reflect.UnsafeFloatFieldAccessorImpl.getFloat(UnsafeFloatFieldAccessorImpl.java:64)
[14:48:03] [Client thread/INFO] [sTDERR]: [mercenarymod.items.armasdefuego.pistolaMercenaria:shouldCauseReequipAnimation:1269]: 	at java.lang.reflect.Field.getFloat(Field.java:648)
[14:48:03] [Client thread/INFO] [sTDERR]: [mercenarymod.items.armasdefuego.pistolaMercenaria:shouldCauseReequipAnimation:1269]: 	at mercenarymod.items.armasdefuego.pistolaMercenaria.shouldCauseReequipAnimation(pistolaMercenaria.java:1255)
[14:48:03] [Client thread/INFO] [sTDERR]: [mercenarymod.items.armasdefuego.pistolaMercenaria:shouldCauseReequipAnimation:1269]: 	at net.minecraftforge.client.ForgeHooksClient.shouldCauseReequipAnimation(ForgeHooksClient.java:658)
[14:48:03] [Client thread/INFO] [sTDERR]: [mercenarymod.items.armasdefuego.pistolaMercenaria:shouldCauseReequipAnimation:1269]: 	at net.minecraft.client.renderer.ItemRenderer.updateEquippedItem(ItemRenderer.java:631)
[14:48:03] [Client thread/INFO] [sTDERR]: [mercenarymod.items.armasdefuego.pistolaMercenaria:shouldCauseReequipAnimation:1269]: 	at net.minecraft.client.renderer.EntityRenderer.updateRenderer(EntityRenderer.java:325)
[14:48:03] [Client thread/INFO] [sTDERR]: [mercenarymod.items.armasdefuego.pistolaMercenaria:shouldCauseReequipAnimation:1269]: 	at net.minecraft.client.Minecraft.runTick(Minecraft.java:1864)
[14:48:03] [Client thread/INFO] [sTDERR]: [mercenarymod.items.armasdefuego.pistolaMercenaria:shouldCauseReequipAnimation:1269]: 	at net.minecraft.client.Minecraft.runGameLoop(Minecraft.java:1117)
[14:48:03] [Client thread/INFO] [sTDERR]: [mercenarymod.items.armasdefuego.pistolaMercenaria:shouldCauseReequipAnimation:1269]: 	at net.minecraft.client.Minecraft.run(Minecraft.java:404)
[14:48:03] [Client thread/INFO] [sTDERR]: [mercenarymod.items.armasdefuego.pistolaMercenaria:shouldCauseReequipAnimation:1269]: 	at net.minecraft.client.main.Main.main(Main.java:118)
[14:48:03] [Client thread/INFO] [sTDERR]: [mercenarymod.items.armasdefuego.pistolaMercenaria:shouldCauseReequipAnimation:1269]: 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[14:48:03] [Client thread/INFO] [sTDERR]: [mercenarymod.items.armasdefuego.pistolaMercenaria:shouldCauseReequipAnimation:1269]: 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
[14:48:03] [Client thread/INFO] [sTDERR]: [mercenarymod.items.armasdefuego.pistolaMercenaria:shouldCauseReequipAnimation:1269]: 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[14:48:03] [Client thread/INFO] [sTDERR]: [mercenarymod.items.armasdefuego.pistolaMercenaria:shouldCauseReequipAnimation:1269]: 	at java.lang.reflect.Method.invoke(Method.java:498)
[14:48:03] [Client thread/INFO] [sTDERR]: [mercenarymod.items.armasdefuego.pistolaMercenaria:shouldCauseReequipAnimation:1269]: 	at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)
[14:48:03] [Client thread/INFO] [sTDERR]: [mercenarymod.items.armasdefuego.pistolaMercenaria:shouldCauseReequipAnimation:1269]: 	at net.minecraft.launchwrapper.Launch.main(Launch.java:28)
[14:48:03] [Client thread/INFO] [sTDERR]: [mercenarymod.items.armasdefuego.pistolaMercenaria:shouldCauseReequipAnimation:1269]: 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[14:48:03] [Client thread/INFO] [sTDERR]: [mercenarymod.items.armasdefuego.pistolaMercenaria:shouldCauseReequipAnimation:1269]: 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
[14:48:03] [Client thread/INFO] [sTDERR]: [mercenarymod.items.armasdefuego.pistolaMercenaria:shouldCauseReequipAnimation:1269]: 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[14:48:03] [Client thread/INFO] [sTDERR]: [mercenarymod.items.armasdefuego.pistolaMercenaria:shouldCauseReequipAnimation:1269]: 	at java.lang.reflect.Method.invoke(Method.java:498)
[14:48:03] [Client thread/INFO] [sTDERR]: [mercenarymod.items.armasdefuego.pistolaMercenaria:shouldCauseReequipAnimation:1269]: 	at net.minecraftforge.gradle.GradleStartCommon.launch(GradleStartCommon.java:97)
[14:48:03] [Client thread/INFO] [sTDERR]: [mercenarymod.items.armasdefuego.pistolaMercenaria:shouldCauseReequipAnimation:1269]: 	at GradleStart.main(GradleStart.java:26)

 

 

thanks for reading

Choonster Reality Controller

Choonster

Posted
Posted

The argument of 

Field#getFloat

(and the other 

Field#getX

methods) is the instance to get the field's value from. In this case, the 

ItemRenderer

instance. Don't pass the 

Field

as an argument.

 

Your current code won't work in the release (obfuscated) environment because there won't a field called 

equippedProgressMainHand

. Instead, it will have an SRG name like 

field_0013_a

(use MCPBot to find the actual name). This means you need to check both names, FML's 

ReflectionHelper

provides some useful methods for this.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Draco18s Reality Controller

Draco18s

Posted
Posted

You are doing Reflection, not ASM.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Choonster Reality Controller

Choonster

Posted
Posted

Are we talking about assembly here? Or ASM stands for something else?

 

Also I'm pretty sure you are doing reflection.

 

ASM is a library for manipulating Java bytecode. Minecraft and Forge use it, but mods should avoid using it where possible.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

perromercenary00 Dragon Slayer

perromercenary00

Posted
  • Author
Posted

well thanks for aclaration

 

i been able to read the data whith reflecction

 

	// ############################################################################################3
@Override
public boolean shouldCauseReequipAnimation(ItemStack oldStack, ItemStack newStack, boolean slotChanged) {

	Boolean b = oldStack.equals(newStack);
                Boolean showValues = true;


	if (showValues)
	{
	Minecraft mc = Minecraft.getMinecraft();
	EntityPlayer playerIn = mc.thePlayer;
	ItemRenderer IR = mc.getItemRenderer();

	System.out.println("#=");


	try {
		float cas = playerIn.getCooledAttackStrength(1.0F);
		{
			// this.prevEquippedProgressMainHand

			Field field = ItemRenderer.class.getDeclaredField("equippedProgressMainHand");
			field.setAccessible(true);
			float f = field.getFloat(IR);
			System.out.println(" f=" + f );

		}

		{
			Field field = ItemRenderer.class.getDeclaredField("prevEquippedProgressMainHand");
			field.setAccessible(true);
			float pf = field.getFloat(IR);
			System.out.println(" pf="+pf);
		}

	} catch (Exception e) {
		e.printStackTrace();
	}

	}


	System.out.println("B="+!b);
	return !b;

}
// ############################################################################################3

 

it makes clear why some of the things i try failed whith wicked results

 

console output cleaned

[08:48:25] [Client ]: [:shouldCauseReequipAnimation:1188]: #=
[08:48:25] [Client ]: [:shouldCauseReequipAnimation:1199]:  f=1.0
[08:48:25] [Client ]: [:shouldCauseReequipAnimation:1207]:  pf=1.0
[08:48:25] [Client ]: [:shouldCauseReequipAnimation:1368]: B=false
[08:48:26] [Client ]: [:shouldCauseReequipAnimation:1188]: #=
[08:48:26] [Client ]: [:shouldCauseReequipAnimation:1199]:  f=1.0
[08:48:26] [Client ]: [:shouldCauseReequipAnimation:1207]:  pf=1.0
[08:48:26] [Client ]: [:shouldCauseReequipAnimation:1368]: B=false

here it begins the reequip thing
[08:48:26] [Client ]: [:shouldCauseReequipAnimation:1188]: #=
[08:48:26] [Client ]: [:shouldCauseReequipAnimation:1199]:  f=1.0
[08:48:26] [Client ]: [:shouldCauseReequipAnimation:1207]:  pf=1.0
[08:48:26] [Client ]: [:shouldCauseReequipAnimation:1368]: B=true
[08:48:26] [Client ]: [:shouldCauseReequipAnimation:1188]: #=
[08:48:26] [Client ]: [:shouldCauseReequipAnimation:1199]:  f=0.6
[08:48:26] [Client ]: [:shouldCauseReequipAnimation:1207]:  pf=0.6
[08:48:26] [Client ]: [:shouldCauseReequipAnimation:1368]: B=true
[08:48:26] [Client ]: [:shouldCauseReequipAnimation:1188]: #=
[08:48:26] [Client ]: [:shouldCauseReequipAnimation:1199]:  f=0.20000002
[08:48:26] [Client ]: [:shouldCauseReequipAnimation:1207]:  pf=0.20000002
[08:48:26] [Client ]: [:shouldCauseReequipAnimation:1368]: B=true


when it reaches zero the itemStatck change B becomes again false this take like three ticks 
then there goes back to 1.0F

[08:48:26] [Client ]: [:shouldCauseReequipAnimation:1188]: #=
[08:48:26] [Client ]: [:shouldCauseReequipAnimation:1199]:  f=0.0
[08:48:26] [Client ]: [:shouldCauseReequipAnimation:1207]:  pf=0.0
[08:48:26] [Client ]: [:shouldCauseReequipAnimation:1368]: B=false
[08:48:26] [Client ]: [:shouldCauseReequipAnimation:1188]: #=
[08:48:26] [Client ]: [:shouldCauseReequipAnimation:1199]:  f=0.4
[08:48:26] [Client ]: [:shouldCauseReequipAnimation:1207]:  pf=0.4
[08:48:26] [Client ]: [:shouldCauseReequipAnimation:1368]: B=false
[08:48:26] [Client ]: [:shouldCauseReequipAnimation:1188]: #=
[08:48:26] [Client ]: [:shouldCauseReequipAnimation:1199]:  f=0.8
[08:48:26] [Client ]: [:shouldCauseReequipAnimation:1207]:  pf=0.8
[08:48:26] [Client ]: [:shouldCauseReequipAnimation:1368]: B=false
[08:48:26] [Client ]: [:shouldCauseReequipAnimation:1188]: #=
[08:48:26] [Client ]: [:shouldCauseReequipAnimation:1199]:  f=1.0
[08:48:26] [Client ]: [:shouldCauseReequipAnimation:1207]:  pf=1.0
[08:48:26] [Client ]: [:shouldCauseReequipAnimation:1368]: B=false

 

 

inthe other hand i think im to young for the irc chat

a wass able to enter using the web client but is like i never get inside the channel #mcp  or de other

inside i wass the only user in th list and when try to call the bot it says then the user is not found

 

 

 

 

 

Choonster Reality Controller

Choonster

Posted
Posted

inthe other hand i think im to young for the irc chat

a wass able to enter using the web client but is like i never get inside the channel #mcp  or de other

inside i wass the only user in th list and when try to call the bot it says then the user is not found

 

I don't think I had much luck with the web client, I ended up downloading HexChat to use MCPBot.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept