[1.10] Add drops to mob death event

[American2050]

I'm curious about how this works.

 

I am "monitoring" when mobs dies, and I want to add drops to their list. This is what I'm doing, the "problem" is that I'm not sure, will this guarantee the drop 100% the time? Is there a way to pass a % chance of dropping the added item.

 

PS: Would it be ok to spawn the item on the world, so I can add a chance % there?

 

	@SubscribeEvent
public void onLivingDropsEvent(LivingDropsEvent event) {

	Entity entity = event.getEntity();
	World world = event.getEntity().getEntityWorld();
	BlockPos pos = event.getEntity().getPosition();

	if(entity.getClass().equals(MobsReference.VANILLA_ZOMBIE)){

		EntityItem itemDropX = new EntityItem(world, pos.getX()+.5, pos.getY()+.5, pos.getZ()+.5, ItemsReference.IRON_ORE.copy());

//			world.spawnEntityInWorld(itemDropX);

		event.getDrops().add(itemDropX);

	}

}

[Ernio]

Well, if you add drop to drops - it will be dropped (unless someone would catch event after you and remove drops), simple as that.

The % chance can be done by you (Random) inside event. (e.g: 50% to add some item to drop list).

[American2050]

if(entity.getClass().equals(MobsReference.VANILLA_ZOMBIE)){

Oh god why? Please use

entity instanceof EntityZombie

- it will be more performant and also not exclude mod-mobs that are zombies.

 

I did that so I can also reference Mobs from other mods in the near future.

 

Is there a better way? That's what worked for me on a 1.7.10 Mod I "did" (Continued the updates) time ago.

 

Example: If I use instanceof I wont be able to reference "KingSlime" A mob from the Aether mod, or "demonmobs.rahovart" a Boss Mob from Lycanites Mobs.

[Draco18s]

Entity entity = event.getEntity();

World world = event.getEntity().getEntityWorld();

 

"Eh, just fuck that reference we made. Call that method again! "

[American2050]

Entity entity = event.getEntity();

World world = event.getEntity().getEntityWorld();

 

"Eh, just fuck that reference we made. Call that method again! "

 

Whut???

 

Entity entity = event.getEntity();

World world = entity .getEntityWorld();

 

I see that, would it really matter?

 

What reference you talking about?

[American2050]

Sure you would?

So I don't know how to use instanceof in this case... Been:

 

MobsReference

public static final Class VANILLA_ZOMBIE = (Class) EntityList.NAME_TO_CLASS.get("Zombie");

 

How would I go about getting the entity to see if it's an instanceof the entity on the die event later on?

 

And why would it be better to use instanceof? I lose control as you said, and any mod that extends a Minecraft Zombie will also drop my items, using the equals gives me control to set a different drop for that mod mob.

[American2050]

If you only want vanilla zombies, use getClass() == EntityZombie.class.

 

Ohhh ok, I shouldn't be using .equals() in this cases? Not sure why, but thanks you

 

[American2050]

So I can reference the mobs with the names on the registry, even if I don't know the class they belong to. At least I think that's why it was done like that on the old 1.7.10 mod I told you.

[Draco18s]

Entity entity = event.getEntity();

World world = event.getEntity().getEntityWorld();

 

"Eh, just fuck that reference we made. Call that method again! "

 

Whut???

 

Entity entity = event.getEntity();

World world = entity .getEntityWorld();

 

I see that, would it really matter?

 

What reference you talking about?

 

Entity entity

This is a reference.

 

If you don't use it, you're wasting space in the JVM stack.  By calling

getEntity()

over and over again, you're wasting execution speed on bytes that are irrelevant (because the result is already stored in a local variable).

 

Try to pretend that

getEntity()

takes 2 days to execute.  You don't mind your program taking a day or two to execute, but a week would be too long.

 

How many times would you call

getEntity()

then?

[American2050]

Entity entity = event.getEntity();

World world = event.getEntity().getEntityWorld();

 

"Eh, just fuck that reference we made. Call that method again! "

 

Whut???

 

Entity entity = event.getEntity();

World world = entity .getEntityWorld();

 

I see that, would it really matter?

 

What reference you talking about?

 

Entity entity

This is a reference.

 

If you don't use it, you're wasting space in the JVM stack.  By calling

getEntity()

over and over again, you're wasting execution speed on bytes that are irrelevant (because the result is already stored in a local variable).

 

Try to pretend that

getEntity()

takes 2 days to execute.  You don't mind your program taking a day or two to execute, but a week would be too long.

 

How many times would you call

getEntity()

then?

 

So the best practice would be:

 

if(event.getEntity().getClass() == MobsReference.VANILLA_ZOMBIE)

 

and...

 

doDrop(event, event.getEntity().getEntityWorld(), itemDropX, ChancesControl.ZOMBIE_BY_HUMAN, ChancesControl.ZOMBIE_BY_OTHER, killedByPlayer);

 

And not create "entity" and "world"?

[Draco18s]

And not create "entity" and "world"?

 

Jesus fucking christ.  The opposite of this.

[American2050]

And not create "entity" and "world"?

 

Jesus fucking christ.  The opposite of this.

Now I'm just more confuse, I really don't understand what you pointing at, and what you think I'm doing wrong / should do different.

 

 

[Draco18s]

Step 1: make a local variable (you skipped this in your last post)

Step 2: fucking use it (you skipped this in your first post)

[American2050]

Step 1: make a local variable (you skipped this in your last post)

Step 2: fucking use it (you skipped this in your first post)

That's why I'm confuse, I did used the variable on my first post.

 

Entity entity = event.getEntity();
	World world = event.getEntity().getEntityWorld();
	BlockPos pos = event.getEntity().getPosition();

 

I did used entity, world and pos. None of them are unused.

 

If you mean that what I should have created is a Class class = event.getEntity().getClass(); That's something I did missed.

[Draco18s]

How about

entity.getEntityWorld()

so your actually using the local variable instead of calling getEntity again. 

[American2050]

How about

entity.getEntityWorld()

so your actually using the local variable instead of calling getEntity again. 

Got you