Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

[1.10.2] Can't get assets to work

asd123

By asd123
in Modder Support

 Share

Recommended Posts

asd123 Tree Puncher

asd123

Posted
Posted

I'm trying to follow this tutorial but I got stuck at the part where you assign a model and texture to an item and I need someone to take a look at my code. It doesn't throw any exceptions but I get the default texture either way.

 

What I see ingame:

https://i.imgur.com/PqBy2TR.png

 

Log:

https://gist.github.com/anonymous/163b6f63327650f71d46e6f77dc1bc09

 

Project structure:

https://i.imgur.com/emzcsry.png

 

Code:

https://github.com/asdf-mnbv/forge_src *

Baijson Tree Puncher

Baijson

Posted
Posted

In your ItemRenderRegister.java

 

change line 16, Minecraft.getMinecraft().getRenderItem().getItemModelMesher().register(item, 0, new ModelResourceLocation("mapoverlay:item/tutorial_item", "inventory"));

 

into: ModelLoader.setCustomModelResourceLocation ( item, 0, new ModelResourceLocation("mapoverlay:item/tutorial_item", "inventory") );

jeffryfisher World Shaper

jeffryfisher

Posted
Posted

And make sure you're calling setCustomModelResourceLocation in or under preInit.

The debugger is a powerful and necessary tool in any IDE, so learn how to use it. You'll be able to tell us more and get better help here if you investigate your runtime problems in the debugger before posting.

asd123 Tree Puncher

asd123

Posted
  • Author
Posted

In your ItemRenderRegister.java

 

change line 16, Minecraft.getMinecraft().getRenderItem().getItemModelMesher().register(item, 0, new ModelResourceLocation("mapoverlay:item/tutorial_item", "inventory"));

 

into: ModelLoader.setCustomModelResourceLocation ( item, 0, new ModelResourceLocation("mapoverlay:item/tutorial_item", "inventory") );

 

That just gives me a NullPointerException:

https://gist.github.com/anonymous/6dad8bcf1012129230681d4276d0158c

 

And make sure you're calling setCustomModelResourceLocation in or under preInit.

 

That does, too:

https://gist.github.com/anonymous/fdb196d7922b8d5a25fa15a3b088ae9f

 

I believe your assets should be in your resources folder, not java.

 

Can you post the full path the files should be in?

/forge/src/main/java/assets/mapoverlay/textures/item/tutorial_item.png

and

/forge/src/main/java/assets/mapoverlay/models/item/tutorial_item.json

are the only locations where the game will start without throwing any exceptions.

Ugdhar Reality Controller

Ugdhar

Posted
Posted

You would want it to be

/forge/src/main/resources/assets/mapoverlay/models/item/tutorial_item.json

 

If it's throwing an error, what's it telling you?

asd123 Tree Puncher

asd123

Posted
  • Author
Posted

Here's the exception I'd get:

 

 

[22:16:04] [Client thread/INFO] [FML]: Max texture size: 16384
[22:16:04] [Client thread/INFO]: Created: 16x16 textures-atlas
[22:16:05] [Client thread/ERROR] [FML]: Exception loading model for variant mapoverlay:tutorial_item#inventory for item "mapoverlay:tutorial_item", normal location exception: 
net.minecraftforge.client.model.ModelLoaderRegistry$LoaderException: Exception loading model mapoverlay:item/tutorial_item with loader VanillaLoader.INSTANCE, skipping
at net.minecraftforge.client.model.ModelLoaderRegistry.getModel(ModelLoaderRegistry.java:153) ~[ModelLoaderRegistry.class:?]
at net.minecraftforge.client.model.ModelLoader.loadItemModels(ModelLoader.java:317) ~[ModelLoader.class:?]
at net.minecraft.client.renderer.block.model.ModelBakery.loadVariantItemModels(ModelBakery.java:170) ~[ModelBakery.class:?]
at net.minecraftforge.client.model.ModelLoader.setupModelRegistry(ModelLoader.java:147) ~[ModelLoader.class:?]
at net.minecraft.client.renderer.block.model.ModelManager.onResourceManagerReload(ModelManager.java:28) [ModelManager.class:?]
at net.minecraft.client.resources.SimpleReloadableResourceManager.registerReloadListener(SimpleReloadableResourceManager.java:122) [simpleReloadableResourceManager.class:?]
at net.minecraft.client.Minecraft.startGame(Minecraft.java:540) [Minecraft.class:?]
at net.minecraft.client.Minecraft.run(Minecraft.java:386) [Minecraft.class:?]
at net.minecraft.client.main.Main.main(Main.java:118) [Main.class:?]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_91]
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_91]
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_91]
at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_91]
at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) [launchwrapper-1.12.jar:?]
at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.12.jar:?]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_91]
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_91]
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_91]
at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_91]
at net.minecraftforge.gradle.GradleStartCommon.launch(GradleStartCommon.java:97) [start/:?]
at GradleStart.main(GradleStart.java:26) [start/:?]
Caused by: java.io.FileNotFoundException: mapoverlay:models/item/tutorial_item.json
at net.minecraft.client.resources.FallbackResourceManager.getResource(FallbackResourceManager.java:68) ~[FallbackResourceManager.class:?]
at net.minecraft.client.resources.SimpleReloadableResourceManager.getResource(SimpleReloadableResourceManager.java:65) ~[simpleReloadableResourceManager.class:?]
at net.minecraft.client.renderer.block.model.ModelBakery.loadModel(ModelBakery.java:311) ~[ModelBakery.class:?]
at net.minecraftforge.client.model.ModelLoader.access$1100(ModelLoader.java:118) ~[ModelLoader.class:?]
at net.minecraftforge.client.model.ModelLoader$VanillaLoader.loadModel(ModelLoader.java:868) ~[ModelLoader$VanillaLoader.class:?]
at net.minecraftforge.client.model.ModelLoaderRegistry.getModel(ModelLoaderRegistry.java:149) ~[ModelLoaderRegistry.class:?]
... 20 more
[22:16:05] [Client thread/ERROR] [FML]: Exception loading model for variant mapoverlay:tutorial_item#inventory for item "mapoverlay:tutorial_item", blockstate location exception: 
net.minecraftforge.client.model.ModelLoaderRegistry$LoaderException: Exception loading model mapoverlay:tutorial_item#inventory with loader VariantLoader.INSTANCE, skipping
at net.minecraftforge.client.model.ModelLoaderRegistry.getModel(ModelLoaderRegistry.java:153) ~[ModelLoaderRegistry.class:?]
at net.minecraftforge.client.model.ModelLoader.loadItemModels(ModelLoader.java:325) ~[ModelLoader.class:?]
at net.minecraft.client.renderer.block.model.ModelBakery.loadVariantItemModels(ModelBakery.java:170) ~[ModelBakery.class:?]
at net.minecraftforge.client.model.ModelLoader.setupModelRegistry(ModelLoader.java:147) ~[ModelLoader.class:?]
at net.minecraft.client.renderer.block.model.ModelManager.onResourceManagerReload(ModelManager.java:28) [ModelManager.class:?]
at net.minecraft.client.resources.SimpleReloadableResourceManager.registerReloadListener(SimpleReloadableResourceManager.java:122) [simpleReloadableResourceManager.class:?]
at net.minecraft.client.Minecraft.startGame(Minecraft.java:540) [Minecraft.class:?]
at net.minecraft.client.Minecraft.run(Minecraft.java:386) [Minecraft.class:?]
at net.minecraft.client.main.Main.main(Main.java:118) [Main.class:?]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_91]
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_91]
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_91]
at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_91]
at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) [launchwrapper-1.12.jar:?]
at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.12.jar:?]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_91]
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_91]
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_91]
at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_91]
at net.minecraftforge.gradle.GradleStartCommon.launch(GradleStartCommon.java:97) [start/:?]
at GradleStart.main(GradleStart.java:26) [start/:?]
Caused by: net.minecraft.client.renderer.block.model.ModelBlockDefinition$MissingVariantException
at net.minecraft.client.renderer.block.model.ModelBlockDefinition.getVariant(ModelBlockDefinition.java:78) ~[ModelBlockDefinition.class:?]
at net.minecraftforge.client.model.ModelLoader$VariantLoader.loadModel(ModelLoader.java:1183) ~[ModelLoader$VariantLoader.class:?]
at net.minecraftforge.client.model.ModelLoaderRegistry.getModel(ModelLoaderRegistry.java:149) ~[ModelLoaderRegistry.class:?]
... 20 more
[22:16:05] [Client thread/INFO] [FML]: Injecting itemstacks

 

 

Edit: I've moved the files to the path you posted and it's doing the same as in my original location, no exceptions but the assets don't show up.

Ugdhar Reality Controller

Ugdhar

Posted
Posted

Try changing

ModelResourceLocation("mapoverlay:item/tutorial_item", "inventory"));

 

to

 

ModelResourceLocation("mapoverlay:tutorial_item", "inventory"));

 

Looking at a simple item I made, I didn't specify the "item/" in theModelResourceLocation call.

asd123 Tree Puncher

asd123

Posted
  • Author
Posted

Alright, it's working now. Here's the summary for anyone coming from Google six months later:

 

* The call to ModItems.createItems() goes in CommonProxy.preInit(), the call to ItemRenderRegister.registerItemRenderer() goes in ClientProxy.init() after calling the base method.

 

* I completely missed something in createItems(), can you spot it?

 

(...)
    public static Item tutorialItem;
    
    public static final void createItems() {
    	Item tutorialItem = new BasicItem("tutorial_item");
(...)

 

Fuck me ...

 

* Now the game would start up, but still displayed the error texture. Turns out that this code proposed upthread

 

ModelLoader.setCustomModelResourceLocation ( item, 0, new ModelResourceLocation("mapoverlay:item/tutorial_item", "inventory") );

 

doesn't actually work, so I changed it back into the code based on the the tutorial and there you go, working model & texture:

 

Minecraft.getMinecraft().getRenderItem().getItemModelMesher()
    .register(item, 0, new ModelResourceLocation("mapoverlay:tutorial_item", "inventory"));

 

  • 6 months later...
magruder85 Tree Puncher

magruder85

Posted
Posted

I was stuck on same tutorial and came to here. What fixed it for me was making sure that ItemRenderRegister.registerItemRenderer()  was in preInit() under ClientProxy.java. And then I was able to follow as others suggested to use "ModelLoader.setCustomModelResourceLocation".

 

Thanks all for providing input, it definitely helps for others down the road. 

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



  • Recently Browsing

    • No registered users viewing this page.

  • Posts

    • Azero
      Unable to build with shadow

      By Azero · Posted

      Im trying to build my mod using shade since i use the luaj library however i keep getting this error Reason: Task ':reobfJar' uses this output of task ':shadowJar' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. So i try adding reobfJar.dependsOn shadowJar  Could not get unknown property 'reobfJar' for object of type org.gradle.api.internal.artifacts.dsl.dependencies.DefaultDependencyHandler. my gradle file plugins { id 'eclipse' id 'idea' id 'maven-publish' id 'net.minecraftforge.gradle' version '[6.0,6.2)' id 'com.github.johnrengelman.shadow' version '7.1.2' id 'org.spongepowered.mixin' version '0.7.+' } apply plugin: 'net.minecraftforge.gradle' apply plugin: 'org.spongepowered.mixin' apply plugin: 'com.github.johnrengelman.shadow' version = mod_version group = mod_group_id base { archivesName = mod_id } // Mojang ships Java 17 to end users in 1.18+, so your mod should target Java 17. java.toolchain.languageVersion = JavaLanguageVersion.of(17) //jarJar.enable() println "Java: ${System.getProperty 'java.version'}, JVM: ${System.getProperty 'java.vm.version'} (${System.getProperty 'java.vendor'}), Arch: ${System.getProperty 'os.arch'}" minecraft { mappings channel: mapping_channel, version: mapping_version copyIdeResources = true runs { configureEach { workingDirectory project.file('run') property 'forge.logging.markers', 'REGISTRIES' property 'forge.logging.console.level', 'debug' arg "-mixin.config=derp.mixin.json" mods { "${mod_id}" { source sourceSets.main } } } client { // Comma-separated list of namespaces to load gametests from. Empty = all namespaces. property 'forge.enabledGameTestNamespaces', mod_id } server { property 'forge.enabledGameTestNamespaces', mod_id args '--nogui' } gameTestServer { property 'forge.enabledGameTestNamespaces', mod_id } data { workingDirectory project.file('run-data') args '--mod', mod_id, '--all', '--output', file('src/generated/resources/'), '--existing', file('src/main/resources/') } } } sourceSets.main.resources { srcDir 'src/generated/resources' } repositories { flatDir { dirs './libs' } maven { url = "https://jitpack.io" } } configurations { shade implementation.extendsFrom shade } dependencies { minecraft "net.minecraftforge:forge:${minecraft_version}-${forge_version}" implementation 'org.luaj:luaj-jse-3.0.2' implementation fg.deobf("com.github.Virtuoel:Pehkui:${pehkui_version}") annotationProcessor 'org.spongepowered:mixin:0.8.5:processor' minecraftLibrary 'luaj:luaj-jse:3.0.2' shade 'luaj:luaj-jse:3.0.2' } // Example for how to get properties into the manifest for reading at runtime. tasks.named('jar', Jar).configure { manifest { attributes([ 'Specification-Title' : mod_id, 'Specification-Vendor' : mod_authors, 'Specification-Version' : '1', // We are version 1 of ourselves 'Implementation-Title' : project.name, 'Implementation-Version' : project.jar.archiveVersion, 'Implementation-Vendor' : mod_authors, 'Implementation-Timestamp': new Date().format("yyyy-MM-dd'T'HH:mm:ssZ"), "TweakClass" : "org.spongepowered.asm.launch.MixinTweaker", "TweakOrder" : 0, "MixinConfigs" : "derp.mixin.json" ]) } rename 'mixin.refmap.json', 'derp.mixin-refmap.json' } shadowJar { archiveClassifier = '' configurations = [project.configurations.shade] finalizedBy 'reobfShadowJar' } assemble.dependsOn shadowJar reobf { re shadowJar {} } publishing { publications { mavenJava(MavenPublication) { artifact jar } } repositories { maven { url "file://${project.projectDir}/mcmodsrepo" } } }  
    • LIMadrim15
      Dragons

      By LIMadrim15 · Posted

    • G0HAN A LENDA
      Black Screen minecraft forge, help

      By G0HAN A LENDA · Posted

      All versions of Minecraft Forge suddenly black screen even without mods (tried reinstalling original Minecraft, Java, updating drivers doesn't work)
    • TileEntity
      Minecraft crash when i open indentity menu

      By TileEntity · Posted

      identity is conflicting with scguns
    • Bugplayer
      Minecraft crash when i open indentity menu

      By Bugplayer · Posted

      When i join minecraft all ok, when i join world all working fine, but when i open indentity menu, i get this The game crashed whilst unexpected error Error: java.lang.NullPointerException: Cannot invoke "top.ribs.scguns.common.Gun$Projectile.getDamage()" because "this.projectile" is null crash report here https://paste.ee/p/0vKaf

  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept