[1.8.9] Mana bar reset

[JimiIT92]

I was trying to add a mana bar following this tutorial

https://github.com/coolAlias/Forge_Tutorials/blob/master/IExtendedEntityPropertiesTutorial.java#L102

 

The bar actually works, is decreased as well. However if the player logout and then relogin the bar reset.

This is the ExtendedProperties class i'm using

package com.rpg.player;

import net.minecraft.entity.Entity;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.world.World;
import net.minecraftforge.common.IExtendedEntityProperties;

public class ExtendedPlayer implements IExtendedEntityProperties{

public final static String EXT_PROP_NAME = "ExtendedPlayer";
private final EntityPlayer player;

private int currentMana;
private int maxMana;

public ExtendedPlayer(EntityPlayer player) {
	this.player = player;
	this.currentMana = this.maxMana = 50;
}

public static final void register(EntityPlayer player) {
	player.registerExtendedProperties(EXT_PROP_NAME, new ExtendedPlayer(player));
}

public static final ExtendedPlayer get(EntityPlayer player) {
	return (ExtendedPlayer) player.getExtendedProperties(EXT_PROP_NAME);
}

@Override
public void saveNBTData(NBTTagCompound compound) {
	NBTTagCompound properties = new NBTTagCompound();
	properties.setInteger("CurrentMana", this.currentMana);
	properties.setInteger("MaxMana", this.maxMana);
	compound.setTag(EXT_PROP_NAME, properties);
}

@Override
public void loadNBTData(NBTTagCompound compound) {
	NBTTagCompound properties = (NBTTagCompound) compound.getTag(EXT_PROP_NAME);
	this.currentMana = properties.getInteger("CurrentMana");
	this.maxMana = properties.getInteger("MaxMana");

	System.out.println("[Mana from NBT] " + this.currentMana + "/" + this.maxMana);
}

@Override
public void init(Entity entity, World world) {}

public boolean consumeMana(int amount) {
	boolean sufficient = amount <= this.currentMana;
	this.currentMana -= (amount < this.currentMana ? amount : this.currentMana);
	return sufficient;
}

public int getCurrentMana() {
	return this.currentMana;
}

public int getMaxMana() {
	return this.maxMana;
}

public void replenishMana() {
	this.currentMana = this.maxMana;
}

}

 

And this is the EventHandler

package com.rpg.events;

import com.rpg.player.ExtendedPlayer;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraftforge.event.entity.EntityEvent.EntityConstructing;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;

public class EventHandler {

@SubscribeEvent
public void onEntityConstructing(EntityConstructing event) {
	if(event.entity instanceof EntityPlayer && ExtendedPlayer.get((EntityPlayer)event.entity) == null) {
		ExtendedPlayer.register((EntityPlayer)event.entity);
	}
}
}

 

Every time a player relogs in the world, the readFromNBT prints out that the current mana is 50 (the max mana value). How can i solve this?

[Ernio]

IEEP is out-of-use.

 

http://mcforge.readthedocs.org/en/latest/datastorage/capabilities/

[JimiIT92]

Mmm, is there an example of a custom capability class? I did not understand how to implement a custom one since is the first time i'm working with this

[coolAlias]

Sounds to me like you are only consuming mana client-side, so it appears to work via the mana bar, but the server side values are not actually changing and those are the ones that get saved and loaded via NBT. This is relevant whether you use the outdated IEEP or update to use the newer Capability system.

[JimiIT92]

I'm trying to update to use Capability but i really understand anything However i've added a first join check (to give an item to the player if is the very first time he join a world) and this it saves if the player logout (so first login the player gets the item, the if he logs out and then relog he did not get the item as he's already joined one time). So i don't understand why that works but the mana don't

This is the updated class (still IEPP)

package com.rpg.player;

import net.minecraft.entity.Entity;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.world.World;
import net.minecraftforge.common.IExtendedEntityProperties;

public class ExtendedPlayer implements IExtendedEntityProperties{

public final static String EXT_PROP_NAME = "ExtendedPlayer";
private final EntityPlayer player;

private int currentMana;
private int maxMana;

private boolean firstJoin;

public ExtendedPlayer(EntityPlayer player) {
	this.player = player;
	this.maxMana = 50;
	this.firstJoin = true;
}

public void setCurrentMana(int amount) {
	this.currentMana = amount;
}

public static final void register(EntityPlayer player) {
	player.registerExtendedProperties(EXT_PROP_NAME, new ExtendedPlayer(player));
}

public static final ExtendedPlayer get(EntityPlayer player) {
	return (ExtendedPlayer) player.getExtendedProperties(EXT_PROP_NAME);
}

@Override
public void saveNBTData(NBTTagCompound compound) {
	NBTTagCompound properties = new NBTTagCompound();
	properties.setInteger("CurrentMana", this.currentMana);
	properties.setInteger("MaxMana", this.maxMana);
	properties.setBoolean("FirstJoin", this.firstJoin);
	compound.setTag(EXT_PROP_NAME, properties);
}

@Override
public void loadNBTData(NBTTagCompound compound) {
	NBTTagCompound properties = (NBTTagCompound) compound.getTag(EXT_PROP_NAME);
	this.firstJoin = properties.getBoolean("FirstJoin");
	this.currentMana = properties.getInteger("CurrentMana");
	this.maxMana = properties.getInteger("MaxMana");


	System.out.println("First Join? " + this.firstJoin);
	System.out.println("[Mana from NBT] " + this.currentMana + "/" + this.maxMana);
}

public boolean isFirstJoin() {
	return this.firstJoin;
}

public void setJoined() {
	this.firstJoin = false;
}

@Override
public void init(Entity entity, World world) {}

public boolean consumeMana(int amount) {
	boolean sufficient = amount <= this.currentMana;
	this.currentMana -= (amount < this.currentMana ? amount : this.currentMana);
	return sufficient;
}

public int getCurrentMana() {
	return this.currentMana;
}

public int getMaxMana() {
	return this.maxMana;
}

public void replenishMana() {
	this.currentMana = this.maxMana;
}

}

[coolAlias]

Show where you are consuming mana from, e.g. an Item class or something.

[Choonster]

For examples of capabilities, look at the capabilities provided by Forge itself (

CapabilityItemHandler

,

CapabilityFluidHandler

,

CapabilityAnimation

), the Forge capability test mod or my own mod's capabilities (API, implementation).

[JimiIT92]

@coolAlias

The mana is used whenever a player press the skill button (added by a key handler, default Z). This is the code of the key handler

package com.rpg.events;

import org.lwjgl.input.Keyboard;

import com.rpg.player.ExtendedPlayer;

import net.minecraft.client.Minecraft;
import net.minecraft.client.settings.KeyBinding;
import net.minecraftforge.fml.client.registry.ClientRegistry;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;
import net.minecraftforge.fml.common.gameevent.TickEvent.Phase;
import net.minecraftforge.fml.common.gameevent.TickEvent.PlayerTickEvent;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;

public class KeyHandler
{
public static KeyBinding skill_1 = new KeyBinding("Skill 1", Keyboard.KEY_Z, "key.categories.skills");
public static KeyBinding skill_2 = new KeyBinding("Skill 2", Keyboard.KEY_X, "key.categories.skills");
public static KeyBinding skill_3 = new KeyBinding("Skill 3", Keyboard.KEY_C, "key.categories.skills");
public static KeyBinding skill_4 = new KeyBinding("Skill 4", Keyboard.KEY_V, "key.categories.skills");

public KeyHandler()
{
	ClientRegistry.registerKeyBinding(skill_1);
	ClientRegistry.registerKeyBinding(skill_2);
	ClientRegistry.registerKeyBinding(skill_3);
	ClientRegistry.registerKeyBinding(skill_4);
}

@SideOnly(Side.CLIENT)
@SubscribeEvent
public void playerTick(PlayerTickEvent event)
{
	if (event.side == Side.SERVER) return;
	if (event.phase == Phase.START)
	{
		Minecraft mc = Minecraft.getMinecraft();
		if (skill_1.isPressed())
		{
			ExtendedPlayer props = ExtendedPlayer.get(event.player);
			if(props.consumeMana(15)) {
				System.out.println("[sKILL 1] Player had enough mana to use");
			}
			else {
				System.out.println("[sKILL 1] Player ran out of mana");
				props.replenishMana();
			}
		}
		if (skill_2.isPressed())
		{

		}
		if (skill_3.isPressed())
		{

		}
		if (skill_4.isPressed())
		{

		}
	}
}
}

@Choonster

Thank you for the link, i'll check it right now

[Draco18s]

Mm. Yep, that's client side code. The server has no idea WTF is going on.

[coolAlias]

In other words, as I suspected, you have to send a packet - you can't just change mana values on the client. This is true whether you use Capabilities or not.

 

Key press to activate some magic skill -> send packet to server saying 'hey this key was pressed' -> server decides what to do e.g. consume mana and activate skill -> server then notifies client of whatever it needs to know e.g. new current mana amount so mana bar can display properly.

[JimiIT92]

So the problem is that i must send a packet to the server with the current amount of mana, am i right? If so how can i create and send this packet? (never worked with packets )

[JimiIT92]

Ok, so i've added a packet/message handler, but now when i press Z i get this crash

[18:59:41] [Client thread/ERROR] [FML]: FMLIndexedMessageCodec exception caught
io.netty.handler.codec.EncoderException: java.lang.IndexOutOfBoundsException: readerIndex(0) + length(4) exceeds writerIndex(1): UnpooledHeapByteBuf(ridx: 0, widx: 1, cap: 256)
at io.netty.handler.codec.MessageToMessageEncoder.write(MessageToMessageEncoder.java:107) ~[MessageToMessageEncoder.class:4.0.23.Final]
at io.netty.handler.codec.MessageToMessageCodec.write(MessageToMessageCodec.java:116) ~[MessageToMessageCodec.class:4.0.23.Final]
at io.netty.channel.AbstractChannelHandlerContext.invokeWrite(AbstractChannelHandlerContext.java:658) ~[AbstractChannelHandlerContext.class:4.0.23.Final]
at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:716) ~[AbstractChannelHandlerContext.class:4.0.23.Final]
at io.netty.channel.AbstractChannelHandlerContext.writeAndFlush(AbstractChannelHandlerContext.java:706) ~[AbstractChannelHandlerContext.class:4.0.23.Final]
at io.netty.channel.AbstractChannelHandlerContext.writeAndFlush(AbstractChannelHandlerContext.java:741) ~[AbstractChannelHandlerContext.class:4.0.23.Final]
at io.netty.channel.DefaultChannelPipeline.writeAndFlush(DefaultChannelPipeline.java:895) ~[DefaultChannelPipeline.class:4.0.23.Final]
at io.netty.channel.AbstractChannel.writeAndFlush(AbstractChannel.java:240) ~[AbstractChannel.class:4.0.23.Final]
at net.minecraftforge.fml.common.network.simpleimpl.SimpleNetworkWrapper.sendToServer(SimpleNetworkWrapper.java:269) [simpleNetworkWrapper.class:?]
at com.rpg.events.KeyHandler.playerTick(KeyHandler.java:43) [KeyHandler.class:?]
at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_8_KeyHandler_playerTick_PlayerTickEvent.invoke(.dynamic) [?:?]
at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:55) [ASMEventHandler.class:?]
at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:140) [EventBus.class:?]
at net.minecraftforge.fml.common.FMLCommonHandler.onPlayerPreTick(FMLCommonHandler.java:352) [FMLCommonHandler.class:?]
at net.minecraft.entity.player.EntityPlayer.onUpdate(EntityPlayer.java:248) [EntityPlayer.class:?]
at net.minecraft.client.entity.EntityPlayerSP.onUpdate(EntityPlayerSP.java:163) [EntityPlayerSP.class:?]
at net.minecraft.world.World.updateEntityWithOptionalForce(World.java:2009) [World.class:?]
at net.minecraft.world.World.updateEntity(World.java:1974) [World.class:?]
at net.minecraft.world.World.updateEntities(World.java:1803) [World.class:?]
at net.minecraft.client.Minecraft.runTick(Minecraft.java:2176) [Minecraft.class:?]
at net.minecraft.client.Minecraft.runGameLoop(Minecraft.java:1080) [Minecraft.class:?]
at net.minecraft.client.Minecraft.run(Minecraft.java:380) [Minecraft.class:?]
at net.minecraft.client.main.Main.main(Main.java:116) [Main.class:?]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_92]
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_92]
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_92]
at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_92]
at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) [launchwrapper-1.12.jar:?]
at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.12.jar:?]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_92]
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_92]
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_92]
at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_92]
at net.minecraftforge.gradle.GradleStartCommon.launch(GradleStartCommon.java:97) [start/:?]
at GradleStart.main(GradleStart.java:26) [start/:?]
Caused by: java.lang.IndexOutOfBoundsException: readerIndex(0) + length(4) exceeds writerIndex(1): UnpooledHeapByteBuf(ridx: 0, widx: 1, cap: 256)
at io.netty.buffer.AbstractByteBuf.checkReadableBytes(AbstractByteBuf.java:1175) ~[AbstractByteBuf.class:4.0.23.Final]
at io.netty.buffer.AbstractByteBuf.readInt(AbstractByteBuf.java:619) ~[AbstractByteBuf.class:4.0.23.Final]
at net.minecraft.network.PacketBuffer.readInt(PacketBuffer.java:697) ~[PacketBuffer.class:?]
at com.rpg.messages.KeyPressed.toBytes(KeyPressed.java:26) ~[KeyPressed.class:?]
at net.minecraftforge.fml.common.network.simpleimpl.SimpleIndexedCodec.encodeInto(SimpleIndexedCodec.java:11) ~[simpleIndexedCodec.class:?]
at net.minecraftforge.fml.common.network.simpleimpl.SimpleIndexedCodec.encodeInto(SimpleIndexedCodec.java:7) ~[simpleIndexedCodec.class:?]
at net.minecraftforge.fml.common.network.FMLIndexedMessageToMessageCodec.encode(FMLIndexedMessageToMessageCodec.java:55) ~[FMLIndexedMessageToMessageCodec.class:?]
at io.netty.handler.codec.MessageToMessageCodec$1.encode(MessageToMessageCodec.java:67) ~[MessageToMessageCodec$1.class:4.0.23.Final]
at io.netty.handler.codec.MessageToMessageEncoder.write(MessageToMessageEncoder.java:89) ~[MessageToMessageEncoder.class:4.0.23.Final]
... 34 more

 

This is how the KeyHandler looks now

package com.rpg.events;

import org.lwjgl.input.Keyboard;

import com.rpg.RPG;
import com.rpg.messages.KeyPressed;
import com.rpg.player.ExtendedPlayer;

import net.minecraft.client.Minecraft;
import net.minecraft.client.settings.KeyBinding;
import net.minecraftforge.fml.client.registry.ClientRegistry;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;
import net.minecraftforge.fml.common.gameevent.TickEvent.Phase;
import net.minecraftforge.fml.common.gameevent.TickEvent.PlayerTickEvent;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;

public class KeyHandler
{
public static KeyBinding skill_1 = new KeyBinding("Skill 1", Keyboard.KEY_Z, "key.categories.skills");
public static KeyBinding skill_2 = new KeyBinding("Skill 2", Keyboard.KEY_X, "key.categories.skills");
public static KeyBinding skill_3 = new KeyBinding("Skill 3", Keyboard.KEY_C, "key.categories.skills");
public static KeyBinding skill_4 = new KeyBinding("Skill 4", Keyboard.KEY_V, "key.categories.skills");

public KeyHandler()
{
	ClientRegistry.registerKeyBinding(skill_1);
	ClientRegistry.registerKeyBinding(skill_2);
	ClientRegistry.registerKeyBinding(skill_3);
	ClientRegistry.registerKeyBinding(skill_4);
}

@SideOnly(Side.CLIENT)
@SubscribeEvent
public void playerTick(PlayerTickEvent event)
{
	if (event.side == Side.SERVER) return;
	if (event.phase == Phase.START)
	{
		Minecraft mc = Minecraft.getMinecraft();
		if (skill_1.isPressed())
		{
			RPG.INSTANCE.sendToServer(new KeyPressed(skill_1.getKeyCode()));
		}
		if (skill_2.isPressed())
		{

		}
		if (skill_3.isPressed())
		{

		}
		if (skill_4.isPressed())
		{

		}
	}
}
}

Basically i send a message to the server with the code of the key pressed

 

This is the KeyPressed message that i send

package com.rpg.messages;

import io.netty.buffer.ByteBuf;
import net.minecraftforge.fml.common.network.simpleimpl.IMessage;

public class KeyPressed implements IMessage{

public int toSend;

public KeyPressed() {
	this.toSend = 0;
}

public KeyPressed(int key) {
	this.toSend = key;
}

@Override
public void fromBytes(ByteBuf buf) {
	System.out.println("FROM " + this.toSend);
	buf.writeInt(this.toSend);
}

@Override
public void toBytes(ByteBuf buf) {
	System.out.println("TO " + buf.readInt());
	this.toSend = buf.readInt();
}

}

 

And this is the MessageHandler

package com.rpg.messages;

import com.rpg.events.KeyHandler;
import com.rpg.player.ExtendedPlayer;

import net.minecraftforge.fml.common.network.simpleimpl.IMessage;
import net.minecraftforge.fml.common.network.simpleimpl.IMessageHandler;
import net.minecraftforge.fml.common.network.simpleimpl.MessageContext;
import scala.xml.TopScope;

public class MessageHandler implements IMessageHandler<KeyPressed, IMessage>{

public MessageHandler() {

}

@Override
public IMessage onMessage(KeyPressed message, MessageContext ctx) {
	ExtendedPlayer props = ExtendedPlayer.get(ctx.getServerHandler().playerEntity);
	int key = message.toSend;
	if(key == KeyHandler.skill_1.getKeyCode())
		if(props.consumeMana(15)) {
			System.out.println("[sKILL 1] Player had enough mana to use");
		}
		else {
			System.out.println("[sKILL 1] Player ran out of mana");
			props.replenishMana();
		}
	return null;
}

}

 

Registered in the init method with

MinecraftForge.EVENT_BUS.register(new MessageHandler());

 

Also the SimpleNetworkMapper instance is created and registered in the init method

public static SimpleNetworkWrapper INSTANCE;

....

    	INSTANCE = NetworkRegistry.INSTANCE.newSimpleChannel(RPG.MODID);
    	INSTANCE.registerMessage(MessageHandler.class, KeyPressed.class, 0, Side.SERVER);

[coolAlias]

That's because you call #readInt() twice, but #writeInt() only once. They must be exactly the same.

 

Removing your System.out or swapping it to after you read and using the actual field instead of another call to #readInt() will fix it.

[JimiIT92]

Done but still get the same error

[JimiIT92]

I've uploaded all the code to a git repo

https://github.com/JimiIT92/RPGMod

[JimiIT92]

So i should not send the keycode but instead a specific number (for example: 1 for first skill, 2 for second...) ?

[JimiIT92]

Ok. So now i've updated the key handler and the message handler code to send/check specific values, but nothing changed, still got the out of bounds exception

[JimiIT92]

Sooooo what should i change?

[JimiIT92]

Oh  ;D In fact now i get no error But the GUI does not update, so i assume i should send a packet to the client in response with the current amount of mana or what?

[JimiIT92]

Ok, so i've added message and handler for the mana value (server send to client the current amount of mana after the skill), but of course i can't use  getServerHandler() in the onMessage method, so what should i use? (Tried getClientHandler but don't know how to get the equivalent result)

 

EDIT: fixed that (see git), but still if the player log out a world and then login the bar is full (but when it cast a skill it goes to the right value, so if before logout the mana was 75, when he relog and use a skill, he bar will go to 50 (75 he had before - 15 just used))

[coolAlias]

Minecraft.getMinecraft().thePlayer - but really you should make a proxy method that fetches the player entity given the current context / side, and your ClientProxy would return the above.

[JimiIT92]

I use that event to check if the player first join a world. In that event i get the IEEP of the the player, so what should i add to also set the GUI?

[coolAlias]

If you have multiple fields that need to be synced to the client (e.g. mana + some other thing to display on the HUD), I'd create one packet for each of them to send when they change individually, and one packet that syncs all of them for when the player joins the world. This way you aren't sending a bunch of extra data that hasn't changed when you don't need to.

 

Of course if you only have 2 integers or some such it won't make much of a difference, but the network traffic can start to add up as the amount of data you need to send becomes more and more.

[JimiIT92]

I use this to notify the client

RPG.INSTANCE.sendTo(new ManaValue(props.getCurrentMana()), player);

 

but player is an EntityPlayerMP, wich it isn't in the event

If i do

RPG.INSTANCE.sendTo(new ManaValue(props.getCurrentMana()), (EntityPlayerMP) event.player);

It will crash

[JimiIT92]

Don't know why but reloaded the game and it doesn't crash O_o That fully works now Thanks for the precious help to everybody