Search the Forums BEFORE making a new post.

Currently supported: All versions

Brewing Recipe Help [1.10.2]

Posted August 4, 20169 yr

My system works fine but i can brew a resistance potion with a resistance potion. Any help?

Here is the class that extends IBrewingRecipe:

public class PotionRecipe implements IBrewingRecipe{

private ItemStack input;

private ItemStack ingredient;

private ItemStack output;

public PotionRecipe(ItemStack input, ItemStack ingredient, ItemStack output) {

this.input = input;

this.ingredient = ingredient;

this.output = output;

}

@Override

public boolean isInput(ItemStack input2) {

if(!input2.hasTagCompound())

return false;

return PotionUtils.getPotionFromItem(input2)==PotionUtils.getPotionFromItem(this.input);

}

@Override

public boolean isIngredient(ItemStack ingredient2) {

return ingredient2.getItem()==Items.REDSTONE || ingredient2.getItem()==Items.GLOWSTONE_DUST || ingredient2.getItem()==Items.IRON_INGOT||ingredient2.getItem()==Items.FERMENTED_SPIDER_EYE;

}

@Override

public ItemStack getOutput(ItemStack input2, ItemStack ingredient2) {

if(ingredient2 != null && input2 != null && isIngredient(ingredient2)) {

ItemStack output2 = this.output.copy();

if (input2 != output2)

{

return output2;

}

return null;

}

else

return null;

}

How I register the recipes:

public void postInit(FMLPostInitializationEvent event)

{BrewingRecipeRegistry.addRecipe(new PotionRecipe(PotionUtils.addPotionToItemStack(new ItemStack(Items.POTIONITEM,1), CustomPotionTypes.resistance), new ItemStack(Items.FERMENTED_SPIDER_EYE,1), PotionUtils.addPotionToItemStack(new ItemStack(Items.POTIONITEM,1), CustomPotionTypes.weakening)));

BrewingRecipeRegistry.addRecipe(new PotionRecipe(PotionUtils.addPotionToItemStack(new ItemStack(Items.POTIONITEM,1), PotionTypes.AWKWARD), new ItemStack(Items.IRON_INGOT,1), PotionUtils.addPotionToItemStack(new ItemStack(Items.POTIONITEM,1), CustomPotionTypes.resistance)));

}

Quote

August 4, 20169 yr

Why not use

BrewingRecipeRegistry.addRecipe(input, ingredient, output);

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Quote

August 4, 20169 yr

Author

It doesn't differentiate between different potions

Quote

August 4, 20169 yr

In get output you never check if input2 is input. And honestly forge why would you just check to see if the item is the same when you should be comparing ItemStacks.....

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Quote

August 4, 20169 yr

Note these edits work for me.

           // This
   @Override
   public boolean isInput(ItemStack input2) {
      if(!input2.hasTagCompound())
         return false;
      return PotionType.getPotionTypeForName(input2.getTagCompound().getString("Potion")) == PotionType.getPotionTypeForName(input.getTagCompound().getString("Potion"));
   }
           // And this
   @Override
   public ItemStack getOutput(ItemStack input2, ItemStack ingredient2) {
	   if(ingredient2 != null && input2 != null && isIngredient(ingredient2))  {
		   ItemStack output2 = this.output.copy();
		   if (input2 != output2 && isInput(input2)) {
			   return output2;
		   } return null;
	   }  else
		   return null;
   }

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Quote

August 4, 20169 yr

Author

That doesn't seems to solve the problem. I'm pretty sure that the check that you edit didn't change anything.The isInput was my fault ,though . The problem with the system is that even though iron ingot brew the resistance one and fermented spider eye brews the resistance potion to the weakening one, the iron ingot still brew the resistance potion to itself.

Quote

August 4, 20169 yr

May I see the code you used to register the potions?

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Quote

August 4, 20169 yr

Author

I assume you mean the potiontypes:

public class CustomPotionTypes {

public static PotionType resistance;

public static PotionType weakening;

public static void init(){

resistance= GameRegistry.register(new PotionType(new PotionEffect(MobEffects.RESISTANCE, 1800)).setRegistryName("resistance"));

weakening= GameRegistry.register(new PotionType(new PotionEffect(CustomPotion.weakening, 1800)).setRegistryName("weakening"));

}}

In the Mod file:

public void preInit(FMLPreInitializationEvent event)

{

CustomPotionTypes.init();

}

Quote

August 5, 20169 yr

Could you post your updated code for PotionRecipes?

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Quote

August 5, 20169 yr

Author

package minh2908.ores.init.potion;

import net.minecraft.init.Items;

import net.minecraft.item.ItemStack;

import net.minecraft.potion.PotionType;

import net.minecraftforge.common.brewing.IBrewingRecipe;

public class PotionRecipe implements IBrewingRecipe{

private ItemStack input;

private ItemStack ingredient;

private ItemStack output;

public PotionRecipe(ItemStack input, ItemStack ingredient, ItemStack output) {

this.input = input;

this.ingredient = ingredient;

this.output = output;

}

@Override

public boolean isInput(ItemStack input2) {

if(!input2.hasTagCompound())

return false;

return PotionType.getPotionTypeForName(input2.getTagCompound().getString("Potion")) == PotionType.getPotionTypeForName(input.getTagCompound().getString("Potion"));

}

@Override

public boolean isIngredient(ItemStack ingredient2) {

return ingredient2.getItem()==Items.REDSTONE || ingredient2.getItem()==Items.GLOWSTONE_DUST || ingredient2.getItem()==Items.IRON_INGOT||ingredient2.getItem()==Items.FERMENTED_SPIDER_EYE;

}

@Override

public ItemStack getOutput(ItemStack input2, ItemStack ingredient2) {

if(ingredient2 != null && input2 != null && isIngredient(ingredient2)) {

ItemStack output2 = this.output.copy();

if (input2 != output2 && isInput(input2))

{

return output2;

}

return null;

}

else

return null;

}

Quote

August 5, 20169 yr

May I see your entire Main Class?

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Quote

August 5, 20169 yr

Author

I've found the solution! Turns out the ingredient check was defective . Thanks for your help, though, especially on reminding me of the ingredient check.

Quote

August 5, 20169 yr

Post the change here please for future people that have this problem.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Quote

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.

Reply to this topic...

https://forums.minecraftforge.net/topic/40897-brewing-recipe-help-1102/

Followers

Go to topic listing

IPS spam blocked by CleanTalk.

Announcements

Is this forum active?

hello everyone..!

By WinX · 4 hours ago4 hr
How to add my mob to another mod's biome in 1.20.1.

tysm

By ilov3gam3z · 16 hours ago16 hr
Orbital strike cannon fishing rod mod

was focused on school so didnt respond u think ur gonna get 1.21+ done by this week? @FoxyWoxy

By Astoxy · 23 hours ago23 hr
How to add my mob to another mod's biome in 1.20.1.

You can add mob spawns using Forge's Biome Modifiers feature. I won't go into details on how to use a data generator for them, but here's a simple example:
{ "type": "forge:add_spawns", // Required "biomes": "#namespace:biome_tag", // Accepts a biome id, [list of biome ids], or #namespace:biome_tag "spawners": { "type": "namespace:entity_type", // Type of mob to spawn "weight": 100, // int, spawn weighting "minCount": 1, // int, minimum pack size "maxCount": 4 // int, maximum pack size } }This JSON file would go somewhere like this: data/modid/forge/biome_modifier/your_biome_modifier.json

By Jonathing · Yesterday at 12:10 AM1 day
How to change player renderer and transform model parts?

I have been trying for a while now to make a custom player renderer, and replace the vanilla player renderer with it. So far I've come up with a custom player renderer class that extends vanilla PlayerRenderer:
package com.FireDude123.BOTW.entity.renderer; import com.mojang.blaze3d.vertex.PoseStack; import net.minecraft.client.player.AbstractClientPlayer; import net.minecraft.client.renderer.MultiBufferSource; import net.minecraft.client.renderer.entity.player.PlayerRenderer; import net.minecraft.client.renderer.entity.EntityRendererProvider; import net.minecraftforge.client.event.RenderPlayerEvent; import net.minecraftforge.common.MinecraftForge; public class PoseablePlayerRenderer extends PlayerRenderer { public PoseablePlayerRenderer(EntityRendererProvider.Context ctx, boolean slim) { super(ctx, slim); System.out.println("here too"); } @Override public void render(AbstractClientPlayer p_117788_, float p_117789_, float p_117790_, PoseStack poseStack, MultiBufferSource p_117792_, int p_117793_) { System.out.println("didnt get here lol"); model.leftArm.xRot=(float)Math.toRadians(160); super.render(p_117788_, p_117789_, p_117790_, poseStack, p_117792_, p_117793_); } } As you can see, the intended purpose of this is to raise the player's left arm by 160 degrees. However, combined with this logic in ClientModEvents:
@Mod.EventBusSubscriber(modid = MODID, bus = Mod.EventBusSubscriber.Bus.MOD, value = Dist.CLIENT) public static class ClientModEvents { @SubscribeEvent public static void onClientSetup(FMLClientSetupEvent event) { EntityRenderers.register((EntityType<? extends AbstractClientPlayer>)(EntityType<?)EntityType.PLAYER, ctx -> new PoseablePlayerRenderer(ctx, true)); EntityRenderers.register(Entities.MAGNESIS_BLOCK.get(), com.FireDude123.BOTW.entity.renderer.BlockDisplayRenderer::new); EntityRenderers.register(Entities.REMOTE_BOMB.get(), ThrownItemRenderer::new); EntityRenderers.register(Entities.CRYONIS_ICE.get(), com.FireDude123.BOTW.entity.renderer.BlockDisplayRenderer::new); EntityRenderers.register(Entities.STASIS_BLOCK.get(), FallingBlockRenderer::new); } @SubscribeEvent public static void registerLayerDefinitions(EntityRenderersEvent.RegisterLayerDefinitions event) { event.registerLayerDefinition(new ModelLayerLocation(new ResourceLocation(BOTW.MODID, "paraglider"), "main"), ParagliderLayer::createBodyLayer); } }(I also have a paraglider layer here for something else, it's working perfectly fine, also I used the slim setting because the player is slim in 1.20.1 forge)
This logic isn't replacing the renderer, as far as I can tell. Can someone please advise as to why, and how to fix it?

By FireDude123 · Posted Thursday at 12:07 AM2 days

TileEntity

Sign In

Brewing Recipe Help [1.10.2]

Featured Replies

Join the conversation

Posts

Is this forum active?

How to add my mob to another mod's biome in 1.20.1.

Orbital strike cannon fishing rod mod

How to add my mob to another mod's biome in 1.20.1.

How to change player renderer and transform model parts?

Who's Online (See full list)

Important Information

Account

Navigation

Search

Configure browser push notifications

Chrome (Android)

Chrome (Desktop)

Safari (iOS 16.4+)

Safari (macOS)

Edge (Android)

Edge (Desktop)

Firefox (Android)

Firefox (Desktop)