[1.10] Check if block can be harvested and then harvest it without player object

[SamTebbs33]

I am writing some code that will harvest a number of blocks around it (all of which implement IGrowable) and to stop abuse and breaking the mechanics of other mods I will need to check if the block is harvest-able with canHarvestBlock(...) and then harvest it with harvestBlock(...) if it is. These methods require an EntityPlayer object, which isn't applicable since the code will be run from within a tile entity. I could pass null as the player value but I never like doing that due to the risk of running into an NPE. Is there some accepted or established method of checking if a block is harvest-able and then harvesting it without using an EntityPlayer object? I'm open to using libraries.

[Ernio]

Lookup HarvestDropsEvent docs.

Yes - that is even fired when harvestBlock(...) happens and yes - as per design - it expects null players.

[SamTebbs33]

  On 8/21/2016 at 7:29 PM, Ernio said:

Lookup HarvestDropsEvent docs.

Yes - that is even fired when harvestBlock(...) happens and yes - as per design - it expects null players.

 

Will I need to fire the HarvestDropsEvent in order to break the block and spawn the drops? I tried calling canHarvestBlock() with a null player object and as expected I got an NPE.

[Animefan8888]

  On 8/21/2016 at 6:11 PM, SamTebbs33 said:

I am writing some code that will harvest a number of blocks around it (all of which implement IGrowable) and to stop abuse and breaking the mechanics of other mods I will need to check if the block is harvest-able with canHarvestBlock(...) and then harvest it with harvestBlock(...) if it is. These methods require an EntityPlayer object, which isn't applicable since the code will be run from within a tile entity. I could pass null as the player value but I never like doing that due to the risk of running into an NPE. Is there some accepted or established method of checking if a block is harvest-able and then harvesting it without using an EntityPlayer object? I'm open to using libraries.

I have never seen anything that requires a tool to be used to break an IGrowable object, but you could create a fake player.

From BlockEvent.BreakEvent

/** Reference to the Player who broke the block. If no player is available, use a EntityFakePlayer */

Or even store the players UUID and Name when they place it, then check if they are on use the player if so, if not create one(recommend the first more).

[Ernio]

harvestBlock(...) - ALLOWS null player because harvesting can occur without player (e.g explosion).

canHarvestBlock(...) - DOESN'T allow, because it is player-specific check. Why the hell would you even use this check if player is NOT harvesting given block? Just don't use it. If you really need some safety check - do it yourself, write helper method similar to canHarvestBlock. What is so difficult?

 

And no - you don't fire the event, I just mentioned it as a docs reference.

[imadnsn]

Block#canHarvestBlock

is used to check whether the player has the tool to break the block or fire a

PlayerEvent.HarvestCheck

if he doesn't have the required tool to check whether he can. other mods may have other implementations but that's the forge implementation in the Block class

[SamTebbs33]

  On 8/22/2016 at 5:56 AM, Ernio said:

canHarvestBlock(...) - DOESN'T allow, because it is player-specific check. Why the hell would you even use this check if player is NOT harvesting given block? Just don't use it. If you really need some safety check - do it yourself, write helper method similar to canHarvestBlock. What is so difficult?

 

I just thought that canHarvestBlock() was the general (not player-specific) way of checking if a block is harvestable and thought I should be calling it in order to not harvest blocks that shouldn't be harvestable by a non-player entity/machine. Please don't get so hostile all of a sudden.

[SamTebbs33]

  On 8/21/2016 at 9:58 PM, Animefan8888 said:

I have never seen anything that requires a tool to be used to break an IGrowable object, but you could create a fake player.

 

Thanks! I'll go with this solution.

[Draco18s]

  On 8/22/2016 at 11:46 AM, SamTebbs33 said:

I just thought that canHarvestBlock() was the general (not player-specific) way of checking if a block is harvestable

 

"Harvestable" requires a tool to be involved.

Tools can only be used by players.

Ergo a player object is needed.

 

Q.E.D.

[Ernio]

  On 8/22/2016 at 11:46 AM, SamTebbs33 said:

Please don't get so hostile all of a sudden.

 

At this point I would be scared of giving you a flower - too hostile!

Like seriously - what was so hostile in that/my response? There is literally no hard language there.

 

Anyway - cheers to solution.