Jump to content

[1.10.2] [SOLVED] Obtaining an int[] of the player's skin ingame


Rockdude101
 Share

Recommended Posts

As a part of my mod, I need to be able to take control of rendering the player, so I handled the necessary event and redirected the call to RenderPlayer.doRender to my own renderer's doRender method. As far as I know, this code is perfectly fine, but I'm including it in case the event itself is necessary for the following problem:

	@SubscribeEvent
public void onPlayerRender(RenderPlayerEvent.Pre event){
	event.setCanceled(true);
	float f=event.getEntityPlayer().prevRotationYaw + (event.getEntityPlayer().rotationYaw - event.getEntityPlayer().prevRotationYaw) * event.getPartialRenderTick();
	DNATRenderPlayer.instance.doRender((AbstractClientPlayer) event.getEntityPlayer(), event.getX(), event.getY(), event.getZ(), f, event.getPartialRenderTick());
}

Now, within DNATRenderPlayer.doRender, everything is the same as RenderPlayer.doRender, except with its calls to RenderLivingBase.doRender and Render.doRender being pasted directly into the method instead of being called using super.doRender. This is so I can call my own versions of RenderLiving.renderModel and Render.bindEntityTexture. My current goal is to get the player's skin as an int[] so that I can tweak it and then bind the modified version. Currently, this is my code for this:

    protected boolean bindEntityTexture(AbstractClientPlayer entity)
    {
        ResourceLocation resourcelocation = entity.getLocationSkin();

        if (resourcelocation == null)
        {
            return false;
        }
        else if(/*just testing for some entity capabilities here*/)
        {
        	int[] iA;
        	try {
        		iA=TextureUtil.readImageData(Minecraft.getMinecraft().getResourceManager(),entity.getLocationSkin());
        	} catch (Exception e) {
		ModDNAT.logger.error("Exception occurred when attempting to read player ResourceLocation.",e);
		return false;
	}
        	//manipulation of iA occurs here
            return true;
        }else{
            this.bindTexture(resourcelocation);
            return true;
        }
    }

However, a FileNotFoundException happens on the line where iA is set to whatever TextureUtil.readImageData returns. Upon digging through the stack trace, I found that FallbackResourceManager.getResource is throwing it:

public IResource getResource(ResourceLocation location) throws IOException
    {
        this.checkResourcePath(location);
        IResourcePack iresourcepack = null;
        ResourceLocation resourcelocation = getLocationMcmeta(location);

        for (int i = this.resourcePacks.size() - 1; i >= 0; --i)
        {
            IResourcePack iresourcepack1 = (IResourcePack)this.resourcePacks.get(i);

            if (iresourcepack == null && iresourcepack1.resourceExists(resourcelocation))
            {
                iresourcepack = iresourcepack1;
            }

            if (iresourcepack1.resourceExists(location))
            {
                InputStream inputstream = null;

                if (iresourcepack != null)
                {
                    inputstream = this.getInputStream(resourcelocation, iresourcepack);
                }

                return new SimpleResource(iresourcepack1.getPackName(), location, this.getInputStream(location, iresourcepack1), inputstream, this.frmMetadataSerializer);
            }
        }

And after looking at the function of this code, it seems that it is supposed to iterate through FallbackResourceManager.resourcePacks and find the texture that is called; though apparently, it's not there. After some more digging, I did find a file in C:/Users/Me/.gradle/caches/minecraft/assets/skins that matches the number after the FileNotFoundException explanation in the stacktrace, so I assume this is my cached skin, it's just not being found for some reason.

Just in case, here's the stacktrace:

 

java.io.FileNotFoundException: minecraft:skins/2510ebc9fffa367a507462d74c2eb2ebbd74cb9d889cc77f035799e68ad818b

at net.minecraft.client.resources.FallbackResourceManager.getResource(FallbackResourceManager.java:68) ~[FallbackResourceManager.class:?]

at net.minecraft.client.resources.SimpleReloadableResourceManager.getResource(SimpleReloadableResourceManager.java:65) ~[simpleReloadableResourceManager.class:?]

at net.minecraft.client.renderer.texture.TextureUtil.readImageData(TextureUtil.java:318) ~[TextureUtil.class:?]

at com.Rockdude101.DNAT.model.DNATRenderPlayer.bindEntityTexture(DNATRenderPlayer.java:248) [DNATRenderPlayer.class:?]

at com.Rockdude101.DNAT.model.DNATRenderPlayer.renderModel(DNATRenderPlayer.java:211) [DNATRenderPlayer.class:?]

at com.Rockdude101.DNAT.model.DNATRenderPlayer.doRender(DNATRenderPlayer.java:163) [DNATRenderPlayer.class:?]

at com.Rockdude101.DNAT.DNATEventHandler.onPlayerRender(DNATEventHandler.java:135) [DNATEventHandler.class:?]

at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_11_DNATEventHandler_onPlayerRender_Pre.invoke(.dynamic) [?:?]

at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:72) [ASMEventHandler.class:?]

at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:168) [EventBus.class:?]

at net.minecraft.client.renderer.entity.RenderPlayer.doRender(RenderPlayer.java:62) [RenderPlayer.class:?]

at net.minecraft.client.renderer.entity.RenderPlayer.doRender(RenderPlayer.java:28) [RenderPlayer.class:?]

at net.minecraft.client.renderer.entity.RenderManager.doRenderEntity(RenderManager.java:371) [RenderManager.class:?]

at net.minecraft.client.renderer.entity.RenderManager.renderEntityStatic(RenderManager.java:355) [RenderManager.class:?]

at net.minecraft.client.renderer.RenderGlobal.renderEntities(RenderGlobal.java:643) [RenderGlobal.class:?]

at net.minecraft.client.renderer.EntityRenderer.renderWorldPass(EntityRenderer.java:1368) [EntityRenderer.class:?]

at net.minecraft.client.renderer.EntityRenderer.renderWorld(EntityRenderer.java:1282) [EntityRenderer.class:?]

at net.minecraft.client.renderer.EntityRenderer.updateCameraAndRender(EntityRenderer.java:1091) [EntityRenderer.class:?]

at net.minecraft.client.Minecraft.runGameLoop(Minecraft.java:1139) [Minecraft.class:?]

at net.minecraft.client.Minecraft.run(Minecraft.java:406) [Minecraft.class:?]

at net.minecraft.client.main.Main.main(Main.java:118) [Main.class:?]

at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_101]

at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_101]

at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_101]

at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_101]

at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) [launchwrapper-1.12.jar:?]

at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.12.jar:?]

at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_101]

at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_101]

at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_101]

at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_101]

at net.minecraftforge.gradle.GradleStartCommon.launch(GradleStartCommon.java:97) [start/:?]

at GradleStart.main(GradleStart.java:26) [start/:?]

 

 

So, in short, this line:

iA=TextureUtil.readImageData(Minecraft.getMinecraft().getResourceManager(),entity.getLocationSkin());

is not actually finding the skin, even though it exists.

I should also note that I did have this same problem in a previous thread (http://www.minecraftforge.net/forum/index.php?topic=24897.0), but that was within a GUI and outside of the actual game, so I was able to resolve it my just handling the download code myself. Of course, this is pretty impractial for rendering.

Please let me know if you need any more code, and thanks in advance for any help.

Link to comment
Share on other sites

So, looking at the DynamicTexture object, I see two ways I could potentially get an int[] of the player's skin: either getting a DynamicTexture object itself and calling DynamicObject.getTextureData, or using mc.getTextureManager().getDynamicTextureLocation(String,DynamicTexture) to get a ResourceLocation that I assume might be useable with TextureUtil.readImageData. However, I can't find any functions that could possibly return a DynamicTexture, so the latter option seems to be the only option. Looking at calls of this function, it seems that the first String is the name of some texture: "modlogo","lightMap","texturepackicon", etc. So, should I be putting the player's texture UUID here to get the skin?

Of course, I might be looking at the wrong place, and if there is just a way to pull a BufferedImage of the player's cached skin from somewhere, that works too.

Please let me know what I should be doing with the DynamicTexture; I understand that the player's skin is likely stored in this format, but I'm not sure how even Minecraft references it.

Thanks for all of the help so far.

Link to comment
Share on other sites

I've looked over the ThreadDownloadImageData class to see how I can obtain the data inside, but the BufferedImage contained within is private and so far I haven't succeeded in using my own implementations of classes to get a variation of the ThreadDownloadImageData with the image public. At the moment, the only thing I can think of doing is just creating an entire new cache of player skins, since Minecraft's TextureManager just had the private image data classes.

Do you know of any other ways of pulling the int[] or BufferedImage from the player skin cache, or, if making my own cache is the only option, could you tell me how to go about doing that?

Link to comment
Share on other sites

Hi

 

You could use reflection and access modifiers to make the BufferedImage public.  It adds a bit of extra maintenance because you need to know both the obfuscated and the deobfuscated name of the variable, but it's pretty straightforward.

 

There's an example here:

https://github.com/TheGreyGhost/SpeedyTools/blob/V3-0-0/src/main/java/speedytools/clientside/userinput/KeyBindingInterceptor.java

in particular this bit

 

  private static final Field keybindArrayField = ReflectionHelper.findField(KeyBinding.class, "keybindArray", "field_74516_a");

 

The syntax will be slightly different because your field is non-static, but you seem to have enough of a clue to figure it out :)

 

An alternative which I've also used before is to render the skin into a framebuffer and then use that framebuffer as a texture.  It's a lot more complicated, but in case you're interested the code is here

https://github.com/TheGreyGhost/SpeedyTools/blob/V3-0-0/src/main/java/speedytools/clientside/selections/SelectionBlockTextures.java

(I used it to capture "flat" textures from rendered block models)

 

-TGG

 

 

 

Link to comment
Share on other sites

I tried to use the ReflectionHelper to get the BufferedImage public, but I don't think my implementation is correct, as the BufferedImage that I'm getting back is just returning null.

Here's the code that uses my superclass of ThreadDownloadImageData:

DNATThreadDownloadImageData itextureobject = (DNATThreadDownloadImageData)DNATThreadDownloadImageData.getDownloadImageSkin(entity.getLocationSkin(), entity.getName());
BufferedImage im=itextureobject.getBufferedImage();

And here's the superclass itself:

public class DNATThreadDownloadImageData extends ThreadDownloadImageData
{
public DNATThreadDownloadImageData(File cacheFileIn, String imageUrlIn,
		ResourceLocation textureResourceLocation, IImageBuffer imageBufferIn) {
	super(cacheFileIn, imageUrlIn, textureResourceLocation, imageBufferIn);
}
public BufferedImage getBufferedImage(){
	try {
		return (BufferedImage)ReflectionHelper.findField(ThreadDownloadImageData.class, "bufferedImage","field_110560_d").get(this);
	} catch (IllegalArgumentException e) {
		ModDNAT.logger.error("IllegalArgumentException occurred when attempting to get the BufferedImage from a DNATThreadDownloadImageData",e);
		return null;
	} catch (IllegalAccessException e) {
		ModDNAT.logger.error("IllegalAccessException occurred when attempting to get the BufferedImage from a DNATThreadDownloadImageData",e);
		return null;
	}
}
    public static DNATThreadDownloadImageData getDownloadImageSkin(ResourceLocation resourceLocationIn, String username)
    {
        TextureManager texturemanager = Minecraft.getMinecraft().getTextureManager();
        ITextureObject itextureobject = texturemanager.getTexture(resourceLocationIn);

        if (itextureobject == null || !(itextureobject instanceof DNATThreadDownloadImageData))
        {
            itextureobject = new DNATThreadDownloadImageData((File)null, String.format("http://skins.minecraft.net/MinecraftSkins/%s.png", new Object[] {StringUtils.stripControlCodes(username)}), DefaultPlayerSkin.getDefaultSkin(AbstractClientPlayer.getOfflineUUID(username)), new ImageBufferDownload());
            texturemanager.loadTexture(resourceLocationIn, itextureobject);
        }

        return (DNATThreadDownloadImageData)itextureobject;
    }
}

The bufferedImage field inside the the ThreadDownloadImageData part of the DNATThreadDownloadImageData is being initialized properly, so the error lies within DNATThreadDownloadImageData.getBufferedImage(). My guess is that the ".get(this)" part has to be changed, but I don't know what to change it to; I didn't even know that it was possible to access a private instance variable.

Once again, thanks for the help so far, and let me know if you need any more info.

Link to comment
Share on other sites

Here's what I've found: after a ThreadDownloadImageData is created in SkinManager.loadSkin, TextureManager.loadTexture is called, which then calls ThreadDownloadImageData.loadTexture. This then calls its submethod SimpleTexture.loadTexture, which calls resourceManager.getResource to get an IResource which is then read into a BufferedImage, which is then finally used in TextureUtil.uploadTextureImageAllocate to bind the texture or something.

After that, the ThreadDownloadImageData then reads its cache File as a BufferedImage and uses that to set its IImageBuffer.

If for some reason the cache file is unavailable, then the ThreadDownloadImageData just creates a thread to download the image.

After all this, the TextureManager then puts the TDID in its own Map, tied to the ResourceLocation provided, and TextureManager also has a method to easily get the TDID from the ResourceLocation.

 

I am completely able to access that TDID using Minecraft.getMinecraft().getTextureManager().getTexture(entity.getLocationSkin()). The issue is, I need to get the BufferedImage buried within in order to get an int[] of the texture's pixels, but the BufferedImage is private. The only thing that I can get from the TDID is its gl texture id.

 

This is why I'm trying to see if I can somehow get the player's skin into my own variation of ThreadDownloadImageData, but with the BufferedImage public or accessable via methods. If it is possible to use TextureUtils or something in order to get the BufferedImage from the gl texture id, or even rip the BufferedImage out of the TDID directly, then that is what I would like to know; if there is no simple way, then I might look into TGG's other method of rendering the skin into a framebuffer.

 

In short, all I need to know is how to get the BufferedImage from a fully initialized ThreadDownloadImageData; if I can do that, then my problem is solved.

Link to comment
Share on other sites

Here's what I've found: after a ThreadDownloadImageData is created in SkinManager.loadSkin, TextureManager.loadTexture is called, which then calls ThreadDownloadImageData.loadTexture. This then calls its submethod SimpleTexture.loadTexture, which calls resourceManager.getResource to get an IResource which is then read into a BufferedImage, which is then finally used in TextureUtil.uploadTextureImageAllocate to bind the texture or something.

After that, the ThreadDownloadImageData then reads its cache File as a BufferedImage and uses that to set its IImageBuffer.

If for some reason the cache file is unavailable, then the ThreadDownloadImageData just creates a thread to download the image.

After all this, the TextureManager then puts the TDID in its own Map, tied to the ResourceLocation provided, and TextureManager also has a method to easily get the TDID from the ResourceLocation.

 

I am completely able to access that TDID using Minecraft.getMinecraft().getTextureManager().getTexture(entity.getLocationSkin()). The issue is, I need to get the BufferedImage buried within in order to get an int[] of the texture's pixels, but the BufferedImage is private. The only thing that I can get from the TDID is its gl texture id.

 

This is why I'm trying to see if I can somehow get the player's skin into my own variation of ThreadDownloadImageData, but with the BufferedImage public or accessable via methods. If it is possible to use TextureUtils or something in order to get the BufferedImage from the gl texture id, or even rip the BufferedImage out of the TDID directly, then that is what I would like to know; if there is no simple way, then I might look into TGG's other method of rendering the skin into a framebuffer.

 

In short, all I need to know is how to get the BufferedImage from a fully initialized ThreadDownloadImageData; if I can do that, then my problem is solved.

You can use Reflection to access this private field.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

Thanks, I just figured out how to use ReflectionHelper.getPrivateValue to get what I needed:

ThreadDownloadImageData dat=(ThreadDownloadImageData) Minecraft.getMinecraft().getTextureManager().getTexture(entity.getLocationSkin());
BufferedImage bufferedimage = ReflectionHelper.getPrivateValue(ThreadDownloadImageData.class, dat, "bufferedImage","field_110560_d");
int[] iA=bufferedimage.getRGB(0, 0, bufferedimage.getWidth(), bufferedimage.getHeight(), null, 0, bufferedimage.getWidth());

(This code, given an EntityPlayer, simply obtains the player's skin.)

I just made the false assumption that you needed to create your own extension of the class that you want to reflect a variable from, but it turns out you just need the instance stored in an accessible variable somewhere.

Once again, thank you for helping me resolve this problem! :D

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.