Jump to content

[MC 1.10.2] World Generator is not doing any despite being called


Komodo2013

Recommended Posts

I've created a world generator, successfully registered it, and it is being called (as is evidence as the system log shows the print lines). Despite this, the generator itself is not working.

Code:

public class BettermentsWorldGenerator implements IWorldGenerator{

@Override
public void generate(Random random, int chunkX, int chunkZ, World world, IChunkGenerator chunkGenerator, IChunkProvider chunkProvider) {
	int dim = world.provider.getDimension();
	//System.out.printf("Betterments mod now loading for dimension %s", dim);
	if(dim == 0) {generateOverworld(random, chunkX, chunkZ, world, chunkGenerator, chunkProvider);}
	else if(dim == 1) {generateEnd(random, chunkX, chunkZ, world, chunkGenerator, chunkProvider);}
	else if(dim == -1) {generateNether(random, chunkX, chunkZ, world, chunkGenerator, chunkProvider);}
}

private void generateNether(Random random, int chunkX, int chunkZ, World world, IChunkGenerator chunkGenerator, IChunkProvider chunkProvider) {

}

private void generateEnd(Random random, int chunkX, int chunkZ, World world, IChunkGenerator chunkGenerator, IChunkProvider chunkProvider) {

}

private void generateOverworld(Random random, int chunkX, int chunkZ, World world, IChunkGenerator chunkGenerator, IChunkProvider chunkProvider) {
	BlockPos pos = new BlockPos(chunkX * 16, 70, chunkZ * 16);
	String s = world.getBiomeGenForCoords(pos).getBiomeName();
	System.out.println(s);

	//Vanilla minecraft addition
	generate(Blocks.IRON_ORE.getDefaultState(), world, random, chunkX, chunkZ, 1, 128, 32, 10, Blocks.STONE);

	//Biome specific spawns
	if(s.contains("Desert")) {
		generate(Blocks.EMERALD_ORE.getDefaultState(), world, random, chunkX, chunkZ, 1, 64, 16, 1, Blocks.STONE);
	}
	generate(BettermentsBlocks.marble.getDefaultState(), world, random, chunkX, chunkZ, 1, 128, 64, 3, Blocks.STONE);

}

private void generate(IBlockState block, World world, Random random, int x, int z, int minY, int maxY, int size, int tries, Block inside){
	int dy = maxY - minY;
	if (minY < 0 || maxY  > 256 || dy < 0) {
		throw new IllegalArgumentException("Illegal Height Arguments for WorldGenerator");
	}
	for (int i = 0; i<tries; i++){
		x = x + random.nextInt(16);
		z = z + random.nextInt(16);
		int y = minY + random.nextInt(dy);


		if(y==0){y=1;}
		BlockPos pos = new BlockPos(x, y, z);

		WorldGenMinable generator = new WorldGenMinable(block, size, BlockMatcher.forBlock(inside));
		generator.generate(world, random, pos);
		//System.out.println("Betterments World Generator called.");
	}
}

}

 

I am human and thus will make stupid and obvious mistakes and cannot be expected to know everything.

Link to comment
Share on other sites

*Face palm*

Implemented that change:

public class BettermentsWorldGenerator implements IWorldGenerator{

@Override
public void generate(Random random, int chunkX, int chunkZ, World world, IChunkGenerator chunkGenerator, IChunkProvider chunkProvider) {
	int dim = world.provider.getDimension();
	//System.out.printf("Betterments mod now loading for dimension %s", dim);
	if(dim == 0) {generateOverworld(random, chunkX, chunkZ, world, chunkGenerator, chunkProvider);}
	else if(dim == 1) {generateEnd(random, chunkX, chunkZ, world, chunkGenerator, chunkProvider);}
	else if(dim == -1) {generateNether(random, chunkX, chunkZ, world, chunkGenerator, chunkProvider);}
}

private void generateNether(Random random, int chunkX, int chunkZ, World world, IChunkGenerator chunkGenerator, IChunkProvider chunkProvider) {

}

private void generateEnd(Random random, int chunkX, int chunkZ, World world, IChunkGenerator chunkGenerator, IChunkProvider chunkProvider) {

}

private void generateOverworld(Random random, int chunkX, int chunkZ, World world, IChunkGenerator chunkGenerator, IChunkProvider chunkProvider) {
	BlockPos pos = new BlockPos(chunkX * 16, 70, chunkZ * 16);
	String s = world.getBiomeGenForCoords(pos).getBiomeName();
	System.out.println(s);

	//Vanilla minecraft addition
	generate(Blocks.IRON_ORE.getDefaultState(), world, random, chunkX, chunkZ, 1, 128, 32, 10, Blocks.STONE);

	//Biome specific spawns
	if(s.contains("Desert")) {
		generate(Blocks.EMERALD_ORE.getDefaultState(), world, random, chunkX, chunkZ, 1, 64, 16, 1, Blocks.STONE);
	}
	generate(BettermentsBlocks.marble.getDefaultState(), world, random, chunkX, chunkZ, 1, 128, 64, 3, Blocks.STONE);
}

private void generate(IBlockState block, World world, Random random, int x, int z, int minY, int maxY, int size, int tries, Block inside){
	int cx = x >> 4;
	int cz = z >> 4;

	int dy = maxY - minY;
	if (minY < 0 || maxY  > 256 || dy < 0) {
		throw new IllegalArgumentException("Illegal Height Arguments for WorldGenerator");
	}
	for (int i = 0; i<tries; i++){
		x = x + random.nextInt(16);
		z = z + random.nextInt(16);
		int y = minY + random.nextInt(dy);


		if(y==0){y=1;}
		BlockPos pos = new BlockPos(cx, y, cz);

		WorldGenMinable generator = new WorldGenMinable(block, size, BlockMatcher.forBlock(inside));
		generator.generate(world, random, pos);
		//System.out.println("Betterments World Generator called.");
	}
}

}

 

But it still doesn't do anything.

I am human and thus will make stupid and obvious mistakes and cannot be expected to know everything.

Link to comment
Share on other sites

Modified again, but still isn't working. If I shift the bits the other way, then it crashes.

public class BettermentsWorldGenerator implements IWorldGenerator{

@Override
public void generate(Random random, int chunkX, int chunkZ, World world, IChunkGenerator chunkGenerator, IChunkProvider chunkProvider) {
	int dim = world.provider.getDimension();
	//System.out.printf("Betterments mod now loading for dimension %s", dim);
	if(dim == 0) {generateOverworld(random, chunkX, chunkZ, world, chunkGenerator, chunkProvider);}
	else if(dim == 1) {generateEnd(random, chunkX, chunkZ, world, chunkGenerator, chunkProvider);}
	else if(dim == -1) {generateNether(random, chunkX, chunkZ, world, chunkGenerator, chunkProvider);}
}

private void generateNether(Random random, int chunkX, int chunkZ, World world, IChunkGenerator chunkGenerator, IChunkProvider chunkProvider) {

}

private void generateEnd(Random random, int chunkX, int chunkZ, World world, IChunkGenerator chunkGenerator, IChunkProvider chunkProvider) {

}

private void generateOverworld(Random random, int chunkX, int chunkZ, World world, IChunkGenerator chunkGenerator, IChunkProvider chunkProvider) {
	int cx = chunkX >> 4;
	int cz = chunkZ >> 4;

	BlockPos pos = new BlockPos(cx, 70, cz);
	String s = world.getBiomeGenForCoords(pos).getBiomeName();
	System.out.println(s);

	//Vanilla minecraft addition
	generate(Blocks.IRON_ORE.getDefaultState(), world, random, cx, cz, 1, 128, 32, 10, Blocks.STONE);

	//Biome specific spawns
	if(s.contains("Desert")) {
		generate(Blocks.EMERALD_ORE.getDefaultState(), world, random, cx, cz, 1, 64, 16, 1, Blocks.STONE);
	}
	generate(BettermentsBlocks.marble.getDefaultState(), world, random, cx, cz, 1, 128, 64, 3, Blocks.STONE);
}

private void generate(IBlockState block, World world, Random random, int cx, int cz, int minY, int maxY, int size, int tries, Block inside){

	int dy = maxY - minY;
	if (minY < 0 || maxY  > 256 || dy < 0) {
		throw new IllegalArgumentException("Illegal Height Arguments for WorldGenerator");
	}
	for (int i = 0; i<tries; i++){
		cx = cx + random.nextInt(16);
		cz = cz + random.nextInt(16);
		int y = minY + random.nextInt(dy);


		if(y==0){y=1;}
		BlockPos pos = new BlockPos(cx, y, cz);

		WorldGenMinable generator = new WorldGenMinable(block, size, BlockMatcher.forBlock(inside));
		generator.generate(world, random, pos);
		//System.out.println("Betterments World Generator called.");
	}
}

}

I am human and thus will make stupid and obvious mistakes and cannot be expected to know everything.

Link to comment
Share on other sites

Posting the crash helps.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

First, it looks as if you have some very deep recursion (the stack is repetitive). Look at those calls and see if you're calling in a circle by accident.

 

Second, a NoClassDefFoundError often means that the server is attempting to use a client-side only class. It can aslo mean that you attempted to use reflection, but you forgot to load a class before invoking it.

 

Set a break point upstream of the error and run again to look at what's trying to do what with what values.

The debugger is a powerful and necessary tool in any IDE, so learn how to use it. You'll be able to tell us more and get better help here if you investigate your runtime problems in the debugger before posting.

Link to comment
Share on other sites

Alright, I got my code to work perfectly. I didn't realize that I had two "generate" functions  :P, so I fixed that, but it still didn't fix the error. For some reason, the game did not like using the block coordinates using the bit shift, but it is working just fine by simply multiplying them by 16. Anyway, here is my working code, which also has the working biome specific generation:

public class BettermentsWorldGenerator implements IWorldGenerator{

@Override
public void generate(Random random, int chunkX, int chunkZ, World world, IChunkGenerator chunkGenerator, IChunkProvider chunkProvider) {
	int dim = world.provider.getDimension();
	//System.out.printf("Betterments mod now loading for dimension %s", dim);
	if(dim == 0) {generateOverworld(random, chunkX, chunkZ, world, chunkGenerator, chunkProvider);}
	else if(dim == 1) {generateEnd(random, chunkX, chunkZ, world, chunkGenerator, chunkProvider);}
	else if(dim == -1) {generateNether(random, chunkX, chunkZ, world, chunkGenerator, chunkProvider);}
}

private void generateNether(Random random, int chunkX, int chunkZ, World world, IChunkGenerator chunkGenerator, IChunkProvider chunkProvider) {

}

private void generateEnd(Random random, int chunkX, int chunkZ, World world, IChunkGenerator chunkGenerator, IChunkProvider chunkProvider) {

}

private void generateOverworld(Random random, int chunkX, int chunkZ, World world, IChunkGenerator chunkGenerator, IChunkProvider chunkProvider) {

	int cx = chunkX << 4;
	int cz = chunkZ << 4;
	BlockPos pos = new BlockPos(cx, 70, cz);
	String s = world.getBiomeGenForCoords(pos).getBiomeName();
	System.out.println(s);

	//Vanilla minecraft addition
	generateSeam(Blocks.IRON_ORE.getDefaultState(), world, random, chunkX*16, chunkZ*16, 1, 128, 32, 10, Blocks.STONE);

	//Biome specific spawns
	if(s.contains("Desert")) {
		generateSeam(Blocks.EMERALD_ORE.getDefaultState(), world, random, cx, cz, 1, 64, 16, 1, Blocks.STONE);
	}
	generateSeam(BettermentsBlocks.marble.getDefaultState(), world, random, cx, cz, 1, 128, 64, 3, Blocks.STONE);
}

private void generateSeam(IBlockState block, World world, Random random, int cx, int cz, int minY, int maxY, int size, int tries, Block inside){

	int dy = maxY - minY;
	if (minY < 0 || maxY  > 256 || dy < 0) {
		throw new IllegalArgumentException("Illegal Height Arguments for WorldGenerator");
	}

	for (int i = 0; i<tries; i++){
		int rx = cx + random.nextInt(15);
		int rz = cz + random.nextInt(15);
		int y = minY + random.nextInt(dy);
		//System.out.println(tries - i);

		if(y==0){y=1;}
		BlockPos pos = new BlockPos(rx, y, rz);

		WorldGenMinable generator = new WorldGenMinable(block, size, BlockMatcher.forBlock(inside));
		generator.generate(world, random, pos);
		//System.out.println("Betterments World Generator called.");
	}
}

}

*Edit: Apparently I need to work on noticing my variables, but I now see that I latter use the bit shifted coordinates, and it was still working fine. I don't understand what fixed the crashes that were still occurring after I fixed my duplicate functions.

I am human and thus will make stupid and obvious mistakes and cannot be expected to know everything.

Link to comment
Share on other sites

x >> 4 is division.

x << 4 is multiplication.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

x >> 4 is division.

x << 4 is multiplication.

Yes, I realized I had made that mistake before. But you can see from my code that I've fixed it, and I still had it crash, I'm having difficulty trying to get it to crash again, so I can post the error report, but this is a good problem.

Perhaps it simply decided to stop giving me grief? :)

I am human and thus will make stupid and obvious mistakes and cannot be expected to know everything.

Link to comment
Share on other sites

By the way, why are you using "chunkx*16" in one place, but "cx" in the others?

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

By the way, why are you using "chunkx*16" in one place, but "cx" in the others?

Since I changed the infinite loop, and still had it crash, I thought that cx, which obtains its value from the bit shift, was the problem. (The best tutorial I could find used chunkx*16 method of finding the cords, and his worked). What you didn't see was the version were I changed all cx to chunkx*16 or commented them out. Once it started to work, I uncommented the references to cx,  and simply haven't changed chunkx*16 to cx as this generator is a dummy generator, and thus I will be altering a different generator class.

(I removed the actual generator out of the package so its presence didn't affect anything)

I am human and thus will make stupid and obvious mistakes and cannot be expected to know everything.

Link to comment
Share on other sites

Don't worry about writing the shifts in your source code. Any optimizer worth the name will replace your "*16" subexpressions with shifts at the assembly level anyway. That liberates you to write what you mean yet enjoy the speed of fast machine execution  :)

The debugger is a powerful and necessary tool in any IDE, so learn how to use it. You'll be able to tell us more and get better help here if you investigate your runtime problems in the debugger before posting.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.