[1.10.2] Code Optimization

[LogicTechCorp]

I would like to know if I there is any code I could optimize or change to make my mod more efficient. All help is appreciated!

 

Concerned Areas:

https://github.com/LogicTechCorp/NetherEx/blob/1.10.2/src/main/java/nex/handler/IMCHandler.java

https://github.com/LogicTechCorp/NetherEx/tree/1.10.2/src/main/java/nex/world

[Rexozz]

Show some lines or methods you think they could be improved!

I think, nobody would search through your entire code to correct or improve something!

 

No offense! 

[larsgerrits]

You have to ask yourself: is it necessary to optimize it right now? Is your mod causing lag right now? Is it causing a lot of unnecessary networking? If not, you most likely don't need any optimization.

[LogicTechCorp]

  On 10/12/2016 at 11:46 PM, Rexozz said:

Show some lines or methods you think they could be improved!

I think, nobody would search through your entire code to correct or improve something!

 

No offense! 

 

None taken and edited original post with what i'm most concerned with.

 

  Quote

You have to ask yourself: is it necessary to optimize it right now? Is your mod causing lag right now? Is it causing a lot of unnecessary networking? If not, you most likely don't need any optimization.

 

All right and thank you for that.

[Draco18s]

[wrong thread] 9.9

[larsgerrits]

  On 10/13/2016 at 12:29 AM, Draco18s said:

You could also override getFlammability, isFlammable, or getFireSpreadSpeed (each called when the fire attempts to spread to that block, at some point) and spawn your lit entity or explosion.

Uhmm, wrong thread? Don't you mean this one: http://www.minecraftforge.net/forum/index.php?topic=42618.0?

[Draco18s]

  On 10/13/2016 at 12:35 AM, larsgerrits said:

  Quote

You could also override getFlammability, isFlammable, or getFireSpreadSpeed (each called when the fire attempts to spread to that block, at some point) and spawn your lit entity or explosion.

Uhmm, wrong thread? Don't you mean this one: http://www.minecraftforge.net/forum/index.php?topic=42618.0?

 

...how'd I manage that? >.<

[jeffryfisher]

For starters, point us to where you use reflection and where you handle ticking, especially when both are combined.

[Rexozz]

Either I'm really stupid or the "SubscribeEvent" annotation is really not needed here!

 

public static void handleMessages(FMLInterModComms.IMCEvent event)

[jabelar]

While it is certainly good to develop habits of using efficient approaches, generally with a modern computer efficiency isn't a big concern and rather it is more important to code in a structured way that is readable and simple.

 

Then if performance does become a concern, it is usually something you can tackle using the Pareto principle -- meaning that usually just a couple things are causing significant impact. You can identify those areas and just tackle them when they are a problem

 

With that being said, if you're doing crazy things like big loops iterating through complicated data structures, or if you're doing things like creating memory leaks that stress out the memory manager or networking, it is best to avoid those in the first place.

 

But generally: 1) Don't do obviously taxing things (2) tackle optimization only when needed.