Trying to create an event where a player holds a custom item

[RBHB16]

Hey guys,

I am trying to make an event as a test to see if I am properly firing events. I am new to forge so it is throwing me off a little.

 

I am not sure if I am just using the wrong event (playerinteractevent) and I should use a different one, or I just didn't do something in initializing my event or whatever it would be. If someone could help, that'd be great.

 

CommonProxy class(I link it with my main, so the info is in proxies but is called by the main):

package me.redstery11.dm.proxy;

import me.redstery11.dm.Events;
import me.redstery11.dm.Recipies;
import me.redstery11.dm._Items;
import me.redstery11.dm.theItems.Phone;
import net.minecraftforge.common.MinecraftForge;
import net.minecraftforge.fml.common.FMLCommonHandler;
import net.minecraftforge.fml.common.Mod.EventHandler;
import net.minecraftforge.fml.common.event.FMLInitializationEvent;
import net.minecraftforge.fml.common.event.FMLPostInitializationEvent;
import net.minecraftforge.fml.common.event.FMLPreInitializationEvent;

public class CommonProxy {
Events handler = new Events();


@EventHandler
public void preInit(FMLPreInitializationEvent e)
{
	MinecraftForge.EVENT_BUS.register(handler);
	_Items.preinit();

}
@EventHandler
public void Init(FMLInitializationEvent e)
{
	Recipies.init();
	MinecraftForge.EVENT_BUS.register(new Phone());

}

@EventHandler
public void postInit(FMLPostInitializationEvent e){

}

}

 

The events class:

The first problem I came up with was that an Itemstack cannot be compared to an item, so I went around it, but I am not sure if that worked.

package me.redstery11.dm;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemStack;
import net.minecraftforge.event.entity.player.PlayerInteractEvent;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;

public class Events {

@SubscribeEvent
public void onRightClick(PlayerInteractEvent e)
{
	EntityPlayer p = e.getEntityPlayer();
	if(p.inventory.getCurrentItem() != null)
	{
		if(p.inventory.getCurrentItem() == new ItemStack(_Items.cell_phone))
		{
			p.setFire(5);
		}
	}
}

}

[Matryoshika]

if(p.inventory.getCurrentItem() == new ItemStack(_Items.cell_phone))

Sorry, but that will never be true, because ItemStacks are not singletons like items or blocks.

You can draw parallels with this: If [this pebble from here] is [this pebble from over there]... They can never be the same, be cause they -aren't- the same.

To get the item from an itemstack, use

ItemStack#getItem

. Never create a new instance to compare.

[RBHB16]

Thanks for the response. I changed up the code a little, but now the problem is it is saying I cannot make a static reference to a non-static method, so what I did was make an instance of my items class so I can call cell phone into the if statement. I still am getting the error, so does that mean I need to fix up my items class to make cell_phone non static?

 

package me.redstery11.dm;

import net.minecraft.entity.item.EntityItem;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemStack;
import net.minecraftforge.event.entity.player.PlayerInteractEvent;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;

public class Events {

public _Items c = new _Items();


@SubscribeEvent
public void onRightClick(PlayerInteractEvent e)
{
	EntityPlayer p = e.getEntityPlayer();
	if(p.inventory.getCurrentItem() != null)
	{
		if(EntityItem.getEntityItem().getItem().equals(c.cell_phone))
		{
			p.setFire(5);
		}
	}
}

}

[Draco18s]

  On 11/13/2016 at 11:08 PM, RBHB16 said:

MinecraftForge.EVENT_BUS.register(new Phone());

 

What the..?

[RBHB16]

Don't worry about that, it was from when I first started working on the event. I used to have a class called phones but got rid of it and made an events class instead and never removed it.

 

[Animefan8888]

  On 11/14/2016 at 2:31 AM, RBHB16 said:

Don't worry about that, it was from when I first started working on the event. I used to have a class called phones but got rid of it and made an events class instead and never removed it.

First thing is first do you know Java? If you do explain what a static reference is...

EntityItem.getEntityItem()

[RBHB16]

I do know what a static reference is. Basically having something as static lets you use it all over without instantiating it.

 

Update:

I was able to create an if statement, but I get an error when holding the "cell phone"

 

The code:

 

  Reveal hidden contents

 

package me.redstery11.dm;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemStack;
import net.minecraftforge.event.entity.player.PlayerInteractEvent;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;

public class Events {

@SubscribeEvent
public void onRightClick(PlayerInteractEvent e)
{
	EntityPlayer p = e.getEntityPlayer();
	ItemStack hand = p.getActiveItemStack();
	if(hand.getItem() != null)
	{
		if(hand.getItem() == _Items.cell_phone)
		{
			p.setFire(5);
		}
	}
}

}

 

 

 

The error:

 

  Reveal hidden contents

Thread: Client thread
Stacktrace:
at me.redstery11.dm.Events.onRightClick(Events.java:15)
at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_6_Events_onRightClick_PlayerInteractEvent.invoke(.dynamic)
at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:68)
at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:159)
at net.minecraftforge.common.ForgeHooks.onRightClickBlock(ForgeHooks.java:992)
at net.minecraft.client.multiplayer.PlayerControllerMP.processRightClickBlock(PlayerControllerMP.java:418)
at net.minecraft.client.Minecraft.rightClickMouse(Minecraft.java:1603)
at net.minecraft.client.Minecraft.processKeyBinds(Minecraft.java:2281)
at net.minecraft.client.Minecraft.runTickKeyboard(Minecraft.java:2058)

-- Affected level --
Details:
Level name: MpServer
All players: 1 total; [EntityPlayerSP['Player359'/229, l='MpServer', x=-240.98, y=76.00, z=212.47]]
Chunk stats: MultiplayerChunkCache: 49, 49
Level seed: 0
Level generator: ID 00 - default, ver 1. Features enabled: false
Level generator options: 
Level spawn location: World: (-244,64,148), Chunk: (at 12,4,4 in -16,9; contains blocks -256,0,144 to -241,255,159), Region: (-1,0; contains chunks -32,0 to -1,31, blocks -512,0,0 to -1,255,511)
Level time: 92545 game time, 92545 day time
Level dimension: 0
Level storage version: 0x00000 - Unknown?
Level weather: Rain time: 0 (now: false), thunder time: 0 (now: false)
Level game mode: Game mode: creative (ID 1). Hardcore: false. Cheats: false
Forced entities: 4 total; [EntitySkeleton['Skeleton'/139, l='MpServer', x=-239.49, y=68.69, z=203.53], EntitySpider['Spider'/138, l='MpServer', x=-240.50, y=14.00, z=197.50], EntityBat['Bat'/369, l='MpServer', x=-231.90, y=26.96, z=206.84], EntityPlayerSP['Player359'/229, l='MpServer', x=-240.98, y=76.00, z=212.47]]
Retry entities: 0 total; []
Server brand: fml,forge
Server type: Integrated singleplayer server
Stacktrace:
at net.minecraft.client.multiplayer.WorldClient.addWorldInfoToCrashReport(WorldClient.java:450)
at net.minecraft.client.Minecraft.addGraphicsAndWorldToCrashReport(Minecraft.java:2779)
at net.minecraft.client.Minecraft.run(Minecraft.java:435)
at net.minecraft.client.main.Main.main(Main.java:118)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)
at net.minecraft.launchwrapper.Launch.main(Launch.java:28)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at net.minecraftforge.gradle.GradleStartCommon.launch(GradleStartCommon.java:97)
at GradleStart.main(GradleStart.java:26)

 

 

 

[hugo_the_dwarf]

ItemStack hand = p.getActiveItemStack();
	if(hand.getItem() != null)
	{

The error is a null exception right?

 

See you get an ItemStack "hand" which is player.getActiveItemStack()

 

the error you made is you reach into the object to check to see if it's null. Which is a no no you should have:

 

ItemStack hand = p.getActiveItemStack();

if(hand) != null)

{

 

When checking for "nulls" you check the direct object you got, reaching in to check is a big no.

 

So your full method should look like:

 

@SubscribeEvent
public void onRightClick(PlayerInteractEvent e)
{
	EntityPlayer p = e.getEntityPlayer();
	ItemStack hand = p.getActiveItemStack();
	if(hand != null) //Check to make sure the ItemStack gotten is not null.
	{
		if(hand.getItem() == _Items.cell_phone) // this is correct, well as long as you registered the item #cell_phone correctly 
		{
			p.setFire(5); //Honestly I prefer Console.out().Println("Am I holding a Phone?!?"); rather than directly causing things to happen
		}
	}
}

 

[RBHB16]

  On 11/14/2016 at 3:25 AM, hugo_the_dwarf said:

ItemStack hand = p.getActiveItemStack();
	if(hand.getItem() != null)
	{

The error is a null exception right?

 

See you get an ItemStack "hand" which is player.getActiveItemStack()

 

the error you made is you reach into the object to check to see if it's null. Which is a no no you should have:

 

ItemStack hand = p.getActiveItemStack();

if(hand) != null)

{

 

When checking for "nulls" you check the direct object you got, reaching in to check is a big no.

 

So your full method should look like:

 

@SubscribeEvent
public void onRightClick(PlayerInteractEvent e)
{
	EntityPlayer p = e.getEntityPlayer();
	ItemStack hand = p.getActiveItemStack();
	if(hand != null) //Check to make sure the ItemStack gotten is not null.
	{
		if(hand.getItem() == _Items.cell_phone) // this is correct, well as long as you registered the item #cell_phone correctly 
		{
			p.setFire(5); //Honestly I prefer Console.out().Println("Am I holding a Phone?!?"); rather than directly causing things to happen
		}
	}
}

 

 

Hmmm. Well I tried that and ran a debug. It seems that when I hold the cell phone, the event is registered, but once it gets to that if(hand != null), the result is always null and doesn't move on to the other if statements even if I am holding the cell phone. Not sure what is causing this to happen.. could it be because its a custom item?

[hugo_the_dwarf]

you can try

ItemStack hand = p.inventory.getCurrentItem();

[RBHB16]

That works, thank you very much!

[Choonster]

Don't subscribe to

PlayerInteractEvent

directly, use the appropriate sub-event (

PlayerInteractEvent.RightClickItem

in this case).

 

EntityLivingBase#getActiveItemStack

only returns a non-

null

value if the entity is actively using an item like a bow or shield. Use

PlayerInteractEvent#getItemStack

to get the

ItemStack

that the event was fired for. Use

EntityLivingBase#getHeldItemMainhand

,

EntityLivingBase#getHeldItemOffhand

or

EntityLivingBase#getHeldItem

to get an entity's held item when it hasn't been provided for you.

 

Events should generally only be used for external objects (i.e. items, blocks, etc. created by vanilla or other mods); you should prefer to override the appropriate callback method when possible (

Item#onItemRightClick

).

 

 

  On 11/14/2016 at 3:51 AM, hugo_the_dwarf said:

you can try

ItemStack hand = p.inventory.getCurrentItem();

 

That will only ever return the item in the player's main hand, but the event may have been fired for the off hand.

[Draco18s]

  On 11/14/2016 at 2:47 AM, RBHB16 said:

I do know what a static reference is. Basically having something as static lets you use it all over without instantiating it.

 

While true, it completely misses the point.

A static reference can only be used with non-instances.  An instance reference cannot use static references.

You can pass instances to a static method, but a static method does not magically contain the information from an instance just because they're the same class.

[RBHB16]

I've moved onto adding more code and I am stuck again...

 

I am thinking about making a GUI for the cell phone when the player holds the item and right clicks. I think everything works up until I try to check to see if the player right clicked. I am going to add another event to check if the player right clicked the item while looking at a block, since I am limited to either checking to see if the player right clicked in the air or right clicked looking at a block. This is what I have so far:

 

Also, any help is appreciated

 

  Reveal hidden contents

 

package me.redstery11.dm;

import java.awt.Event;

import org.lwjgl.input.Keyboard;
import org.lwjgl.input.Mouse;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemStack;
import net.minecraft.util.EnumHand;
import net.minecraftforge.event.entity.player.PlayerEvent;
import net.minecraftforge.event.entity.player.PlayerInteractEvent;
import net.minecraftforge.event.entity.player.PlayerInteractEvent.RightClickEmpty;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;
import scala.Console;

public class Events {

public enum Action
{
	RIGHT_CLICK_AIR,
	RIGHT_CLICK_BLOCK;
}

@SubscribeEvent
public void onRightClickPhone(PlayerInteractEvent.RightClickItem e)
{
	EntityPlayer p = e.getEntityPlayer();
	ItemStack hand = p.inventory.getCurrentItem();
	if(hand != null)
	{
		if(hand.getItem() == _Items.cell_phone)
		{
			if (e.getHand().equals(Action.RIGHT_CLICK_AIR))
			{
				Console.out().println("It works!");
			}		

		}
	}
}

}

 

 

[Choonster]

  On 11/15/2016 at 1:58 AM, RBHB16 said:

import java.awt.Event;

You should very rarely need to import or use any AWT classes with the possible exception of

Color

, which can be used to get the RGB integer of a colour.

 

  Quote

import org.lwjgl.input.Keyboard;

import org.lwjgl.input.Mouse;

You can't use LWJGL or read player input in common code, these can only be done on the client.

 

  Quote

import scala.Console;

Why are you using Scala's

Console

class?

 

  Quote

public enum Action

{

RIGHT_CLICK_AIR,

RIGHT_CLICK_BLOCK;

}

You shouldn't need this enum.

 

  Quote

if (e.getHand().equals(Action.RIGHT_CLICK_AIR))

PlayerInteractEvent#getHand

returns an

EnumHand

. Checking if an

EnumHand

is equal to an

Action

makes no sense and will never be

true

.

 

PlayerInteractEvent.RightClickBlock

is fired when a player right clicks a block.

PlayerInteractEvent.RightClickItem

is fired when a player right clicks air while holding an item.