Hello i know how to make tooltip show under a item but what if i want to add it to existing item without modifiyng the class?

Use the

ItemTooltipEvent

.

Use the

ItemTooltipEvent

.

i have code like that

	@SubscribeEvent
public static void onItemTooltip(ItemTooltipEvent e) {

	List<String> toolTip = e.getToolTip();

	if (e.getItemStack().getItem() instanceof ItemBlock) {

		toolTip.add("Weigth: "+CustomValues.BLOCKWEIGHT.get(Block.getBlockFromItem(e.getItemStack().getItem())));

	} else if (e.getItemStack().getItem() instanceof Item) {

		toolTip.add("Weigth: "+CustomValues.BLOCKWEIGHT.get(e.getItemStack().getItem()));

	}



}

and it does not work and console does not say anything about this

By the way, you've misspelled "weight"

By the way, you've misspelled "weight"

Try just accessing the "e.getToolTip().add(String);" directly instead of holding a new instance.

 

if (e.getItemStack().getItem() instanceof ItemBlock) {

		e.getToolTip().add("Weigth: "+CustomValues.BLOCKWEIGHT.get(Block.getBlockFromItem(e.getItemStack().getItem())));

	} else if (e.getItemStack().getItem() instanceof Item) {

		e.getToolTip().add("Weigth: "+CustomValues.BLOCKWEIGHT.get(e.getItemStack().getItem()));

	}

 

EDIT:

 

If still nothing, then it's potentially the data wasn't found "client-side"

no succes

this may be basic, but you registered the event right?

this may be basic, but you registered the event right?

i am using MinecraftForge.EVENT_BUS.register(new EventHooks()); in pre init

	@EventHandler
public static void preInit(FMLPreInitializationEvent e) {
	Logger.setLogger(LogManager.getLogger(Reference.MODID.toUpperCase()));
	Logger.info("Pre Init!");

	MinecraftForge.EVENT_BUS.register(new EventHooks());

	Reference.CONFIG = new Configuration(e.getSuggestedConfigurationFile());

	ModItems.main();
	//Logger.info("Loaded and registered succesfully: " + ModItems.ITEMS.size() + " Items");

	CustomValues.initValues(Reference.CONFIG);


	proxy.preInit(e);
}

What's the CustomValues class/object?

What's the CustomValues class/object?

package lukas2005.idea;

import java.util.HashMap;

import net.minecraft.block.Block;
import net.minecraft.item.Item;
import net.minecraftforge.common.config.Configuration;
import net.minecraftforge.common.config.Property;

public class CustomValues {

public static HashMap<Item,Float> ITEMWEIGHT = new HashMap<Item,Float>();
public static HashMap<Block,Float> BLOCKWEIGHT = new HashMap<Block,Float>();

public static void initValues(Configuration config) {

	config.addCustomCategoryComment("BLOCKS WEIGHT", "Here you can change how much ceratin blocks weight");

	for (Block block : Block.REGISTRY) {

		Property pr = config.get("BLOCKS WEIGHT", block.getRegistryName().toString(), "1.0");

		BLOCKWEIGHT.put(block, Float.parseFloat(pr.getString()));

		Logger.info("Weight of " + block.getRegistryName().toString()+"="+Float.parseFloat(pr.getString()));

		pr.setComment("Weight of " + block.getRegistryName().toString());

	}

	config.addCustomCategoryComment("ITEMS WEIGHT", "Here you can change how much ceratin items weight");

	for (Item item : Item.REGISTRY) {

		Property pr = config.get("ITEMS WEIGHT", item.getRegistryName().toString(), "1.0");

		ITEMWEIGHT.put(item, Float.parseFloat(pr.getString()));

		Logger.info("Weight of "+item.getRegistryName().toString()+"="+Float.parseFloat(pr.getString()));

		pr.setComment("Weight of " + item.getRegistryName().toString());

	}
	config.save();
}

}

i decided to make a repo for better look at this https://github.com/lukas2005/IDEA-Mod

So I shoved a test event handler for this event into my project (because seriously, it shouldn't be that hard) and....

 

Nothing.  The Forge event bus does not see my handler so my code is never executed.

 

I can't figure out why.

 

Try just accessing the "e.getToolTip().add(String);" directly instead of holding a new instance.

 

This is irrelevant. If the getter returns a copy, then doing this makes no difference. If it doesn't, then this makes no difference.  It's not a "new instance" when you store a reference in a variable.

Your

EventHooks.onItemTooltip

method is static, but you registered an instance of

EventHooks

with the event bus.

 

For static

@SubscribeEvent

methods to work, you need to register the

Class

(

EventHooks.class

) with the event bus. For instance

@SubscribeEvent

methods to work, you need to register an instance of the class (

new EventHooks()

) with the event bus.

 

You can also annotate a class with

@Mod.EventBusSubscriber

to automatically register the

Class

with the Forge event bus at loading time.

Your

EventHooks.onItemTooltip

method is static, but you registered an instance of

EventHooks

with the event bus.

 

For static

@SubscribeEvent

methods to work, you need to register the

Class

(

EventHooks.class

) with the event bus. For instance

@SubscribeEvent

methods to work, you need to register an instance of the class (

new EventHooks()

) with the event bus.

 

You can also annotate a class with

@Mod.EventBusSubscriber

to automatically register the

Class

with the Forge event bus at loading time.

oh my fault thank you for noticing this now it works