{Solved!!! Finally!!!} [1.10.2] Gui With Chest

Draco18s · December 20, 2016

Well your ContainerTestChest needs to be updated too.

EscapeMC · December 20, 2016

EDIT: I notice whenever I place my block in game, it is fine, but when I break it!

The log spits out this:

[20:31:17] [Client thread/INFO]: [CHAT] Player281 has just earned the achievement [Taking Inventory]
[20:31:55] [server thread/FATAL]: Error executing task
java.util.concurrent.ExecutionException: java.lang.NullPointerException
at java.util.concurrent.FutureTask.report(FutureTask.java:122) ~[?:1.8.0_101]
at java.util.concurrent.FutureTask.get(FutureTask.java:192) ~[?:1.8.0_101]
at net.minecraft.util.Util.runTask(Util.java:26) [util.class:?]
at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:742) [MinecraftServer.class:?]
at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:687) [MinecraftServer.class:?]
at net.minecraft.server.integrated.IntegratedServer.tick(IntegratedServer.java:156) [integratedServer.class:?]
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:536) [MinecraftServer.class:?]
at java.lang.Thread.run(Thread.java:745) [?:1.8.0_101]
Caused by: java.lang.NullPointerException
at com.github.escapemc.thingsmod.init.test_chest.removedByPlayer(test_chest.java:63) ~[test_chest.class:?]
at net.minecraft.server.management.PlayerInteractionManager.removeBlock(PlayerInteractionManager.java:298) ~[PlayerInteractionManager.class:?]
at net.minecraft.server.management.PlayerInteractionManager.removeBlock(PlayerInteractionManager.java:292) ~[PlayerInteractionManager.class:?]
at net.minecraft.server.management.PlayerInteractionManager.tryHarvestBlock(PlayerInteractionManager.java:339) ~[PlayerInteractionManager.class:?]
at net.minecraft.server.management.PlayerInteractionManager.onBlockClicked(PlayerInteractionManager.java:175) ~[PlayerInteractionManager.class:?]
at net.minecraft.network.NetHandlerPlayServer.processPlayerDigging(NetHandlerPlayServer.java:658) ~[NetHandlerPlayServer.class:?]
at net.minecraft.network.play.client.CPacketPlayerDigging.processPacket(CPacketPlayerDigging.java:56) ~[CPacketPlayerDigging.class:?]
at net.minecraft.network.play.client.CPacketPlayerDigging.processPacket(CPacketPlayerDigging.java:12) ~[CPacketPlayerDigging.class:?]
at net.minecraft.network.PacketThreadUtil$1.run(PacketThreadUtil.java:15) ~[PacketThreadUtil$1.class:?]
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) ~[?:1.8.0_101]
at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[?:1.8.0_101]
at net.minecraft.util.Util.runTask(Util.java:25) ~[util.class:?]
... 5 more

And then also, when I try to walk through where the block was, I get stuck in a buggy walk, not able to go through it but I can go around it.

To your comment, can you link me to a container of yours that I can compare to?

Draco18s · December 20, 2016

You haven't implemented getCapability on your TE yet.

EscapeMC · December 20, 2016

	@Override
public <T> T getCapability(Capability<T> capability, EnumFacing facing) {
	return super.getCapability(capability, facing);
}

That work for it?

And what changes nor for the Container?

Draco18s · December 20, 2016

Welll.....

you don't want that, that's the whole point of overriding

EscapeMC · December 20, 2016

Welll.....

you don't want that, that's the whole point of overriding

Wait a sec,

I got it...?

	public boolean getCapability() {
	return false;


}

Draco18s · December 20, 2016

*facepalm*

No. Not even close.

https://github.com/Draco18s/ReasonableRealism/blob/master/src/main/java/com/draco18s/ores/entities/TileEntitySifter.java#L136

EscapeMC · December 20, 2016

*facepalm*

No. Not even close.

https://github.com/Draco18s/ReasonableRealism/blob/master/src/main/java/com/draco18s/ores/entities/TileEntitySifter.java#L136

*pulls out knife, trembles in fear, cuts apple into 8 even slices and enjoys delicious meal of apple slices and caramel*

Gosh I suck at this...

TEACH ME YOUR WAYS OH GREAT DRACO!!! I GIVE THINESELF TO THEE FOR EDUCATIONAL PORPOISES

Whelp, thanks for that too. What's next?

Draco18s · December 20, 2016

I'd just tell you to take a look at all my sifter stuff. Block, Entity, Container, GUI and GUI handler.

EscapeMC · December 20, 2016

I redid my Container (I think correctly)

package com.github.escapemc.thingsmod.container;

import com.github.escapemc.thingsmod.tileentity.TileEntityTestChest;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.entity.player.InventoryPlayer;
import net.minecraft.inventory.Container;
import net.minecraft.inventory.IInventory;
import net.minecraft.inventory.Slot;
import net.minecraft.item.ItemStack;

public class ContainerTestChest extends Container {

private TileEntityTestChest te;


public ContainerTestChest(InventoryPlayer inventory, TileEntityTestChest te) {
	this.te = te;

	this.addSlotToContainer(new Slot((IInventory) te, 0, 80, 16));
	bindPlayerInventory(inventory);


	//Player Inventory
	for (int y = 0; y < 3; ++y) {
		for (int x = 0; x < 9; ++x) {
			this.addSlotToContainer(new Slot(inventory, x + y * 9 + 9, 8 + x * 18, 41 + y * 18));
		}
	}
	//Player Hotbar	
	for (int x = 0; x < 9; ++x) {
		this.addSlotToContainer(new Slot(inventory, x, 8 + x * 18, 99));
	}

}

private void bindPlayerInventory(InventoryPlayer inventory) {
	// TODO Auto-generated method stub

}

@Override
public boolean canInteractWith(EntityPlayer playerIn) {
	return this.te.isUseableByPlayer(playerIn);
}

@Override
public ItemStack transferStackInSlot(EntityPlayer playerIn, int fromSlot) {
	ItemStack previous = null;
	Slot slot = (Slot) this.inventorySlots.get(fromSlot);

	if (slot != null && slot.getHasStack()) {
		ItemStack current = slot.getStack();
	        previous = current.copy();

	        if (fromSlot < 1) {
			// From TE Inventory to Player Inventory
	        	if (!this.mergeItemStack(current, 1, this.inventorySlots.size(), true)){
                    		return null;
                	}
	        } else {
	            // From Player Inventory to TE Inventory
	            if (!this.mergeItemStack(current, 0, 1, false))
	                return null;
	        }

	        if (current.stackSize == 0)
	            slot.putStack((ItemStack) null);
	        else
	            slot.onSlotChanged();
	    }
	    return previous;
}


}

Still confused though, your Container for your Sifter extended CommonContainer, but it would not let me extend that at all, so I kept Container.

When I destroy my chest block, I still cannot run through it and I get the same error in the log:

[21:12:49] [server thread/FATAL]: Error executing task
java.util.concurrent.ExecutionException: java.lang.NullPointerException
at java.util.concurrent.FutureTask.report(FutureTask.java:122) ~[?:1.8.0_101]
at java.util.concurrent.FutureTask.get(FutureTask.java:192) ~[?:1.8.0_101]
at net.minecraft.util.Util.runTask(Util.java:26) [util.class:?]
at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:742) [MinecraftServer.class:?]
at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:687) [MinecraftServer.class:?]
at net.minecraft.server.integrated.IntegratedServer.tick(IntegratedServer.java:156) [integratedServer.class:?]
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:536) [MinecraftServer.class:?]
at java.lang.Thread.run(Thread.java:745) [?:1.8.0_101]
Caused by: java.lang.NullPointerException
at com.github.escapemc.thingsmod.init.test_chest.removedByPlayer(test_chest.java:60) ~[test_chest.class:?]
at net.minecraft.server.management.PlayerInteractionManager.removeBlock(PlayerInteractionManager.java:298) ~[PlayerInteractionManager.class:?]
at net.minecraft.server.management.PlayerInteractionManager.removeBlock(PlayerInteractionManager.java:292) ~[PlayerInteractionManager.class:?]
at net.minecraft.server.management.PlayerInteractionManager.tryHarvestBlock(PlayerInteractionManager.java:339) ~[PlayerInteractionManager.class:?]
at net.minecraft.server.management.PlayerInteractionManager.onBlockClicked(PlayerInteractionManager.java:175) ~[PlayerInteractionManager.class:?]
at net.minecraft.network.NetHandlerPlayServer.processPlayerDigging(NetHandlerPlayServer.java:658) ~[NetHandlerPlayServer.class:?]
at net.minecraft.network.play.client.CPacketPlayerDigging.processPacket(CPacketPlayerDigging.java:56) ~[CPacketPlayerDigging.class:?]
at net.minecraft.network.play.client.CPacketPlayerDigging.processPacket(CPacketPlayerDigging.java:12) ~[CPacketPlayerDigging.class:?]
at net.minecraft.network.PacketThreadUtil$1.run(PacketThreadUtil.java:15) ~[PacketThreadUtil$1.class:?]
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) ~[?:1.8.0_101]
at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[?:1.8.0_101]
at net.minecraft.util.Util.runTask(Util.java:25) ~[util.class:?]
... 5 more

And right-clicking my block still does not open the GUI

EscapeMC · December 20, 2016

Comments to stuff:

I have no idea why right-clicking my block gives no response, it used to; it would crash the game.

Also, when I set up a hopper to my block, nothing goes in (does this mean I have an issue with my TileEntity?)

Draco18s · December 20, 2016

CommonContainer is my own class, you would know that by checking my imports.

https://github.com/Draco18s/ReasonableRealism/blob/master/src/main/java/com/draco18s/hardlib/api/internal/CommonContainer.java

new Slot((IInventory) te
No, you haven't gotten that right yet either. You need SlotItemHandler or a subclass thereof (which my SlotDust is).

EscapeMC · December 20, 2016

Ok, I must be going crazy or something.

I have my classes for this chest, Exactly as yours (except for name [and yes I took your SlotDust, SlotOutput, and CommonContainer just for now, unless it is ok if I keep them. Otherwise I will change them to be my own]) but right-clicking still does nothing, and destorying the block still gives me the error:

[22:27:30] [server thread/FATAL]: Error executing task
java.util.concurrent.ExecutionException: java.lang.NullPointerException
at java.util.concurrent.FutureTask.report(FutureTask.java:122) ~[?:1.8.0_101]
at java.util.concurrent.FutureTask.get(FutureTask.java:192) ~[?:1.8.0_101]
at net.minecraft.util.Util.runTask(Util.java:26) [util.class:?]
at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:742) [MinecraftServer.class:?]
at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:687) [MinecraftServer.class:?]
at net.minecraft.server.integrated.IntegratedServer.tick(IntegratedServer.java:156) [integratedServer.class:?]
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:536) [MinecraftServer.class:?]
at java.lang.Thread.run(Thread.java:745) [?:1.8.0_101]
Caused by: java.lang.NullPointerException
at com.github.escapemc.thingsmod.init.test_chest.removedByPlayer(test_chest.java:59) ~[test_chest.class:?]
at net.minecraft.server.management.PlayerInteractionManager.removeBlock(PlayerInteractionManager.java:298) ~[PlayerInteractionManager.class:?]
at net.minecraft.server.management.PlayerInteractionManager.removeBlock(PlayerInteractionManager.java:292) ~[PlayerInteractionManager.class:?]
at net.minecraft.server.management.PlayerInteractionManager.tryHarvestBlock(PlayerInteractionManager.java:339) ~[PlayerInteractionManager.class:?]
at net.minecraft.server.management.PlayerInteractionManager.onBlockClicked(PlayerInteractionManager.java:175) ~[PlayerInteractionManager.class:?]
at net.minecraft.network.NetHandlerPlayServer.processPlayerDigging(NetHandlerPlayServer.java:658) ~[NetHandlerPlayServer.class:?]
at net.minecraft.network.play.client.CPacketPlayerDigging.processPacket(CPacketPlayerDigging.java:56) ~[CPacketPlayerDigging.class:?]
at net.minecraft.network.play.client.CPacketPlayerDigging.processPacket(CPacketPlayerDigging.java:12) ~[CPacketPlayerDigging.class:?]
at net.minecraft.network.PacketThreadUtil$1.run(PacketThreadUtil.java:15) ~[PacketThreadUtil$1.class:?]
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) ~[?:1.8.0_101]
at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[?:1.8.0_101]
at net.minecraft.util.Util.runTask(Util.java:25) ~[util.class:?]
... 5 more

That line of my code mentioned is this:

			IItemHandler inventory = worldIn.getTileEntity(pos).getCapability(CapabilityItemHandler.ITEM_HANDLER_CAPABILITY, null);

Anything wrong with it? IS IT THAT IITEMHANDLER? Or am I still sane? I do not believe it is IItemHandler in that case, because it is the same as your code for you sifter.

ANY ideas on 1) Why this block when destroyed generates this error and 2) Why right-clicking my block does nothing?

Draco18s · December 20, 2016

Simplify down to a single ItemHandler. Right now you have a combined wrapper that's merging two or more handlers, one of which is

outputSlotWrapper

which is null (crashing the combiner).

EscapeMC · December 20, 2016

Simplify down to a single ItemHandler. Right now you have a combined wrapper that's merging two or more handlers, one of which is
outputSlotWrapper
which is null (crashing the combiner).

So, can/should I do

	@Override
public <T> T getCapability(Capability<T> capability, EnumFacing facing) {
	if (capability == CapabilityItemHandler.ITEM_HANDLER_CAPABILITY) {
		this.markDirty();
		if(worldObj != null && worldObj.getBlockState(pos).getBlock() != getBlockType()) {//if the block at myself isn't myself, allow full access (Block Broken)
			return (T) new CombinedInvWrapper(inputSlot);
		}
		if(facing == null) {
			return (T) new CombinedInvWrapper(inputSlot);
		}
	}
	return super.getCapability(capability, facing);
}

or do I make CombinedInvWrapper to InvWrapper? With only InvWrapper, I get an error for putting outputSlotWrapper or any other ItemStackHandler.

Draco18s · December 20, 2016

You don't need CombinedInvWrapper. Combining one ItemHandler into one ItemHandler is meaningless.

EscapeMC · December 20, 2016

You don't need CombinedInvWrapper. Combining one ItemHandler into one ItemHandler is meaningless.

Alright, so I now get the error (on both parts) saying "The constructor InvWrapper(ItemStackHandler) is undefined" and telling me to either cast it or add constructor involving IInventory, which I believe I need not to do.

Draco18s · December 20, 2016

No no, you don't need the CombinedInvWrapper at all.

Just

return (T) inputSlot;

EscapeMC · December 20, 2016

No no, you don't need the CombinedInvWrapper at all.

Just
return (T) inputSlot;

Didn't solve problem

[23:44:53] [server thread/FATAL]: Error executing task
java.util.concurrent.ExecutionException: java.lang.NullPointerException
at java.util.concurrent.FutureTask.report(FutureTask.java:122) ~[?:1.8.0_101]
at java.util.concurrent.FutureTask.get(FutureTask.java:192) ~[?:1.8.0_101]
at net.minecraft.util.Util.runTask(Util.java:26) [util.class:?]
at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:742) [MinecraftServer.class:?]
at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:687) [MinecraftServer.class:?]
at net.minecraft.server.integrated.IntegratedServer.tick(IntegratedServer.java:156) [integratedServer.class:?]
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:536) [MinecraftServer.class:?]
at java.lang.Thread.run(Thread.java:745) [?:1.8.0_101]
Caused by: java.lang.NullPointerException
at com.github.escapemc.thingsmod.init.test_chest.removedByPlayer(test_chest.java:59) ~[test_chest.class:?]
at net.minecraft.server.management.PlayerInteractionManager.removeBlock(PlayerInteractionManager.java:298) ~[PlayerInteractionManager.class:?]
at net.minecraft.server.management.PlayerInteractionManager.removeBlock(PlayerInteractionManager.java:292) ~[PlayerInteractionManager.class:?]
at net.minecraft.server.management.PlayerInteractionManager.tryHarvestBlock(PlayerInteractionManager.java:339) ~[PlayerInteractionManager.class:?]
at net.minecraft.server.management.PlayerInteractionManager.onBlockClicked(PlayerInteractionManager.java:175) ~[PlayerInteractionManager.class:?]
at net.minecraft.network.NetHandlerPlayServer.processPlayerDigging(NetHandlerPlayServer.java:658) ~[NetHandlerPlayServer.class:?]
at net.minecraft.network.play.client.CPacketPlayerDigging.processPacket(CPacketPlayerDigging.java:56) ~[CPacketPlayerDigging.class:?]
at net.minecraft.network.play.client.CPacketPlayerDigging.processPacket(CPacketPlayerDigging.java:12) ~[CPacketPlayerDigging.class:?]
at net.minecraft.network.PacketThreadUtil$1.run(PacketThreadUtil.java:15) ~[PacketThreadUtil$1.class:?]
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) ~[?:1.8.0_101]
at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[?:1.8.0_101]
at net.minecraft.util.Util.runTask(Util.java:25) ~[util.class:?]
... 5 more

Hmf...

Draco18s · December 20, 2016

Update your git

EscapeMC · December 20, 2016

Update your git

done

Draco18s · December 20, 2016

Is it still crashing the same way? Post the crashlog, put a breakpoint here and run it in the debugger. Figure out what is null and why.

Ancilary: remove anything that doesn't have an @Override on it, unless it's being called from something that does.

EscapeMC · December 20, 2016

Is it still crashing the same way? Post the crashlog, put a breakpoint here and run it in the debugger. Figure out what is null and why.

Umm... well, you see... I've never used the debugger and I do not know how to use it...

Ancilary: remove anything that doesn't have an @Override on it, unless it's being called from something that does.

In all classes? (Only in ContainterTestChest, TileEntityTestChest, GuiHandler, and gui_test_chest I mean)

Draco18s · December 20, 2016

Is it still crashing the same way? Post the crashlog, put a breakpoint here and run it in the debugger. Figure out what is null and why.

Umm... well, you see... I've never used the debugger and I do not know how to use it...

Ancilary: remove anything that doesn't have an @Override on it, unless it's being called from something that does.

In all classes? (Only in ContainterTestChest, TileEntityTestChest, GuiHandler, and gui_test_chest I mean)

I meant the TileEntityTestChest class. Basically, clean up from the IInventory stuff. You should have just deleted the methods rather than removing the @Override.

[me=Draco18s]checks something[/me]

Hmm. Doesn't appear to be an option to clean up -> remove unused methods, but I could be overlooking it.

EscapeMC · December 20, 2016

Alright, so should I look up [lmgtfy]how to use the debugger in eclipse?[/lmgtfy] and still do all that?

Sign In

{Solved!!! Finally!!!} [1.10.2] Gui With Chest

Recommended Posts

Top Posters In This Topic

Popular Days

Top Posters In This Topic

Popular Days

Join the conversation

Announcements

Recently Browsing

Posts

Topics

Who's Online (See full list)

Important Information