[1.10.2] {Solved} Preventing putting an item in itself

[EscapeMC]

Hello! 

 

So if you all remember from my last thread, you all helped me make an item where on right click, it would bring up a chest-like Gui.

 

Now, I realized I need to make the item not be able to be put in itself... Anyone know how to do that?

[Draco18s]

You have a custom slot class, yeah?

Make that slot not accept your bag item.

 

Done.

[EscapeMC]

You have a custom slot class, yeah?

Make that slot not accept your bag item.

 

Done.

 

What would I be overriding here? canTakeStack? or what else?

 

 

 

EDIT: NEVERMIND I found isItemValid. Now, how do I say "test_bag is a no-no"? if(__ = test_bag) return false?

[Animefan8888]

You have a custom slot class, yeah?

Make that slot not accept your bag item.

 

Done.

 

What would I be overriding here? canTakeStack? or what else?

 

 

 

EDIT: NEVERMIND I found isItemValid. Now, how do I say "test_bag is a no-no"? if(__ = test_bag) return false?

Quick question, how much Java do you know, how much Minecraft/Forge do you know?

[EscapeMC]

You have a custom slot class, yeah?

Make that slot not accept your bag item.

 

Done.

 

What would I be overriding here? canTakeStack? or what else?

 

 

 

EDIT: NEVERMIND I found isItemValid. Now, how do I say "test_bag is a no-no"? if(__ = test_bag) return false?

Quick question, how much Java do you know, how much Minecraft/Forge do you know?

 

I am not too experienced with Java, and I try to learn as much Minecraft/Forge as I can. Everything I have coded I understand (I go back and ask everything to understand it) and I understand some other stuff.

 

Keep in mind, I am only 14, still in 8th grade. I like coding so that's why I am here.

[Animefan8888]

Ok just asking, you know what an ItemStack is, right? And do you know what an instanceof check is?

[EscapeMC]

Ok just asking, you know what an ItemStack is, right? And do you know what an instanceof check is?

 

Yes I do. Now that you say this, let me see if I can piece together this with new ideas.

[Draco18s]

You don't even need InstanceOf here at all.

[Animefan8888]

You don't even need InstanceOf here at all.

Just in case he wants to make more Bags than just one. This way you can't put any bag inside a bag.

[EscapeMC]

You don't even need InstanceOf here at all.

 

What can/should/do I use here then? (I was just experimenting with instanceof and no good, so that's why I ask)

[Animefan8888]

You don't even need InstanceOf here at all.

 

What can/should/do I use here then? (I was just experimenting with instanceof and no good, so that's why I ask)

How did you use instanceof and you could also use stack.getItem() != bagItemField.

[EscapeMC]

I was using something like

 

		instanceof(stack.isItemEqual(ModItems.test_bag)){
	return false;
	}

 

yes, I think this isn't correct (I know test_bag isn't an itemstack, i am trying to figure out what to do there...)

 

Anyway, with that instanceof stuff I think I got it to work with "while"...

 

		while(stack.getItem() != ModItems.test_bag){
	return false;

	}

	return true;

}

 

Is while ok here?

[Jay Avery]

No,

while

is for a loop to run repeatedly. You just need an

if

. You've got the actual comparison right, though.

[Animefan8888]

To use the instanceof check do

stack.getItem() instanceof bagClassName

[Draco18s]

instanceof(stack.isItemEqual(ModItems.test_bag))

 

ok, for one, that's not even valid java. and two, even if it was, an ItemStack and an Item will never ever not in a billion years be equal.

[EscapeMC]

Ok, so I have

	@Override
public boolean isItemValid(ItemStack stack) {

	if(stack.getItem() != ModItems.test_bag){
	return false;

	}

	return true;

}

 

And this does not work. I can still put my item in there.

 

WAIT!

*Cheeks code once more, sees !=, slams head into desk* Wow I am stupid.

 

Solved