Jump to content

Recommended Posts

Posted

Hi,

 

I'm wondering if I need anything like IInventory and a container when I've got a GUI which does show the player inventory and some information. The GUI itself has no slots except for the slots from the player inventory.

 

Thx in advance.

Bektor

Developer of Primeval Forest.

Posted

You need a container for the players inventory.

Ok, thx. Now I'm only left with the problem that I've got some variables in the tile entity which are also saved to nbt data, but my GUI shows always 0.

 

some parts of the GUI:

 

[...]
private final TileEntitySolarPanel panel;

public GuiSolarPanel(InventoryPlayer playerInv, TileEntitySolarPanel panel) {
	super(new ContainerSolarPanel(playerInv, panel));
	this.playerInv = playerInv;
	this.panel = panel;
}
[...]
int stored = this.panel.container.getEnergyStored();

 

 

some parts of the TileEntity:

 

public class TileEntitySolarPanel extends TileEntity implements ITickable {

public final BaseMPContainer container;

public TileEntitySolarPanel() {
	this.container = new BaseMPContainer();
}

@Override
public void update() {
[...]
}

@Override
public void readFromNBT(NBTTagCompound compound) {
	super.readFromNBT(compound);
	this.container.setEnergyStored(compound.getInteger("StoredJAE"));
}

@Override
public NBTTagCompound writeToNBT(NBTTagCompound compound) {
	compound.setInteger("StoredJAE", this.container.getEnergyStored());
	return super.writeToNBT(compound);
}

@Override
public SPacketUpdateTileEntity getUpdatePacket() {
	return super.getUpdatePacket();
}

@Override
public void onDataPacket(NetworkManager net, SPacketUpdateTileEntity pkt) {
	super.onDataPacket(net, pkt);
	this.readFromNBT(pkt.getNbtCompound());
}

 

 

GuiHandler:

 

[...]
@Override
public Object getServerGuiElement(int ID, EntityPlayer player, World world, int x, int y, int z) {
	switch (ID) {
		case GUI_ID_SOLAR_PANEL:
			return new ContainerSolarPanel(player.inventory, (TileEntitySolarPanel) world.getTileEntity(new BlockPos(x, y, z)));
	}

	return null;
}

@Override
public Object getClientGuiElement(int ID, EntityPlayer player, World world, int x, int y, int z) {
	switch (ID) {
		case GUI_ID_SOLAR_PANEL:
			return new GuiSolarPanel(player.inventory, (TileEntitySolarPanel) world.getTileEntity(new BlockPos(x, y, z)));
	}
	return null;
}

 

 

Container:

 

public class ContainerSolarPanel extends Container {

private TileEntitySolarPanel panel;

public ContainerSolarPanel(InventoryPlayer playerInv, TileEntitySolarPanel panel) {
	this.panel = panel;

	for(int y = 0; y < 3; ++y)
		for(int x = 0; x < 9; ++x)
			this.addSlotToContainer(new Slot(playerInv, x + y * 9 + 9, 8 + x * 18, 84 + y * 18));

	for(int x = 0; x < 9; ++x)
		this.addSlotToContainer(new Slot(playerInv, x, 8 + x * 18, 142));
}

@Override
public boolean canInteractWith(EntityPlayer playerIn) {
	return this.panel.isUsableByPlayer(playerIn);
}
}

 

 

Any ideas how to fix this?

 

Developer of Primeval Forest.

Posted

You need to sync it to the client, if it can be converted to a number then look at ContainerFurnace. Other wise you need to use packets.

It's actually a number from a class which is somehow connected to some capability. ;) (Energy stuff)

 

So I implemented now this method here, but it does still not work...

	@Override
public void detectAndSendChanges() {
	super.detectAndSendChanges();

	for(int i = 0; i < this.listeners.size(); i++) {
		IContainerListener listener = (IContainerListener) this.listeners.get(i);

		if(this.energyStored != this.panel.container.getEnergyStored())
			listener.sendProgressBarUpdate(this, this.energyStored, this.panel.container.getEnergyStored());
	}

	this.energyStored = this.panel.container.getEnergyStored();
}

Developer of Primeval Forest.

Posted

You also need to override another method that has a similar name to sendProgressBarUpdate.

Well, I would guess updateProgressBar, but what to put in there? I don't have a method setfield and getField, cause I've got only one variable there.

Developer of Primeval Forest.

Posted

You also need to override another method that has a similar name to sendProgressBarUpdate.

Well, I would guess updateProgressBar, but this would be a new method, because it does not exists in the default Container class and is also not overriden in Furnace (there it is created). But this method seems also to be just there, but not used... atleast in TileEntityFurnace and in the GUI and in the Container itself, eclipse couldn't find any place where it's called.

It does override updateProgressBar and it does exist in Container. ContainerFurnace just doesn't have the @Override over it.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Posted

You also need to override another method that has a similar name to sendProgressBarUpdate.

Well, I would guess updateProgressBar, but this would be a new method, because it does not exists in the default Container class and is also not overriden in Furnace (there it is created). But this method seems also to be just there, but not used... atleast in TileEntityFurnace and in the GUI and in the Container itself, eclipse couldn't find any place where it's called.

It does override updateProgressBar and it does exist in Container. ContainerFurnace just doesn't have the @Override over it.

Yeah, just noticed now. ^^ That's why I always use @Override !

But what to put in there? I don't have a method setField and getField, cause I've got only one variable there

 

EDIT: Ok, found it out. Works now. Just one last question: How to change the size of text for a Gui? Because currently the complete text has the same size, but I want it to have different sizes. And in drawGuiContainerForegroundLayer these two lines seem to get different results then in drawGuiContainerBackgroundLayer which causes that the text is placed correct, but when you resize the window, the text is drawn on the wrong location while everything in drawGuiContainerBackgroundLayer works fine.

int guiStartX = (this.width - this.getXSize()) / 2;
	int guiStartY = (this.height - this.getYSize()) / 2;

 

EDIT 2: Ok, seems like drawGuiContainerBackgroundLayer uses other coordinates as drawGuiContainerForegroundLayer and fixed the other stuff now also with looking more indeph into setField and getField from the Vanilla Furnace.

Developer of Primeval Forest.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Okay, but does the modpack works with 1.12 or just with 1.12.2, because I need the Forge client specifically for Minecraft 1.12, not 1.12.2
    • Version 1.19 - Forge 41.0.63 I want to create a wolf entity that I can ride, so far it seems to be working, but the problem is that when I get on the wolf, I can’t control it. I then discovered that the issue is that the server doesn’t detect that I’m riding the wolf, so I’m struggling with synchronization. However, it seems to not be working properly. As I understand it, the server receives the packet but doesn’t register it correctly. I’m a bit new to Java, and I’ll try to provide all the relevant code and prints *The comments and prints are translated by chatgpt since they were originally in Spanish* Thank you very much in advance No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. MountableWolfEntity package com.vals.valscraft.entity; import com.vals.valscraft.network.MountSyncPacket; import com.vals.valscraft.network.NetworkHandler; import net.minecraft.client.Minecraft; import net.minecraft.network.syncher.EntityDataAccessor; import net.minecraft.network.syncher.EntityDataSerializers; import net.minecraft.network.syncher.SynchedEntityData; import net.minecraft.server.MinecraftServer; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.EntityType; import net.minecraft.world.entity.Mob; import net.minecraft.world.entity.ai.attributes.AttributeSupplier; import net.minecraft.world.entity.ai.attributes.Attributes; import net.minecraft.world.entity.animal.Wolf; import net.minecraft.world.entity.player.Player; import net.minecraft.world.entity.Entity; import net.minecraft.world.InteractionHand; import net.minecraft.world.InteractionResult; import net.minecraft.world.item.ItemStack; import net.minecraft.world.item.Items; import net.minecraft.world.level.Level; import net.minecraft.world.phys.Vec3; import net.minecraftforge.event.TickEvent; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.network.PacketDistributor; public class MountableWolfEntity extends Wolf { private boolean hasSaddle; private static final EntityDataAccessor<Byte> DATA_ID_FLAGS = SynchedEntityData.defineId(MountableWolfEntity.class, EntityDataSerializers.BYTE); public MountableWolfEntity(EntityType<? extends Wolf> type, Level level) { super(type, level); this.hasSaddle = false; } @Override protected void defineSynchedData() { super.defineSynchedData(); this.entityData.define(DATA_ID_FLAGS, (byte)0); } public static AttributeSupplier.Builder createAttributes() { return Wolf.createAttributes() .add(Attributes.MAX_HEALTH, 20.0) .add(Attributes.MOVEMENT_SPEED, 0.3); } @Override public InteractionResult mobInteract(Player player, InteractionHand hand) { ItemStack itemstack = player.getItemInHand(hand); if (itemstack.getItem() == Items.SADDLE && !this.hasSaddle()) { if (!player.isCreative()) { itemstack.shrink(1); } this.setSaddle(true); return InteractionResult.SUCCESS; } else if (!level.isClientSide && this.hasSaddle()) { player.startRiding(this); MountSyncPacket packet = new MountSyncPacket(true); // 'true' means the player is mounted NetworkHandler.CHANNEL.sendToServer(packet); // Ensure the server handles the packet return InteractionResult.SUCCESS; } return InteractionResult.PASS; } @Override public void travel(Vec3 travelVector) { if (this.isVehicle() && this.getControllingPassenger() instanceof Player) { System.out.println("The wolf has a passenger."); System.out.println("The passenger is a player."); Player player = (Player) this.getControllingPassenger(); // Ensure the player is the controller this.setYRot(player.getYRot()); this.yRotO = this.getYRot(); this.setXRot(player.getXRot() * 0.5F); this.setRot(this.getYRot(), this.getXRot()); this.yBodyRot = this.getYRot(); this.yHeadRot = this.yBodyRot; float forward = player.zza; float strafe = player.xxa; if (forward <= 0.0F) { forward *= 0.25F; } this.flyingSpeed = this.getSpeed() * 0.1F; this.setSpeed((float) this.getAttributeValue(Attributes.MOVEMENT_SPEED) * 1.5F); this.setDeltaMovement(new Vec3(strafe, travelVector.y, forward).scale(this.getSpeed())); this.calculateEntityAnimation(this, false); } else { // The wolf does not have a passenger or the passenger is not a player System.out.println("No player is mounted, or the passenger is not a player."); super.travel(travelVector); } } public boolean hasSaddle() { return this.hasSaddle; } public void setSaddle(boolean hasSaddle) { this.hasSaddle = hasSaddle; } @Override protected void dropEquipment() { super.dropEquipment(); if (this.hasSaddle()) { this.spawnAtLocation(Items.SADDLE); this.setSaddle(false); } } @SubscribeEvent public static void onServerTick(TickEvent.ServerTickEvent event) { if (event.phase == TickEvent.Phase.START) { MinecraftServer server = net.minecraftforge.server.ServerLifecycleHooks.getCurrentServer(); if (server != null) { for (ServerPlayer player : server.getPlayerList().getPlayers()) { if (player.isPassenger() && player.getVehicle() instanceof MountableWolfEntity) { MountableWolfEntity wolf = (MountableWolfEntity) player.getVehicle(); System.out.println("Tick: " + player.getName().getString() + " is correctly mounted on " + wolf); } } } } } private boolean lastMountedState = false; @Override public void tick() { super.tick(); if (!this.level.isClientSide) { // Only on the server boolean isMounted = this.isVehicle() && this.getControllingPassenger() instanceof Player; // Only print if the state changed if (isMounted != lastMountedState) { if (isMounted) { Player player = (Player) this.getControllingPassenger(); // Verify the passenger is a player System.out.println("Server: Player " + player.getName().getString() + " is now mounted."); } else { System.out.println("Server: The wolf no longer has a passenger."); } lastMountedState = isMounted; } } } @Override public void addPassenger(Entity passenger) { super.addPassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(true)); } } } @Override public void removePassenger(Entity passenger) { super.removePassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is no longer mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(false)); } } } @Override public boolean isControlledByLocalInstance() { Entity entity = this.getControllingPassenger(); return entity instanceof Player; } @Override public void positionRider(Entity passenger) { if (this.hasPassenger(passenger)) { double xOffset = Math.cos(Math.toRadians(this.getYRot() + 90)) * 0.4; double zOffset = Math.sin(Math.toRadians(this.getYRot() + 90)) * 0.4; passenger.setPos(this.getX() + xOffset, this.getY() + this.getPassengersRidingOffset() + passenger.getMyRidingOffset(), this.getZ() + zOffset); } } } MountSyncPacket package com.vals.valscraft.network; import com.vals.valscraft.entity.MountableWolfEntity; import net.minecraft.network.FriendlyByteBuf; import net.minecraft.server.level.ServerLevel; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.Entity; import net.minecraft.world.entity.player.Player; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class MountSyncPacket { private final boolean isMounted; public MountSyncPacket(boolean isMounted) { this.isMounted = isMounted; } public void encode(FriendlyByteBuf buffer) { buffer.writeBoolean(isMounted); } public static MountSyncPacket decode(FriendlyByteBuf buffer) { return new MountSyncPacket(buffer.readBoolean()); } public void handle(NetworkEvent.Context context) { context.enqueueWork(() -> { ServerPlayer player = context.getSender(); // Get the player from the context if (player != null) { // Verifies if the player has dismounted if (!isMounted) { Entity vehicle = player.getVehicle(); if (vehicle instanceof MountableWolfEntity wolf) { // Logic to remove the player as a passenger wolf.removePassenger(player); System.out.println("Server: Player " + player.getName().getString() + " is no longer mounted."); } } } }); context.setPacketHandled(true); // Marks the packet as handled } } networkHandler package com.vals.valscraft.network; import com.vals.valscraft.valscraft; import net.minecraft.resources.ResourceLocation; import net.minecraftforge.network.NetworkRegistry; import net.minecraftforge.network.simple.SimpleChannel; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class NetworkHandler { private static final String PROTOCOL_VERSION = "1"; public static final SimpleChannel CHANNEL = NetworkRegistry.newSimpleChannel( new ResourceLocation(valscraft.MODID, "main"), () -> PROTOCOL_VERSION, PROTOCOL_VERSION::equals, PROTOCOL_VERSION::equals ); public static void init() { int packetId = 0; // Register the mount synchronization packet CHANNEL.registerMessage( packetId++, MountSyncPacket.class, MountSyncPacket::encode, MountSyncPacket::decode, (msg, context) -> msg.handle(context.get()) // Get the context with context.get() ); } }  
    • Do you use features of inventory profiles next (ipnext) or is there a change without it?
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.