[1.10.2] Apply potion effect on sword hit.

[SachK]

Hi, I'm working on porting a mod to 1.10.2 and I'm having trouble making the potion effect work correctly on 1.10.2. Here's the code from 1.7.10 if that helps.

 

 

 

public boolean hitEntity(ItemStack par1ItemStack, EntityLivingBase par2EntityLiving, EntityLivingBase par3EntityLiving)

{

par2EntityLiving.addPotionEffect(new PotionEffect(Potion.moveSlowdown.id, 40, 5));

return super.hitEntity(par1ItemStack, par2EntityLiving, par3EntityLiving);

}

 

 

Thanks for any help.

[Animefan8888]

EntityLivingBase#addPotionEffect(new PotionEffect(Potion.getPotionById(10), 100, 3));

Will give the entity regeneration for 100 seconds and level 4.

[Choonster]

EntityLivingBase#addPotionEffect(new PotionEffect(Potion.getPotionById(10), 100, 3));

Will give the entity regeneration for 100 seconds and level 4.

 

Don't use numeric IDs, they're not guaranteed to be the same for every save and they're a lot less descriptive than using fields or registry names.

 

The vanilla

Potion

instances are now stored in the

MobEffects

class.

 

[SachK]

Alright so I've got the potion effect part, I just need to apply it on sword hit. Any help with that?

[Draco18s]

There should be a function in the ItemSword class that deals with hurting enemies. Find it, override it, add that code to it.

[Animefan8888]

EntityLivingBase#addPotionEffect(new PotionEffect(Potion.getPotionById(10), 100, 3));

Will give the entity regeneration for 100 seconds and level 4.

 

Don't use numeric IDs, they're not guaranteed to be the same for every save and they're a lot less descriptive than using fields or registry names.

 

The vanilla

Potion

instances are now stored in the

MobEffects

class.

Ah, very true, but why did MobEffects become MobEffects and not Potions? Kinda like how we have Block and Blocks or Item and Items?

[Draco18s]

Ah, very true, but why did MobEffects become MobEffects and not Potions? Kinda like how we have Block and Blocks or Item and Items?

 

Because potions cause Effects.  There are also (or can be) affects that aren't applied by potions.

[Animefan8888]

Ah, very true, but why did MobEffects become MobEffects and not Potions? Kinda like how we have Block and Blocks or Item and Items?

 

Because potions cause Effects.  There are also (or can be) affects that aren't applied by potions.

You are right there, but I fail to see the logic behind that reasoning. All that MobEffects stores is the Potion instances from the Registry. It doesn't store any effects inside of it. And the only link between Potions and Mobs is that potion effects are applied to mobs.

[SachK]

Ok, here's my code so far.

 

 

 

 

    public boolean hitEntity(ItemStack par1ItemStack, EntityLivingBase par2EntityLiving, EntityLivingBase par3EntityLiving)

    {

          EntityLivingBase#addPotionEffect(new PotionEffect(Potion.getPotionById(10), 100, 3));

          return super.hitEntity(par1ItemStack, par2EntityLiving, par3EntityLiving);

    }

 

 

 

 

It doesn't compile due to illegal characters in the potion effect line. Any idea why this is happening?

[Draco18s]

Classname#MethodName() is not valid java.  It's javadoc notation.

 

If you'd been told to use

someEntityLivingBaseObject_ThisNameIsArbitrary.addPotionEffect(...)

you'd have pasted

someEntityLivingBaseObject_ThisNameIsArbitrary.addPotionEffect(...)

into your code and then complained that eclipse doesn't know what

someEntityLivingBaseObject_ThisNameIsArbitrary

was, despite the obviously arbitrary name.  So we told you the type of the object because its variable name is arbitrary.

[SachK]

I copied Animefan8888's code. I'm a bit confused on how to fix it, can you help?

[Animefan8888]

I copied Animefan8888's code. I'm a bit confused on how to fix it, can you help?

First how much Java do you know?

[SachK]

I used to be into modding 1.2.5, I know c decently. I can't remember any java syntax though.

[Animefan8888]

I used to be into modding 1.2.5, I know c decently. I can't remember any java syntax though.

"#"'s are not used in Java for any actual programming. They are  used to denote that what comes after it is a method and is not static so no confusion comes. AKA

EntityLivingBase.addPotionEffect(...)

is different from

EntityLivingBase living = ...

living.addPotionEffect(...)

[SachK]

Alright, so what should I change in my actual code?

 

 

 

    public boolean hitEntity(ItemStack par1ItemStack, EntityLivingBase par2EntityLiving, EntityLivingBase par3EntityLiving)

    {

          EntityLivingBase#addPotionEffect(new PotionEffect(Potion.getPotionById(10), 100,3));

          return super.hitEntity(par1ItemStack, par2EntityLiving, par3EntityLiving);

    }

 

 

 

[Draco18s]

Find an EntityLivingBase that is available within the method (hint: there are two) and use one of those.

[larsgerrits]

You should call

EntityLivingBase#addPotionEffect

on an instance of

EntityLivingBase

. You have to parameters of type

EntityLivingBase

, the first one being the target and the second being the attacker. You decide which one to use.

[Tyfyter]

On 1/8/2017 at 11:54 PM, Choonster said:

 

Don't use numeric IDs, they're not guaranteed to be the same for every save and they're a lot less descriptive than using fields or registry names.

 

The vanilla

Potion

 

instances are now stored in the

MobEffects

 

class.

 

unless the source code of minecraft forge 1.10 changes based on the world seed numeric potion IDs of vanilla potion effects are always the same.

Edited June 23, 2018 by Tyfyter

[Draco18s]

5 hours ago, Tyfyter said:

unless the source code of minecraft forge 1.10 changes based on the world seed numeric potion IDs are always the same.

Mods that add potions may not have the same ID every time.

 

Also this thread is over a year old.