Jump to content

Recommended Posts

Posted

Hello, I'm a fan of minecraft and thought i would give modding a try. Most of my code mirrors various tutorials, but I seem to get this very tedious problem. My WorldGenerator class should load all of my custom ore blocks, but It gets stuck upon the Building Terrain loading screen. My custom items and blocks worked perfectly fine until I added the generation. It is very strange because it works if I allow one block to generate (commenting out the others) but goes back to being stuck if I add in the others. No crash report  >:(

 

This is the only message I get from Forge before it freezes:

 

2012-12-28 23:05:48 [iNFO] [sTDOUT] Scanning folders...

2012-12-28 23:05:48 [iNFO] [sTDOUT] Total conversion count is 0

2012-12-28 23:05:48 [FINE] [ForgeModLoader] The difference set is equal

2012-12-28 23:05:48 [iNFO] [ForgeModLoader] Loading dimension 0 (New World) (net.minecraft.server.integrated.IntegratedServer@23fd55f6)

2012-12-28 23:05:48 [iNFO] [ForgeModLoader] Loading dimension 37 (New World) (net.minecraft.server.integrated.IntegratedServer@23fd55f6)

2012-12-28 23:05:48 [iNFO] [ForgeModLoader] Loading dimension 1 (New World) (net.minecraft.server.integrated.IntegratedServer@23fd55f6)

2012-12-28 23:05:48 [iNFO] [ForgeModLoader] Loading dimension -1 (New World) (net.minecraft.server.integrated.IntegratedServer@23fd55f6)

 

 

 

 

My World Generation Code:

 

 

 

public class WorldGeneratorExcelteor implements IWorldGenerator {

 

public void generate(Random random, int chunkX, int chunkZ, World world,

IChunkProvider chunkGenerator, IChunkProvider chunkProvider) {

 

switch (world.provider.dimensionId) {

case -1:

generateNether(world, random, chunkX * 16, chunkZ * 16);

case 0:

generateSurface(world, random, chunkX * 16, chunkZ * 16);

case 37:

generateSurface(world, random, chunkX * 16, chunkZ * 16);

}

 

}

 

private void generateNether(World world, Random random, int blockX,

int blockZ) {

 

for (int i = 0; i < 50; i++) {

int Xcoord = blockX + random.nextInt(16);

int Ycoord = random.nextInt(60);

int Zcoord = blockZ + random.nextInt(16);

 

(new WorldGenMinable(Excelteor.SingiOre.blockID, 10)).generate(

world, random, Xcoord, Ycoord, Zcoord);

}

 

}

 

private void generateSurface(World world, Random random, int blockX,

int blockZ) {

 

for (int i = 0; i < 50; i++) {

int Xcoord = blockX + random.nextInt(16);

int Ycoord = random.nextInt(60);

int Zcoord = blockZ + random.nextInt(16);

 

(new WorldGenMinable(Excelteor.DronadiumOre.blockID, 10)).generate(

world, random, Xcoord, Ycoord, Zcoord);

}

 

for (int i = 0; i < 10; i++) {

int Xcoord = blockX + random.nextInt(16);

int Ycoord = random.nextInt(60);

int Zcoord = blockZ + random.nextInt(16);

 

(new WorldGenClay(Excelteor.AduraOre.blockID)).generate(world,

random, Xcoord, Ycoord, Zcoord);

}

 

for (int i = 0; i < 40; i++) {

int Xcoord = blockX + random.nextInt(16);

int Ycoord = random.nextInt(60);

int Zcoord = blockZ + random.nextInt(16);

 

(new WorldGenMinable(Excelteor.SiculOre.blockID, 10)).generate(

world, random, Xcoord, Ycoord, Zcoord);

}

 

for (int i = 0; i < 30; i++) {

int Xcoord = blockX + random.nextInt(16);

int Ycoord = random.nextInt(30);

int Zcoord = blockZ + random.nextInt(16);

 

(new WorldGenMinable(Excelteor.LatroOre.blockID, 10)).generate(

world, random, Xcoord, Ycoord, Zcoord);

}

 

for (int i = 0; i < 10; i++) {

int Xcoord = blockX + random.nextInt(16);

int Ycoord = random.nextInt(20);

int Zcoord = blockZ + random.nextInt(16);

 

(new WorldGenMinable(Excelteor.AminaOre.blockID, 10)).generate(

world, random, Xcoord, Ycoord, Zcoord);

}

 

for (int i = 0; i < 10; i++) {

int Xcoord = blockX + random.nextInt(16);

int Ycoord = random.nextInt(20);

int Zcoord = blockZ + random.nextInt(16);

 

(new WorldGenMinable(Excelteor.ArretOre.blockID, 10)).generate(

world, random, Xcoord, Ycoord, Zcoord);

}

 

}

 

}

 

 

 

 

I used the latest version of forge for 1.4.6.

 

Thanks for any future help, or sorry if this was a stupid problem  :P

Posted

Stick some System.out.println()'s between the for loops (for debuging) and lower the iteration count. It may just be sluggish.

 

BTW, this is the wrong forum.

There's an EAQ for a reason. Read it!

"Note that failure to read this will make you look idiotic. You don't want that do you?" -- luacs1998

 

First rule of bug reports: More information is always better.

Oh, and logs OR IT DIDN'T HAPPEN!!

Posted

You're generating an infinite amount of chunks, check that you are not expanding over chunk boundaries.

If you let it run for long enough you'd probably get a OOM error.

I do Forge for free, however the servers to run it arn't free, so anything is appreciated.
Consider supporting the team on Patreon

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.