Renamed: Figured out most of villagers, need help ironing out bugs

OrangeVillager61 · January 17, 2017

I've extended EntityVillager and made a class with a few things that I will use in my mod. How to use the EntityRegistry and I want these to override vanilla mc villagers but only the vanilla careers and professions. Also, do I need to put in EntityVillager AI and my custom made AI or is this not needed?

OrangeVillager61 · January 20, 2017

Okay, so I've figured out everything above, however, my villagers don't work at all. They override regular villagers successfully and display the correct texture. That's it, they don't move or have any AI. They just gets hearts and endless stacks villages inside the same block. They don't die from lava, they don't even fall.

public class OverrideVillagers {
@SubscribeEvent
public void entityJoinedWorldEventHandler(EntityJoinWorldEvent event)
{
	if (event.getEntity().getClass() == EntityVillager.class && Config.overwriteOriginalVillagers)
	{
		doOverwriteVillager(event, (EntityVillager) event.getEntity());
	}
}

private void doOverwriteVillager(EntityJoinWorldEvent event, EntityVillager entity) 
{
	if (entity.getProfession() >= 0 && entity.getProfession() <= 4)
	{
		entity.setDead();
		EntityVillager entityVillager = new EntityVillager(event.getWorld());
		entityVillager.onInitialSpawn(event.getWorld().getDifficultyForLocation(new BlockPos(entity)), (IEntityLivingData)null);
		entityVillager.setLocationAndAngles(entity.posX, entity.posY, entity.posZ, 0.0F, 0.0F);
		event.getWorld().spawnEntity(entityVillager);
		event.getWorld().setEntityState(entityVillager, (byte)12);
		entityVillager.setProfession(entity.getProfession()); 
		entityVillager.setGrowingAge(entity.getGrowingAge());
	}
}
}

public class IvVillager extends EntityVillager{

protected Village villageObj; 
public String name;
public int Gender;
    protected boolean isWillingToMate;
    protected int wealth;
    private MerchantRecipeList buyingList;
    private String lastBuyingPlayer;
    private int careerId;
    private int careerLevel;
    private boolean isLookingForHome;
    private boolean areAdditionalTasksSet;
    private final InventoryBasic villagerInventory;
    Random r = new Random();
    /** A multi-dimensional array mapping the various professions, careers and career levels that a Villager may offer */
protected String[] male_list = {"Bob", "Joseph", "Aaron", "Philp", "Adam", "Paul", "Donald", "Ryan", 
								"Mark", "Brian", "Robert", "Willam", "Harold", "Anthony", "Julius", 
								"Mathew", "Tyler", "Noah", "Patrick", "Caden", "Michael", "Jeffery",
								"James", "John", "Thomas", "Otto", "Bill", "Sheldon", "Leonard", 
								"Howard", "Carter", "Theodore", "Herbert"};
protected String[] female_list = {"Karen", "Lessie", "Kayla", "Brianna", "Isabella", "Elizabeth",
								  "Kira", "Jadzia", "Abigail", "Chloe", "Olivia", "Sophia", "Emily", 
								  "Charlotte", "Amelia", "Maria", "Daria", "Sarah", "Theodora",
								  "Tia", "Jennifer", "Anglica", "Denna", "Tasha", "Catherine", "Lily",
								  "Amy", "Penny", "Julina", "Audrey", "Avery"};


public IvVillager(World world, int professionId) {
	super(world, professionId);
    this.villagerInventory = new InventoryBasic("Items", false, ;
    this.setCanPickUpLoot(true);
    this.setProfession(professionId);
}
public InventoryBasic getVillagerInventory()
    {
        return this.villagerInventory;
    }

private void setAdditionalAItasks()
    {
        if (!this.areAdditionalTasksSet)
        {
            this.areAdditionalTasksSet = true;

            if (this.isChild())
            {
                this.tasks.addTask(8, new EntityAIPlay(this, 0.32D));
            }
            else if (this.getProfession() == 0)
            {
                this.tasks.addTask(6, new EntityAIHarvestFarmland(this, 0.6D));
            }
        }
    }
 @Override
 public void writeEntityToNBT(NBTTagCompound compound)
    {
        super.writeEntityToNBT(compound);
        compound.setInteger("Profession", this.getProfession());
        compound.setString("ProfessionName", this.getProfessionForge().getRegistryName().toString());
        compound.setInteger("Riches", this.wealth);
        compound.setInteger("Career", this.careerId);
        compound.setInteger("CareerLevel", this.careerLevel);
        compound.setBoolean("Willing", this.isWillingToMate);

        if (this.buyingList != null)
        {
            compound.setTag("Offers", this.buyingList.getRecipiesAsTags());
        }

        NBTTagList nbttaglist = new NBTTagList();

        for (int i = 0; i < this.getVillagerInventory().getSizeInventory(); ++i)
        {
            ItemStack itemstack = this.villagerInventory.getStackInSlot(i);

            if (!itemstack.isEmpty())
            {
                nbttaglist.appendTag(itemstack.writeToNBT(new NBTTagCompound()));
            }
        }

        compound.setTag("Inventory", nbttaglist);
        if (compound.getInteger("Gender") != 1 || compound.getInteger("Gender") != 2)
        {
        	compound.setInteger("Gender", this.Gender);
        }
        if (this.getCustomNameTag() == null){
        	if (compound.getInteger("Gender") == 1){
        		this.setCustomNameTag(male_list[r.nextInt(male_list.length)]);
        	}
        if (compound.getInteger("Gender") == 2){
        			this.setCustomNameTag(female_list[r.nextInt(female_list.length)]);
        	}
        }
        
    }
 @Override
 public void readEntityFromNBT(NBTTagCompound compound){
	 super.writeEntityToNBT(compound);
	 this.name = this.getCustomNameTag();
	 this.Gender = compound.getInteger("Gender");
	 this.setProfession(compound.getInteger("Profession"));
        if (compound.hasKey("ProfessionName"))
        {
            net.minecraftforge.fml.common.registry.VillagerRegistry.VillagerProfession p =
                net.minecraftforge.fml.common.registry.VillagerRegistry.instance().getRegistry().getValue(new net.minecraft.util.ResourceLocation(compound.getString("ProfessionName")));
            if (p == null)
                p = net.minecraftforge.fml.common.registry.VillagerRegistry.instance().getRegistry().getValue(new net.minecraft.util.ResourceLocation("minecraft:farmer"));
            this.setProfession(p);
        }
        this.wealth = compound.getInteger("Riches");
        this.careerId = compound.getInteger("Career");
        this.careerLevel = compound.getInteger("CareerLevel");
        this.isWillingToMate = compound.getBoolean("Willing");

        if (compound.hasKey("Offers", 10))
        {
            NBTTagCompound nbttagcompound = compound.getCompoundTag("Offers");
            this.buyingList = new MerchantRecipeList(nbttagcompound);
        }

        NBTTagList nbttaglist = compound.getTagList("Inventory", 10);

        for (int i = 0; i < nbttaglist.tagCount(); ++i)
        {
            ItemStack itemstack = new ItemStack(nbttaglist.getCompoundTagAt(i));

            if (!itemstack.isEmpty())
            {
                this.villagerInventory.addItem(itemstack);
            }
        }

        this.setCanPickUpLoot(true);
        this.setAdditionalAItasks();

 }
 private void populateBuyingList()
    {
        if (this.careerId != 0 && this.careerLevel != 0)
        {
            ++this.careerLevel;
        }
        else
        {
            this.careerId = this.getProfessionForge().getRandomCareer(this.rand) + 1;
            this.careerLevel = 1;
        }

        if (this.buyingList == null)
        {
            this.buyingList = new MerchantRecipeList();
        }

        int i = this.careerId - 1;
        int j = this.careerLevel - 1;
        java.util.List<EntityVillager.ITradeList> trades = this.getProfessionForge().getCareer(i).getTrades(j);

        if (trades != null)
        {
            for (EntityVillager.ITradeList entityvillager$itradelist : trades)
            {
                entityvillager$itradelist.addMerchantRecipe(this, this.buyingList, this.rand);
            }
        }
    }
 @Override
 public boolean processInteract(EntityPlayer player, EnumHand hand){
	BlockPos blockpos = new BlockPos(this);
	this.villageObj = this.world.getVillageCollection().getNearestVillage(blockpos, 32);
        ItemStack itemstack = player.getHeldItem(hand);

        if (itemstack.getItem() == IvItems.thieving_nose && !player.capabilities.isCreativeMode && !this.isChild())
        {
        	itemstack.damageItem(1, player);
        	if (rand.nextInt(10) + 1 < 6){
        		
        	}
        	if (rand.nextInt(10) + 1 < 9 && rand.nextInt(10) + 1  > 5){
        		player.dropItem(new ItemStack(Items.EMERALD, r.nextInt(2) + 1), false);
        	}
        	if (rand.nextInt(10) + 1 < 10 && rand.nextInt(10) + 1  > {
        		player.dropItem(new ItemStack(Items.EMERALD, r.nextInt(6) + 3), false);
        	}
        	if (this.villageObj != null)
            {
        		this.villageObj.modifyPlayerReputation(player.getName(), -2);
            } 
            return true;
        }
        else if (!this.holdingSpawnEggOfClass(itemstack, this.getClass()) && this.isEntityAlive() && !this.isTrading() && !this.isChild())
        {
            if (this.buyingList == null)
            {
                this.populateBuyingList();
            }

            if (hand == EnumHand.MAIN_HAND)
            {
                player.addStat(StatList.TALKED_TO_VILLAGER);
            }

            if (!this.world.isRemote && !this.buyingList.isEmpty())
            {
                this.setCustomer(player);
                player.displayVillagerTradeGui(this);
            }
            else if (this.buyingList.isEmpty())
            {
                return super.processInteract(player, hand);
            }

            return true;
        }
        else
        {
            return super.processInteract(player, hand);
        }
    }

}

public class CommonProxy {

@EventHandler
    public void preInit(FMLPreInitializationEvent e) {
	ResourceLocation resourceLocation1 = new ResourceLocation("minecraft", "EntityVillager");
	EntityRegistry.registerModEntity(resourceLocation1, IvVillager.class, "IvVillager", 0, Iv.instance, 32, 1, true);

}
@EventHandler
    public void init(FMLInitializationEvent e) {
}
    @EventHandler
    public void postInit(FMLPostInitializationEvent e) {

    }
}

Draco18s · January 20, 2017

Show your entity class. You fucked something up there, not in the replacement.

OrangeVillager61 · January 21, 2017

Show your entity class. You fucked something up there, not in the replacement.

I have, I put three classes in there, I'll separate them.

OrangeVillager61 · January 21, 2017

Reposting entity class + the AI I give to EntityVillagers and the IvVillager.

public class IvVillager extends EntityVillager{

protected Village villageObj; 
public String name;
public int Gender;
    protected boolean isWillingToMate;
    protected int wealth;
    private MerchantRecipeList buyingList;
    private String lastBuyingPlayer;
    private int careerId;
    private int careerLevel;
    private boolean isLookingForHome;
    private boolean areAdditionalTasksSet;
    private final InventoryBasic villagerInventory;
    Random r = new Random();
    /** A multi-dimensional array mapping the various professions, careers and career levels that a Villager may offer */
protected String[] male_list = {"Bob", "Joseph", "Aaron", "Philp", "Adam", "Paul", "Donald", "Ryan", 
								"Mark", "Brian", "Robert", "Willam", "Harold", "Anthony", "Julius", 
								"Mathew", "Tyler", "Noah", "Patrick", "Caden", "Michael", "Jeffery",
								"James", "John", "Thomas", "Otto", "Bill", "Sheldon", "Leonard", 
								"Howard", "Carter", "Theodore", "Herbert"};
protected String[] female_list = {"Karen", "Lessie", "Kayla", "Brianna", "Isabella", "Elizabeth",
								  "Kira", "Jadzia", "Abigail", "Chloe", "Olivia", "Sophia", "Emily", 
								  "Charlotte", "Amelia", "Maria", "Daria", "Sarah", "Theodora",
								  "Tia", "Jennifer", "Anglica", "Denna", "Tasha", "Catherine", "Lily",
								  "Amy", "Penny", "Julina", "Audrey", "Avery"};


public IvVillager(World world, int professionId) {
	super(world, professionId);
    this.villagerInventory = new InventoryBasic("Items", false, ;
    this.setCanPickUpLoot(true);
    this.setProfession(professionId);
}
public InventoryBasic getVillagerInventory()
    {
        return this.villagerInventory;
    }

private void setAdditionalAItasks()
    {
        if (!this.areAdditionalTasksSet)
        {
            this.areAdditionalTasksSet = true;

            if (this.isChild())
            {
                this.tasks.addTask(8, new EntityAIPlay(this, 0.32D));
            }
            else if (this.getProfession() == 0)
            {
                this.tasks.addTask(6, new EntityAIHarvestFarmland(this, 0.6D));
            }
        }
    }
 @Override
 public void writeEntityToNBT(NBTTagCompound compound)
    {
        super.writeEntityToNBT(compound);
        compound.setInteger("Profession", this.getProfession());
        compound.setString("ProfessionName", this.getProfessionForge().getRegistryName().toString());
        compound.setInteger("Riches", this.wealth);
        compound.setInteger("Career", this.careerId);
        compound.setInteger("CareerLevel", this.careerLevel);
        compound.setBoolean("Willing", this.isWillingToMate);

        if (this.buyingList != null)
        {
            compound.setTag("Offers", this.buyingList.getRecipiesAsTags());
        }

        NBTTagList nbttaglist = new NBTTagList();

        for (int i = 0; i < this.getVillagerInventory().getSizeInventory(); ++i)
        {
            ItemStack itemstack = this.villagerInventory.getStackInSlot(i);

            if (!itemstack.isEmpty())
            {
                nbttaglist.appendTag(itemstack.writeToNBT(new NBTTagCompound()));
            }
        }

        compound.setTag("Inventory", nbttaglist);
        if (compound.getInteger("Gender") != 1 || compound.getInteger("Gender") != 2)
        {
        	compound.setInteger("Gender", this.Gender);
        }
        if (this.getCustomNameTag() == null){
        	if (compound.getInteger("Gender") == 1){
        		this.setCustomNameTag(male_list[r.nextInt(male_list.length)]);
        	}
        if (compound.getInteger("Gender") == 2){
        			this.setCustomNameTag(female_list[r.nextInt(female_list.length)]);
        	}
        }
        
    }
 @Override
 public void readEntityFromNBT(NBTTagCompound compound){
	 super.writeEntityToNBT(compound);
	 this.name = this.getCustomNameTag();
	 this.Gender = compound.getInteger("Gender");
	 this.setProfession(compound.getInteger("Profession"));
        if (compound.hasKey("ProfessionName"))
        {
            net.minecraftforge.fml.common.registry.VillagerRegistry.VillagerProfession p =
                net.minecraftforge.fml.common.registry.VillagerRegistry.instance().getRegistry().getValue(new net.minecraft.util.ResourceLocation(compound.getString("ProfessionName")));
            if (p == null)
                p = net.minecraftforge.fml.common.registry.VillagerRegistry.instance().getRegistry().getValue(new net.minecraft.util.ResourceLocation("minecraft:farmer"));
            this.setProfession(p);
        }
        this.wealth = compound.getInteger("Riches");
        this.careerId = compound.getInteger("Career");
        this.careerLevel = compound.getInteger("CareerLevel");
        this.isWillingToMate = compound.getBoolean("Willing");

        if (compound.hasKey("Offers", 10))
        {
            NBTTagCompound nbttagcompound = compound.getCompoundTag("Offers");
            this.buyingList = new MerchantRecipeList(nbttagcompound);
        }

        NBTTagList nbttaglist = compound.getTagList("Inventory", 10);

        for (int i = 0; i < nbttaglist.tagCount(); ++i)
        {
            ItemStack itemstack = new ItemStack(nbttaglist.getCompoundTagAt(i));

            if (!itemstack.isEmpty())
            {
                this.villagerInventory.addItem(itemstack);
            }
        }

        this.setCanPickUpLoot(true);
        this.setAdditionalAItasks();

 }
 private void populateBuyingList()
    {
        if (this.careerId != 0 && this.careerLevel != 0)
        {
            ++this.careerLevel;
        }
        else
        {
            this.careerId = this.getProfessionForge().getRandomCareer(this.rand) + 1;
            this.careerLevel = 1;
        }

        if (this.buyingList == null)
        {
            this.buyingList = new MerchantRecipeList();
        }

        int i = this.careerId - 1;
        int j = this.careerLevel - 1;
        java.util.List<EntityVillager.ITradeList> trades = this.getProfessionForge().getCareer(i).getTrades(j);

        if (trades != null)
        {
            for (EntityVillager.ITradeList entityvillager$itradelist : trades)
            {
                entityvillager$itradelist.addMerchantRecipe(this, this.buyingList, this.rand);
            }
        }
    }
 @Override
 public boolean processInteract(EntityPlayer player, EnumHand hand){
	BlockPos blockpos = new BlockPos(this);
	this.villageObj = this.world.getVillageCollection().getNearestVillage(blockpos, 32);
        ItemStack itemstack = player.getHeldItem(hand);

        if (itemstack.getItem() == IvItems.thieving_nose && !player.capabilities.isCreativeMode && !this.isChild())
        {
        	itemstack.damageItem(1, player);
        	if (rand.nextInt(10) + 1 < 6){
        		
        	}
        	if (rand.nextInt(10) + 1 < 9 && rand.nextInt(10) + 1  > 5){
        		player.dropItem(new ItemStack(Items.EMERALD, r.nextInt(2) + 1), false);
        	}
        	if (rand.nextInt(10) + 1 < 10 && rand.nextInt(10) + 1  > {
        		player.dropItem(new ItemStack(Items.EMERALD, r.nextInt(6) + 3), false);
        	}
        	if (this.villageObj != null)
            {
        		this.villageObj.modifyPlayerReputation(player.getName(), -2);
            } 
            return true;
        }
        else if (!this.holdingSpawnEggOfClass(itemstack, this.getClass()) && this.isEntityAlive() && !this.isTrading() && !this.isChild())
        {
            if (this.buyingList == null)
            {
                this.populateBuyingList();
            }

            if (hand == EnumHand.MAIN_HAND)
            {
                player.addStat(StatList.TALKED_TO_VILLAGER);
            }

            if (!this.world.isRemote && !this.buyingList.isEmpty())
            {
                this.setCustomer(player);
                player.displayVillagerTradeGui(this);
            }
            else if (this.buyingList.isEmpty())
            {
                return super.processInteract(player, hand);
            }

            return true;
        }
        else
        {
            return super.processInteract(player, hand);
        }
    }

}

public class ChangeVilMateAI {

@SubscribeEvent
public void entityVillagerAIOverride(LivingSpawnEvent event) {
     if (event.getEntity() != null){
	    if (event.getEntity() instanceof EntityVillager) {
	          EntityVillager villager = (EntityVillager) event.getEntity();
	          villager.tasks.addTask(3, new VilsPerDoor(villager));
	     }
	    else if (event.getEntity() instanceof IvVillager) {
	          IvVillager villager = (IvVillager) event.getEntity();
	          villager.tasks.addTask(3, new IvVilsPerDoor(villager));
	     }
	}
}
}

Draco18s · January 21, 2017

I'm at a loss.

You call super for the methods you've overridden and you haven't overridden onUpdate...

Nope, no idea.

Animefan8888 · January 21, 2017

In your event you are not creating a new instance of your EntityVillager, but a vanilla one. And then you add it to the world which fires the on EntityJoinedWorldEvent, this hangs the server thread and nothing gets updated.

OrangeVillager61 · January 22, 2017

Thank, however my code crashes on

@Override
 public boolean processInteract(EntityPlayer player, EnumHand hand){
	BlockPos blockpos = new BlockPos(this);
	this.villageObj = this.world.getVillageCollection().getNearestVillage(blockpos, 32); //Here
        ItemStack itemstack = player.getHeldItem(hand);

Animefan8888 · January 22, 2017

Thank, however my code crashes on

@Override
 public boolean processInteract(EntityPlayer player, EnumHand hand){
	BlockPos blockpos = new BlockPos(this);
	this.villageObj = this.world.getVillageCollection().getNearestVillage(blockpos, 32); //Here
        ItemStack itemstack = player.getHeldItem(hand);

Probably a NullPointerException use your debugger to figure it out, or use printlns to identify it.

OrangeVillager61 · January 24, 2017

Whenever I spawn in a villager and it gets overridden, I get this error

[FML]: A severe problem occurred during the spawning of an entity at ( 940.5,4.0, -362.5)
java.lang.NoSuchMethodException: orangeVillager61.ImprovedVillagers.Entities.IvVillager.<init>(net.minecraft.world.World)
at java.lang.Class.getConstructor0(Unknown Source) ~[?:1.8.0_111]
at java.lang.Class.getConstructor(Unknown Source) ~[?:1.8.0_111]
at net.minecraftforge.fml.common.network.internal.EntitySpawnHandler.spawnEntity(EntitySpawnHandler.java:96) [EntitySpawnHandler.class:?]
at net.minecraftforge.fml.common.network.internal.EntitySpawnHandler.process(EntitySpawnHandler.java:73) [EntitySpawnHandler.class:?]
at net.minecraftforge.fml.common.network.internal.EntitySpawnHandler.access$000(EntitySpawnHandler.java:48) [EntitySpawnHandler.class:?]
at net.minecraftforge.fml.common.network.internal.EntitySpawnHandler$1.run(EntitySpawnHandler.java:63) [EntitySpawnHandler$1.class:?]
at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source) [?:1.8.0_111]
at java.util.concurrent.FutureTask.run(Unknown Source) [?:1.8.0_111]
at net.minecraft.util.Util.runTask(Util.java:26) [util.class:?]
at net.minecraft.client.Minecraft.runGameLoop(Minecraft.java:1107) [Minecraft.class:?]
at net.minecraft.client.Minecraft.run(Minecraft.java:405) [Minecraft.class:?]
at net.minecraft.client.main.Main.main(Main.java:118) [Main.class:?]

I think it may be related to my nullpointer issue.

OrangeVillager61 · January 24, 2017

Entity classes must have a public constructor with a single
World
argument.

Yep

public IvVillager(World world, int professionId) {
	super(world, professionId);
    this.villagerInventory = new InventoryBasic("Items", false, ;
    this.setCanPickUpLoot(true);
}

OrangeVillager61 · January 24, 2017

That is a
World
and an
int
. Not a single
World
argument.

Alright, but I've still be getting this crash,

java.lang.NullPointerException: Unexpected error
at orangeVillager61.ImprovedVillagers.Entities.IvVillager.processInteract(IvVillager.java:223)
at net.minecraft.entity.EntityLiving.processInitialInteract(EntityLiving.java:1337)
at net.minecraft.entity.player.EntityPlayer.interactOn(EntityPlayer.java:1273)
at net.minecraft.client.multiplayer.PlayerControllerMP.interactWithEntity(PlayerControllerMP.java:573)
at net.minecraft.client.Minecraft.rightClickMouse(Minecraft.java:1592)
at net.minecraft.client.Minecraft.processKeyBinds(Minecraft.java:2274)
at net.minecraft.client.Minecraft.runTickKeyboard(Minecraft.java:2051)
at net.minecraft.client.Minecraft.runTick(Minecraft.java:1839)
at net.minecraft.client.Minecraft.runGameLoop(Minecraft.java:1117)

@Override
 public boolean processInteract(EntityPlayer player, EnumHand hand){
        ItemStack itemstack = player.getHeldItem(hand);
        BlockPos blockpos = new BlockPos(this);
	this.ivillageObj = this.getWorld().getVillageCollection().getNearestVillage(blockpos, 32); // Crashing here.
        if (itemstack.getItem() == IvItems.thieving_nose && !player.capabilities.isCreativeMode && !this.isChild())
        {
...

OrangeVillager61 · January 24, 2017

So this would work?

@SideOnly(Side.SERVER)
 public void initServerVars(){
		BlockPos blockpos = new BlockPos(this);
		this.ivillageObj = this.getWorld().getVillageCollection().getNearestVillage(blockpos, 32);
 }@Override
 public boolean processInteract(EntityPlayer player, EnumHand hand){
        ItemStack itemstack = player.getHeldItem(hand);
        this.initServerVars();
        if (itemstack.getItem() == IvItems.thieving_nose && !player.capabilities.isCreativeMode && !this.isChild())
        {...

OrangeVillager61 · January 26, 2017

Alright, so I'm trying to get MC to give every villager a name from a list I made, however this is not working.

t
protected String[] male_list = {"Bob", "Joseph", "Aaron", "Philp", "Adam", "Paul", "Donald", "Ryan", 
								"Mark", "Brian", "Robert", "Willam", "Harold", "Anthony", "Julius", 
								"Mathew", "Tyler", "Noah", "Patrick", "Caden", "Michael", "Jeffery",
								"James", "John", "Thomas", "Otto", "Bill", "Sheldon", "Leonard", 
								"Howard", "Carter", "Theodore", "Herbert"};
protected String[] female_list = {"Karen", "Lessie", "Kayla", "Brianna", "Isabella", "Elizabeth",
								  "Kira", "Jadzia", "Abigail", "Chloe", "Olivia", "Sophia", "Emily", 
								  "Charlotte", "Amelia", "Maria", "Daria", "Sarah", "Theodora",
								  "Tia", "Jennifer", "Anglica", "Denna", "Tasha", "Catherine", "Lily",
								  "Amy", "Penny", "Julina", "Audrey", "Avery"};
@Override
public void readEntityFromNBT(NBTTagCompound compound){
this.name = this.getCustomNameTag();
	 System.out.println(this.name);
	 this.Gender = compound.getInteger("Gender");
	    if (this.Gender != 1 || this.Gender != 2){
	    	this.Gender = r.nextInt(2) + 1;
	    }
	 if (this.name == null){
		    if (this.Gender == 1){
	        	this.name = male_list[r.nextInt(male_list.length)];
	        }
	        else if (this.Gender == 2){
	        	this.name = female_list[r.nextInt(female_list.length)];
		    }
		    else if (this.Gender != 1 && this.Gender != 2){
		        this.name = "None";
		        System.out.println("Villager Gender Error");
		    }
	    }
}

Draco18s · January 26, 2017

Use capabilities.

OrangeVillager61 · January 26, 2017

Use capabilities.

For what? Naming the mob? Applying the name to the mob?

Draco18s · January 26, 2017

Storing the information and syncing with the client.

getEntityData() is not a good use for what you are doing.

OrangeVillager61 · January 27, 2017

Storing the information and syncing with the client.

getEntityData() is not a good use for what you are doing.

So how to have a capability use two variables? Since I tried using two of them and it crashed.

public class VillagerStoragesName implements IStorage<IVillagerStorage>

{

 @Override

 public NBTBase writeNBT(Capability<IVillagerStorage> capability, IVillagerStorage instance, EnumFacing side)

 {
 return new NBTTagString(instance.getName());
 }



 public void readNBT(Capability<IVillagerStorage> capability, IVillagerStorage instance, EnumFacing side, NBTBase nbt)

 {
 instance.setName(((NBTPrimitive) nbt).toString());

 }
}

public class VillagerStoragesGender implements IStorage<IVillagerStorage>

{

 @Override

 public NBTBase writeNBT(Capability<IVillagerStorage> capability, IVillagerStorage instance, EnumFacing side)

 {
 return new NBTTagInt(instance.getGender());
 }



 public void readNBT(Capability<IVillagerStorage> capability, IVillagerStorage instance, EnumFacing side, NBTBase nbt)

 {

 instance.setGender(((NBTPrimitive) nbt).getInt());
 }
}

Draco18s · January 27, 2017

and it crashed.

OrangeVillager61 · January 27, 2017

and it crashed.

The crash said that I can't register two capabilities with the almost the same thing.

@EventHandler
    public void preInit(FMLPreInitializationEvent e) {
	MinecraftForge.EVENT_BUS.register(new CapabilityHandler());
	CapabilityManager.INSTANCE.register(IVillagerStorage.class, new VillagerStoragesGender(), VillagerStorage.class);
	CapabilityManager.INSTANCE.register(IVillagerStorage.class, new VillagerStoragesName(), VillagerStorage.class);
}
}

OrangeVillager61 · January 27, 2017

Don't register the same capability twice. Your storage needs to save everything from your capability. Don't create a separate storage for every piece of data.

Okay, but how would I merge the two since writeNbt can return only one thing.

OrangeVillager61 · January 29, 2017

NBTTagCompound
for example.

So this would work.

@Override

 public NBTBase writeNBT(Capability<IVillagerStorage> capability, IVillagerStorage instance, EnumFacing side)

 {
	NBTTagCompound compound = new NBTTagCompound();
	compound.setInteger("Gender", instance.getGender());
	compound.setString("Name", instance.getName());
	return new NBTTagString(instance.getName());
 }



 public void readNBT(Capability<IVillagerStorage> capability, IVillagerStorage instance, EnumFacing side, NBTBase nbt)

 {
 instance.setName(((NBTPrimitive) nbt).toString());
 instance.setGender(((NBTPrimitive) nbt).getInt());
 }

Choonster · January 29, 2017

No, that wouldn't work.

In

writeNBT

, you create an

NBTTagCompound

and store the data in it; but you then return a completely unrelated

NBTTagString

and do nothing with the

NBTTagCompound

. You need to return the

NBTTagCompound

.

In

readNBT

, you assume that the

NBTBase

argument is an instance of

NBTPrimitive

(it won't be if

writeNBT

returns an

NBTTagCompound

) that somehow contains both the name and the gender at the same time. You need to cast the argument to

NBTTagCompound

and retrieve the individual values from it using

NBTTagCompound#getString

and

NBTTagCompound#getInteger

.

OrangeVillager61 · January 29, 2017

No, that wouldn't work.

In
writeNBT
, you create an
NBTTagCompound
and store the data in it; but you then return a completely unrelated
NBTTagString
and do nothing with the
NBTTagCompound
. You need to return the
NBTTagCompound
.

In
readNBT
, you assume that the
NBTBase
argument is an instance of
NBTPrimitive
(it won't be if
writeNBT
returns an
NBTTagCompound
) that somehow contains both the name and the gender at the same time. You need to cast the argument to
NBTTagCompound
and retrieve the individual values from it using
NBTTagCompound#getString
and
NBTTagCompound#getInteger
.

Ah, okay so this would work.

@Override

 public NBTBase writeNBT(Capability<IVillagerStorage> capability, IVillagerStorage instance, EnumFacing side)

 {
	NBTTagCompound compound = new NBTTagCompound();
	compound.setInteger("Gender", instance.getGender());
	compound.setString("Name", instance.getName());
	return compound;
 }



 public void readNBT(Capability<IVillagerStorage> capability, IVillagerStorage instance, EnumFacing side, NBTBase nbt)

 {

 instance.setName(((NBTTagCompound) nbt).getString("Name"));
 instance.setGender(((NBTTagCompound) nbt).getInteger("Gender"));
 }

Choonster · January 29, 2017

That should work, yes.

Sign In

Renamed: Figured out most of villagers, need help ironing out bugs

Recommended Posts

OrangeVillager61

OrangeVillager61

Draco18s

OrangeVillager61

OrangeVillager61

Draco18s

Animefan8888

OrangeVillager61

Animefan8888

OrangeVillager61

OrangeVillager61

OrangeVillager61

OrangeVillager61

OrangeVillager61

Draco18s

OrangeVillager61

Draco18s

OrangeVillager61

Draco18s

OrangeVillager61

OrangeVillager61

OrangeVillager61

Choonster

OrangeVillager61

Choonster

Join the conversation

Announcements

Recently Browsing

Posts

Topics

Who's Online (See full list)

Browse

Activity

Important Information