Entity not spawning block on impact/replacing existing blocks [1.11.2] [Solved]

[hhggtg3279]

Basically when my entity hits a block it's supposed to place a flowing lava on top of existing blocks, however my entity currently replaces existing blocks with lava instead of on top, also it doesn't place lava every time it impacts a block,  can someone help.

 

Here is my code:

http://pastebin.com/sVRKj8vM

 

Fixed code for anyone who is having the same issue:

 

package top.mod.item;

 

import net.minecraft.entity.EntityLivingBase;

import net.minecraft.entity.monster.EntityBlaze;

import net.minecraft.entity.projectile.EntityThrowable;

import net.minecraft.init.Blocks;

import net.minecraft.util.DamageSource;

import net.minecraft.util.EnumParticleTypes;

import net.minecraft.util.datafix.DataFixer;

import net.minecraft.util.math.BlockPos;

import net.minecraft.util.math.RayTraceResult;

import net.minecraft.world.World;

import net.minecraftforge.fml.relauncher.Side;

import net.minecraftforge.fml.relauncher.SideOnly;

 

public class EntityFirestaff extends EntityThrowable

{

    public EntityFirestaff(World worldIn)

    {

        super(worldIn);

    }

 

    public EntityFirestaff(World worldIn, EntityLivingBase throwerIn)

    {

        super(worldIn, throwerIn);

    }

 

    public EntityFirestaff(World worldIn, double x, double y, double z)

    {

        super(worldIn, x, y, z);

    }

 

    public static void registerFixesSnowball(DataFixer fixer)

    {

        EntityThrowable.registerFixesThrowable(fixer, "Snowball");

    }

 

    @SideOnly(Side.CLIENT)

    public void handleStatusUpdate(byte id)

    {

        if (id == 3)

        {

            for (int i = 0; i < 8; ++i)

            {

                this.world.spawnParticle(EnumParticleTypes.FLAME, this.posX, this.posY, this.posZ, 0.0D, 0.0D, 0.0D, new int[0]);

            }

        }

    }

 

    /**

    * Called when this EntityThrowable hits a block or entity.

    */

    protected void onImpact(RayTraceResult result)

    {

        if (result.entityHit != null)

        {

            int i = 0;

 

            if (result.entityHit instanceof EntityBlaze)

            {

                i = 3;

            }

 

            result.entityHit.attackEntityFrom(DamageSource.causeThrownDamage(this, this.getThrower()), 41.0F);

           

        }

 

        if (!this.world.isRemote)

        {

            this.world.setEntityState(this, (byte)3);

            world.setBlockState(new BlockPos(this.posX, this.posY, this.posZ), Blocks.FLOWING_LAVA.getDefaultState(), 3);

            this.setDead();

        }

    }

}

           

 

[hhggtg3279]

Thanks anyway, 1.11.2 screwed up all my entities and a range of other things, I just want a block to spawn every time the entity impacts a block, as my current method is inconsistent and just replaces blocks.

[Draco18s]

Change:

if (true) {

To:

if(world.getBlockState(new BlockPos(this.posX, this.posY, this.posZ)).getMaterial() == Material.AIR) {

 

And you can create one blockpos for the if-statement and the next line (the setBlock) as well.  And maybe you'll want a loop that checks a range of blocks.

[larsgerrits]

I think it might be better to use

Block#isReplaceable(...)

so you don't have to rely on the

Material

to be replaceable.

[hhggtg3279]

Through a bit of trial and error and using your help I managed to get the lava to spawn every time the projectile gits a block without replacing existing ones.

 

Here's my code if anyone else needs it:

 

package top.mod.item;

 

import net.minecraft.entity.EntityLivingBase;

import net.minecraft.entity.monster.EntityBlaze;

import net.minecraft.entity.projectile.EntityThrowable;

import net.minecraft.init.Blocks;

import net.minecraft.util.DamageSource;

import net.minecraft.util.EnumParticleTypes;

import net.minecraft.util.datafix.DataFixer;

import net.minecraft.util.math.BlockPos;

import net.minecraft.util.math.RayTraceResult;

import net.minecraft.world.World;

import net.minecraftforge.fml.relauncher.Side;

import net.minecraftforge.fml.relauncher.SideOnly;

 

public class EntityFirestaff extends EntityThrowable

{

    public EntityFirestaff(World worldIn)

    {

        super(worldIn);

    }

 

    public EntityFirestaff(World worldIn, EntityLivingBase throwerIn)

    {

        super(worldIn, throwerIn);

    }

 

    public EntityFirestaff(World worldIn, double x, double y, double z)

    {

        super(worldIn, x, y, z);

    }

 

    public static void registerFixesSnowball(DataFixer fixer)

    {

        EntityThrowable.registerFixesThrowable(fixer, "Snowball");

    }

 

    @SideOnly(Side.CLIENT)

    public void handleStatusUpdate(byte id)

    {

        if (id == 3)

        {

            for (int i = 0; i < 8; ++i)

            {

                this.world.spawnParticle(EnumParticleTypes.FLAME, this.posX, this.posY, this.posZ, 0.0D, 0.0D, 0.0D, new int[0]);

            }

        }

    }

 

    /**

    * Called when this EntityThrowable hits a block or entity.

    */

    protected void onImpact(RayTraceResult result)

    {

        if (result.entityHit != null)

        {

            int i = 0;

 

            if (result.entityHit instanceof EntityBlaze)

            {

                i = 3;

            }

 

            result.entityHit.attackEntityFrom(DamageSource.causeThrownDamage(this, this.getThrower()), 41.0F);

           

        }

 

        if (!this.world.isRemote)

        {

            this.world.setEntityState(this, (byte)3);

            world.setBlockState(new BlockPos(this.posX, this.posY, this.posZ), Blocks.FLOWING_LAVA.getDefaultState(), 3);

            this.setDead();

        }

    }

}