So I have just started to create mods and I have run into a large stumbling block, I can't figure out how to reference a tile entity through its' GUI and save it to NBT. The goal of this mod is to create, essentially survival command blocks, so this code should run the command you enter in the GUI by hitting the run button and it should save what you entered. Currently I can type different commands into different blocks and run them, but the NBT won't save correctly. I have found with the way that I have done it that the tile entity is in the correct position, but I seem to get different instances of the tile entity. This is strange to me though because I can see form debugging that they are in the same spot and that there is only single tile entity registered for each block I place. This causes my string called command to equal nothing when I try to write it to NBT. I could be wrong in some of these assumptions, but I hope this helps. Thanks!

TileEntityIronCommand.java

BlockIronCommand.java

guiCommandBlock.java

post your IGuiHander impl, as code not as download plz

 

in your IGuiHander impl you have a world and x y z you can get the tile from there and have your gui take a tile in its constructer

like so

public guiCommandBlock(TileEntityIronCommand tile)

and a field that holds the tile

Edited February 8, 20178 yr by loordgek

This is GUI handler that I have currently. Hope this helps.

 

package com.radar.spearmod.client.gui;

import com.radar.spearmod.tileentities.TileEntityIronCommand;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.world.World;
import net.minecraftforge.fml.common.network.IGuiHandler;

public class ModGuiHandler implements IGuiHandler{
    public static final int MOD_TILE_ENTITY_GUI = 0;
    @Override
    public Object getServerGuiElement(int ID, EntityPlayer player, World world, int x, int y, int z) {
        return null;
    }

    @Override
    public Object getClientGuiElement(int ID, EntityPlayer player, World world, int x, int y, int z) {
        if (ID == MOD_TILE_ENTITY_GUI) 
            return new guiCommandBlock(x, y, z);
        return null;
    }

}

 

Sorry about the downloads, I thought they would show up as text.

You probably shouldn't return null if you're trying to interact with the server side TileEntity

do you need a container for this ??

 

I have changed my code to include what you said Loordgek, and it still seems to be null before it saves the data to the block. I have been playing around with it and found a way that might work. I can get the block position of the tile entity through the tileEntity.pos, then can get the instance through the Minecraft world. This works when saving the data but then I have a new problem that on loading the World, the readFromNBT is called before the world is intialized causing a null pointer exception. I am not sure how to fix this since readFromNBT is called by minecraft and I can't call it again after the world is created.

That or packets.

Probably packets. The server side container only handles items.

Edited February 8, 20178 yr by Draco18s

Sorry about the blank post, I am apparently really bad at using this forum (3rd try at writing this). Anyway I have done what you said Loordgek and have found that it still doesn't work, but I was playing around with it and found a way to do it possibly. So I can get the correct instance of the tile entity by using tileEntity.pos and I can use the Minecraft world to get the tile entity from position. This works for saving the data, but when starting the world the readFromNBT is called before the world is loaded so I get a null pointer because the world isn't created. I don't know how to fix this because I can recall readFromNBT because only Minecraft can do that. I hope this helps, thanks!

Solved I have to use

ctx.getServerHandler().playerEntity.worldObj.getTileEntity(tilePos);

 

So I have been working on trying to do this with packets, I have made a packet to send to the server and that works, but how do I set the command from the packet handler? Right now I have been trying to set the command by sending the coordinates to the packet handler and having it find the tile entity instance through

Minecraft.getMinecraft().theWorld.getTileEntity(pos);

But that still seems to get a different instance of the tile entity...

I am registering the message through the server side which I believe is correct because I want to get the data to the server, but I just am not sure how else to do this. Thanks for any help.

 

CommandMessage.java

package com.radar.spearmod.packages;

import com.radar.spearmod.tileentities.TileEntityIronCommand;

import io.netty.buffer.ByteBuf;
import net.minecraftforge.fml.common.network.ByteBufUtils;
import net.minecraftforge.fml.common.network.simpleimpl.IMessage;

public class CommandMessage implements IMessage{
	int i = 0;
	private String command;
	private int xPos, yPos, zPos;

	public CommandMessage () {}
	
	public CommandMessage(String command, int xPos, int yPos, int zPos){
		System.out.println(command);
		this.setCommand(command);
		this.setxPos(xPos);
		this.setyPos(yPos);
		this.setzPos(zPos);
	}

	@Override
	public void fromBytes(ByteBuf buf) {
		System.out.println("From bytes");
		this.command = ByteBufUtils.readUTF8String(buf);
		System.out.println("Test");
		this.xPos = buf.readInt();
		this.yPos = buf.readInt();
		this.zPos = buf.readInt();
		System.out.println(getxPos()+" "+getyPos()+" "+getzPos());
	}

	@Override
	public void toBytes(ByteBuf buf) {
		System.out.println("To bytes");
		ByteBufUtils.writeUTF8String(buf, this.command);
		buf.writeInt(xPos);
		buf.writeInt(yPos);
		buf.writeInt(zPos);
	}

	public String getCommand() {
		return command;
	}

	public void setCommand(String command) {
		this.command = command;
	}

	public int getxPos() {
		return xPos;
	}

	public void setxPos(int xPos) {
		this.xPos = xPos;
	}

	public int getyPos() {
		return yPos;
	}

	public void setyPos(int yPos) {
		this.yPos = yPos;
	}

	public int getzPos() {
		return zPos;
	}

	public void setzPos(int zPos) {
		this.zPos = zPos;
	}
}

 

MessageHandler.java

package com.radar.spearmod.packages;

import com.radar.spearmod.tileentities.TileEntityIronCommand;

import net.minecraft.client.Minecraft;
import net.minecraft.util.IThreadListener;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.WorldServer;
import net.minecraftforge.fml.common.network.simpleimpl.IMessage;
import net.minecraftforge.fml.common.network.simpleimpl.IMessageHandler;
import net.minecraftforge.fml.common.network.simpleimpl.MessageContext;

public class MessageHandler implements IMessageHandler <CommandMessage, IMessage>{

	@Override
	public IMessage onMessage(CommandMessage message, MessageContext ctx) {
		final String command = message.getCommand();
		final int x = message.getxPos();
		final int y = message.getyPos();
		final int z = message.getzPos();
		IThreadListener mainThread = (WorldServer) ctx.getServerHandler().playerEntity.worldObj;
		mainThread.addScheduledTask(new Runnable() {

			@Override
			public void run() {

				System.out.println("What I am sending : "+command+" "+x+" "+y+" "+z);
				
				BlockPos tilePos = new BlockPos(x,y,z);

				TileEntityIronCommand tile = (TileEntityIronCommand) Minecraft.getMinecraft().theWorld.getTileEntity(tilePos);

				System.out.println(tile.toString());
				tile.setCommand(command);
			}
		});
		return null;
	}

}

 

Edited February 13, 20178 yr by Radar6255
Solved