Jump to content

Referencing Tile Entity through GUI


Radar6255

Recommended Posts

So I have just started to create mods and I have run into a large stumbling block, I can't figure out how to reference a tile entity through its' GUI and save it to NBT. The goal of this mod is to create, essentially survival command blocks, so this code should run the command you enter in the GUI by hitting the run button and it should save what you entered. Currently I can type different commands into different blocks and run them, but the NBT won't save correctly. I have found with the way that I have done it that the tile entity is in the correct position, but I seem to get different instances of the tile entity. This is strange to me though because I can see form debugging that they are in the same spot and that there is only single tile entity registered for each block I place. This causes my string called command to equal nothing when I try to write it to NBT. I could be wrong in some of these assumptions, but I hope this helps. Thanks!

TileEntityIronCommand.java

BlockIronCommand.java

guiCommandBlock.java

Link to comment
Share on other sites

post your IGuiHander impl, as code not as download plz

 

in your IGuiHander impl you have a world and x y z you can get the tile from there and have your gui take a tile in its constructer

like so

public guiCommandBlock(TileEntityIronCommand tile)

and a field that holds the tile

Edited by loordgek
Link to comment
Share on other sites

This is GUI handler that I have currently. Hope this helps.

 

package com.radar.spearmod.client.gui;

import com.radar.spearmod.tileentities.TileEntityIronCommand;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.world.World;
import net.minecraftforge.fml.common.network.IGuiHandler;

public class ModGuiHandler implements IGuiHandler{
    public static final int MOD_TILE_ENTITY_GUI = 0;
    @Override
    public Object getServerGuiElement(int ID, EntityPlayer player, World world, int x, int y, int z) {
        return null;
    }

    @Override
    public Object getClientGuiElement(int ID, EntityPlayer player, World world, int x, int y, int z) {
        if (ID == MOD_TILE_ENTITY_GUI) 
            return new guiCommandBlock(x, y, z);
        return null;
    }

}

 

Sorry about the downloads, I thought they would show up as text.

Link to comment
Share on other sites

You probably shouldn't return null if you're trying to interact with the server side TileEntity

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

I have changed my code to include what you said Loordgek, and it still seems to be null before it saves the data to the block. I have been playing around with it and found a way that might work. I can get the block position of the tile entity through the tileEntity.pos, then can get the instance through the Minecraft world. This works when saving the data but then I have a new problem that on loading the World, the readFromNBT is called before the world is intialized causing a null pointer exception. I am not sure how to fix this since readFromNBT is called by minecraft and I can't call it again after the world is created.
Link to comment
Share on other sites

That or packets.

Probably packets. The server side container only handles items.

Edited by Draco18s

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Sorry about the blank post, I am apparently really bad at using this forum (3rd try at writing this). Anyway I have done what you said Loordgek and have found that it still doesn't work, but I was playing around with it and found a way to do it possibly. So I can get the correct instance of the tile entity by using tileEntity.pos and I can use the Minecraft world to get the tile entity from position. This works for saving the data, but when starting the world the readFromNBT is called before the world is loaded so I get a null pointer because the world isn't created. I don't know how to fix this because I can recall readFromNBT because only Minecraft can do that. I hope this helps, thanks!

Link to comment
Share on other sites

Solved I have to use

ctx.getServerHandler().playerEntity.worldObj.getTileEntity(tilePos);

 

So I have been working on trying to do this with packets, I have made a packet to send to the server and that works, but how do I set the command from the packet handler? Right now I have been trying to set the command by sending the coordinates to the packet handler and having it find the tile entity instance through

Minecraft.getMinecraft().theWorld.getTileEntity(pos);

But that still seems to get a different instance of the tile entity...

I am registering the message through the server side which I believe is correct because I want to get the data to the server, but I just am not sure how else to do this. Thanks for any help.

 

CommandMessage.java

package com.radar.spearmod.packages;

import com.radar.spearmod.tileentities.TileEntityIronCommand;

import io.netty.buffer.ByteBuf;
import net.minecraftforge.fml.common.network.ByteBufUtils;
import net.minecraftforge.fml.common.network.simpleimpl.IMessage;

public class CommandMessage implements IMessage{
	int i = 0;
	private String command;
	private int xPos, yPos, zPos;

	public CommandMessage () {}
	
	public CommandMessage(String command, int xPos, int yPos, int zPos){
		System.out.println(command);
		this.setCommand(command);
		this.setxPos(xPos);
		this.setyPos(yPos);
		this.setzPos(zPos);
	}

	@Override
	public void fromBytes(ByteBuf buf) {
		System.out.println("From bytes");
		this.command = ByteBufUtils.readUTF8String(buf);
		System.out.println("Test");
		this.xPos = buf.readInt();
		this.yPos = buf.readInt();
		this.zPos = buf.readInt();
		System.out.println(getxPos()+" "+getyPos()+" "+getzPos());
	}

	@Override
	public void toBytes(ByteBuf buf) {
		System.out.println("To bytes");
		ByteBufUtils.writeUTF8String(buf, this.command);
		buf.writeInt(xPos);
		buf.writeInt(yPos);
		buf.writeInt(zPos);
	}

	public String getCommand() {
		return command;
	}

	public void setCommand(String command) {
		this.command = command;
	}

	public int getxPos() {
		return xPos;
	}

	public void setxPos(int xPos) {
		this.xPos = xPos;
	}

	public int getyPos() {
		return yPos;
	}

	public void setyPos(int yPos) {
		this.yPos = yPos;
	}

	public int getzPos() {
		return zPos;
	}

	public void setzPos(int zPos) {
		this.zPos = zPos;
	}
}

 

MessageHandler.java

package com.radar.spearmod.packages;

import com.radar.spearmod.tileentities.TileEntityIronCommand;

import net.minecraft.client.Minecraft;
import net.minecraft.util.IThreadListener;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.WorldServer;
import net.minecraftforge.fml.common.network.simpleimpl.IMessage;
import net.minecraftforge.fml.common.network.simpleimpl.IMessageHandler;
import net.minecraftforge.fml.common.network.simpleimpl.MessageContext;

public class MessageHandler implements IMessageHandler <CommandMessage, IMessage>{

	@Override
	public IMessage onMessage(CommandMessage message, MessageContext ctx) {
		final String command = message.getCommand();
		final int x = message.getxPos();
		final int y = message.getyPos();
		final int z = message.getzPos();
		IThreadListener mainThread = (WorldServer) ctx.getServerHandler().playerEntity.worldObj;
		mainThread.addScheduledTask(new Runnable() {

			@Override
			public void run() {

				System.out.println("What I am sending : "+command+" "+x+" "+y+" "+z);
				
				BlockPos tilePos = new BlockPos(x,y,z);

				TileEntityIronCommand tile = (TileEntityIronCommand) Minecraft.getMinecraft().theWorld.getTileEntity(tilePos);

				System.out.println(tile.toString());
				tile.setCommand(command);
			}
		});
		return null;
	}

}

 

Edited by Radar6255
Solved
Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • we tried both versions and both cant run on her laptop for some reason idk what to do  
    • Okay so we tried both versions and both cant run on her pc for some reason!  
    • Well. Make sure you installed a correct jdk for your forge mdk version. Make sure your JAVA_HOME and %PATH% environment-variables are setup correctly. (If you're on windows)   I downloaded an example forge mdk for my version and extracted the contents to a folder I'm working in Using Eclipse, I opened Eclipse and imported an existing gradle Project (with its root directory in the folder directory which I previously extracted my contents to). Waited for Eclipse to do its thing After it having finished, I ran genEclipseRuns, setupDecompWorkspace and setupDevWorkspace (Gradle Tasks > your mod name here > forgegradle)    If it still didn't work (and you're using Eclipse) run cleanEclipse and, in a command prompt  Also If I recall correctly, someone, somewhere said that the way you setup your workspace changes depending on your Minecraft Version. I did this in 1.8.9.
    • https://mclo.gs/ZlRMU4G Still crash, help 
    • Hi, im having problem with error: Could not resolve dependency: net.minecraftforge:forge:1.20.1:userdev   im new in modding, but i tried everything, and it is still not working. all versions are correct etc.   build gradle: plugins {     id 'eclipse'     id 'idea'     id 'maven-publish'     id 'net.minecraftforge.gradle' version '[6.0,6.2)'     id 'org.parchmentmc.librarian.forgegradle' version '1.+' } version = mod_version group = mod_group_id base {     archivesName = mod_id } // Mojang ships Java 17 to end users in 1.18+, so your mod should target Java 17. java.toolchain.languageVersion = JavaLanguageVersion.of(17) println "Java: ${System.getProperty 'java.version'}, JVM: ${System.getProperty 'java.vm.version'} (${System.getProperty 'java.vendor'}), Arch: ${System.getProperty 'os.arch'}" minecraft {     // See more information here: https://github.com/MinecraftForge/MCPConfig/blob/master/Mojang.md     // Additional setup is needed to use their mappings: https://parchmentmc.org/docs/getting-started     mappings channel: mapping_channel, version: mapping_version          copyIdeResources = true          runs {         // applies to all the run configs below         configureEach {             workingDirectory project.file('run')             property 'forge.logging.markers', 'REGISTRIES'             // Please read: https://stackoverflow.com/questions/2031163/when-to-use-the-different-log-levels             property 'forge.logging.console.level', 'debug'             mods {                 "${mod_id}" {                     source sourceSets.main                 }             }         }         client {             // Comma-separated list of namespaces to load gametests from. Empty = all namespaces.             property 'forge.enabledGameTestNamespaces', mod_id         }         server {             property 'forge.enabledGameTestNamespaces', mod_id             args '--nogui'         }                  gameTestServer {             property 'forge.enabledGameTestNamespaces', mod_id         }         data {             workingDirectory project.file('run-data')                          args '--mod', mod_id, '--all', '--output', file('src/generated/resources/'), '--existing', file('src/main/resources/')         }     } } // Include resources generated by data generators. sourceSets.main.resources { srcDir 'src/generated/resources' } repositories { } dependencies {     minecraft "net.minecraftforge:forge:1.20.1" } tasks.named('processResources', ProcessResources).configure {     var replaceProperties = [             minecraft_version: minecraft_version, minecraft_version_range: minecraft_version_range,             forge_version: forge_version, forge_version_range: forge_version_range,             loader_version_range: loader_version_range,             mod_id: mod_id, mod_name: mod_name, mod_license: mod_license, mod_version: mod_version,             mod_authors: mod_authors, mod_description: mod_description,     ]     inputs.properties replaceProperties     filesMatching(['META-INF/mods.toml', 'pack.mcmeta']) {         expand replaceProperties + [project: project]     } } // Example for how to get properties into the manifest for reading at runtime. tasks.named('jar', Jar).configure {     manifest {         attributes([                 'Specification-Title'     : mod_id,                 'Specification-Vendor'    : mod_authors,                 'Specification-Version'   : '1', // We are version 1 of ourselves                 'Implementation-Title'    : project.name,                 'Implementation-Version'  : project.jar.archiveVersion,                 'Implementation-Vendor'   : mod_authors,                 'Implementation-Timestamp': new Date().format("yyyy-MM-dd'T'HH:mm:ssZ")         ])     }     // This is the preferred method to reobfuscate your jar file     finalizedBy 'reobfJar' } publishing {     publications {         register('mavenJava', MavenPublication) {             artifact jar         }     }     repositories {         maven {             url "file://${project.projectDir}/mcmodsrepo"         }     } } tasks.withType(JavaCompile).configureEach {     options.encoding = 'UTF-8' // Use the UTF-8 charset for Java compilation }       please help me out
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.