Event transformer NPE on downloaded classes

[keepcalm]

My mod downloads libraries, and as of recent forge builds, I've been getting reports of issues in which EventTransformer throws a NullPointerException for some reason.

 

The reports can be found here and here

[LexManos]

Wherever you're putting these libraries are not in the classpath, and therefor the classes can not be found.

I should probably toss a null check in there, but.. eah..

[keepcalm]

But I'm downloading them using FML's hooks... Returning ILibrarySets from the loading plugin. So is FML misbehaving or did I screw up something?

 

EDIT: it was them misplacing the mod...

[manawyrm]

Hello keepcalm,

 

in ForgeEventHandler.java your function onPlayerInteraction checks whether it runs on the Client.

 

you do that like this:

	public void onPlayerInteraction(final PlayerInteractEvent ev) {
	if (!ready|| Side.CLIENT.isClient())

 

Side.CLIENT.isClient() does ALWAYS return true!

 

Why are you doing this? This looks extremly strange. Especially when you consider that your code is always killed at that point via the return; statement.

 

Please have a look into this!

 

Thanks,

Tobias (manawyrm@github)