[1.11.2] Make item stay in crafting and decrease durability

[Villfuk02]

I want my item to stay in crafting and decrease its durability when used in recipe - not just be consumed

how can i do it?

[Draco18s]

Override hasContainerItem and getContainerItem

[Villfuk02]

and what do i do in these methods?

[Draco18s]

Should be obvious. The first one you want to return true and in the second one you want to take the item stack passed in, damage it, and return it.

[Villfuk02]

WAT?
still doesn't work:

public class QuartzKnife extends Item {
	
	public QuartzKnife(String unlocalizedName){
		this.setUnlocalizedName(unlocalizedName);
		this.setRegistryName(new ResourceLocation(Reference.MODID, unlocalizedName));
		this.setMaxStackSize(1);
		this.setMaxDamage(256);
	}
	
	@Override
	public boolean hasContainerItem(ItemStack stack) {		
		return true;
	}
	
	@Override
	public ItemStack getContainerItem(ItemStack itemStack) {
		itemStack.setItemDamage(itemStack.getItemDamage() + 1);
		return super.getContainerItem(itemStack);
	}
}

 

[Choonster]

That's not what Draco told you to do.

 

You damage the ItemStack, but then you return the result of the super method (a completely separate ItemStack). The original ItemStack that you damaged is ignored.

 

You need to return the ItemStack that you damaged.

[Jay Avery]

5 minutes ago, Villfuk02 said:

WAT?
still doesn't work:

public class QuartzKnife extends Item {
	
	public QuartzKnife(String unlocalizedName){
		this.setUnlocalizedName(unlocalizedName);
		this.setRegistryName(new ResourceLocation(Reference.MODID, unlocalizedName));
		this.setMaxStackSize(1);
		this.setMaxDamage(256);
	}
	
	@Override
	public boolean hasContainerItem(ItemStack stack) {		
		return true;
	}
	
	@Override
	public ItemStack getContainerItem(ItemStack itemStack) {
		itemStack.setItemDamage(itemStack.getItemDamage() + 1);
		return super.getContainerItem(itemStack);
	}
}

 

You are returning super.getContainerItem, which is null.

[Villfuk02]

Well, i'm stupid
how could i overlook that!?
 

Edited February 16, 2017 by Villfuk02

[Tschipp]

I was just about to ask the same question, but then I saw this thread.

This all works for me, but after i've used the item once in crafting (meaning its damaged), I can no longer use it.

Note that I am using a shapeless OreDict recipe.

[Choonster]

6 minutes ago, Tschipp said:

I was just about to ask the same question, but then I saw this thread.

This all works for me, but after i've used the item once in crafting (meaning its damaged), I can no longer use it.

Note that I am using a shapeless OreDict recipe.

 

You're probably using 0 as the ingredient's metadata when adding the recipe, so only metadata 0 is accepted. Use OreDictionary.WILDCARD_VALUE to accept any metadata value.

[Tschipp]

1 minute ago, Choonster said:

 

You're probably using 0 as the ingredient's metadata when adding the recipe, so only metadata 0 is accepted. Use OreDictionary.WILDCARD_VALUE to accept any metadata value.

Nope, as I mentioned, I'm using a oreDictionary entry, in this case "listAllwater"

[Choonster]

Just now, Tschipp said:

Nope, as I mentioned, I'm using a oreDictionary entry, in this case "listAllwater"

 

You mentioned an ore recipe, but you didn't mention that the ingredient was an ore dictionary entry.

 

In that case, you need to use OreDictionary.WILDCARD_VALUE when adding your item to the ore dictionary.

[Tschipp]

1 minute ago, Choonster said:

 

You mentioned an ore recipe, but you didn't mention that the ingredient was an ore dictionary entry.

 

In that case, you need to use OreDictionary.WILDCARD_VALUE when adding your item to the ore dictionary.

Ah I see, sorry I wasn't clear enough.

[Tschipp]

I have one more unrelated question that is not worth opening an entire new thread:

How do you damage/repair an item if the player is in creative mode?

[Choonster]

2 minutes ago, Tschipp said:

I have one more unrelated question that is not worth opening an entire new thread:

How do you damage/repair an item if the player is in creative mode?

 

Create your own copy of the ItemStack#damageItem method without the creative mode check.

[Tschipp]

4 minutes ago, Choonster said:

 

Create your own copy of the ItemStack#damageItem method without the creative mode check.

I am currently using the ItemStack#setItemDamage method, but there still seems to be some sort of creative mode check somewhere, as the item isn't damageable while in creative mode.

Where is this check even happening?

[Draco18s]

22 minutes ago, Tschipp said:

I am currently using the ItemStack#setItemDamage method, but there still seems to be some sort of creative mode check somewhere, as the item isn't damageable while in creative mode.

Where is this check even happening?

Inside the ItemStack class.  IIRC, If the entity passed in is null, that check can't be made (because there is no entity, and the damage just happens).

[Tschipp]

2 hours ago, Draco18s said:

Inside the ItemStack class.  IIRC, If the entity passed in is null, that check can't be made (because there is no entity, and the damage just happens).

No, it crashes with a null pointer. I guess I'll try making it any arbitrary entity, like an EntityPig

Edited February 16, 2017 by Tschipp

[Tschipp]

It somehow still does a creative mode check, even when using a entityPig as the argument... There must be a simpler way to damage an item in creative mode...

 

You know what, I'll just open a new thread for it.

Edited February 16, 2017 by Tschipp

[Zamion101]

I have 2 little question;

I created Item which contains subItems (4 different type) and this subItems has colorMultiplier.

Firstly i want to get different ItemDurability per subItem, how can i do? 

Secondly i want to subItems stay in crafting table but descrease durability is it possible with subItems? if is what should i do?

 

Edit:

I Also try to use hasContainerItem and getContainerItem methods but when i used this methods returns my subItems rather than changing durability.

Edited January 18, 2019 by Zamion101

[Legenes]

EDIT: I was blind. Nevermind.

Edited January 18, 2019 by Legenes

[Legenes]

20 minutes ago, Zamion101 said:

I have 2 little question;

I created Item which contains subItems (4 different type) and this subItems has colorMultiplier.

Firstly i want to get different ItemDurability per subItem, how can i do? 

Secondly i want to subItems stay in crafting table but descrease durability is it possible with subItems? if is what should i do?

 

Edit:

I Also try to use hasContainerItem and getContainerItem methods but when i used this methods returns my subItems rather than changing durability. 

Please don't change a post's topic. If you have a problem like that, than just make another post.