LivingDeathEvent not firing

[Checkium]

I'm trying to make a JFrame that will log all players kills, but the LivingDeathEvent is not firing.

 

Main class:

package me.checkium.pvplog;
import java.awt.FlowLayout;
import javax.swing.JFrame;
import javax.swing.JLabel;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraftforge.common.MinecraftForge;
import net.minecraftforge.event.entity.living.LivingDeathEvent;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.common.Mod.EventHandler;
import net.minecraftforge.fml.common.event.FMLInitializationEvent;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;
@Mod(modid = ExampleMod.MODID, version = ExampleMod.VERSION)
public class PvPLog
{
 public static final String MODID = "pvplog";
 public static final String VERSION = "1.0";
 JFrame frame;
 @EventHandler
 public void init(FMLInitializationEvent event)
 {
 MinecraftForge.EVENT_BUS.register(new EventKill(frame));
 frame = new JFrame();
 frame.getContentPane().setLayout(new FlowLayout());
 frame.setVisible(true);
 frame.setDefaultCloseOperation(JFrame.DO_NOTHING_ON_CLOSE);
 frame.setSize(500, 500);
 
 System.out.println("Loaded");
 }
 
 
}
 

 

EventKill:

 package me.checkium.pvplog;
import javax.swing.JFrame;
import javax.swing.JLabel;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraftforge.event.entity.living.LivingDeathEvent;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;
public class EventKill {
JFrame frame;

public EventKill(JFrame framee) {
frame = framee;
}
@SubscribeEvent
public void kill(LivingDeathEvent e) {
System.out.println("Event");
if (e.getSource().getEntity() instanceof EntityPlayer && e.getEntity() instanceof EntityPlayer) {
System.out.println("Player");
JLabel label = new JLabel(e.getSource().getEntity().getName() + " killed " + e.getEntity().getName());
frame.add(label);
}
}

}

[Draco18s]

 MinecraftForge.EVENT_BUS.register(new EventKill(frame));

Hmm, what's this frame object, looking up...

 JFrame frame;

Oh, it's null. Got it.

Edited February 26, 2017 by Draco18s

[Checkium]

@Draco18sThat was a test, even after frame declaration it doesn't work.

[Checkium]

Seems that it works fine on singleplayer

[Draco18s]

Well, yes.  The dedicated server has no idea what a JFrame is.

[Checkium]

1 minute ago, Draco18s said:

Well, yes.  The dedicated server has no idea what a JFrame is.

 

I'm trying to use it in a multiplayer vanilla server, and it isn't working. The mod is client-side only.

[Draco18s]

Does the death event actually fire client-side? (for non-this-client-player entities, that is) I'm not sure it does.

Edited February 27, 2017 by Draco18s

[Checkium]

@Draco18syhea, I dont think so, what could I use instead? I don't care if it only logs rendered players.

[Checkium]

@diesieben07Would there be any way that when any entity is removed it would get all nearby players?

Also, is it possible to check the item in the player's hand when it changes?

[ModderInTraining]

How do you check the item in hand?

i am trying to make an achievement that requires you to be holding two specific items while wearing certain armor. I have figured out the armor portion.

 

[Jay Avery]

4 hours ago, ModderInTraining said:

How do you check the item in hand?

 

EntityPlayer#getHeldItem(EnumHand)