[1.11.2]WorldSavedData issues

[BeardlessBrady]

So I'm trying to make my own WorldSavedData. Not quite sure what I'm doing wrong but this is the error I get when I attempt to get data:

http://pastebin.com/aWWXhpj1

 

WorldSavedData: https://github.com/BeardlessBrady/Currency-Mod/blob/master-1.11/src/main/java/gunn/modcurrency/mod/core/data/BankAccountSavedData.java

Data Saved: https://github.com/BeardlessBrady/Currency-Mod/blob/master-1.11/src/main/java/gunn/modcurrency/mod/core/data/BankAccount.java

Testing when Block Activated here: https://github.com/BeardlessBrady/Currency-Mod/blob/master-1.11/src/main/java/gunn/modcurrency/mod/block/BlockATM.java

 

 

[Choonster]

[06:52:29] [Server thread/INFO]: [STDERR]: java.lang.RuntimeException: Failed to instantiate class gunn.modcurrency.mod.core.data.BankAccountSavedData

...
[06:52:29] [Server thread/INFO]: [STDERR]: Caused by: java.lang.NoSuchMethodException: gunn.modcurrency.mod.core.data.BankAccountSavedData.<init>(java.lang.String)

 

Your WorldSavedData class must have a constructor that takes a single String argument.

[BeardlessBrady]

Interesting, yes that has fixed the current issue. Thanks Choonster

[BeardlessBrady]

So I can grab the data but if I restart the world the data is reset. Am I not saving it correctly?

[Choonster]

Are there any errors in the log?

[BeardlessBrady]

Nope. When I grab the SavedData it just gives me a fresh instance

Edited March 25, 2017 by BeardlessBrady

[BeardlessBrady]

In the Block Activated I would add a test account, run it, then comment it out. Then I would get the account and I could get it fine. Once I restart the world and try to get the account again it would be empty. The set Account statement I used is commented out here: https://github.com/BeardlessBrady/Currency-Mod/blob/master-1.11/src/main/java/gunn/modcurrency/mod/block/BlockATM.java#L70

[BeardlessBrady]

Yes it is

[BeardlessBrady]

Yes it's called

[BeardlessBrady]

So I tried making two different accounts and the array when I reload the world has a size of 2. But it isn't saving the information in the account correctly. All it outputs for both is " :0"

[BeardlessBrady]

...Omg...I derped lol, thanks for helping me find my mistake!

[BeardlessBrady]

So what is the best way to sync server WorldSavedData to client?

[Draco18s]

Packets.

[Choonster]

7 minutes ago, BeardlessBrady said:

So what is the best way to sync server WorldSavedData to client?

 

Which clients need which data and when?

 

If a client always needs to know a particular value (e.g to render it on a HUD), send a packet to any relevant players when they log in and when the value changes.

 

If a client only needs to know the value in a GUI, you can probably sync it through the Container (either using the built-in syncing packets or your own).

 

If a bank account is only ever linked to one player, consider storing a player's bank account(s) in a player Capability instead of using World Saved Data.

[BeardlessBrady]

Well I was going to store it in the player but I plan on adding ComputerCraft integration so computers can make accounts so I figured it was the best. Anywho I just wanted to double check that packets was the way, thanks