TheTrollguy_ Posted April 11, 2017 Posted April 11, 2017 Hello again In my mod, I have a 'property' called placement mode (it's just a custom object) that, as the name says, determines how a block is going to be placed, aka what properties should be set when placed in that mode. If I were to make this mod Client-Only, there wouldn't be any problems, however, I want this mod to be run on servers too and this is a client-specific property. What I want to do with it is send its ID to the server when a player tries to place the block right before the block itself is placed(or the code for the placement is run). So how could I accomplish that? Quote
Jay Avery Posted April 11, 2017 Posted April 11, 2017 I don't fully understand your issue. Can you explain your aim in gameplay terms, instead of describing how you want to code it? Quote
TheTrollguy_ Posted April 11, 2017 Author Posted April 11, 2017 So, you're in the world, and you have one of my slabs in your hands. On the top left part of the screen, it says e.g. horizontal mode. This enables you to place a normal slab, and an upside-down slab. You click F9, and the mode switches to vertical mode. This enables you to place vertical slabs facing where you're facing. You click F9 and it switches to another mode called axis, and then the next one random and so on. I hope I explained it well. Quote
Jay Avery Posted April 11, 2017 Posted April 11, 2017 Got it! I think you'll need to give the player a capability to keep track of the property. (The forge docs has information about capabilities if you're not familiar with the system). Then, when your custom block is placed, you check the player's capability and define the behaviour depending on the property. If your blocks are placed with ordinary ItemBlocks, then you can override Block#getStateForPlacement and it will be handled by vanilla ItemBlock behaviour. If it's a custom item then you'll probably need to override Item#onItemUse to manually place the block with the appropriate state. 1 Quote
TheTrollguy_ Posted April 13, 2017 Author Posted April 13, 2017 Everything seems to be going fine for now. Now, I've read that the capability gets reset when a player dies and it says I should do it through an event. So which one should I use, because the tutorial I was looking at s using an old version and that event doesn't exist in the current version. Basically I should have an entity before death and after death or something like that. All in all I don't know how to copy that.... Quote
Choonster Posted April 14, 2017 Posted April 14, 2017 5 hours ago, TheTrollguy_ said: Everything seems to be going fine for now. Now, I've read that the capability gets reset when a player dies and it says I should do it through an event. So which one should I use, because the tutorial I was looking at s using an old version and that event doesn't exist in the current version. Basically I should have an entity before death and after death or something like that. All in all I don't know how to copy that.... PlayerCloneEvent is fired when a copy of a player is created before they respawn. Use this to copy data from the old player to the new one. 1 Quote Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.
TheTrollguy_ Posted April 16, 2017 Author Posted April 16, 2017 Happy Easter to anyone who's reading this! Thanks, @diesieben07, will do that later. I'm getting headaches from these capabilities. I don't fully understand them aand I've got another problem. Here the crash log: Spoiler [01:00:10] [Server thread/ERROR] [FML]: Exception caught during firing event net.minecraftforge.event.AttachCapabilitiesEvent$Entity@750ad0e: java.lang.IllegalStateException: Duplicate Capability Key: betterslabsmod:placement_mode tt.betterslabsmod.capability.placementmode.PlacementModeProvider@4641d06a at net.minecraftforge.event.AttachCapabilitiesEvent.addCapability(AttachCapabilitiesEvent.java:77) ~[AttachCapabilitiesEvent.class:?] at tt.betterslabsmod.event.BSMCapabilityHandler.attachCapability(BSMCapabilityHandler.java:22) ~[BSMCapabilityHandler.class:?] at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_6_BSMCapabilityHandler_attachCapability_AttachCapabilitiesEvent.invoke(.dynamic) ~[?:?] at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:90) ~[ASMEventHandler.class:?] at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:185) [EventBus.class:?] at net.minecraftforge.event.ForgeEventFactory.gatherCapabilities(ForgeEventFactory.java:576) [ForgeEventFactory.class:?] at net.minecraftforge.event.ForgeEventFactory.gatherCapabilities(ForgeEventFactory.java:558) [ForgeEventFactory.class:?] at net.minecraft.entity.Entity.<init>(Entity.java:258) [Entity.class:?] at net.minecraft.entity.EntityLivingBase.<init>(EntityLivingBase.java:197) [EntityLivingBase.class:?] at net.minecraft.entity.player.EntityPlayer.<init>(EntityPlayer.java:181) [EntityPlayer.class:?] at net.minecraft.entity.player.EntityPlayerMP.<init>(EntityPlayerMP.java:166) [EntityPlayerMP.class:?] at net.minecraft.server.management.PlayerList.createPlayerForUser(PlayerList.java:512) [PlayerList.class:?] at net.minecraft.server.network.NetHandlerLoginServer.tryAcceptPlayer(NetHandlerLoginServer.java:141) [NetHandlerLoginServer.class:?] at net.minecraft.server.network.NetHandlerLoginServer.update(NetHandlerLoginServer.java:68) [NetHandlerLoginServer.class:?] at net.minecraft.network.NetworkManager.processReceivedPackets(NetworkManager.java:308) [NetworkManager.class:?] at net.minecraft.network.NetworkSystem.networkTick(NetworkSystem.java:195) [NetworkSystem.class:?] at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:817) [MinecraftServer.class:?] at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:698) [MinecraftServer.class:?] at net.minecraft.server.integrated.IntegratedServer.tick(IntegratedServer.java:156) [IntegratedServer.class:?] at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:547) [MinecraftServer.class:?] at java.lang.Thread.run(Unknown Source) [?:1.8.0_101] [01:00:10] [Server thread/ERROR] [FML]: Index: 2 Listeners: [01:00:10] [Server thread/ERROR] [FML]: 0: NORMAL [01:00:10] [Server thread/ERROR] [FML]: 1: ASM: tt.betterslabsmod.event.BSMCapabilityHandler@6ed1fdb7 attachCapability(Lnet/minecraftforge/event/AttachCapabilitiesEvent;)V [01:00:10] [Server thread/ERROR] [FML]: 2: ASM: tt.betterslabsmod.event.BSMCapabilityHandler@431dc52b attachCapability(Lnet/minecraftforge/event/AttachCapabilitiesEvent;)V [01:00:10] [Server thread/ERROR]: Encountered an unexpected exception net.minecraft.util.ReportedException: Ticking memory connection at net.minecraft.network.NetworkSystem.networkTick(NetworkSystem.java:210) ~[NetworkSystem.class:?] at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:817) ~[MinecraftServer.class:?] at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:698) ~[MinecraftServer.class:?] at net.minecraft.server.integrated.IntegratedServer.tick(IntegratedServer.java:156) ~[IntegratedServer.class:?] at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:547) [MinecraftServer.class:?] at java.lang.Thread.run(Unknown Source) [?:1.8.0_101] Caused by: java.lang.IllegalStateException: Duplicate Capability Key: betterslabsmod:placement_mode tt.betterslabsmod.capability.placementmode.PlacementModeProvider@4641d06a at net.minecraftforge.event.AttachCapabilitiesEvent.addCapability(AttachCapabilitiesEvent.java:77) ~[AttachCapabilitiesEvent.class:?] at tt.betterslabsmod.event.BSMCapabilityHandler.attachCapability(BSMCapabilityHandler.java:22) ~[BSMCapabilityHandler.class:?] at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_6_BSMCapabilityHandler_attachCapability_AttachCapabilitiesEvent.invoke(.dynamic) ~[?:?] at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:90) ~[ASMEventHandler.class:?] at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:185) ~[EventBus.class:?] at net.minecraftforge.event.ForgeEventFactory.gatherCapabilities(ForgeEventFactory.java:576) ~[ForgeEventFactory.class:?] at net.minecraftforge.event.ForgeEventFactory.gatherCapabilities(ForgeEventFactory.java:558) ~[ForgeEventFactory.class:?] at net.minecraft.entity.Entity.<init>(Entity.java:258) ~[Entity.class:?] at net.minecraft.entity.EntityLivingBase.<init>(EntityLivingBase.java:197) ~[EntityLivingBase.class:?] at net.minecraft.entity.player.EntityPlayer.<init>(EntityPlayer.java:181) ~[EntityPlayer.class:?] at net.minecraft.entity.player.EntityPlayerMP.<init>(EntityPlayerMP.java:166) ~[EntityPlayerMP.class:?] at net.minecraft.server.management.PlayerList.createPlayerForUser(PlayerList.java:512) ~[PlayerList.class:?] at net.minecraft.server.network.NetHandlerLoginServer.tryAcceptPlayer(NetHandlerLoginServer.java:141) ~[NetHandlerLoginServer.class:?] at net.minecraft.server.network.NetHandlerLoginServer.update(NetHandlerLoginServer.java:68) ~[NetHandlerLoginServer.class:?] at net.minecraft.network.NetworkManager.processReceivedPackets(NetworkManager.java:308) ~[NetworkManager.class:?] at net.minecraft.network.NetworkSystem.networkTick(NetworkSystem.java:195) ~[NetworkSystem.class:?] ... 5 more All related, name-self-explanatory classes: package tt.betterslabsmod.capability.placementmode; import net.minecraft.nbt.NBTBase; import net.minecraft.nbt.NBTPrimitive; import net.minecraft.nbt.NBTTagInt; import net.minecraft.util.EnumFacing; import net.minecraftforge.common.capabilities.Capability; import net.minecraftforge.common.capabilities.Capability.IStorage; import net.minecraftforge.common.capabilities.CapabilityInject; import net.minecraftforge.common.capabilities.ICapabilitySerializable; public class PlacementMode implements IPlacementMode { @CapabilityInject(IPlacementMode.class) public static final Capability<IPlacementMode> PLACEMENT_MODE = null; private Mode placement_mode = Mode.NORMAL; @Override public void setPlacementMode(PlacementMode.Mode newPlacementMode) { placement_mode = newPlacementMode; } @Override public PlacementMode.Mode getCurrentPlacementMode() { return placement_mode; } public enum Mode { NORMAL(0, "normal"), VERTICAL(1, "vertical"), AXIS(2, "axis"), ROTATIONAL(3, "rotational"), RANDOM(4, "random"); public int ID; public String name; Mode(int ID_, String name_) { this.ID = ID_; this.name = name_; } } } package tt.betterslabsmod.capability.placementmode; import net.minecraft.nbt.NBTBase; import net.minecraft.nbt.NBTPrimitive; import net.minecraft.util.EnumFacing; import net.minecraftforge.common.capabilities.Capability; import net.minecraftforge.common.capabilities.CapabilityInject; import net.minecraftforge.common.capabilities.ICapabilitySerializable; public class PlacementModeProvider implements ICapabilitySerializable<NBTBase> { private IPlacementMode instance = PlacementMode.PLACEMENT_MODE.getDefaultInstance(); @Override public boolean hasCapability(Capability<?> capability, EnumFacing facing) { return capability == PlacementMode.PLACEMENT_MODE; } @Override public <T> T getCapability(Capability<T> capability, EnumFacing facing) { return capability == PlacementMode.PLACEMENT_MODE ? PlacementMode.PLACEMENT_MODE.<T>cast(instance) : null; } @Override public NBTBase serializeNBT() { return (NBTPrimitive)PlacementMode.PLACEMENT_MODE.getStorage().writeNBT(PlacementMode.PLACEMENT_MODE, instance, null); } @Override public void deserializeNBT(NBTBase NBT) { PlacementMode.PLACEMENT_MODE.getStorage().readNBT(PlacementMode.PLACEMENT_MODE, instance, null, NBT); } } package tt.betterslabsmod.capability.placementmode; import net.minecraft.nbt.NBTBase; import net.minecraft.nbt.NBTPrimitive; import net.minecraft.nbt.NBTTagByte; import net.minecraft.nbt.NBTTagInt; import net.minecraft.util.EnumFacing; import net.minecraftforge.common.capabilities.Capability; import net.minecraftforge.common.capabilities.Capability.IStorage; public class PlacementModeStorage implements IStorage<IPlacementMode> { @Override public NBTBase writeNBT(Capability<IPlacementMode> capability, IPlacementMode placementMode, EnumFacing side) { return new NBTTagByte((byte)(placementMode.getCurrentPlacementMode().ID)); } @Override public void readNBT(Capability<IPlacementMode> capability, IPlacementMode placementMode, EnumFacing side, NBTBase NBT) { placementMode.setPlacementMode(PlacementMode.Mode.values()[((NBTPrimitive) NBT).getByte()]); } } package tt.betterslabsmod.capability.placementmode; import tt.betterslabsmod.capability.placementmode.PlacementMode.Mode; public interface IPlacementMode { void setPlacementMode(PlacementMode.Mode newPlacementMode); PlacementMode.Mode getCurrentPlacementMode(); } Quote
TheTrollguy_ Posted April 16, 2017 Author Posted April 16, 2017 (edited) I registered my event handler in both preInit and init, so that part has been solved. (Its 1 AM for me) Now 2 questions: 1) Do I put the registrations for event handlers in preInit or init (I've seen both on the internet, both seem to work...) 2) Do I have to do the check in the code? package tt.betterslabsmod.event; import net.minecraft.entity.Entity; import net.minecraft.entity.player.EntityPlayer; import net.minecraft.entity.player.EntityPlayerMP; import net.minecraft.util.ResourceLocation; import net.minecraftforge.event.AttachCapabilitiesEvent; import net.minecraftforge.fml.common.eventhandler.SubscribeEvent; import net.minecraftforge.fml.relauncher.Side; import net.minecraftforge.fml.relauncher.SideOnly; import tt.betterslabsmod.capability.placementmode.PlacementMode; import tt.betterslabsmod.capability.placementmode.PlacementModeProvider; import tt.betterslabsmod.utils.BSMUtils; public class BSMCapabilityHandler { @SubscribeEvent public void attachCapability(AttachCapabilitiesEvent<Entity> event) { // THE LINE DOWN HERE if (event.getObject() instanceof EntityPlayer && !event.getObject().hasCapability(PlacementMode.PLACEMENT_MODE, null)) // <- is the check for the mode even required { event.addCapability(new ResourceLocation(BSMUtils.MODID, "placement_mode"), new PlacementModeProvider()); System.out.println("whatever the hell should be here...."); } } } Edited April 16, 2017 by TheTrollguy_ Quote
TheTrollguy_ Posted April 16, 2017 Author Posted April 16, 2017 (edited) Content removed Edited April 16, 2017 by TheTrollguy_ Quote
TheTrollguy_ Posted April 17, 2017 Author Posted April 17, 2017 Okay another thing, kinda connected to capabilities. In the event RenderGameOverlayEvent.Text, how can I get the player object so I can grab its capability to show it on the screen? Is Minecraft.getMinecraft().player the right way? Quote
Draco18s Posted April 17, 2017 Posted April 17, 2017 1 hour ago, TheTrollguy_ said: Okay another thing, kinda connected to capabilities. In the event RenderGameOverlayEvent.Text, how can I get the player object so I can grab its capability to show it on the screen? Is Minecraft.getMinecraft().player the right way? On the client? Yes. 1 Quote Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable. If you think this is the case, JUST REPORT ME. Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice. Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked. DO NOT PM ME WITH PROBLEMS. No help will be given.
TheTrollguy_ Posted April 17, 2017 Author Posted April 17, 2017 (edited) Welp, I have another problem which really doesn't require a new thread on its own, still connected to showing the capability on the screen. The following code doesn't get called at all. It's inside BSMClientEventHandler(Client only class), however, I had the same code in an another mod and it worked. Spoiler @SubscribeEvent public static void renderPlacementMode(RenderGameOverlayEvent.Post event) { System.out.println("RUN1"); // doesnt get called EntityPlayer player = Minecraft.getMinecraft().player; if (player != null) { ItemStack itemStack = player.getActiveItemStack(); if (itemStack != null) { if (itemStack.getItem() instanceof BSMItemBlock) { System.out.println("RUN2"); // doesnt get called if (!Minecraft.getMinecraft().gameSettings.showDebugInfo) { System.out.println("RUN3"); // doesnt get called GlStateManager.pushMatrix(); GlStateManager.enableAlpha(); GlStateManager.enableBlend(); GlStateManager.color(1.0F, 1.0F, 1.0F, 1.0F); GlStateManager.disableLighting(); fontRenderer.drawString(I18n.format("placeement_mode.header") + ":" + player.getCapability(PlacementMode.PLACEMENT_MODE, null).getCurrentPlacementMode().getLocalizedName(), 1.5F, 1.5F, 0xFFFFFF, true); GlStateManager.popMatrix(); } } } } } The event handler class is registered in ClientProxy in init. There's also another event inside BSMClientEventHandler that gets called normally. Spoiler Quote public void init(FMLInitializationEvent e) { super.init(e); BSMKeyboard.registerKeyBindings(); MinecraftForge.EVENT_BUS.register(new BSMClientEventHandler()); System.out.println("Registered clienet event handler...."); //registerColorMultipliers(); } I really don't know what's happening here, but knowing me it's going to be an idiotic mistake... Edited April 17, 2017 by TheTrollguy_ grammar mistakes Quote
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.