[URGENT]Help with ITextureProvider

[blaytz]

Hello everybody,

 

I've got a problem: i've been modding with forge and i just tried adding an armor set so i put this code in:

 

 

package MiscBlocksAndItems.common;

 

import net.minecraft.item.EnumArmorMaterial;

import net.minecraft.item.ItemArmor;

import net.minecraft.item.ItemStack;

import net.minecraftforge.common.IArmorTextureProvider;

 

public class ObsidianArmor extends ItemArmor implements ITextureProvider, IArmorTextureProvider {

 

public ObsidianArmor(int par1, EnumArmorMaterial par2EnumArmorMaterial,

int par3, int par4) {

super(par1, par2EnumArmorMaterial, par3, par4);

}

 

public String getTextureFile(){

return "/MiscBlocksAndItems/Textures.png";

}

public String getArmorTextureFile(ItemStack itemstack) {

if (itemstack.itemID == MiscBlocksAndItems.shiftedIndex || itemstack.itemID == MiscBlocksAndItems.ObsidianChestplate.shiftedIndex || itemstack.itemID == MiscBlocksAndItems.ObsidianBoots.shiftedIndex)

{

    return "/MiscBlocksAndItems/Obsidian_1.png";

}

else if (itemstack.itemID == MiscBlocksAndItems.ObsidianLeggings.shiftedIndex)

{

    return "/MiscBlcoksAndItems/Obsidian_2.png";

}

 

return null;

}

}

 

 

 

but it says "ITextureProvider cannot be resolved as a type."

So i would need some help because without ITextureProvider i cannot create an armor set wich would be stupid since that is the goal of my mod.

 

Thanks for your help,

Mr Blaytz

[shucke]

you spelled your file name wrong

else if (itemstack.itemID == MiscBlocksAndItems.ObsidianLeggings.shiftedIndex) 
      {
          return "/MiscBlcoksAndItems/Obsidian_2.png";
      }

dont know if this is the reason but it would create a problem 

[blaytz]

Thanks for the prompt response but that is not the problem because when I hover with my mouse over the error it doesn't propose to import ITextureProvider and I know thats not the problem caus' it already gave me that error even before i wrote anything...

 

[endershadow]

ITextureProvider isn't needed anymore to use custom texture files. so you can delete it and still use a custom texture file.

[blaytz]

Thank you, I tried that but now it gives me an error on the shiftedIndex...  :'(

[Mazetar]

Solving 1 error didn't make the other, it made the other become clear

usually when you remove some bad code, you find more

 

So now we solve for the new problem, what error is it giving?

Post the exact error it is giving and if possible a www.pastebin.com(Set Syntax Highlighting to Java) of the class with the error.

And I'm sure you will get it resolved

 

[blaytz]

thanks for the advice 

 

Here is my pastebin link: http://pastebin.com/kAMpKijj

 

It doesn't actually give me an error it just underlines it in red with these possibilities:

 

http://bayimg.com/iAJhdAaee

[endershadow]

in 1.4.7 shiftedIndex was changed to itemID

[Mazetar]

Well what it says inn it's way is that

What is this "shiftedIndex" you speak of?

 

I'm not sure but I think there is a different name for it now, opening the soruce class for the item's should let you know what the name is now.

 

Edit: endershadow wrote as I made my post, there ya have it^^

[mardiff]

I'm not sure, but try to switch shiftedIndex to itemID.

[blaytz]

Thanks but thats not all :'(

 

Now it discovered new errors in my main mod class (MiscBlocksAndItems.java):

 

http://bayimg.com/GajICAaEE

[endershadow]

I think it's a problem in ObsidianArmor.java

[Mazetar]

Well if you look at the error it is giving you, what is it telling you?

It's saying that something is undefined... meaning that it's not there!

What is it? Well it can't find a constructor at the class with those parameters, meaning you either have to change the paramterts to match the constructor you have or create a constructor which accepts the parameters you are passing into it

 

Without looking into the ObsidianArmor.java file, I can't be sure but I belive you have an constructor method like this:

public ObsidianArmor(int itemID, int TextureID, Material material){

 

so adding the textureID into the lines where you are calling the constructor inn your MiscBlocksAndItems file, should resolve the issue.

 

How much experience with modding and java in general do you have? if you have troubles understanding the error messages like that I assume you are quite new to java and programming? Don't take this as an insult, but if you are let me know and I can find some resources for you to learn some more which in turn will help you solve these kinds of errors on your own

 

 

[blaytz]

Thank you Mazetar. I do not consider what you said as an insult, I consider it like a very nice act. Anyways, I do not have any constructor method like that, but I do not quite understand what you mean by saying "adding the textureID  into the lines where you are calling the constructor".

 

EDIT: This is my first minecraft/forge mod and I am currently learning java so I am not very good at it

[Mazetar]

For the problem:

Paste the ObsidianArmor.java file on pastebin and let us see, you are either missing the constructor or it's parameters are different, in anycase it should be easy to fix

 

 

 

For Learning:

Here is a great source for learning the basics of Java, I recommend that you do watch the videos up until he starts with drawing GUI's using JFrame and such. Theres a lot of them but they are all really simple to follow and short!(Like 4-7 mins usually).

http://thenewboston.org/list.php?cat=31

 

Futher following some tutorial series on basics of forge modding will give you a good understanding not only of the specific things which you are creating but also the forge/minecraft code inn general

 

Wuppy here has created some nice tutorials both in tekst form AND as videos which could be a nice place to start if you aren't already following a tutorial series

http://wuppy29.blogspot.nl/2012/10/forge-modding-142.html

 

 

 

[blaytz]

Haha! Thanks for the tutorials! What a coincidence! I am watching thenewboston tutorials!

 

Here is the pastebin link: http://pastebin.com/mZV9JCU5

[Mazetar]

Video 17 will be dealing with constructors ^^

thenewboston is awesome!

 

Now to your code again:

public ObsidianArmor(int par1, EnumArmorMaterial par2EnumArmorMaterial,
                        int par3, int par4) {
                super(par1, par2EnumArmorMaterial, par3, par4);
        }

 

is the ObsidianArmor Constructor, whenever you call for new ObsidianArmor();

This is what's getting called. as you see it takes inn 4 parameters (Parameters are the name for variables that a function needs as an input). Namely Integers par1, par3 and par4, and the EnumArmorMaterial par2.

 

When you inn your mod file "MiscBlocksAndItems" call the line for a new Obsidan Armor, you are not giving it all the variables it needs! You are just giving it the first two variables it needs when you say

ObsidianHelemet = new ObsidianArmor(IbsidianHelmetID, OBSIDIAN)

You need to give it two more ints, to satisfy the 3rd and 4th parameters.

I'm not sure what they are but it should be easy to find out by looking at what the super() call inside the constructor is doing to them.

 

When you click on the line which says super("SOME PARAMETERS HERE"); and press F3 inn eclipse you should be taken to the deffinition of that method which will show you this code:

 

  public ItemArmor(int par1, EnumArmorMaterial par2EnumArmorMaterial, int par3, int par4)
    {
        super(par1);
        this.material = par2EnumArmorMaterial;
        this.armorType = par4;
        this.renderIndex = par3;
//etc.

 

From this you can see that the 3rd paramter is the renderIndex for the ObsidianHelmet and the 4th is for the armor type of the helment

Fill inn these numbers when you instansiate the ObsidianHelm like this:

ObsidianHelemet = new ObsidianArmor(IbsidianHelmetID, OBSIDIAN, armorTypeHere, renderIndexNumberHere)

 

[blaytz]

Thank you SO much for your help!! It doesn't give me any errors anymore and I will try it and tell you if it works and... I LOVE YOU Mazetar!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! 

 

No seriously you have solved my probleem and I will never thank you enough!

[blaytz]

Yeah... It show the boots but not the rest in my inventory and when I wear those boots they are like white pants...  :'(

[Davidobot]

Yeah... It show the boots but not the rest in my inventory and when I wear those boots they are like white pants...  :'(

I guess you are testing within Eclipse, this just means that it didn't find the file. It should work if you compile it and out the textures in the right place. As for the Eclipse texture you need to put them in a special place in the folder, though I don't remember witch folder it was.

[Mazetar]

If you place the image files into eclipse into the package structure which you reffer to it as being inn, it should find it.

Also it should find it inside the mcp/src/"The string for the file location you specified inn the code".

[blaytz]

Thanks for the advice but i have already added the texture files but they dont show up even without the miniature

[blaytz]

Ok tried what Mazetar said, it worked for the boots because I had just writen a file name wrong. But I still can't see the items in my inventory

[Mazetar]

Okay so the boots are fixed, you can now wear them and you see them on you but the icon inn the inventory is not working as you wanted it too? It's just some weird or random icon, right?

 

Maybe you havent told it to read the item texture from a new texture file so it is reading the texture from the /items.png file as is default for all items?

[Seigyoku]

Hello there, the ItemArmor class is a little trickier to work with than other things, mainly due to how it handles rendering its armor. I'm personally awed that you're trying this as a first project, so kudos on your progress.

 

I decided to take the time today to learn about custom armor rendering thanks to this topic, and I'm glad I managed to solve it before the night was over.

 

You can find my source code on an example of how to do so here: https://github.com/Seigyoku/customarmortest

 

This is my first time working with GitHub, and it sadly doesn't make use of IArmorTextureProvider, but I hope it's of help all the same!