[1.11.2] Injecting custom MovementInput

[BeardlessBrady]

Currently Im just trying to see if I can inject my own custom MovementInput into the game via EntityJoinWorldEvent. Right now I've only copied the MovementInputFromOptions class to the t just to see if it will allow me and for some reason the game crashes on world

 

MovementInput Class: https://github.com/BeardlessBrady/Carts-Mod/blob/master/src/main/java/gunn/modcarts/mod/CartMovementInput.java

CommonEvent Class: https://github.com/BeardlessBrady/Carts-Mod/blob/master/src/main/java/gunn/modcarts/mod/core/handler/EventHandlerCommon.java#L35-L38

Crashlog: https://pastebin.com/fQeyyUCA

[Abastro]

1. You should not reference Minecraft on the event like that, especially when it could be called from both client and server. Create an event handler dedicated for client, and register it on the client proxy.

2. The event is called whenever an entity is created. You should check if the entity is a player, and cast the entity as EntityPlayer.(or EntityPlayerSP)

3. What kind of behavior do you want with it? This approach does not look fine.

[BeardlessBrady]

I originally had it on the client handler, at this point I was just trying things. I also had no idea the event is called for all entities, let me try and check for a player entity first

What I'm trying to do: (in certain circumstances) prevent the player from strafing.

 

EDIT: Alright moved it back to the client and checking for EntityPlayerSP got me into the world! Thanks a bunch

Unfortunately though this way isn't working, if I try and stop strafing even in my modified movementInput it still wont stop it, any ideas?

Edited May 9, 2017 by BeardlessBrady

[Abastro]

So you want to prohibit certain movement of player? Why?

If it is for anti-cheat server, there is always a way to break it with another mod or something. It's better to do it on server by checking for it.

[BeardlessBrady]

It is not for anti-cheat server's. Anyways thanks for helping me.

[Abastro]

Sorry about the blind guess.

 

Would you post your current code? Specifically, did you override MovementInput#updatePlayerMoveState() to block the left/right movement?

Also it's about blocking the strafe control input, right?

Edited May 10, 2017 by Abastro

[BeardlessBrady]

Its all good, I know its an obscure thing I'm trying to do.

 

ClientProxy: https://github.com/BeardlessBrady/Carts-Mod/blob/d7ae34010cb870e3eba29ab21572afe5fbbd4c80/src/main/java/gunn/modcarts/mod/core/handler/EventHandlerClient.java

MovementInput: https://github.com/BeardlessBrady/Carts-Mod/blob/d7ae34010cb870e3eba29ab21572afe5fbbd4c80/src/main/java/gunn/modcarts/mod/CartMovementInput.java

 

I'm copying the MovementInputFromOptions and just commenting out the left movement part but I can still move left

 

[Abastro]

  On 5/10/2017 at 11:13 PM, BeardlessBrady said:

MovementInput: https://github.com/BeardlessBrady/Carts-Mod/blob/d7ae34010cb870e3eba29ab21572afe5fbbd4c80/src/main/java/gunn/modcarts/mod/CartMovementInput.java

 

Expand  

Would you check if the method is actually called? It seems that it might not be properly replaced.

[BeardlessBrady]

You are correct, it is not being called.

[Abastro]

Then it's not correctly patched. Please check if the movement input of the player is your custom one. Detecting it on some kind of key binding will be handy.