Okay, so I'm trying to figure out what event, or how to even do something that will allow an enchantment I've thought of; Stepping. It would allow the player (when their boots are enchanted with this) to step up blocks at level 1 and 2, and walk on water and lava at level 2.

 

Would this be done with an event, or...? I've got the code all ready to go, I just don't know where to put it.

 

EDIT: I'm not even sure the title of this thread is appropriate for what I'm trying to do...

Edited May 15, 20178 yr by blahblahbal

I actually already have the stepping/water walking code. I'm just trying to figure out how to actually run it while the player has boots that are enchanted with this enchantment equipped. I tried onLivingUpdate, but that broke the whole thing.

@SubscribeEvent
	public void onLivingUpdate(LivingEvent event)
	{
		if (event.entityLiving instanceof EntityPlayer)
		{
			EntityPlayer player = (EntityPlayer)event.entityLiving;
			if (EnchantmentHelper.getEnchantments(player.getCurrentArmor(3)).containsValue(86))
			{
				if (EnchantmentHelper.getEnchantmentLevel(86, new ItemStack(player.getCurrentArmor(3).getItem())) == 2)
				{
					if (player.worldObj.isRemote)
					{
						int x = (int) Math.floor(player.posX);
						int y = (int) (player.posY - player.getYOffset());
						int z = (int) Math.floor(player.posZ);
						BlockPos pos = new BlockPos(x, y, z);

						Block b = player.worldObj.getBlockState(pos.down()).getBlock();

						if ((b == Blocks.lava || b == Blocks.flowing_lava || b == Blocks.water || b == Blocks.flowing_water) && player.worldObj.isAirBlock(pos))
						{
							if (!player.isSneaking())
							{
								player.motionY = 0.0d;
								player.fallDistance = 0.0f;
								player.onGround = true;
							}
						}
					}
		        }
				if ((!player.capabilities.isFlying) && (player.moveForward > 0.0F))
			    {
					if ((player.worldObj.isRemote) && (!player.isSneaking()))
			    	{
						if (!PlayerEvents.INSTANCE.prevStep.containsKey(Integer.valueOf(player.getEntityId())))
						{
							PlayerEvents.INSTANCE.prevStep.put(Integer.valueOf(player.getEntityId()), Float.valueOf(player.stepHeight));
						}
						player.stepHeight = 1.0F;
			    	}
			    }
			}
		}
	}

Here it is. I have it in my ModEventHandler class.

1 hour ago, blahblahbal said:

if (EnchantmentHelper.getEnchantments(player.getCurrentArmor(3)).containsValue(86))

Ew. Absolutely ew.

Contains value 86? Really? You couldn't use an actual enchantment instance?

I could have, yes, but why do that when it's longer and less direct? Plus, I looked at the vanilla code for the getEnchantments method and it simply saves the id and level.

1 hour ago, blahblahbal said:

I could have, yes, but why do that when it's longer and less direct? Plus, I looked at the vanilla code for the getEnchantments method and it simply saves the id and level.

Because you are not the same person when you get back to the code some time later and you'll wonder what was it. Readability is that important.

Also the id is subjected to change on

is important.

Also the id is subjected to change on MC version update, so using the instance is better as at least it will give you some errors if the reference got changed. Chances are instance based code will work on the ID change.

EDIT: Was it your own enchantment? If it's the case, you just can't use the if, it is highly subjected to change.

Edited May 16, 20178 yr by Abastro
See EDIT

Not to mention if someone else registers an enchantment before you do.

Alright, I see your point. Regardless, this isn't the reason why the code isn't working. I don't know why we're discussing something that has nothing to do with why the code isn't working.

I've changed the Event to a TickEvent, but it still doesn't seem to work. I'm still using the hardcoded value of 86, but will change it when I get it working. I did notice that the ID is stored as the Key, not the Value, so I changed containsValue to containsKey.

	@SubscribeEvent
	public void playerTick(TickEvent.PlayerTickEvent event)
	{
		if (event.phase == TickEvent.Phase.END) // && event.side == Side.SERVER)
		{
			EntityPlayer player = (EntityPlayer)event.player;
			if (player.inventory.armorInventory[3] != null)
			{
				if (EnchantmentHelper.getEnchantments(player.getCurrentArmor(3)).containsKey(86))
				{
					if (EnchantmentHelper.getEnchantmentLevel(86, new ItemStack(player.getCurrentArmor(3).getItem())) == 2)
					{
						if (player.worldObj.isRemote)
						{
							int x = (int) Math.floor(player.posX);
							int y = (int) (player.posY - player.getYOffset());
							int z = (int) Math.floor(player.posZ);
							BlockPos pos = new BlockPos(x, y, z);

							Block b = player.worldObj.getBlockState(pos.down()).getBlock();

							if ((b == Blocks.lava || b == Blocks.flowing_lava || b == Blocks.water || b == Blocks.flowing_water) && player.worldObj.isAirBlock(pos))
							{
								if (!player.isSneaking())
								{
									player.motionY = 0.0d;
									player.fallDistance = 0.0f;
									player.onGround = true;
								}
							}
						}
			        }
					if ((!player.capabilities.isFlying) && (player.moveForward > 0.0F))
				    {
						if ((player.worldObj.isRemote) && (!player.isSneaking()))
				    	{
							if (!PlayerEvents.INSTANCE.prevStep.containsKey(Integer.valueOf(player.getEntityId())))
							{
								PlayerEvents.INSTANCE.prevStep.put(Integer.valueOf(player.getEntityId()), Float.valueOf(player.stepHeight));
							}
							player.stepHeight = 1.0F;
				    	}
				    }
				}
			}
		}
	}

I know it's getting to at least the containsKey call because I had forgotten the null check and it errored.

1 hour ago, blahblahbal said:

if (EnchantmentHelper.getEnchantmentLevel(86, new ItemStack(player.getCurrentArmor(3).getItem())) == 2)

You're making a NEW itemstack, with the item from the itemstack you've already gained...

Of course it is not gonna have an enchantment on it, unless you actually add one manually to that new itemstack

Just use the itemstack you get from getCurrentArmor instead of making a new one

...Derp. That's fixed. But something else must be wrong, because it still doesn't work.

EDIT: Nevermind, I had the wrong index on the getCurrentArmor call. And all the other things where the index is needed.

Edited May 16, 20178 yr by blahblahbal