Jump to content

Recommended Posts

Posted

I'm trying to make a mod with some sword that should emit sound only once at its equip. Detection of slot change works like this: last item in player's hand being written to static variable lastSlotItem, and then if  equipped item on next tick != lastSlotItem means that slot is changed. And by some unknown reason onPlayerTick is being called like this:

First change tick: item == sword

Second change tick: item == previous item (why does it goes back to prev. item on this tick?)

Third change tick: item == sword (again)

 

There's my code:

onPlayerTick:

Spoiler

public class FMLEventHandler
{
	public static Item lastSlotItem;
	
	@SubscribeEvent
	public void onPlayerTick(PlayerTickEvent event)
	{
		if(event.phase == TickEvent.Phase.START)
		{
			ItemStack itemStack = event.player.getCurrentEquippedItem();
			if(itemStack != null)
			{
				Item item = itemStack.getItem();
				if(item instanceof ItemTestSword)
				{
					if(lastSlotItem != null) event.player.addChatComponentMessage(new ChatComponentText(item.getClass().getName()));
					if(lastSlotItem != item)
					{
						event.player.addChatComponentMessage(new ChatComponentText("Test sword!"));
					}
				}
				lastSlotItem = item;
			}
			else lastSlotItem = null;
		}
	}
}

 

 

preInit:

Spoiler

@EventHandler
public void preInit(FMLPreInitializationEvent event)
{
    MinecraftForge.EVENT_BUS.register(new ModEventHandler());
    FMLCommonHandler.instance().bus().register(new FMLEventHandler());
    ModItems.init();
}

 

 

And even if i trying to handle slot change detection with onUpdate override in my sword class it does the same thing.

Sword Class:

Spoiler

public class ItemTestSword extends ModItemSword
{
	public List itemDescription = Arrays.asList(new String[]
			{
					"Some",
					"Description",
              		"Here"
			});
	
	public boolean isHeld;
	
	public ItemTestSword(String unlocalizedName, ToolMaterial material)
	{
        super(material);
        this.setUnlocalizedName(unlocalizedName);
	}
	
	@Override
	public void addInformation(ItemStack itemStack, EntityPlayer entityPlayer, List list, boolean bool)
	{
		list.addAll(itemDescription);
	}
	
	@Override
    public ItemStack onItemRightClick(ItemStack itemStack, World world, EntityPlayer entityPlayer)
    {
		return itemStack;
    }
	
	public void onUpdate(ItemStack itemStack, World world, Entity entity, int integer, boolean bool)
	{
      	if(entity instanceof EntityPlayer)
        {
            if(bool && !isHeld)
            {
                    EntityPlayer ep = (EntityPlayer)entity;
                    ep.addChatMessage(new ChatComponentText("Test sword!"));
                    isHeld = true;
            }
            else if(!bool && isHeld) isHeld = false;
        }
	}
}

 

 

Posted

Sorry, but 1.7.10 is no longer supported here. Please update!

Apparently I'm addicted to these forums and can't help but read all the posts. So if I somehow help you, please click the "Like This" button, it helps.

Posted (edited)

That's bad... I need to create mod on 1.7.10 because of some other mods are still on this version, like GregTech or Extra Bees (Binnie's mods).

But maybe someone can help me with this thing?.. I don't know what to do...

Edited by exys
Posted
5 minutes ago, exys said:

Thanks, i'll check this later.

Note: Using Capabilities requires upgrading past 1.7.10

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Try the latest build: https://modrinth.com/mod/axiom/version/4.1.1
    • *** buffer overflow detected ***: terminated /usr/bin/forge-1.12.2d: line 162: 15787 Aborted                 (core dumped) ${SUDO_CMD} screen -S "${SESSION_NAME}" -Q select . > /dev/null Starting server...There are several suitable screens on:     14630.forge-1.12.2    (Detached)     15796.forge-1.12.2    (Detached) Use -S to specify a session How do i fix this issue?
    • Oh I forgot to update the title. I figured out the issue and I'm rather embarrassed to say that it was a file path issue. The game already knew I was accessing the achievements so I wasn't suppose to include advancements in the file path. Minecraft file paths have always confused me a little bit... ResourceLocation advancementId = new ResourceLocation( TheDeadRise.MODID,"adventure/spawntrigger");
    • Can someone help my with this? My forge server won't open and I'm not that good with this stuff. It gave me this error message:   C:\Users\apbeu\Desktop\Forge server>java -Xmx4G -Xms1G -jar server.jar nogui 2024-12-11 18:21:01,054 main WARN Advanced terminal features are not available in this environment [18:21:01] [main/INFO] [cp.mo.mo.Launcher/MODLAUNCHER]: ModLauncher running: args [--gameDir, ., --launchTarget, fmlserver, --fml.forgeVersion, 36.2.34, --fml.mcpVersion, 20210115.111550, --fml.mcVersion, 1.16.5, --fml.forgeGroup, net.minecraftforge, nogui] [18:21:01] [main/INFO] [cp.mo.mo.Launcher/MODLAUNCHER]: ModLauncher 8.1.3+8.1.3+main-8.1.x.c94d18ec starting: java version 21.0.4 by Oracle Corporation Exception in thread "main" java.lang.IllegalAccessError: class cpw.mods.modlauncher.SecureJarHandler (in unnamed module @0x402e37bc) cannot access class sun.security.util.ManifestEntryVerifier (in module java.base) because module java.base does not export sun.security.util to unnamed module @0x402e37bc         at cpw.mods.modlauncher.SecureJarHandler.lambda$static$1(SecureJarHandler.java:45)         at cpw.mods.modlauncher.api.LamdbaExceptionUtils.uncheck(LamdbaExceptionUtils.java:95)         at cpw.mods.modlauncher.SecureJarHandler.<clinit>(SecureJarHandler.java:45)         at cpw.mods.modlauncher.Launcher.lambda$new$6(Launcher.java:55)         at java.base/java.util.concurrent.ConcurrentHashMap.computeIfAbsent(ConcurrentHashMap.java:1708)         at cpw.mods.modlauncher.api.TypesafeMap.computeIfAbsent(TypesafeMap.java:52)         at cpw.mods.modlauncher.api.TypesafeMap.computeIfAbsent(TypesafeMap.java:47)         at cpw.mods.modlauncher.Environment.computePropertyIfAbsent(Environment.java:62)         at cpw.mods.modlauncher.Launcher.<init>(Launcher.java:55)         at cpw.mods.modlauncher.Launcher.main(Launcher.java:66)         at net.minecraftforge.server.ServerMain$Runner.runLauncher(ServerMain.java:63)         at net.minecraftforge.server.ServerMain$Runner.access$100(ServerMain.java:60)         at net.minecraftforge.server.ServerMain.main(ServerMain.java:57) C:\Users\apbeu\Desktop\Forge server>pause
    • Here is the url for the crash report if anyone can help me, please. https://mclo.gs/KGn5LWy  
  • Topics

  • Who's Online (See full list)

    • There are no registered users currently online
×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.