ItemStack item changing

[meee39]

In my multiblock crafting structure the final result is placed inside the inventory of a block. It is possible to see through the TESR and System.out.println() that the item does become the final result, but when it is taken out of the inventory it changes back into what was originally put in the block.

 

package com.leo.mobsuppressors.tileentity;

import com.leo.mobsuppressors.EnumAltarRecipes;
import com.leo.mobsuppressors.MobSuppressors;
import com.leo.mobsuppressors.network.PacketUpdateTower;

import net.minecraft.entity.effect.EntityLightningBolt;
import net.minecraft.item.ItemStack;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.ITickable;
import net.minecraft.util.math.BlockPos;
import net.minecraftforge.fml.common.network.NetworkRegistry;
import net.minecraftforge.items.CapabilityItemHandler;

public class TileEntitySuppressionAltarCore extends TileEntity implements ITickable {
	public TileEntitySuppressionAltarCore() {
		
	}

	@Override
	public void update() {
		attemptCraft();
	}
	
	public boolean attemptCraft() {
		if (!(world.getTileEntity(new BlockPos(getPos().getX(), getPos().getY() + 1, getPos().getZ())) instanceof TileEntitySuppressionTower)) {
			return false;
		}
		
		TileEntitySuppressionTower tower;
		//Check structure
		BlockPos[] positions = {
			//Edges
			new BlockPos(getPos().getX() + 1, getPos().getY(), getPos().getZ()), 
			new BlockPos(getPos().getX(), getPos().getY(), getPos().getZ() + 1 ), 
			new BlockPos(getPos().getX() -1, getPos().getY(), getPos().getZ()), 
			new BlockPos(getPos().getX(), getPos().getY(), getPos().getZ() - 1), 
			//Corners
			new BlockPos(getPos().getX() + 1, getPos().getY(), getPos().getZ() + 1), 
			new BlockPos(getPos().getX() + 1, getPos().getY(), getPos().getZ() - 1), 
			new BlockPos(getPos().getX() - 1, getPos().getY(), getPos().getZ() - 1), 
			new BlockPos(getPos().getX() - 1, getPos().getY(), getPos().getZ() + 1)
		};
		
		tower = (TileEntitySuppressionTower)world.getTileEntity(new BlockPos(getPos().getX(), getPos().getY() + 1, getPos().getZ()));
		
		for (BlockPos position: positions) {
			if (!(world.getTileEntity(position) instanceof TileEntitySuppressionPedestal)) {
				return false;
			}
		}
		
		for (EnumAltarRecipes recipe: EnumAltarRecipes.values()) {
			if (tower.getCapability(CapabilityItemHandler.ITEM_HANDLER_CAPABILITY, EnumFacing.NORTH).getStackInSlot(0).getItem() == recipe.inputs[4]) {
				//Check edges
				if (((TileEntitySuppressionPedestal)world.getTileEntity(positions[0])).getCapability(CapabilityItemHandler.ITEM_HANDLER_CAPABILITY, EnumFacing.NORTH).getStackInSlot(0).getItem() == recipe.inputs[1] && ((TileEntitySuppressionPedestal)world.getTileEntity(positions[1])).getCapability(CapabilityItemHandler.ITEM_HANDLER_CAPABILITY, EnumFacing.NORTH).getStackInSlot(0).getItem() == recipe.inputs[1] && ((TileEntitySuppressionPedestal)world.getTileEntity(positions[2])).getCapability(CapabilityItemHandler.ITEM_HANDLER_CAPABILITY, EnumFacing.NORTH).getStackInSlot(0).getItem() == recipe.inputs[1] && ((TileEntitySuppressionPedestal)world.getTileEntity(positions[3])).getCapability(CapabilityItemHandler.ITEM_HANDLER_CAPABILITY, EnumFacing.NORTH).getStackInSlot(0).getItem() == recipe.inputs[1]) {
					//Check corners
					if (((TileEntitySuppressionPedestal)world.getTileEntity(positions[4])).getCapability(CapabilityItemHandler.ITEM_HANDLER_CAPABILITY, EnumFacing.NORTH).getStackInSlot(0).getItem() == recipe.inputs[0] && ((TileEntitySuppressionPedestal)world.getTileEntity(positions[5])).getCapability(CapabilityItemHandler.ITEM_HANDLER_CAPABILITY, EnumFacing.NORTH).getStackInSlot(0).getItem() == recipe.inputs[0] && ((TileEntitySuppressionPedestal)world.getTileEntity(positions[6])).getCapability(CapabilityItemHandler.ITEM_HANDLER_CAPABILITY, EnumFacing.NORTH).getStackInSlot(0).getItem() == recipe.inputs[0] && ((TileEntitySuppressionPedestal)world.getTileEntity(positions[7])).getCapability(CapabilityItemHandler.ITEM_HANDLER_CAPABILITY, EnumFacing.NORTH).getStackInSlot(0).getItem() == recipe.inputs[0]) {
						if (tower.netherStarUsesLeft > 0) {
							tower.netherStarUsesLeft -= 1;
							tower.getCapability(CapabilityItemHandler.ITEM_HANDLER_CAPABILITY, EnumFacing.NORTH).extractItem(0, 64, false);
							tower.getCapability(CapabilityItemHandler.ITEM_HANDLER_CAPABILITY, EnumFacing.NORTH).insertItem(0, new ItemStack(recipe.output, 1), false);
							MobSuppressors.network.sendToAllAround(new PacketUpdateTower(tower), new NetworkRegistry.TargetPoint(world.provider.getDimension(), pos.getX(), pos.getY(), pos.getZ(), 64));
						
							world.addWeatherEffect(new EntityLightningBolt(world, pos.getX(), pos.getY(), pos.getZ(), false));
						
							for (BlockPos position: positions) {
								((TileEntitySuppressionPedestal)world.getTileEntity(position)).getCapability(CapabilityItemHandler.ITEM_HANDLER_CAPABILITY, EnumFacing.NORTH).extractItem(0, 1, false);
							}
						}
					}
				}
			}
		}
		
		return true;
	}
}

 

[jeffryfisher]

What did you see when you stepped through these actions in the debugger? The data for " taken out of the inventory" should hit you in the face when watched in the debugger.

[meee39]

When the craft was complete it showed that the correct item was in the inventory, but when I took it out I didn't get that item.

[jeffryfisher]

20 hours ago, meee39 said:

When the craft was complete it showed that the correct item was in the inventory, but when I took it out I didn't get that item.

That's not stepping using the debugger. You're telling us only the user experience. Set some break points and step through the code so you can see, line by line, what field of what object the itemstack is moving to when you "put it in inventory", and so you can see what field of what object the "wrong" itemstack is coming from when you "take it out" (and follow it all the way into your hand to see that it's not switched).

[meee39]

I stepped through with the debugger and I found that the itemstack doesn't actually change. When the success part of the function was reached it sent a packet to update the inventory and that also made the TESR think that the inventory was updated, but in reality it didn't change at all. I think there is a problem with my packet then:

package com.leo.mobsuppressors.network;

import com.leo.mobsuppressors.tileentity.TileEntitySuppressionPedestal;
import com.leo.mobsuppressors.tileentity.TileEntitySuppressionTower;

import io.netty.buffer.ByteBuf;
import net.minecraft.client.Minecraft;
import net.minecraft.item.ItemStack;
import net.minecraft.util.math.BlockPos;
import net.minecraftforge.fml.common.network.ByteBufUtils;
import net.minecraftforge.fml.common.network.simpleimpl.IMessage;
import net.minecraftforge.fml.common.network.simpleimpl.IMessageHandler;
import net.minecraftforge.fml.common.network.simpleimpl.MessageContext;

public class PacketUpdateTower implements IMessage {
	public static class Handler implements IMessageHandler<PacketUpdateTower, IMessage> {
		@Override
		public IMessage onMessage(PacketUpdateTower message, MessageContext ctx) {
			Minecraft.getMinecraft().addScheduledTask(() -> {
				TileEntitySuppressionTower te = (TileEntitySuppressionTower)Minecraft.getMinecraft().world.getTileEntity(message.pos);
				te.itemStackHandler.setStackInSlot(0, message.stack);
				System.out.println(te.itemStackHandler.getStackInSlot(0));
				te.lastChangeTime = message.lastChangeTime;
			});
			return null;
		}
	
	}

	
	private BlockPos pos;
	private ItemStack stack;
	private long lastChangeTime;
	
	public PacketUpdateTower(BlockPos pos, ItemStack stack, long lastChangeTime) {
		this.pos = pos;
		this.stack = stack;
		this.lastChangeTime = lastChangeTime;
	}
	
	public PacketUpdateTower(TileEntitySuppressionTower te) {
		this(te.getPos(), te.itemStackHandler.getStackInSlot(0), te.lastChangeTime);
	}
	
	public PacketUpdateTower() {
	
	}
	
	@Override
	public void toBytes(ByteBuf buf) {
		buf.writeLong(pos.toLong());
		ByteBufUtils.writeItemStack(buf, stack);
		buf.writeLong(lastChangeTime);
	}
	
	@Override
	public void fromBytes(ByteBuf buf) {
		pos = BlockPos.fromLong(buf.readLong());
		stack = ByteBufUtils.readItemStack(buf);
		lastChangeTime = buf.readLong();
	}

}

 

[meee39]

Bump

[meee39]

I just realised that the packet I was sending was a client packet, but being sent on the server side. I wrote this packet:

package com.leo.mobsuppressors.network;

import com.leo.mobsuppressors.tileentity.TileEntitySuppressionAltarCore;
import com.leo.mobsuppressors.tileentity.TileEntitySuppressionPedestal;
import com.leo.mobsuppressors.tileentity.TileEntitySuppressionTower;

import io.netty.buffer.ByteBuf;
import net.minecraft.client.Minecraft;
import net.minecraft.item.ItemStack;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.World;
import net.minecraftforge.fml.common.FMLCommonHandler;
import net.minecraftforge.fml.common.network.ByteBufUtils;
import net.minecraftforge.fml.common.network.simpleimpl.IMessage;
import net.minecraftforge.fml.common.network.simpleimpl.IMessageHandler;
import net.minecraftforge.fml.common.network.simpleimpl.MessageContext;

public class PacketAltarCraft implements IMessage {
	public static class Handler implements IMessageHandler<PacketAltarCraft, IMessage> {
		@Override
		public PacketUpdatePedestal onMessage(PacketAltarCraft message, MessageContext ctx) {
			Minecraft.getMinecraft().addScheduledTask(() -> {
				TileEntitySuppressionTower te = (TileEntitySuppressionTower)Minecraft.getMinecraft().world.getTileEntity(message.pos);
				te.itemStackHandler.setStackInSlot(0, message.stack);
				System.out.println(te.itemStackHandler.getStackInSlot(0));
				te.lastChangeTime = message.lastChangeTime;
				System.out.println(message.stack + "handler");
			});
			return null;
		}
	}
	
	private BlockPos pos;
	private ItemStack stack;
	private long lastChangeTime;
	
	public PacketAltarCraft(BlockPos pos, ItemStack itemStack, long lastChangeTime) {
		this.pos = pos;
		this.stack = itemStack;
		this.lastChangeTime = lastChangeTime;
	}
	
	public PacketAltarCraft(TileEntitySuppressionTower te, ItemStack stack) {
		this(te.getPos(), stack, te.lastChangeTime);
		System.out.println(stack + "constructor");
	}
	
	public PacketAltarCraft() {
		
	}
	
	@Override
	public void toBytes(ByteBuf buf) {
		buf.writeLong(pos.toLong());
		ByteBufUtils.writeItemStack(buf, stack);
		buf.writeLong(lastChangeTime);
	}
	
	@Override
	public void fromBytes(ByteBuf buf) {
		pos = BlockPos.fromLong(buf.readLong());
		stack = ByteBufUtils.readItemStack(buf);
		lastChangeTime = buf.readLong();
	}
}

hoping that it would work, but I still have the same problem as before.

[meee39]

Bump

[Alpvax]

Is there an error printed to the console? Is your packet registered correctly (on both sides)? 

[meee39]

There is no error. Also does the packet need to be registered on both client and server side?

[Alpvax]

Yes, otherwise how will they know what packet to encode/decode?

The sender needs to have the packet registered in order to send it to the reciever, and the reciever needs to have it registered in order for it to be decoded back into the data you then handle.

[meee39]

There is no error. Also does the packet need to be registered on both client and server side?

[Draco18s]

Um...

On 7/5/2017 at 11:00 AM, Alpvax said:

Yes, otherwise how will they know what packet to encode/decode?

The sender needs to have the packet registered in order to send it to the reciever, and the reciever needs to have it registered in order for it to be decoded back into the data you then handle.

[meee39]

Oops. For some reason Forge Forums resent the last message. The real one was: "It still doesn't work"

[Draco18s]

"It hurts doctor. It hurts."

 

Please define "doesn't work" in a manner that is actually troubleshootable.

[meee39]

It does the same as before; the item that should be there is on the pedestal and when you take it out you just get back the item that was originally in that place.