[1.12] [RESOLVED] Shulker box doesn't generate

[That_Martin_Guy]

I am trying to generate a shulker box with a single item inside in this class. The problem is that it simply doesn't generate at all. Forge doesn't give me any related to the loot table (only rendering errors because I don't have any renderer for my items and blocks). Any ideas?

 

EDIT: A solution has been found. Feel free to look at this diff.

Edited July 3, 2017 by That_Martin_Guy
Problem has been fixed

[Jay Avery]

Is the method definitely being called?

[Earthcomputer]

In class TheDarkness, you have then line:

GameRegistry.registerWorldGenerator(new WorldGenReliquaryChest(), 0);

You have set the generation weight to zero, which means there is zero chance that the world generator will generate.

[That_Martin_Guy]

  On 7/3/2017 at 5:33 AM, Jay Avery said:

Is the method definitely being called?

Expand  

I'm not sure, I haven't messed with world generation before. I looked at Choonster's test mod while doing it, and he seemed to do something very similar to what I did.

  On 7/3/2017 at 8:00 AM, Earthcomputer said:

In class TheDarkness, you have then line:

GameRegistry.registerWorldGenerator(new WorldGenReliquaryChest(), 0);

You have set the generation weight to zero, which means there is zero chance that the world generator will generate.

Expand  

Changing it to 100 doesn't work. Are you sure that is the case?

  On 7/3/2017 at 8:21 AM, diesieben07 said:

No.

Expand  

That doesn't really help much

[That_Martin_Guy]

I don't really understand that. Like I said I haven't messed with world generation yet. Also, I don't think I explained this properly, but I want this shulker box to spawn at the edge of the obsidian platform the player spawns on in the end 100% of the time, then never again.

[That_Martin_Guy]

How do I call it at 0? I thought I based it off of the player's spawn position. 

[That_Martin_Guy]

Would you mind showing me the line were I set the position at 0? I'm sorry but I'm really confused here.

[That_Martin_Guy]

Still doesn't generate. Code

 

EDIT: Actually I got an idea. Let me try it.

 

EDIT 2: Shoot. It didn't work. Here's what I tried.

Edited July 3, 2017 by That_Martin_Guy

[That_Martin_Guy]

World#getChunkFromCoords already uses shift right:

    public Chunk getChunkFromBlockCoords(BlockPos pos)
    {
        return this.getChunkFromChunkCoords(pos.getX() >> 4, pos.getZ() >> 4);
    }

.  Either way, this didn't work.

[Draco18s]

Of course not.

world.getChunkFromBlockCoords(new BlockPos(spawnX >> 4, world.getSpawnPoint().getY(), spawnZ >> 4));

You said "get me a chunk from block coords" and then passed in chunk coords.

Also, the Y value is irrelevant, you should just pass 0 there rather than spending CPU cycles calculating how high up the spawn is, just to pass it into a method that gives no fucks.

[That_Martin_Guy]

The reason I created that is because that's what diesieben told me to try it (atleast the way I interpreted it, which might be the wrong way). Besides, passing in the normal block coordinates without shift-right doesn't generate it either.

[V0idWa1k3r]

You are using the wrong coordinate getter. You need WorldServer::getSpawnCoordinate, not World::getSpawnPoint

[Draco18s]

  On 7/3/2017 at 5:12 PM, That_Martin_Guy said:

The reason I created that is because that's what diesieben told me to try it (atleast the way I interpreted it, which might be the wrong way). Besides, passing in the normal block coordinates without shift-right doesn't generate it either.

Expand  

That's because you don't need getChunkFromBlockCoords at all.

All you need to do is take the spawn coordinates (in block form) and do >>4 on them to get the chunk coordinates. You don't need the chunk, all you want to know is if the current chunk has the same coordinates as the spawn chunk.

[That_Martin_Guy]

It works now! Thanks guys! Diff for anyone curious on how I did it.