Jump to content

Recommended Posts

Posted (edited)

Description of the issue:

Textures, registration and item localisation all work correctly, but I am currently stuck on getting tiles to localise.

Here's a visual example of the issue...

Spoiler

04221a0ca6.png

3b78932938.png

As you can see from the pictures, my copper ingot works perfectly, but the tile (Copper ore) doesn't.

 

Here is the code stuff:

Spoiler

public class CopperOre extends Block {
    public CopperOre() {
        super(Material.ROCK);
        setRegistryName(new ResourceLocation(Ref.MOD_ID, Ref.COPPER_ORE));
        setUnlocalizedName(getRegistryName().getResourcePath());
    }

    @SideOnly(Side.CLIENT)
    public void initModel() {
        ModelLoader.setCustomModelResourceLocation(Item.getItemFromBlock(this), 0, new ModelResourceLocation(getRegistryName(), "inventory"));
    }
}

public class CopperIngot extends Item {
    public CopperIngot() {
        setRegistryName(new ResourceLocation(Ref.MOD_ID, Ref.COPPER_INGOT));
        setUnlocalizedName(getRegistryName().getResourcePath());
    }

    @SideOnly(Side.CLIENT)
    public void initModel() {
        ModelLoader.setCustomModelResourceLocation(this, 0, new ModelResourceLocation(getRegistryName(), "inventory"));
    }
}

public class ModBlocks {
    @GameRegistry.ObjectHolder(Ref.RESOURCE_PREFIX + Ref.COPPER_ORE)
    public static CopperOre copperOre;

    @SideOnly(Side.CLIENT)
    public static void initModels() {
        copperOre.initModel();
    }
}

public class ModItems {
    @GameRegistry.ObjectHolder(Ref.RESOURCE_PREFIX + Ref.COPPER_INGOT)
    public static CopperIngot copperIngot;

    @SideOnly(Side.CLIENT)
    public static void initModels() {
        copperIngot.initModel();
    }
}

public class Ref {
    public static final String MOD_ID = "tau";
    public static final String RESOURCE_PREFIX = Ref.MOD_ID + ":";
    public static final String NAME = "Tau mod";
    public static final String CLIENT_PROXY = "com.taunetwork.dev.tau.proxy.ClientProxy";
    public static final String SERVER_PROXY = "com.taunetwork.dev.tau.proxy.ServerProxy";

    public static final String COPPER_ORE = "copper_ore";
    public static final String COPPER_INGOT = "copper_ingot";
}

@Mod.EventBusSubscriber
public class CommonProxy {
    // Config instance
    public static Configuration config;

    public void preInit(FMLPreInitializationEvent event) {
        File directory = event.getModConfigurationDirectory();
        config = new Configuration(new File(directory.getPath(), "tau.cfg"));
        Config.readConfig();
    }

    public void init(FMLInitializationEvent event) {
    }

    public void postInit(FMLPostInitializationEvent event) {
        if (config.hasChanged()) {
            config.save();
        }
    }

    @SubscribeEvent
    public static void registerBlocks(RegistryEvent.Register<Block> event) {
        event.getRegistry().register(new CopperOre());
    }

    @SubscribeEvent
    public static void registerItems(RegistryEvent.Register<Item> event) {
        event.getRegistry().register(new ItemBlock(ModBlocks.copperOre)
                .setRegistryName(ModBlocks.copperOre.getRegistryName())
                .setUnlocalizedName(ModBlocks.copperOre.getRegistryName().getResourcePath()));

        event.getRegistry().register(new CopperIngot());
    }
}

@Mod.EventBusSubscriber(Side.CLIENT)
public class ClientProxy extends CommonProxy {
    @Override
    public void preInit(FMLPreInitializationEvent e) {
        super.preInit(e);
    }

    @SubscribeEvent
    public static void registerModels(ModelRegistryEvent event) {
        ModBlocks.initModels();
        ModItems.initModels();
    }
}

public class ServerProxy extends CommonProxy {

}

Here is the directory in the IntelliJ IDE

Spoiler

63fbca57cc.png

And finally the main attraction...

en_us.lang

# Blocks
tile:copper_ore.name=Copper Ore
item:copper_ore.name=Copper Ore
block:copper_ore.name=Copper Ore
# Items
item.copper_ingot.name=Copper Ingot

 

I was testing with numerous ways of trying to get the localisation file to recognise the block but to no avail.

Note: I do not use the mod id of the mod in my localisation files because I pass in the registry path string, I would doubt blocks and items have different unlocalised names based on the same parameters inputted... But feel free to explain if they do.

 

[17:43:57] [main/INFO] [tau/tau]: Copper Ore unlocalised name: tile.copper_ore
[17:43:57] [main/INFO] [tau/tau]: Copper Ore registry name: tau:copper_ore
[17:43:57] [main/INFO] [tau/tau]: Copper Ore Item unlocalised name: tile.copper_ore
[17:43:57] [main/INFO] [tau/tau]: Copper Ore Item registry name: tau:copper_ore
[17:43:57] [main/INFO] [tau/tau]: Copper Ingot unlocalised name: item.copper_ingot
[17:43:57] [main/INFO] [tau/tau]: Copper Ingot registry name: tau:copper_ingot

Finally the registry names and unlocalised names of the blocks/items in question, outputted using the logger during post initialisation, for my own verification that I haven't missed anything when registering the objects.

 

On the same context as the post itself, is the technique I am using to register blocks better or the same as doing:

public CopperOre() {
    super(Material.ROCK);
    setRegistryName(new ResourceLocation(Ref.MOD_ID, Ref.COPPER_ORE));
    setUnlocalizedName(getRegistryName().toString());
}

Or does it not exactly matter for Forge conventions?

 

fml-client-latest.log

Edited by Nayrisian
Issue solved

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hi, i'm really having problems trying to set the texture to my custom item. I thought i'm doing everything correctly, but all i see is the missing texture block for my item. I am trying this for over a week now and getting really frustrated. The only time i could make the texture work, was when i used an older Forge version (52.0.1) for Minecraft (1.21.4). Was there a fundamental change for textures and models somewhere between versions that i'm missing? I started with Forge 54.1.0 and had this problem, so in my frustration i tried many things: Upgrading to Forge 54.1.1, created multiple new projects, workspaces, redownloaded everything and setting things up multiple times, as it was suggested in an older thread. Therea are no errors in the console logs, but maybe i'm blind, so i pasted the console logs to pastebin anyway: https://pastebin.com/zAM8RiUN The only time i see an error is when i change the models JSON file to an incorrect JSON which makes sense and that suggests to me it is actually reading the JSON file.   I set the github repository to public, i would be so thankful if anyone could take a look and tell me what i did wrong: https://github.com/xLorkin/teleport_pug_forge   As a note: i'm pretty new to modding, this is my first mod ever. But i'm used to programming. I had some up and downs, but through reading the documentation, using google and experimenting, i could solve all other problems. I only started modding for Minecraft because my son is such a big fan and wanted this mod.
    • Please read the FAQ (link in orange bar at top of page), and post logs as described there.
    • Hello fellow Minecrafters! I recently returned to Minecraft and realized I needed a wiki that displays basic information easily and had great user navigation. That’s why I decided to build: MinecraftSearch — a site by a Minecraft fan, for Minecraft fans. Key Features So Far Straight-to-the-Point Info: No extra fluff; just the essentials on items, mobs, recipes, loot and more. Clean & Intuitive Layout: Easy navigation so you spend less time scrolling and more time playing. Optimized Search: Search for anything—items, mobs, blocks—and get results instantly. What I’m Thinking of Adding More data/information: Catch chances for fishing rod, traveling villager trades, biomes info and a lot more. The website is still under development and need a lot more data added. Community Contributions: Potential for user-uploaded tips for items/mobs/blocks in the future. Feature Requests Welcome: Your ideas could shape how the wiki evolves! You can see my roadmap at the About page https://minecraftsearch.com/about I’d love for you to check out MinecraftSearch and see if it helps you find the info you need faster. Feedback is crucial—I want to develop this further based on what the community needs most, so please let me know what you think. Thanks, and happy crafting!
    • Instructions on how to install newer Java can be found in the FAQ
    • That's just plain wrong... newer versions are much better optimised and start a lot faster than 1.8.9, both Forge and Minecraft itself. Comparing Fabric 1.21 with Forge 1.8 is like comparing apples and oranges... one's brand new and the other's over a decade old.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.