Jump to content

Recommended Posts

Posted

In Forge 1.12 the ItemAxe and ItemPickaxe constructors are protected, while ItemHoe, ItemSpade and ItemSword are public. Is there a reason for this inconsistency? There are no issues on GitHub about this so I assume it was done intentionally, but I'd like to know if it's an oversight that needs to be fixed or if it was planned.

Posted

Usually, when a constructor is protected, it is not the only constructor. What else do you see?

The debugger is a powerful and necessary tool in any IDE, so learn how to use it. You'll be able to tell us more and get better help here if you investigate your runtime problems in the debugger before posting.

Posted

The only one of these constructors added by Forge is ItemAxe(ToolMaterial, float, float), which uses the same access level as the vanilla ItemAxe(ToolMaterial) constructor. All of the others are vanilla constructors whose access levels aren't changed by Forge.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Posted

Thanks, I figured that was the case. Is there any way to make these constructors public without?:

1) editing forge's patches

2) editing vanilla minecraft's jar file

3) writing an encapsulating class with public constructors

 

I'm not writing a mod for any actual gameplay reason. It's an introduction into modding and needs to be as minimal in typing as possible. The mod also needs to run across several computers so editing the jars/reinstalling a modified forge patches isn't a viable option. I understand that there probably isn't an easier way to do this but it doesn't hurt to as. 

Posted

You could use an Access Transformer, but I'm not sure how much documentation there is on them.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Posted

Better question: why do you need those constructors?

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted

I'm using the constructors inside a factory for tools that can create axes, shovels/spades, swords, pickaxes and hoes. I'm doing this instead of creating a subclass for each of the 5 tools which is really what should be done, I'm just using one class that can make any of the 5 because,as said before the typing must be as minimal as possible. Regardless of why I need the constructors it's smart to standardize certain things. They should all be public or all be protected, which is why I asked.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.