Jump to content

Recommended Posts

Posted (edited)

Alright so I have a custom entity created that is meant to be a "bullet" for an item. The item on right click will shoot the bullet. I have been unable to find anything relating to how to render ThrowableEntites correctly so I pieced this together with various sources. There are two problems. One is when you right click the item it does indeed "shoot" the enttiy however it also blows up the log with this error:

	[19:08:07] [Client thread/ERROR]: ########## GL ERROR ##########
[19:08:07] [Client thread/ERROR]: @ Post render
[19:08:07] [Client thread/ERROR]: 1283: Stack overflow
[19:08:07] [Client thread/ERROR]: ########## GL ERROR ##########
[19:08:07] [Client thread/ERROR]: @ Post render
[19:08:07] [Client thread/ERROR]: 1283: Stack overflow
	
Edited by HalestormXV
Posted

Ah, yes, I see the problem.

On line 109 in your Render class you perform an illegal action. You should do this:

 

Post your damn code

  • Like 2

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted (edited)
16 minutes ago, Draco18s said:

Ah, yes, I see the problem.

On line 109 in your Render class you perform an illegal action. You should do this:

 

 

  Reveal hidden contents

Post your damn code

 

Wow lmfao epic response for epic fail. I didn't even realize the whole post after the code box got cut off. My fault for nto double checking the thread. Got to comfortable with the "bling" nosie the site makes. Lol sorry.

 

Here is the render class. Relatively simply or at least all teh examples I looked at seem to do rendering items this same way.

Render: https://pastebin.com/QFx9pPEv

Edited by HalestormXV
Posted
1 hour ago, HalestormXV said:

Wow lmfao epic response for epic fail. I didn't even realize the whole post after the code box got cut off. My fault for nto double checking the thread. Got to comfortable with the "bling" nosie the site makes. Lol sorry.

A lot of people post "I have problem" and don't post code or error and expect us to help merely by recognizing a vague description of the problem.

So I end up writing a lot of witty retorts.

  • Like 1

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted
2 hours ago, Silly511 said:

You need to put GlStateManager.popMatrix() at the end of your render method.

Excellent that resolved it. Didn't realize i missed that. Now perhaps the next issue can be looked at? Rather than make a whole new thread for it? The entity does not fire outward. Its simply looks as if it falls at the feet of the player. Now I am sure that perhaps i am not setting my velocity correctly, or maybe it has to do with throwableHeading, I am not sure. But I know I missing something. In doing some searching on the forums it is actually quite simialr of an issue to this post 

Spoiler


 


 

 

However mine seems to be worse and almost never seems to show the render unless I am looking straight down. Here is the entity class. It is very very basic right now and basically does nothing except exist, simply because I just want to get it to work first before I start adding to it.

 

EntityClass: https://pastebin.com/AF8sZVuy

 

1 hour ago, Draco18s said:

A lot of people post "I have problem" and don't post code or error and expect us to help merely by recognizing a vague description of the problem.

So I end up writing a lot of witty retorts.

 

Yes I know that quite well.

Posted
29 minutes ago, HalestormXV said:

However mine seems to be worse and almost never seems to show the render unless I am looking straight down. Here is the entity class. It is very very basic right now and basically does nothing except exist, simply because I just want to get it to work first before I start adding to it.

In the code you provided you never actually set the velocity in anyway. Do you ever set the velocity?

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Posted (edited)
19 minutes ago, Animefan8888 said:

In the code you provided you never actually set the velocity in anyway. Do you ever set the velocity?

Yes i have tried that also by taking the setVelocity function and setting the motion X, Y and Z to add 4. Perhaps that is not the correct way to do it?

 

https://pastebin.com/efwUVtkS

 

Maybe it is not supposed to be done that way? 

Edited by HalestormXV
Posted (edited)
5 minutes ago, HalestormXV said:

Yes i have tried that also by taking the setVelocity function and setting the motion X, Y and Z to add 4. Perhaps that is not the correct way to do it?

 


@SideOnly(Side.CLIENT)
public void setVelocity(double x, double y, double z)
{
    this.motionX = x + 4;
    this.motionY = y + 4;
    this.motionZ = z + 4;

}

Maybe it is not supposed to be done that way? 

Where do you call this method?

 

Edit: This method should only be called to update the variables when they have been changed on the server. Do you call EntityThrowable#setHeadingFromThrower or EntityThrowable#setThrowableHeading?

Edited by Animefan8888

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Posted (edited)
14 minutes ago, Animefan8888 said:

Where do you call this method?

 

 

I tried in two places. (separate runs of course) Once in here

 

public EntityCelestialBolt(World world, EntityLivingBase entity)

{

super(world, entity);

this.setVelocity(2, motionY, motionZ);  

}

 

And the other one above that you quoted (for just testing numbers) in the onUpdate.

 

Problem is, the item still doesn't render fully and you can't tell if it is actually moving or not since you can't see it. The same as above applies though. If you are at the right angle you can see it for a second, but not enough to tell if it is doing anything or not.

Edited by HalestormXV
Posted (edited)

Gotta bump this unfortuantly. Alright so I fixed it, the entity now travels at the speed it should, it does the damage it should if it hits an entity. If it hits a non-living entity it exploads. Perfect. However, here is the last problem. It does not render the projectile unless you are looking down. It "shoots" but does not render. I don't even know where this issue might reside. 

 

Here is the updated EntityClass: https://pastebin.com/yypQkJ4S

Here is the updated RenderClas: https://pastebin.com/HeR2eTuN

Just for Giggles here is the JSON for the item that is supposed to render if that has anything to do with it: https://pastebin.com/reTEi3Sk

 

EDIT 2: Here is an example to illustrate the issue. As you can see the item is rendered only when flying around and looking at it form other angles and stuff. Otherwise it doesnt appear to render. And the trails that follow the projectile are just there for testing so i can see that it is actually moving. They will be removed once I can figure out this render issue.

https://www.dropbox.com/s/4k0eibj8zetmnot/Example.mp4?dl=0

Edited by HalestormXV
Posted
15 minutes ago, HalestormXV said:

Bump, if anyone might know how to fix this? Here is the link to the example again. And the classes haven't changed.

https://www.dropbox.com/s/4k0eibj8zetmnot/Example.mp4?dl=0

Change (in your render class)

Quote

        GlStateManager.enableColorMaterial();
        super.doRender(entity, x, y, z, entityYaw, partialTicks);
        GlStateManager.popMatrix();

 

to (from RenderSnowball)

Quote

        GlStateManager.disableRescaleNormal();
        GlStateManager.popMatrix();
        super.doRender(entity, x, y, z, entityYaw, partialTicks);

 

 

  • Like 1

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Posted (edited)
11 minutes ago, Animefan8888 said:

Change (in your render class)

to (from RenderSnowball)

 

Changed them and still the exact same result. Only renders like in the video clip above. Talk about icnredibly frustrating. 

Edited by HalestormXV

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Version 1.19 - Forge 41.0.63 I want to create a wolf entity that I can ride, so far it seems to be working, but the problem is that when I get on the wolf, I can’t control it. I then discovered that the issue is that the server doesn’t detect that I’m riding the wolf, so I’m struggling with synchronization. However, it seems to not be working properly. As I understand it, the server receives the packet but doesn’t register it correctly. I’m a bit new to Java, and I’ll try to provide all the relevant code and prints *The comments and prints are translated by chatgpt since they were originally in Spanish* Thank you very much in advance No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. MountableWolfEntity package com.vals.valscraft.entity; import com.vals.valscraft.network.MountSyncPacket; import com.vals.valscraft.network.NetworkHandler; import net.minecraft.client.Minecraft; import net.minecraft.network.syncher.EntityDataAccessor; import net.minecraft.network.syncher.EntityDataSerializers; import net.minecraft.network.syncher.SynchedEntityData; import net.minecraft.server.MinecraftServer; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.EntityType; import net.minecraft.world.entity.Mob; import net.minecraft.world.entity.ai.attributes.AttributeSupplier; import net.minecraft.world.entity.ai.attributes.Attributes; import net.minecraft.world.entity.animal.Wolf; import net.minecraft.world.entity.player.Player; import net.minecraft.world.entity.Entity; import net.minecraft.world.InteractionHand; import net.minecraft.world.InteractionResult; import net.minecraft.world.item.ItemStack; import net.minecraft.world.item.Items; import net.minecraft.world.level.Level; import net.minecraft.world.phys.Vec3; import net.minecraftforge.event.TickEvent; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.network.PacketDistributor; public class MountableWolfEntity extends Wolf { private boolean hasSaddle; private static final EntityDataAccessor<Byte> DATA_ID_FLAGS = SynchedEntityData.defineId(MountableWolfEntity.class, EntityDataSerializers.BYTE); public MountableWolfEntity(EntityType<? extends Wolf> type, Level level) { super(type, level); this.hasSaddle = false; } @Override protected void defineSynchedData() { super.defineSynchedData(); this.entityData.define(DATA_ID_FLAGS, (byte)0); } public static AttributeSupplier.Builder createAttributes() { return Wolf.createAttributes() .add(Attributes.MAX_HEALTH, 20.0) .add(Attributes.MOVEMENT_SPEED, 0.3); } @Override public InteractionResult mobInteract(Player player, InteractionHand hand) { ItemStack itemstack = player.getItemInHand(hand); if (itemstack.getItem() == Items.SADDLE && !this.hasSaddle()) { if (!player.isCreative()) { itemstack.shrink(1); } this.setSaddle(true); return InteractionResult.SUCCESS; } else if (!level.isClientSide && this.hasSaddle()) { player.startRiding(this); MountSyncPacket packet = new MountSyncPacket(true); // 'true' means the player is mounted NetworkHandler.CHANNEL.sendToServer(packet); // Ensure the server handles the packet return InteractionResult.SUCCESS; } return InteractionResult.PASS; } @Override public void travel(Vec3 travelVector) { if (this.isVehicle() && this.getControllingPassenger() instanceof Player) { System.out.println("The wolf has a passenger."); System.out.println("The passenger is a player."); Player player = (Player) this.getControllingPassenger(); // Ensure the player is the controller this.setYRot(player.getYRot()); this.yRotO = this.getYRot(); this.setXRot(player.getXRot() * 0.5F); this.setRot(this.getYRot(), this.getXRot()); this.yBodyRot = this.getYRot(); this.yHeadRot = this.yBodyRot; float forward = player.zza; float strafe = player.xxa; if (forward <= 0.0F) { forward *= 0.25F; } this.flyingSpeed = this.getSpeed() * 0.1F; this.setSpeed((float) this.getAttributeValue(Attributes.MOVEMENT_SPEED) * 1.5F); this.setDeltaMovement(new Vec3(strafe, travelVector.y, forward).scale(this.getSpeed())); this.calculateEntityAnimation(this, false); } else { // The wolf does not have a passenger or the passenger is not a player System.out.println("No player is mounted, or the passenger is not a player."); super.travel(travelVector); } } public boolean hasSaddle() { return this.hasSaddle; } public void setSaddle(boolean hasSaddle) { this.hasSaddle = hasSaddle; } @Override protected void dropEquipment() { super.dropEquipment(); if (this.hasSaddle()) { this.spawnAtLocation(Items.SADDLE); this.setSaddle(false); } } @SubscribeEvent public static void onServerTick(TickEvent.ServerTickEvent event) { if (event.phase == TickEvent.Phase.START) { MinecraftServer server = net.minecraftforge.server.ServerLifecycleHooks.getCurrentServer(); if (server != null) { for (ServerPlayer player : server.getPlayerList().getPlayers()) { if (player.isPassenger() && player.getVehicle() instanceof MountableWolfEntity) { MountableWolfEntity wolf = (MountableWolfEntity) player.getVehicle(); System.out.println("Tick: " + player.getName().getString() + " is correctly mounted on " + wolf); } } } } } private boolean lastMountedState = false; @Override public void tick() { super.tick(); if (!this.level.isClientSide) { // Only on the server boolean isMounted = this.isVehicle() && this.getControllingPassenger() instanceof Player; // Only print if the state changed if (isMounted != lastMountedState) { if (isMounted) { Player player = (Player) this.getControllingPassenger(); // Verify the passenger is a player System.out.println("Server: Player " + player.getName().getString() + " is now mounted."); } else { System.out.println("Server: The wolf no longer has a passenger."); } lastMountedState = isMounted; } } } @Override public void addPassenger(Entity passenger) { super.addPassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(true)); } } } @Override public void removePassenger(Entity passenger) { super.removePassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is no longer mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(false)); } } } @Override public boolean isControlledByLocalInstance() { Entity entity = this.getControllingPassenger(); return entity instanceof Player; } @Override public void positionRider(Entity passenger) { if (this.hasPassenger(passenger)) { double xOffset = Math.cos(Math.toRadians(this.getYRot() + 90)) * 0.4; double zOffset = Math.sin(Math.toRadians(this.getYRot() + 90)) * 0.4; passenger.setPos(this.getX() + xOffset, this.getY() + this.getPassengersRidingOffset() + passenger.getMyRidingOffset(), this.getZ() + zOffset); } } } MountSyncPacket package com.vals.valscraft.network; import com.vals.valscraft.entity.MountableWolfEntity; import net.minecraft.network.FriendlyByteBuf; import net.minecraft.server.level.ServerLevel; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.Entity; import net.minecraft.world.entity.player.Player; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class MountSyncPacket { private final boolean isMounted; public MountSyncPacket(boolean isMounted) { this.isMounted = isMounted; } public void encode(FriendlyByteBuf buffer) { buffer.writeBoolean(isMounted); } public static MountSyncPacket decode(FriendlyByteBuf buffer) { return new MountSyncPacket(buffer.readBoolean()); } public void handle(NetworkEvent.Context context) { context.enqueueWork(() -> { ServerPlayer player = context.getSender(); // Get the player from the context if (player != null) { // Verifies if the player has dismounted if (!isMounted) { Entity vehicle = player.getVehicle(); if (vehicle instanceof MountableWolfEntity wolf) { // Logic to remove the player as a passenger wolf.removePassenger(player); System.out.println("Server: Player " + player.getName().getString() + " is no longer mounted."); } } } }); context.setPacketHandled(true); // Marks the packet as handled } } networkHandler package com.vals.valscraft.network; import com.vals.valscraft.valscraft; import net.minecraft.resources.ResourceLocation; import net.minecraftforge.network.NetworkRegistry; import net.minecraftforge.network.simple.SimpleChannel; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class NetworkHandler { private static final String PROTOCOL_VERSION = "1"; public static final SimpleChannel CHANNEL = NetworkRegistry.newSimpleChannel( new ResourceLocation(valscraft.MODID, "main"), () -> PROTOCOL_VERSION, PROTOCOL_VERSION::equals, PROTOCOL_VERSION::equals ); public static void init() { int packetId = 0; // Register the mount synchronization packet CHANNEL.registerMessage( packetId++, MountSyncPacket.class, MountSyncPacket::encode, MountSyncPacket::decode, (msg, context) -> msg.handle(context.get()) // Get the context with context.get() ); } }  
    • Do you use features of inventory profiles next (ipnext) or is there a change without it?
    • Remove rubidium - you are already using embeddium, which is a fork of rubidium
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.