Jump to content

[1.12] How to disable some mod recipe files via config file


Recommended Posts

Posted

Hey, i update my mods to 1.12 and i use for some recipes a config option to disable these recipes.

 

But how i do this with the new recipe json file system?

Posted

Hello,

 

i have some additional questions to the condition system.

 

1. When i use System.out.println in IConditionFactory must it be shown in the console output?

2. Is it possible to call an condition everywhere in the json-recipe like so:

 

{
	"type": "minecraft:crafting_shaped",
	"pattern": [
		" C ",
		"C C",
		"CCC"
	],
	"key": {
		"C":
		[
			{
				"type": "forge:ore_dict",
				"ore": "itemRubber"
			},
			{
				"conditions":
				[
					{
					  "type" : "mod_loaded",
					  "mod" : "thermalfoundation"
					}
				],
				"item": "thermalfoundation:material",
				"data": 832
			}
		]
	},
	"result": {
		"item": "schopcraft:enh_canteen",
		"data": 0,
		"nbt":
		{
			"canteen_type": 0
		}
	}
}

 

I cannot confirm this why i don't receive an console output from my variables that i combine and mix in my IConditionFactory-Class and the json interpreter says that ingredient are not exists.

 

{
	"conditions":
	{
		"mod_allowed" : "net.test.config.ConditionFactoryModExists"
	}
}

 

And now my crappy IConditionFActory-Class:

 

public class ConditionFactoryModExists implements IConditionFactory
{
	@Override
	public BooleanSupplier parse(JsonContext context, JsonObject json)
	{
		// Loader.isModLoaded("Railcraft");
		String key = JsonUtils.getString(json , "mod");
		boolean value = JsonUtils.getBoolean(json , "value", true);
		//return () -> ApiUtils.isExistingOreName(key) == value;
		System.out.println ("Condition Key:" + key);
		return () -> Loader.isModLoaded(key);
	}
}

 

Yes i know crappy but without an system.out.println i don't have the ability to bugfix oldscool and when the triggering an factory not show an console ouput i have only an error-free json-parser output and then i must test with mod and without if it functioned.

 

thx

 

Posted

Conditions only apply to the recipe, not to individual ingredients. You need to specify the conditions property in the top-level object.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Posted

Ah okay, but how can i make an item-recipe that use and OR-Condition? Can i only make an JSON-Recipe for an item that binded on one Condition? When i use conditions in the top-level object how can i say to forge use 2 possible ingredients when both mods are present, use 1 possible ingredient when only 1 mod are present or ignore the recipe when non mod are present?

 

I will bind the IConditionFacrory to an true boolean if the Config says Yes and the Mod are present. (Yes i know not perfectly my code but how i say i code with system.out.println it is importent for me:)).

 

I will try to love the new JSON-Recipe System, i hope you can forgive me if you see that i cannot good handle with JSON-Logik but i learn every second:). If-Conditions are in my blood, but i understand that the json-system is not only performance technically good its prefend bugs and error before i can made an item in minecraft.

Posted

If you want conditional ingredients, you'll need to create an IIngredientFactory and specify it in _factories.json. In the IIngredientFactory, you can use CraftingHelper.processConditions to check if the conditions are met. If they are, return an Ingredient instance for the specified item; if they aren't, return Ingredient.EMPTY (an Ingredient that never matches any ItemStack).

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Posted
  On 8/2/2017 at 5:30 PM, CyberPunkBln said:

Hi,

thx but do you know an example or an example-url?

Expand  

 

I have some IIngredientFactory implementations here, but none of them do what you're trying to achieve.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Posted

Hi,

nevertheless thx, nevertheless i can sniff some ideas. so i have grabed github and no one use this so as i need it, but at the moment i use my mod in my own modpack and there are all two mods. Hopefully a guy foudn this thread there have made this too in her mod:).

Posted

Hello,

 

completly fail at my side. Now i have the  IConditionFactory ready but are completly useless why i can only deactivate ore activate the hole recipe and do this only for a clean minecraft-log :).

 

That is only what i have found

https://gist.github.com/LexManos/2a11d4f7aa9d680d861dae4faf9dcfa6

thats an inspiration, but i can only say what Ingredient should it be when a mod is present, but when i have 2 mods and what use of both mod-ingredients in my multi-recipe.

 

but if when i have no mod, can i use Ingredient.EMPTY with constants?

 

Fuuh good old times, before 1.12 i have an Condition for GameRegistry:) ;).

 

ps: I think my big big problem is that thermalfoundation and industrialforgoing will make her Rubber-Products not as ore.itemPlastic, then i would have no problems

 

Posted

Have you tried making an IIngredientFactory like I recommended?

 

I just implemented one to do this here. I ended up using a custom Ingredient that never matches any ItemStack rather than using Ingredient.EMPTY; this is to prevent the Ingredient from matching an empty ItemStack when the conditions aren't met.

 

I also added a recipe like your example that uses a compound ingredient consisting of an itemRubber ore ingredient and a conditional ingredient that matches Thermal Foundation's Rosin when Thermal Foundation is loaded.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

  • 5 weeks later...
Posted (edited)
  On 7/26/2017 at 8:40 AM, diesieben07 said:

Implement IConditionFactory and implement your condition there. A condition is really just something that returns a boolean, so you'd return whether or not your recipe should be active.

Then create a file assets/<modid>/recipes/_factories.json. It's structure is like so:

{
    "conditions": {
        "<name>": "<fully qualified classname for IConditionFactory>
    }
}

 

You can specify recipe and ingredient factories, too.

 

Now in your recipe json you can specify conditions like so:

{
    "conditions": [
        {
            "type": "<modid>:<name>"
        }
    ]
}

The JSON object in the conditions array will be passed to your IConditionFactory, so you can specify additional data here.

 

Note that this is only updated once at startup, conditions are not dynamically checked.

Expand  

 

 

 

Okay i tried is, but now is the recipe deactivated regardless of whether the config option is true or false, whats wrong?

 

heres my condition class:

  Reveal hidden contents

 

the _factories.json:

  Reveal hidden contents

 

and a recipe json file:

  Reveal hidden contents

 

Edited by Razor
Posted (edited)

Okay, i found a easier way to deactivate recipes!   

 

Here is my code:

  Reveal hidden contents

 

Edited by Razor
Posted

Note that if you do it that way and have an Advancement set to grant the player the recipe, it will throw an error upon world load.

  • Like 1

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • The specific issue is that items in my inventory wont stack properly. For instance, if I punch a tree down to collect wood, the first block I collected goes to my hand. So when I punch the second block of wood to collect it, it drops, but instead of stacking with the piece of wood already in my hand, it goes to the second slot in my hotbar instead. Another example is that I'll get some dirt, and then when I'm placing it down later I'll accidentally place a block where I don't want it. When I harvest it again, it doesn't go back to the stack that it came from on my hotbar, where it should have gone, but rather into my inventory. That means that if my inventory is full, then the dirt wont be picked up even though there should be space available in the stack I'm holding. The forge version I'm using is 40.3.0, for java 1.18.2. I'll leave the mods I'm using here, and I'd appreciate it if anybody can point me in the right direction in regards to figuring out how to fix this. I forgot to mention that I think it only happens on my server but I&#39;m not entirely sure. PLEASE HELP ME! LIST OF THE MODS. aaa_particles Adorn AdvancementPlaques AI-Improvements AkashicTome alexsdelight alexsmobs AmbientSounds amwplushies Animalistic another_furniture AppleSkin Aquaculture aquamirae architectury artifacts Atlas-Lib AutoLeveling AutoRegLib auudio balm betterfpsdist biggerstacks biomancy BiomesOPlenty blockui blueprint Bookshelf born_in_chaos Botania braincell BrassAmberBattleTowers brutalbosses camera CasinoCraft cfm (MrCrayfish’s Furniture Mod) chat_heads citadel cloth-config Clumps CMDCam CNB cobweb collective comforts convenientcurioscontainer cookingforblockheads coroutil CosmeticArmorReworked CozyHome CrabbersDelight crashexploitfixer crashutilities Create CreativeCore creeperoverhaul cristellib crittersandcompanions Croptopia CroptopiaAdditions CullLessLeaves curios curiouslanterns curiouslights Curses' Naturals CustomNPCs CyclopsCore dannys_expansion decocraft Decoration Mod DecorationDelightRefurbished Decorative Blocks Disenchanting DistantHorizons doubledoors DramaticDoors drippyloadingscreen durabilitytooltip dynamic-fps dynamiclights DynamicTrees DynamicTreesBOP DynamicTreesPlus Easy Dungeons EasyAnvils EasyMagic easy_npc eatinganimation ecologics effective_fg elevatorid embeddium emotecraft enchantlimiter EnchantmentDescriptions EnderMail engineersdecor entityculling entity_model_features entity_texture_features epicfight EvilCraft exlinefurniture expandability explosiveenhancement factory-blocks fairylights fancymenu FancyVideo FarmersDelight fast-ip-ping FastSuite ferritecore finsandtails FixMySpawnR Forge Middle Ages fossil FpsReducer2 furnish GamingDeco geckolib goblintraders goldenfood goodall H.e.b habitat harvest-with-ease hexerei hole_filler huge-structure-blocks HunterIllager iammusicplayer Iceberg illuminations immersive_paintings incubation infinitybuttons inventoryhud InventoryProfilesNext invocore ItemBorders itemzoom Jade jei (Just Enough Items) JetAndEliasArmors journeymap JRFTL justzoom kiwiboi Kobolds konkrete kotlinforforge lazydfu LegendaryTooltips libIPN lightspeed lmft lodestone LongNbtKiller LuckPerms Lucky77 MagmaMonsters malum ManyIdeasCore ManyIdeasDoors marbledsarsenal marg mcw-furniture mcw-lights mcw-paths mcw-stairs mcw-trapdoors mcw-windows meetyourfight melody memoryleakfix Mimic minecraft-comes-alive MineTraps minibosses MmmMmmMmmMmm MOAdecor (ART, BATH, COOKERY, GARDEN, HOLIDAYS, LIGHTS, SCIENCE) MobCatcher modonomicon mods_optimizer morehitboxes mowziesmobs MutantMonsters mysticalworld naturalist NaturesAura neapolitan NekosEnchantedBooks neoncraft2 nerb nifty NightConfigFixes nightlights nocube's_villagers_sell_animals NoSeeNoTick notenoughanimations obscure_api oculus oresabovediamonds otyacraftengine Paraglider Patchouli physics-mod Pillagers Gun PizzaCraft placeableitems Placebo player-animation-lib pneumaticcraft-repressurized polymorph PrettyPipes Prism projectbrazier Psychadelic-Chemistry PuzzlesLib realmrpg_imps_and_demons RecipesLibrary reeves-furniture RegionsUnexplored restrictedportals revive-me Scary_Mobs_And_Bosses selene shetiphiancore ShoulderSurfing smoothboot
    • Hi everyone, I'm currently developing a Forge 1.21 mod for Minecraft and I want to display a custom HUD overlay for a minigame. My goal: When the game starts, all players should see an item/block icon (from the base game, not a custom texture) plus its name/text in the HUD – similar to how the bossbar overlay works. The HUD should appear centered above the hotbar (or at a similar prominent spot), and update dynamically (icon and name change as the target item changes). What I've tried: I looked at many online tutorials and several GitHub repos (e.g. SeasonHUD, MiniHUD), but most of them use NeoForge or Forge versions <1.20 that provide the IGuiOverlay API (e.g. implements IGuiOverlay, RegisterGuiOverlaysEvent). In Forge 1.21, it seems that neither IGuiOverlay nor RegisterGuiOverlaysEvent exist anymore – at least, I can't import them and they are missing from the docs and code completion. I tried using RenderLevelStageEvent as a workaround but it is probably not intended for custom HUDs. I am not using NeoForge, and switching the project to NeoForge is currently not an option for me. I tried to look at the original minecraft source code to see how elements like hearts, hotbar etc are drawn on the screen but I am too new to Minecraft modding to understand. What I'm looking for: What is the correct way to add a custom HUD element (icon + text) in Forge 1.21, given that the previous overlay API is missing? Is there a new recommended event, callback, or method in Forge 1.21 for custom HUD overlays, or is everyone just using a workaround? Is there a minimal open-source example repo for Forge 1.21 that demonstrates a working HUD overlay without relying on NeoForge or deprecated Forge APIs? My ideal solution: Centered HUD element with an in-game item/block icon (from the base game's assets, e.g. a diamond or any ItemStack / Item) and its name as text, with a transparent background rectangle. It should be visible to the players when the mini game is running. Easy to update the item (e.g. static variable or other method), so it can change dynamically during the game. Any help, code snippets, or up-to-date references would be really appreciated! If this is simply not possible right now in Forge 1.21, it would also help to know that for sure. Thank you very much in advance!
    • The simple answer is there is not an easy way. You would need to know how to program in Java, as well as at least some familiarity with how Forge works so you could port the differences. You would also need the sourcecode for the original mod, and permission from the author to modify it, if they did not use some sort of open source license. So it's not impossible, but it would take some effort, but doing so would open up a whole new world of possibilities for you!
    • Does it still crash if you remove holdmyitems? Looks like that mod doesn't work on a server as far as I can tell from the error.  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.