Jump to content
View in the app

A better way to browse. Learn more.

Forge Forums

A full-screen app on your home screen with push notifications, badges and more.

To install this app on iOS and iPadOS
  1. Tap the Share icon in Safari
  2. Scroll the menu and tap Add to Home Screen.
  3. Tap Add in the top-right corner.
To install this app on Android
  1. Tap the 3-dot menu (⋮) in the top-right corner of the browser.
  2. Tap Add to Home screen or Install app.
  3. Confirm by tapping Install.

Featured Replies

Posted

Hey,

 

I'm trying to make one of my custom ores drop itself when mined by hand.

 

I ran across this article and did what it suggested:

ModOre::getHarvestTool

@Override
    public String getHarvestTool(IBlockState state)
    {
      if (this == BlockHandler.copperOre)
        return null;
      else
        return this.harvestTool[getMetaFromState(state)];
    }

However, this doesn't work. When I debug, it gets to this point in the forge code:

ForgeHooks::blockStrength

    public static float blockStrength(@Nonnull IBlockState state, @Nonnull EntityPlayer player, @Nonnull World world, @Nonnull BlockPos pos)
    {
        float hardness = state.getBlockHardness(world, pos);
        if (hardness < 0.0F)
        {
            return 0.0F;
        }

        if (!canHarvestBlock(state.getBlock(), player, world, pos))
        {
            return player.getDigSpeed(state, pos) / hardness / 100F;
        }
        else
        {
            return player.getDigSpeed(state, pos) / hardness / 30F;
        }
    }

And it always goes into the second if, meaning that canHarvestBlock is returning false, even though I return null above. I'm not sure what I'm doing wrong, as setting the harvest level to 0 or -1 doesn't fix it and setting the harvest tool to null also doesn't fix it.

 

Here's a link to my git repo if you want all the code

Edited by DragonFerocity

There's a ! there.

 

if (!canHarvestBlock(state.getBlock(), player, world, pos))

Edited by Draco18s

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

5 hours ago, DragonFerocity said:

And it always goes into the second if, meaning that canHarvestBlock is returning false, even though I return null above.

Step into that method in the debugger and find out why it's returning false.

  • Author
8 hours ago, Draco18s said:

There's a ! there.

 

if (!canHarvestBlock(state.getBlock(), player, world, pos))

The function inside returns false, and !false = true, therefore it goes inside the if.

 

I should have been more clear.

 

I think the problem is that I set the material type to rock, and it seems to check if it's harvestable based on the material, not that function I overrode alone.

 

EDIT: Setting it's material type to something that can be mined by hand; dirt, grass, wood...; fixed it.

Edited by DragonFerocity

3 hours ago, DragonFerocity said:

I think the problem is that I set the material type to rock, and it seems to check if it's harvestable based on the material, not that function I overrode alone.

 

EDIT: Setting it's material type to something that can be mined by hand; dirt, grass, wood...; fixed it.

Well. Yes.

All blocks behave that way.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

Important Information

By using this site, you agree to our Terms of Use.

Configure browser push notifications

Chrome (Android)
  1. Tap the lock icon next to the address bar.
  2. Tap Permissions → Notifications.
  3. Adjust your preference.
Chrome (Desktop)
  1. Click the padlock icon in the address bar.
  2. Select Site settings.
  3. Find Notifications and adjust your preference.