Playing a sound event when player is in range of an entity

[Plgue]

Title says a lot. Also, the  "System.out.println("PlayerTickEvent Working");" does not print every tick. Here's my code:

 

    @SubscribeEvent
    public void entitiesInRadius(PlayerTickEvent event)
    {
         EntityPlayer player = event.player;
        
         int monsterCount = player.world.getEntitiesWithinAABB(EntityMob.class, new AxisAlignedBB(player.posX - 16, player.posY - 8, player.posZ - 16, player.posX + 16, player.posY + 8, player.posZ + 16)).size();
         boolean isplayerinrange = false;
         
         System.out.println("PlayerTickEvent Working");
         if(monsterCount > 0) 
         {
             System.out.println("isplayerinrange is true");
             isplayerinrange = true;
             
             if(isplayerinrange = true) 
                {    
                 System.out.println("Battle Music Initiated");
                player.playSound(ModSounds.BATTLE_MUSIC, 1, 1);
                }
          }
         
         else
         {
             isplayerinrange = false;
         }
         
    }

Edited August 17, 2017 by Plgue

[Plaigon]

Hi, you can maybe try using the LivingSetAttackTargetEvent ?

[Plgue]

  On 8/17/2017 at 6:01 PM, Plaigon said:

Hi, you can maybe try using the LivingSetAttackTargetEvent ?

Expand  

So I updated my code:

 

    @SubscribeEvent
    public void livingSetAttacktargetEvent(LivingSetAttackTargetEvent event)
    {
        EntityLivingBase player = event.getTarget();
        
        System.out.println("Set attack target");
        if(event.getTarget() == player)
        {
            System.out.println("Battle Music Play");
            player.playSound(ModSounds.BATTLE_MUSIC, 100, 1);
        }
        
        else
        {
            
        } 
    }

 

It's still a work in progress, but no matter what I do I can't seem to get the event to start my method. The System.out.println's don't even go off, I'm really stumped here. 

 

Edit: This is my common proxy, just in case you wanna see it:

 

public class CommonProxy {

    public void preInit(FMLPreInitializationEvent e) 
    {
        ModItems.init();
        ModItems.register();;
        
        ModEntities.init();

    }

    public void init(FMLInitializationEvent e) 
    {
        MinecraftForge.EVENT_BUS.register(ModSounds.class);
        MinecraftForge.EVENT_BUS.register(EventHandler.class);
    }

    public void postInit(FMLPostInitializationEvent e) 
    {
        
    }
}

Edited August 17, 2017 by Plgue

[Plgue]

  On 8/17/2017 at 6:01 PM, Plaigon said:

Hi, you can maybe try using the LivingSetAttackTargetEvent ?

Expand  

Also, thanks for this idea! This event does exactly what I need it to do.

[Plgue]

  On 8/17/2017 at 8:03 PM, diesieben07 said:

Look at this very closely. Can this ever be false? No, it cannot.

Expand  

Still not the issue

[Plgue]

  On 8/17/2017 at 7:07 PM, Plgue said:

player.playSound(ModSounds.BATTLE_MUSIC, 100, 1);

Expand  

Isn't that what i'm doing here? I'm playing the sound to the target.

[Plgue]

I do understand it to an extent, but I don't know how I would use it here. And sorry if I sound ignorant or like an idiot, I'm still learning

[jeffryfisher]

Use Eclipse to look into source code of vanilla entities . See what they do to make sounds, especially from server side decisions.

[Plgue]

So after everything I've seen in this thread, this is what I came up with:

 

    @SubscribeEvent(priority = EventPriority.HIGHEST)
    public void playBattleSong(LivingSetAttackTargetEvent event)
    {

          EntityLivingBase entity = event.getEntityLiving().getAttackingEntity();

          entity.playSound(ModSounds.BATTLE_MUSIC, 75, 1);
    }

 

It still does not play the sound.

[Draco18s]

How does EventPriority.HIGHEST solve the client-vs-server issue?

I'll give you one hint:

It does fuck all about it.

[Plgue]

  On 8/19/2017 at 2:31 AM, Draco18s said:

How does EventPriority.HIGHEST solve the client-vs-server issue?

I'll give you one hint:

It does fuck all about it.

Expand  

The priority was just me messing around

[Plgue]

  On 8/19/2017 at 9:13 AM, diesieben07 said:

Don't "just mess around". Read the documentation about playing sounds that I linked.

Expand  

But this code should work right? I'm playing a sound from an entity, vanilla Minecraft does the same thing.

So I don't know why it does not work.

Edited August 19, 2017 by Plgue

[Plgue]

  On 8/19/2017 at 4:49 PM, diesieben07 said:

It does not work because you are calling a method that is designed to be called from both sides only on the server.

You would know this if you had read the documentation that I linked.

Expand  

So in this case I should be using "World.playsound" ?

[Plgue]

  On 8/19/2017 at 4:59 PM, diesieben07 said:

That is one solution, yes.

Expand  

Again i'm really sorry if I sound like an idiot, but I don't know how to get the sound to play using "World.playsound()"

Because I don't know how to get my method non static, I did not set it as static though.

 

[Plgue]

  On 8/19/2017 at 5:03 PM, diesieben07 said:

Please clarify what you are talking about. Which method? Why do you want it to be non-static? Do you even know what that means?

Expand  

Never mind, this is what i'm currently using

entity.world.playSound(null, entity.chunkCoordX, entity.chunkCoordY, entity.chunkCoordZ, ModSounds.BATTLE_MUSIC, SoundCategory.MUSIC, 100, 1);

But it still does not work

[Leviathan143]

  On 8/19/2017 at 5:06 PM, Plgue said:

Never mind, this is what i'm currently using

entity.world.playSound(null, entity.chunkCoordX, entity.chunkCoordY, entity.chunkCoordZ, ModSounds.BATTLE_MUSIC, SoundCategory.MUSIC, 100, 1);

But it still does not work

Expand  

It's not working because you are passing chunk coordinates into a method that takes world coordinates. You want Entity#posX, Entity#posY & Entity#posZ.

[Plgue]

  On 8/19/2017 at 5:07 PM, diesieben07 said:

Are you sure the code is executed?

Expand  

Sorry for the late response, but yeah it's being executed 

[Plgue]

  On 8/19/2017 at 9:39 PM, Leviathan143 said:

It's not working because you are passing chunk coordinates into a method that takes world coordinates. You want Entity#posX, Entity#posY & Entity#posZ.

Expand  

Did this and it's still not working