[1.12] Crash when trying to use ObjectHolders

[That_Martin_Guy]

I haven't used ObjectHolders before, but I've seen a lot of people both use and recommend them, so I tried to use them myself. I am not very experienced with these, though, and I am currently crashing with an IllegalStateException.

 

Crash log

ModBlocks
ModItems

 

The linked files are the only files containing the ObjectHolder annotation.

 

[Draco18s]

Uh.

You're not using them correctly.

http://mcforge.readthedocs.io/en/latest/concepts/registries/#injecting-registry-values-into-fields

 

public static final Block diamond_block = null; // public static final is required.
                                                    // Type Block means that the Block registry will be queried.
                                                    // diamond_block is the field name, and as the field is not annotated it is taken to be the resource path.
                                                    // As there is no explicit domain, "minecraft" is inherited from the class.
                                                    // Object to be injected: "minecraft:diamond_block" from the Block registry.

Notice how the field is null.

Notice how the field is of type Block.

Notice how the field name equals the registry name.

Edited August 18, 2017 by Draco18s

[That_Martin_Guy]

How do I instantiate it if the field is null? I want to have multiple instances of BlockHardenedOre with different values in its constructor.

[Draco18s]

7 minutes ago, That_Martin_Guy said:

How do I instantiate it if the field is null? I want to have multiple instances of BlockHardenedOre with different values in its constructor.

That's what the ObjectHolder annotation is for!

Edited August 18, 2017 by Draco18s

[That_Martin_Guy]

Then how do I instantiate it this way? As far as I can tell the docs only tell you how to annotate a class or field properly, not how to instantiate it.

[Draco18s]

Local variables.

[That_Martin_Guy]

Right now I crash with a NullPointerException, and I'm confused as to why. Shouldn't the field be occupied by the time the item registry event is fired?

 

ModBlocks

[That_Martin_Guy]

BlockBase (which BlockHardenedOre inherits from) sets the registry name in it's constructor as the first parameter like this:

 

    public BlockBase(String name, @Nullable CreativeTabs creativeTab, Material materialIn)
    {
      ...
        this.setName(name);
      ...
    }

    private void setName(String name)
    {
        this.setRegistryName(name);
        super.setUnlocalizedName(this.getRegistryName().toString());
    }

. So in this case the hardened coal's registry name is blockhardenedcoal. Is this incorrect?

[That_Martin_Guy]

I thought that I would be able to make some sort of wildcard version of the object, but I can see now that this doesn't really make sense. Works now! Thanks.

 

Working ModBlocks

[Draco18s]

I thought I said that...

17 hours ago, Draco18s said:

Notice how the field name equals the registry name.

Oh, I did.