Underground structures stacking on each other.(screenshots)

[TheRPGAdventurer]

So I tried to make my structure look for air blocks, then spawn it in there. My suspicion with my problem is that air blocks with the requirements are rare thus making it stack on each other. Other people doesn't seem to have this problem tho. I always see that the issue is on the Y level.

public static void generateNestUnderground(World world, Random random, int x, int z) {
	     int xzCheckDistance = 10;
	     if((random.nextInt(125)) == 1) {
	         for (int y = 55; y >= 30; y--) {
	             if (world.getBlockState(new BlockPos(x,y,z)).getBlock().isAir(world.getBlockState(new BlockPos(x,y,z)), world, new BlockPos(x,y,z))) {
	                 for (int y2 = 1; y2 <= 30; y2++) {
	                     if (world.getBlockState(new BlockPos(x,y-y2,z)).isBlockNormalCube()) {
	                         int y4 = 0;
	                         int y5 = 0;
	                         for (int x2 = 0; x2 <= xzCheckDistance; x2++) {
	                             if (world.getBlockState(new BlockPos(x-x2,y-y2+y4 +1,z)).isBlockNormalCube()) {
	                                 Boolean wall = true;
	                                 for (int y3 = 1; y3 <= 4; y3++) {
	                                     if (!world.getBlockState(new BlockPos(x-x2,y-y2+y4+1+y3,z)).isNormalCube()) {
	                                         wall = false;
	                                         y4 += y3;
	                                         break;
	                                     }
	                                 }
	                                 if (wall) {
	                                     if (world.getBlockState(new BlockPos(x - x2, y - y2 + y4, z)).isNormalCube()) {
	                                         StructureDragonNests.generate(world, new BlockPos(x - x2, y - y2 + y4, z), random);
                                       	     Utils.getLogger().info("Underground Nest here at:"  +  new BlockPos(x - x2, y - y2 + y4, z));
                                       }return;
                                   }
                               }
                           } break;
                       }
                   }
               }
           }
       }
	}
}

 

Edited September 3, 2017 by TheRPGAdventurer
screenshots

[TheRPGAdventurer]

Seriously Anyone?

[jeffryfisher]

I suggest that you search for a simpler air pocket and then enlarge the pocket to accommodate your structure (or include surrounding air as part of your structure). Also, if you see stacking, then your search needs to be reprogrammed so that block-changes made by one insertion will affect the results of the next search (preventing overlap).

[TheRPGAdventurer]

Just now, jeffryfisher said:

I suggest that you search for a simpler air pocket and then enlarge the pocket to accommodate your structure (or include surrounding air as part of your structure). Also, if you see stacking, then your search needs to be reprogrammed so that block-changes made by one insertion will affect the results of the next search (preventing overlap).

what's the difference of isNormalCube and isBlockNormalCube?

[Draco18s]

4 hours ago, TheRPGAdventurer said:

what's the difference of isNormalCube and isBlockNormalCube?

Right click -> References -> Find in workspace -> learn

[TheRPGAdventurer]

20 hours ago, Draco18s said:

Right click -> References -> Find in workspace -> learn

Another question, what is the uppermost y level of the nether(bedrock.)

[Draco18s]

1 hour ago, TheRPGAdventurer said:

Another question, what is the uppermost y level of the nether(bedrock.)

Start new game (Creative) -> Travel to the nether -> hit F3 -> Punch your way to the ceiling

 

Seriously. Learn how to figure this shit out for yourself. It's probably also on the wiki.

[TheRPGAdventurer]

1 minute ago, Draco18s said:

Start new game (Creative) -> Travel to the nether -> hit F3 -> Punch your way to the ceiling

 

Seriously. Learn how to figure this shit out for yourself. It's probably also on the wiki.

My computer is kinda laggy for this sometimes, I already found the answer on the wiki. BTW! Thanks for making me learn to myself and notjust turn into some script kiddie.